- 17 Nov, 2020 40 commits
-
-
Elly Fong-Jones authored
Before this change, an element with the "disabled" restriction would disallow every accessibility selector - crucially including selectors like "isAccessibilityElement" or "accessibilityParent", which are required for conforming accessibility elements. This caused disabled elements to be completely skipped by VoiceOver, which hampers uses of them as markers of functionality that exists but is disabled and as menu headings. Bug: 1067760 Change-Id: If64a02223930f3e5c404415798a56738a7faed88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536088 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828226}
-
Jeroen Dhollander authored
This will allow us to move these classes (|AssistantManager| and |AssistantManagerInternal|) to a new Libassistant mojom service, but still access them from the legacy code while the transition is in progress. Bug: b/171748795 Test: chromeos_unittests Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I784c57ea1b1e89fb5ce710e031eae560e2e1cf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537784Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828225}
-
Eugene But authored
This is a monitoring histogram and it's still useful. Bug: 1149516 Change-Id: I3cc1968f502f06c8ab1e42bfb39e12f95b11d50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541608Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#828224}
-
sandromaggi authored
This adds a new option for computing a value by checking whether or not a string value is empty. Bug: None Change-Id: I2f1a18cde4dd9add1e300621d70c27ebe61369b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537353 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#828223}
-
Nohemi Fernandez authored
The Google homepage and Search present consent notifications when the user is signed out. Since GAIA restore logic currently works on a user refresh then avoid triggering restore when the content area UI may conflict with the sign-in notification. Bug: 1131027, 1149902 Change-Id: I4d2b186f126c7fc14f8595062a08bb0fb72212d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540671 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828222}
-
Weiliang Chen authored
Set up a feature flag and corresponding state inside cc to enable using HUD for displaying performance metrics. Currently when we enable the show performance metrics flag we only add WebVitals metrics, which comes from Blink. We might want to add other metrics in the future. R=sadrul Bug: 1149385 Change-Id: I437e113a5fc4f44c6fbaa542c92d1f2da6cbb393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540570 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828221}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011170600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/Y3c3XYAxp6W90cFgZUmorQTsJHW-F5HsqrxoPlvxAxkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I330cdab33069fe105296129c0203eb8a5e668466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544250Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828220}
-
Benoit Lize authored
Acquire the lock only once in ThreadCache::Purge(). Beyond being faster, this also adds the possibility of amortizing thread cache deallocation later. Bug: 998048 Change-Id: I95805fe28f8df557d5783684c172618a304985bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540596 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#828219}
-
Robert Phillips authored
Bug: 1149931 Change-Id: I00c67c52c7b4e6a191d261392d52d0afb644453e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544143Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#828218}
-
Mohamed Heikal authored
Roll R8 to ToT in order to include latest fix for removing generated extensions references for extensions that are not in the dex. Bug: 1147185 Change-Id: I744e76fe2a34396f4f98ac9d72b34f558c9a10d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542367Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828217}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f2bc3b3edd6f..d98e8b70bbb1 2020-11-17 cwallez@chromium.org Use smart Refs for IOKit and CoreFoundation objects. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I5ef0f17bcff5260f3a74ce900c1d1b158bd8d6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828216}
-
Mihai Sardarescu authored
This CL enables the usage of the Gaia ID as the account ID for the account manager for profiles that have no accounts on start-up. This allows us to start using Gaia ID as the account ID on ChromeOS as well. Using this strategy has very little risk as there should not be any data that needs to be migrated from email to Gaia ID. Bug: 1028182 Change-Id: I90cbcf4a9bb8be848276b64d8802e090de428a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491365Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828215}
-
Wojciech Dzierżanowski authored
When UpdateMaxSize() is called in production it always updates to the current work area size. The test called UpdateMaxSize() with artificial values that were not aligned with the work area. This sometimes led to reentrant UpdateMaxSize() calls where the inner call updated the maximum size to the work area size, causing the outer call to return that instead of the value set by the test. This CL solves it by making the test more realistic: Instead of exposing UpdateMaxSize() and calling it from the test directly the way it never happens in production, we fake the work area through the use of a fake Display and call a regular, public Widget API. At the same time, the test has morphed into a unit test, because it's easier to use a fake Display this way, and we don't need the full browser to test what we want anyway. Bug: 1002489 Change-Id: I72bb73c3bd02ca74b7aa410e6a87b6133a990de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517957 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#828214}
-
Dominik Lang authored
When pid was not set trace processor could not fill the profiler_smaps table upid column properly. Bug: 1098746 Change-Id: I93b4681bf9806f12835758fee8ecb66989af7b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544187Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#828213}
-
Robbie Gibson authored
The added view covers the entire BVC and uses a LocationBarSteadyView to display the current web address. Bug: 1094335 Change-Id: I8790c595f079ed31760416a0ef52b8b0232ddf05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537354 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828212}
-
Jasmine Chen authored
Generates the token for CameraHalServer for it to be used for RegisterServerWithToken. Bug: b/170075468 Test: Build, deploy simplechrome, and verify the server token is generated. Change-Id: If3feaa7c06aa67bfbd478d4d0b5aedf22847ff0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534552 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828211}
-
Alex Turner authored
These two page-level metrics are still useful for tracking ads behavior in Chrome. Bug: 1138426 Change-Id: Ia279c184383197084af2a0b05ea2069795f3485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542546Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#828210}
-
Robbie Gibson authored
These coordinators were just being set to nil, without stopping. They should be stopped first. Change-Id: If1a1ffb632176c77b9d5d69655f0e9a4f2a3874c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544464Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#828209}
-
Alfonso Castaño authored
This CL introduces a new probe and a new command to set a breakpoint on a particular Trusted Type violation. Design doc: https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/ Bug: chromium:1142804 Change-Id: I605525db9cba063d6ba583011bbbfbdf02d6b6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517519 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828208}
-
Liviu Tinta authored
There is a potential compat issue with making click/contextmenu pointer events. The coordinates (clientX/clientY, screenX/screenY, pageX/pageY, offsetX/offsetY) will be returned as fractional numbers. This is a mitigation plan for the unlikely case of breakage from fractional coordinates. We believe this is unlikely because we have been running a Finch experiment with ClickPointerEvent flag enabled in Canary+Dev for 2 months and there were no related bug reports. Our mitigation plan would allow us to keep click/contextmenu as pointerevents but make sure to return integer instead of fractional coordinates. Bug: 989958 Change-Id: I190010ab65f1e01b58480973660b4823f51a24fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510931 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828207}
-
ckitagawa authored
Fix a crash that can happen if the compositor client is disconnected or stopped while fetching the proto. Bug: 1148899 Change-Id: Ib8536364e14be1bfdfcfe451bf497cf18be5735a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538113 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#828206}
-
Swapnil authored
This is a reland of f9ad6770 In the previous commit, the flag was overriden only for Windows. But the flag is set to true in case of MacOS too. Original change's description: > Fix ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest > > We check the list of enabled and disabled extensions in > ExtensionPolicyTest.ExtensionRecommendedInstallationMode browsertest. > In Windows, the extension is disabled by default as the user is > prompted before enabling the extension. On other platforms, the > extension is enabled by default. This CL overrides the prompting > flag to false. > > Bug: 1006342 > Change-Id: I1d783a8fc381b50e84e5ba85b5c9f37e58b7a986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537641 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Cr-Commit-Position: refs/heads/master@{#828093} Bug: 1006342 Change-Id: If01e0d818a2b0a1e0f8704852aee5ac478c301ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544292Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828205}
-
Ganggui Tang authored
This reverts commit 536b412d. Reason for revert: the test is failing on Linux Chromium OS ASan LSan Tests, crbug.com/1149939 Original change's description: > desks: Speculative fix for crash. > > The previous attempt [1] added checks for whether the starting or ending > screenshot was taken. In the case of the starting screenshot missing, it > would signal the animation to remove some RootWindowDeskSwitchAnimators, > leading to a vector out of bounds. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2506356 > > Bug: 1148607 > Test: added regression test > Change-Id: I7f14df877cb93619a0ca8a85f5d0ad434dda3ad2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536934 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828034} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I27cc6811a5edd38a56eb82f20752638351e2b2df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544443Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#828204}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4b2f38f2396..f0f126063145 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in har_importer/ 2020-11-17 tvanderlippe@chromium.org Typecheck layer_viewer/LayerTreeOutline.js with TypeScript 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in webauthn/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in settings/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in heap_snapshot_worker/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in screencast/ 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in console/ 2020-11-17 aerotwist@chromium.org [unit test] Add ZoomManager to environment vars 2020-11-17 tvanderlippe@chromium.org Use TypeScript-authored files in snippets/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1148296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf57ad4340eb00e2c711b2b9ba786771b4bc95c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828203}
-
Rohit Agarwal authored
This CL: a) Restricts Incognito CCT to non-3P apps. b) Modifies the existing tests in order for them to launch the Incognito CCT with this change. c) Adds a new IncongitoCustomTabActivityTestRule that adds module overrides to help with the mocking 1P apps. Bug: 1139293 Change-Id: Ie230858361c915470b4d5ff6042b4d6e1784fe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536455 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828202}
-
Xida Chen authored
This CL extends the cc::PaintWorkletInput::PropertyKey to support the native property types. This is needed in order to support composite background color animation, which is described here: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit This CL doesn't change any behavior, because right now only native property uses the PaintWorkletInput. Bug: 1139008 Change-Id: I4e2a7417a982c39106dd28ce43fe7452151e8511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528937Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828201}
-
Anastasiia N authored
Add kAccountManagementFlowsV2 flag for redesign of account management flows and Account Manager page in Settings. Bug: 1144113 Change-Id: I1a5ee10afc5e51ba426d4330c571e84e44effad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526401 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#828200}
-
Liquan (Max) Gu authored
Before the CL, mSpec, mJourneyLogger were destroyed in CPRService. After the CL, they are destroyed in PRService. This change shares the destructions of the two variables with the WebLayer payment request service. Bug: 1025619 Change-Id: I572f8b5f0cc54963e3f3cd86fa2148ebea9c2541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540746 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828199}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/find_in_page Bug: 1113033 Change-Id: Ia31af39407628ab5c568efcfbe92d9f1297bca50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543544 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828198}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I9b031a46008557c42121943b0680da5eef8652b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502338Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#828197}
-
Harry Cutts authored
Otherwise one might only find out when OsSettingsManagerTest.Initialization fails during the submit process. Change-Id: I86f2135f3aca46fdad6cab4be7337de211af625d Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542732Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#828196}
-
Sebastien Lalancette authored
Runs only on iOS 13+, and will: - Select a word on a test page, - Tap on "Link to Text", - Tap on the "Copy" activity, - Assert that the expected URL was added to the pasteboard. Test is skipped on iOS 12 due to the activity view not being accessible by EarlGrey. Test is disabled on iPads due to: Bug: 1149603 Change-Id: Ia1011f538e6d2b6aed00a12cccd19df40da13472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530389 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828195}
-
Roman Aleksandrov authored
Bug: 1144159 Change-Id: I02c5ba9fa2d67755025f364807e4c0e03bba312f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537839 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828194}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605592392-dc172d915909da26cabde4fc0f34ef46d817ea1e.profdata to chrome-linux-master-1605612997-0b538d267d59602889f3873bf24b3a402bd4dd04.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iba237a12cb4ca4bd2cf26f10b20dc53a40c0a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828193}
-
Andrew Shulaev authored
Bug: b/171790119 Change-Id: I00249eab13ecee8163c52f90a91bcaeaa8899a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507651Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#828192}
-
Jan Wilken Dörrie authored
This change unexpires the PasswordImport flag. Bug: None Change-Id: Ie93933f7e12b02f5fc7f9850ae48b433595c3cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542790 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828191}
-
zhiyuancai authored
This CL records whether users turn on the feature "track prices on tabs" and updates the checkbox on the tab switcher menu. Bug: 1146636 Change-Id: I7dbdddb287a30b47298425eda79778433caa2316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524961Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#828190}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1145565 Change-Id: I917d2102c2a9d3276355bf395db2a88749effdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532662 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828189}
-
Karandeep Bhatia authored
Extend expiry of the following histograms: - Extensions.DeclarativeNetRequest.ReadDynamicRulesJSONStatus - Extensions.DeclarativeNetRequest.UpdateDynamicRulesStatus - Extensions.DeclarativeNetRequest.RulesetReindexSuccessful BUG=1149533, 1149532 Change-Id: Id8bb35c0ece810b5c8cadd9f57eb14559cdbebc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541669Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828188}
-
Liquan (Max) Gu authored
Changes: * De-dups the not-show error handling for disconnectForStrictShow and disconnectIfNoPaymentMethodsSupported by onShowFailed(). Behaviour changes: * When the strict-show conditions fail, adds this behaviour: logs "NotShownReason.OTHER". Bug: 1148902 Change-Id: I30dacb87f9e785466edd76a2de9ceb9b6ed9be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540574 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#828187}
-