- 26 Jun, 2019 40 commits
-
-
Rayan Kanso authored
Change-Id: I69c8634691e6bbf8229f14a7f520aa3fc779ff5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678318 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672490}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/166f0ab34656..f20daf0bf0cf git log 166f0ab34656..f20daf0bf0cf --date=short --no-merges --format='%ad %ae %s' 2019-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f9d08a25fbe1..4162de4bbfc5 (4 commits) Created with: gclient setdep -r src/third_party/angle@f20daf0bf0cf The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I15b690cac80cfa59113970175c5c2b31c12cfee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672489}
-
Alice Boxhall authored
Algorithm described here: https://whatpr.org/html/4288/interaction.html#inert-subtrees:inert Bug: 692360 Change-Id: Ie37b2c68cabf7ae9051875b8e15ed3675980a848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568378 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#672488}
-
Caitlin Fischer authored
Bug: 969715, 951174, 978523 Change-Id: I9a7905cc410de5fc7dded45f71026926e361ac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676546Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#672487}
-
Vadym Doroshenko authored
Bug: 949519 Change-Id: I5848a9105afc12b73b20824fad51a58f31f98264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675433Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#672486}
-
Paul Lewis authored
The code we have to populate a tree uses await, except that in the recursive case we don't await its Promise, instead treating it as a sync op. This resulted in the bug that the child list is empty when checked. This patch updates that code such that it now awaits the async populate process before checking for child nodes to expand. Bug: 961141 Change-Id: I35f3aacf3ef67d0de9a0c35a0c98ec500b08df58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657907Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#672485}
-
Shimi Zhang authored
These classes were ignored for not having @Override annotation, now they all properly annotated. Should be fine to remove the exceptions. Bug: 635567 Change-Id: Iaf5c99dddefed47d6117cbcbfa22084a5af6fcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677128 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672484}
-
Vladislav Kuzkokov authored
Send-Username and Close-Job IPP requests must have the same requestingUserName attribute as Create-Job otherwise they fail with either HTTP 401 or 403. Bug: 974048 Change-Id: Ifc6522b24c98f2eacfe04e5039a67c08187498a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667666Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672483}
-
Mikel Astiz authored
No behavioral changes: we extend or refactor signatures so propagate Nigori-related errors explicitly. Bug: 973311 Change-Id: I9a05b87036caf4a15d85b8cce02e7ee510766d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660490 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#672482}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9ae33420aaf..6e269a0babac git log d9ae33420aaf..6e269a0babac --date=short --no-merges --format='%ad %ae %s' 2019-06-26 yangguo@chromium.org Extend git-cl-owners to show all owners for a file Created with: gclient setdep -r src/third_party/depot_tools@6e269a0babac The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idb14b142b76753af4b084c24f45a3c31bc36ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677072Reviewed-by:
-
Paul Lewis authored
Currently mailto links are not special-cased like data: or javascript:, which is incorrect as they get resolved like relative URLs. This patch updates the behavior to copy mailto links as-is. Bug: 968024 Change-Id: Ie84074dfa6a5f6572e85bdaa7c012608433f0c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674157Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#672480}
-
Bailey Berro authored
This change allows editing the printer while offline. When offline, only changes to printer name can be made. All our fields are not editable. If changes are made to other fields, then the device is disconnected from the internet, only the changes to the name will be saved. Bug: 931968 Change-Id: Ia18fbcf45aea9627d19b1c6a030294dfc9bf52af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666328 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672479}
-
Eric Willigers authored
https://drafts.csswg.org/css-images-3/#radial-gradients "Negative values are invalid." We now reject negative radii during radial-gradient parsing. Bug: 978790 Change-Id: I2f5341cb19209e46299bab1982870cbe0cb52321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677071Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#672478}
-
Paul Lewis authored
The current 'Copy XPath' context menu option defaults to providing the user with the optimized XPath. This CL adds an extra menu option to get the full, unoptimized, XPath value. Bug: 933027 Change-Id: I7ea52896291aea22b00d0ca56258808482883cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669365 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This is a part of moving media recorder implementation to blink and a follow-up CL of https://crrev.com/c/1662986. This CL replaces WebMediaStream with MediaStreamDescriptor in media_recorder_handler.h to drop the "Web" type. Bug: 960665 Change-Id: I6085f07f1fb21f70f6e766b08278600c2cf29e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673406Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#672476}
-
Rune Lillesveen authored
Mac 10.13 bot fails this test sometimes. Seemingly because of sizing issues. Make it a ref-test to avoid that. Change-Id: I0ca5ed65f7f65c43871f29100419d7634c3e318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677174Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#672475}
-
Takashi Toyoshima authored
This is a follow up to disallow Web MIDI uses on insecure origins. After this change, the Web MIDI related interfaces won't appear on insecure origins. https://github.com/WebAudio/web-midi-api/issues/183 https://github.com/WebAudio/web-midi-api/issues/199 Bug: 924471 Change-Id: I61d55d5ba192a6cbcea9e29f97c4bfe11ac4b983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673491 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#672474}
-
Rayan Kanso authored
Use the SWDB to store/delete descriptions, and query them all. TBR=tsepez@chromium.org Bug: 973844 Change-Id: I654b2922b1fb127ea5af36c499def079c9d66207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667116 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Leo Zhang authored
Implement DownloadImeFileTo in ImeServiceConnector by SimpleURLLoader and SharedURLLoaderFactory of the user, so that the IME service can access network service. Bug: 971954 Change-Id: Ib36c777bf13cbbf19b1e2348952858f2e8eadabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673255 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#672472}
-
Anders Hartvoll Ruud authored
This is just to change the initialization characteristics of the shorthand, to see if that makes a difference for the bug. BUG=957195 Change-Id: Icb0037219d4f080eb8e9c871f7588bb66038045e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676708Reviewed-by:
-
Rune Lillesveen authored
Determistic failure on some bots. TBR=dpapad@chromium.org Bug: 978792 Change-Id: I105f3597b5c475ae1f42f72762959a27495e3808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676649Reviewed-by:
-
Koji Ishii authored
This is a reland of f2dd14b6 The original patch snapped bounds for inline box, text run, and line box. Snapping inlne box matches to legacy, but it missed that legacy doesn't snap text run, and doing so regressed following test on Mac: external/wpt/intersection-observer/v2/inline-occlusion.html This patch limits the snapping only to inline box. Original change's description: > [LayoutNG] Snap bounds rect to pixel before hit testing inline boxes > > This patch fixes inline hit-testing by snapping bounds rect > only for inline boxes. The behavior matches to legacy. > > Bug: 976606 > Change-Id: I2532fd3d3439ec5e0bc3f73408b9cdc9b5454a7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676564 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672419} TBR=eae@chromium.org, wangxianzhu@chromium.org Bug: 976606 Change-Id: I4fb6d08db01d736eb3e229f4e3054e401518448b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677350Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#672469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/194ce3f152a1..cf11cf135aed Created with: gclient setdep -r src-internal@cf11cf135aed The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I4d3f476925858b4c100748ec9c3a9e5d1520e620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678123Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672468}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d556f63347d5..d16c4109ffab git log d556f63347d5..d16c4109ffab --date=short --no-merges --format='%ad %ae %s' 2019-06-26 rmcilroy@chromium.org [Devil] Double APK install timeout to 4 minutes Created with: gclient setdep -r src/third_party/catapult@d16c4109ffab The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934251 TBR=zhanliang@google.com Change-Id: I2c9867648efc3ed8a76d71dc93ba6abc8b17d976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678121Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a73180b38ccd..e88da56930f5 git log a73180b38ccd..e88da56930f5 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 treehugger-gerrit@google.com Merge "Move the default_socket.h into ext so that Chrome can pull it in to connect to the system service." Created with: gclient setdep -r src/third_party/perfetto@e88da56930f5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7f80162a4cd6c721a5286cc6468eb3fd5a81de95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677702Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d58266ed63a..166f0ab34656 git log 6d58266ed63a..166f0ab34656 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src df86bb44fe47..dfcb5a1e1042 (2 commits) Created with: gclient setdep -r src/third_party/angle@166f0ab34656 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ida5c2613947bd1badabbc5d3205dea7f26aa341c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678119Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8ba769fbe667330fa7f53d5f4b08f229320c254d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678122Reviewed-by:
-
Vadym Doroshenko authored
Bug: 831123, 978787 Change-Id: Id77f3ae3590a9d52557833cdc32a4dfd698bc981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677051Reviewed-by:
-
Rayan Kanso authored
Bug: 927726 Change-Id: I59ce8cffef9800cb2a70567bfe53d1da1cfa6711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635672Reviewed-by:
-
Pavel Shmakov authored
Features that are not yet extracted into separate targets should be able to use utilities in chrome/lib, such as lifecycle classes. Change-Id: I0d3a629881ee53db34713437e97ccd05695c697e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660848 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672461}
-
Friedrich Horschig authored
This CL removes fallback from PSL origins from the fallbacks since the UI has no indication in the accessory V1 to distinguish them from regular saved passwords. Bug: 976761 Change-Id: I466c3396b5c440218e37484ab70909d68d4df5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674095Reviewed-by:
-
Denis Kuznetsov authored
Reuse UI for multiple error screens. Bug: 811556 Change-Id: I93ceefc83c917c9c952f8957f5034f2884605f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674160Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#672459}
-
Yutaka Hirano authored
Also remove [ Failure ] expectation because it is no longer failing. Bug: 974675, 591099 Change-Id: I67b432b3971479e7662cd9bf3014e99de27090e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677349 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 969596 Change-Id: Ifac17477cba9ef9b1db419ce255c7baf7afef876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626065Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672457}
-
Monica Basta authored
This CL implements a mockup that shows a message in the profile chooser view explaining that sync is paused due to cookie settings set to clear cookies on exit. On click on 'your settings' within the message, the user gets directed to the cookie settings page. This view is only visible if sync is paused and cookie settings is set to 'clear cookies on exit'. Bug: 942456 Change-Id: Ia353fe6e5750b56a61d8771c09bea651a267810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664081Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#672456}
-
Tanmoy Mollik authored
Sign-out dialog in chrome did not give the user an option to wipe the local data in device. As a result it lead to some cases when someone would log out of the device but the local data would remain in the device and if someone else logged in and turned sync on that data would get synced to their account. Previously all data from device was wiped only for managed account. Added the new checkbox to give normal users the option to remove all local data. Screenshot: https://crbug.com/836778#c12 Bug: 836778 Change-Id: If34e843fca9232ee641ba69eb45054fa380e389d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593254 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#672455}
-
Simon Zünd authored
This CL adds four null pointer checks of an argument to various 'BindingSecurity::ShouldAllowAccessTo' methods. This fixes a crash that can occur when collecting stack traces where the global proxy object is involved. Bug: chromium:974291 Change-Id: Ic794d9f5b5779867390e358ec7932007e383958a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676709Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL fixes an issue where flag flips on System Web Apps wouldn't trigger reinstall because reinstall was gated on version change detection. This has been fixed by using version change detection to decide whether the apps should be force reinstalled or not, and now we always check for System Web App requested vs installed mismatch. Bug: 972926 Change-Id: I8c0647a87160166cacb6bf1f16ef830a6e3ecfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675207 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#672453}
-
Clemens Arbesser authored
This CL adjusts margins and paddings such that all touchable items in the autofill assistant payment request have a minimum size of 48dp*48dp. Where possible, margins were reduced and paddings were added to keep the same visual appearance with larger touch targets. Also, the privacy notice is now left and right-aligned with the rest of the payment request. Before: https://screenshot.googleplex.com/9q4uqGsqKnp.png After: https://screenshot.googleplex.com/tbjwR2sCxrj.png Touch targets before: https://screenshot.googleplex.com/OfaTnJGm3ty.png Touch targets after: https://screenshot.googleplex.com/DPq1Eovc21K.png Bug: b/135214309 Change-Id: I0ef92c7e5442bde35f6a639c94add9f3ee8ace46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670220 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672452}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/667fa910dad2..d9ae33420aaf git log 667fa910dad2..d9ae33420aaf --date=short --no-merges --format='%ad %ae %s' 2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d9ae33420aaf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3318c0a236fe7460edcb903bf950610fc4aeb0d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678117Reviewed-by:
-
