GitLab

Bug: 873219
Change-Id: I34a7c5024e84d6c2f65f1b6df122dde4ca3798f9
Reviewed-on: https://chromium-review.googlesource.com/1208359Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589052}

The original CL crrev.com/c/1199580 was reverted in crrev.com/c/1204599
because it broke windows compilation (File path literals etc).
This CL limits the compilation to linux and chromeos: the new changes
can be seen in crrev.com/c/1206675e/1..2

TBR=jbudorick@chromium.org, sandersd@chromium.org since the changes
are trivial re. the previous CL.

Original CL description -----------------------------------------------

jpeg_decode_accelerator_unittest is compiled and run on the CrOs
autotest infra, but is not compiled on the bots, when it possibly
should. This CL adds that target to the chromiumos_preflight of
the top level BUILD.gn.

Bug: 732531, 877694

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1199580Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588635}
Change-Id: Ic71fc5076484d30dda90654cd5501aa802258feb
Reviewed-on: https://chromium-review.googlesource.com/1206675Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589051}

Fix the flakiness by checking if all the subresources have
been actually fetched. This check is not really necessary since
the test additionally checks (via UMA) if the resource loading
hints were actually received by the renderer. The tests still check
if the resources that were vlocked via hints are indeed blocked from
loading.

Change-Id: I931570b73068250636916b0c234d17648976c84c
Bug: 866212
Reviewed-on: https://chromium-review.googlesource.com/1203321Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589050}

The semantics of document.activeElement and someElement.shadowRoot.activeElement
seem to have changed between Shadow DOM v0 and v1.

In V1 the following is possible:
someElement.shadowRoot.activeElement is null AND document.activeElement points to a child
belonging to |someElement|.

which does not seem to be the case for Shadow DOM v0.

Always recursing from document.activeElement seems more robust and works for both cases.

Bug: 875470
Change-Id: I53044c23bcfcfa85264b5154e635e44c05ce0f6f
Reviewed-on: https://chromium-review.googlesource.com/1208454Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589049}

This CL :
- Adds some LOG() info of the average time taken for image decoding
for sw & hw, (see e.g https://pastebin.com/raw/RKiGqjBS)
- Removes unnecessary {}

Bug: 877694
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id2147989456a0cb3cb2a64c3e89c355c0e736fa5
Reviewed-on: https://chromium-review.googlesource.com/1198524
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589048}

As described

TEST=None
BUG=None

Change-Id: I655413d632243de7a693fa0bdcaa4d53733aecc0
Reviewed-on: https://chromium-review.googlesource.com/1205474Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589047}

Add a feature to disable AudioContext playbacks counting
towards the MEI score.

BUG=878460

Change-Id: I486f3853ebc26a703e52712bee13600c99c7be14
Reviewed-on: https://chromium-review.googlesource.com/1204728Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589046}

The WebAudio spec says we must throw errors for a negative
rolloffFactor and for a coneOuterGain outside the interval [0,
1]. Make it so.

Also add some additional tests to ctor-panner.html to verify that a
rolloffFactor of 0 or 100 do not throw errors and that a
coneOuterGain of 0 or 1 do not throw errors.

Remove invalid tests from panner-rolloff-clamping.html because
negative rolloffFactor now throws an error.

Finally remove text expectation for ctor-panner.html test, which
passes now.

Bug: 879845
Test: the-pannernode-interface/ctor-panner.html, the-pannernode-interface/panner-rolloff-clamping.html
Change-Id: Ie90e9fe13e82fd3cc955060dc9e77266ef4ff591
Reviewed-on: https://chromium-review.googlesource.com/1205099
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589045}

This CL only handles the files in misc directories. The files in //net
were tackled in https://crrev.com/c/1188959. Parallel CLs tackle other
directories with significant diffs.

net::IOBuffer is (thread-safe) ref-counted. Asides from improving the
ability to reason about instance ownership locally, creating instances
via base::MakeRefCounted makes it possible to use 1-based ref-counting
in the future (see base/memory/ref_counted.h).

This CL is mechanical, to avoid introducing any behavior changes. The
difficult cases will be tackled by follow-up CLs. The following
transformations were performed.

* new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args)
* new IOBufferType => base::MakeRefCounted<IOBufferType>()
* scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) =>
  scoped_refptr x = base::MakeRefCounted<IOBufferType>(args)
* scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) =>
  base::MakeRefCounted<IOBufferType>(args)
* scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) =>
  auto x = base::MakeRefCounted<IOBufferType>(args)
* In comments: creates a new IOBufferType => creates an IOBufferType
  (so it wouldn't trigger future searches for "new BufferType")
* Instantiated static members in HttpResponseBodyDrainer,
  HttpNetworkTransaction, HttpProxyClientSocket, WritersTest,
  UDPSocketTest, TestDelegate, UDPSocketPerfTest
  (needed to fix linker errors)
* arraysize -> base::size (where needed to pass presubmit checks)
* git cl format

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I79c682e76b3cdcee8cc2093801664f97908861b5
Reviewed-on: https://chromium-review.googlesource.com/1189548
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589044}

There was a call to net::NetworkChangeNotifier::GetConnectionType() that
I missed in the intial NetworkChangeNotifier -> NetworkConnectionTracker
conversion. This migrates that over.

This also makes some changes to ScopedTaskEnvironment and
TestBrowserThreadBundle in order to get
ScopedTaskEnvironment::MainThreadType::MOCK_TIME working with
TestBrowserThreadBundle.

Bug: 868001
Change-Id: Ie7d87bdd854ff278a258b26f416c9643b3d4dbcd
Reviewed-on: https://chromium-review.googlesource.com/1185887
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589043}

We should try to install the Highlights app from the update url in
the two cases:

1) Offline enrollment, but offline resources are not available for any
   reason (should be a bug if it ever happens).
2) Online enrollment (will do in a follow-up CL).

In addition, enable app caching so that Highlights app can be launched
in cases when device is offline (but was once enrolled online).
Besides, the correct version of Highlights app can be determined
dynamically, so only one copy will be downloaded/cached to save
bandwidth and disk space.

Bug: 819404
Change-Id: Ia3b6d8d5222411474b106e1871bfbac6f0c755e5
Reviewed-on: https://chromium-review.googlesource.com/1194337Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589042}

When debugger is paused, holding Ctrl/Cmd highlights
Continue-to-location markers, and DevTools prevents scrolling from
adjusting zoom.

This CL checks whether we are paused somewhere, and allows zooming
via Ctrl-Wheel when not paused.

Bug: 878400
Change-Id: Ibe664f5241914b89fff9c5d7ae90658f2d803918
Reviewed-on: https://chromium-review.googlesource.com/1205537Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589041}

Verified sending reports with/without bluetooth keywords and the
correct tags are added.

Bug: 880978, 872403
Change-Id: If139bc6d5c894596fd97de7d234aae63bd88e4dd
Reviewed-on: https://chromium-review.googlesource.com/1208467
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589040}

This adds a second stage to OnStartTerminaVm in the form of a callback,
fired when Tremplin starts.

Bug: 879953
Change-Id: I9dee6f9750f03fb50c12b7473763abc966d0a7a7
Reviewed-on: https://chromium-review.googlesource.com/1203510Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Josh Pratt <jopra@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589039}

This adds full OOBE/first run end-to-end test.

Bug: 880804
Change-Id: Ib1ebe8a9f1412060236f7936de9e385a181a9a3b
Reviewed-on: https://chromium-review.googlesource.com/1206692Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589038}

Feed articles that have been prefetched may be displayed on other
surfaces. When this happens, it should feed back into feed update
scheduling and cause more articles to be fetched. This change wires up
notifications coming from Prefetch, through host logic, and ultimately
to the UserClassifier.

Bug: 874970
Change-Id: I4813564ff8ed0c7d315c2449a823e933a6067e8d
Reviewed-on: https://chromium-review.googlesource.com/1192696
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589037}

Bug: 880928
Change-Id: I373480d1431ba07e2f60332d429052d364f04ce2
Reviewed-on: https://chromium-review.googlesource.com/1207098Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589036}

The enum defined in the file is AXMode, so it's more
logical this way.

Uploading this required making a quick fix to a
PRESUBMIT.py script too.

BUG: none
TBR=nasko@chromium.org

Change-Id: Ic6ef5574645761767e9277e3d34568725deb383a
Reviewed-on: https://chromium-review.googlesource.com/1207353Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589035}

Similarly to pulse_stubs.cc, va_stubs.cc contains dlsym() resolved
functions which trigger cfi-icall failures. The affected builds of
Chromium do use out-of-tree patches to enable hardware-accelerated
video decode on Linux where the VA-API driver is installed, but it
would still be nice to have them work with cfi-icall enabled.

Change-Id: Iefa27f4b95007da23423d17727826adb8825b278
Reviewed-on: https://chromium-review.googlesource.com/1208830Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589034}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7467d2cf1be1c9113e5d371ada28614d9d57bc20
Reviewed-on: https://chromium-review.googlesource.com/1208414
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589033}

In 6e6fab4f, these tests were disabled
on all of OS_MACOSX even though they were only failing on 10.11. Try to
reenable them on other macOS versions.

Bug: 868667, 880496
Change-Id: Icf41045f3fbe032ef06d995e02a0ad1b9f977c24
Reviewed-on: https://chromium-review.googlesource.com/1207611Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589032}

https://chromium.googlesource.com/catapult.git/+log/638bda3a17c0..bcc3e491fb2e


git log 638bda3a17c0..bcc3e491fb2e --date=short --no-merges --format='%ad %ae %s'
2018-09-05 benjhayden@chromium.org Optimize change_internal_only
2018-09-05 anthonyalridge@google.com Add back assignment to all labels.


Created with:
  gclient setdep -r src/third_party/catapult@bcc3e491fb2e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:868512,chromium:866423
TBR=sullivan@chromium.org

Change-Id: I6d171eaf79fe7b80da39bd0a86bf5cdbb1343b0c
Reviewed-on: https://chromium-review.googlesource.com/1208290Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589031}

Update ShapeResultBloberizer to remove use of templates and instead call
ToStringView on TextRuns to allow the same implementation to be used for
both legacy layout and LayoutNG. A StringView has extremely low overhead
both in terms of creation and memory usage, should have no perf impact.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iaebcb3a5893d619950d1e7cc8c77fcef2015fffe
Reviewed-on: https://chromium-review.googlesource.com/1207095Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589030}

The overflow bucket for Navigation.ReadyToCommitUntilCommit accounted
for around half a percent of all data - this seems like too much.

Additionally, some Navigation.* metrics (like Navigation.StartToCommit)
used a 3 minutes cut-off, while others (like
Navigation.ReadyToCommitUntilCommit and Navigation.TimeToReadyToCommit)
used a 10s cut-off - this seems needlessly inconsistent (given that both
TimeToReadyToCommit and StartToCommit will likely spend most of their
time in network-related activities - e.g. waiting for responses from
remote hosts).

Because of the above, this CL consistently sets the overflow bucket
for Navigation histograms to 180s (which is based on
UMA_HISTOGRAM_MEDIUM_TIMES).

Note that this CL retains Navigation-specific underflow bucket which is
set at 1ms (like UMA_HISTOGRAM_TIMES or UMA_HISTOGRAM_LONG_TIMES and
unlike UMA_HISTOGRAM_MEDIUM_TIMES).

Bug: 848821
Change-Id: I4765d8c7dd6da076fb01e209cd02c524b5da9dbf
Reviewed-on: https://chromium-review.googlesource.com/1188977
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589029}

Background:
When assistant is opened, the mask layer of folder icon somehow
disappears to reveal the unclipped folder icon. The root cause is
unknown.

Changes:
Remove the mask layer completely and use skia lib to draw clipped folder
icon instead. This not only fixed the issue, but also improved the
animation efficiency (mask layer is expensive).

Bug: 879372
Change-Id: I240ef1bece839ff80957654de2c19d11fe97abf9
Reviewed-on: https://chromium-review.googlesource.com/1208468Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589028}

This CL fixes a rare issue in SelectableListLayout: if the data in the
adapter isn't changed after a call to initializeRecyclerView, then
RecyclerView visibility stays GONE even though there are items to
display. It happens because initially the visibility of RecyclerView is
GONE and it is only changed from AdapterDataObserver.onChanged. This CL
fixes the issue in bookmarks by calling notifyDataSetChanged after
bookmark model is loaded.

Bug: 789531
Change-Id: Ic424e636a87eed7fc6bbf50a49fdf875a18e5410
Reviewed-on: https://chromium-review.googlesource.com/1206009Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589027}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1b573e9f..fb0b7fe4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibd5ac4217f27c03bd7efc954d4e1b3679ef72d69
Reviewed-on: https://chromium-review.googlesource.com/1207100Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589026}

This CL adds a notification from DecoderStream to DecoderSelector when a
config change is detected. This allows DecoderSelector to be wholly
responsible for decoder change metrics.

All cases where the config change includes a codec change (and decoder
selection is successful) are logged to Media.MSE.CodecChangeTime.
The only time this should currently happen is for MSE changeType().

The HW and SW suffixes are mapped to the final (successful) decoder
selection, they can be read as 'to HW' and 'to SW'.

Bug: 877673
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I19fcd82775fd107b268bacf3d3dc5ed1ab6ca697
Reviewed-on: https://chromium-review.googlesource.com/1205499
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589025}

Any platform that didn't support the App Info menu item would not show
the correct menu due to a bug in the menu construction logic.

Bug: 880257
Change-Id: I26501b4968f65b089d9a17e25b036ccc1178d0d0
Reviewed-on: https://chromium-review.googlesource.com/1205921Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589024}

Before the |unlock_key| bool field was added to EasyUnlockDeviceKeyData,
only a single entry of the object was persisted to the TPM, and it was
implicitly assumed to be the unlock key. However, now multiple
EasyUnlockDeviceKeyData, objects are persisted to the TPM, and the |unlock_key|
field is used to explicitly determine which is the unlock key.

When this field was introduced, there was a critical oversight which failed
to correctly migrate old existing single-device entries in order to recognize
them as unlock keys -- they were recognized as local devices instead, causing
a host of issues (see attached bugs). This CL correctly migrates old, existing
TPM entries to be recognized as unlock keys, by recognizing when only 1 device
entry exists, and defaulting it to be an unlock key.

R=jhawkins@chromium.org

Bug: 866710
Change-Id: Ia5978deb49aad7d7f5dc81979544eb04e37dbe29
Reviewed-on: https://chromium-review.googlesource.com/1208352Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589023}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b9e6b164953..01f0c698fb89


git log 7b9e6b164953..01f0c698fb89 --date=short --no-merges --format='%ad %ae %s'
2018-09-05 ehmaldonado@chromium.org bot_update: Specify the target branch for patch_refs.


Created with:
  gclient setdep -r src/third_party/depot_tools@01f0c698fb89

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:870279
TBR=agable@chromium.org

Change-Id: I83a65c2d50b20527ef7f6864fee5cf425094c053
Reviewed-on: https://chromium-review.googlesource.com/1208730Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589022}

Now builds show as dirty when the .pak.info file format changes.

Bug: 
Change-Id: I54493ac3c8a3010358071523a784ce833dfd7db8
Reviewed-on: https://chromium-review.googlesource.com/1208252
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589021}

While comparing a rule against a url, url_pattern_index assumes that the
provided pattern and domains are in canonical form (internationalized domains in
punycode and non-ascii characters in percent-escaped utf8). Document this as
part of url_pattern_index and disallow indexing rules with non-ascii patterns or
domains.

BUG=879778

Change-Id: I725c37cd837c862ed3f0024c132ce2acf9c79642
Reviewed-on: https://chromium-review.googlesource.com/1198490
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589020}

Details please refer to the bug threads.

Bug: 880552, 880833
Change-Id: I90705523da9c513a70990647915422b574b02753
Reviewed-on: https://chromium-review.googlesource.com/1205536Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jason Guo <jiahuiguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589019}

This is a reland of f7f910d0 with
the changes from https://chromium-review.googlesource.com/c/chromium/src/+/1208293
applied.

Original change's description:
> Add ActivityTabProvider to ChromeActivity
>
> This patch adds ActivityTabProvider to ChromeActivity. This class
> provides an easy mechanism for classes that care about the tab
> that is currently in the foreground (i.e. not in the tab
> switcher/toolbar swipe/animation layout).
>
> The observer provides either the activity's tab or null depending
> on the state of the browser. The null event can be ignored depending
> on the listener.
>
> The ActivityTabObserver interface only has a single method:
> onActivityTabChanged(Tab t)
>
> When an observer is attached to the provider, onActivityTabChanged is
> called on only that observer with the current tab (giving it access
> without requiring a handle to a larger object).
>
> Bug: 871279
> Change-Id: Ice961224c6690dc79c38f5d6cb255fed4730c8ce
> Reviewed-on: https://chromium-review.googlesource.com/1165489
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588872}

TBR: tedchoc
Bug: 871279
Change-Id: I9c17590de19db025110cda2171cd1f8d9c1ffa57
Reviewed-on: https://chromium-review.googlesource.com/1208714Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589018}

In a few places in the code we call AXTreeSerializer::Reset
when there's a tricky reparenting issue or when we really
want the accessibility tree to be re-serialized from
scratch (like when the mode changes).

However, this can lead to a corner case where the next
update from the serializer can't be unserialized, because
the client tries to unserialize it as an incremental
update, but it contains some reparenting.

The trick is to just ensure that we always set
node_id_to_clear on the next update after a reset.
That also requires us to relax the previous requirement
that node_id_to_clear must be valid. Now the
serializer sets node_id_to_clear to be equal to the
root after a reset, to guarantee that the client ends
up with a fresh start.

Bug: 878325
Change-Id: Iff255a3f62e47363be0b3d9c2f6809c229a6a00f
Reviewed-on: https://chromium-review.googlesource.com/1198009Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589017}

In the hope that this is faster. This also matches the style we use
elsewhere in the code.

Additionally, this makes a small change to NGLayoutResult to avoid
an unnecessary adddref (PhysicalFragment() constructs a new scoped_refptr)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9d59180ca0f6c95401ae2d7e36616244d66c59d6
Reviewed-on: https://chromium-review.googlesource.com/1208251Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589016}

It's no longer in *active* development but it's a good feature and we
hope to get back to it.

Marked all the tests as Failure.

Bug: 174167

Change-Id: I9ec257a2ac644ccc8588043c63c796aa8185094b
Reviewed-on: https://chromium-review.googlesource.com/1208432
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589015}

A wrong value of GetDetectedValues was used (after addresses were elided). This
change stores the value of GetDetectedValues so it's not re-computed.

Bug: 878416
Change-Id: Ifd8190148a0bf8dd3643da4016fb41dea3cc1ae3
Reviewed-on: https://chromium-review.googlesource.com/1208194
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#589014}

@protocols do not create symbols so there's no need to export them.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1cc08845aa95a478805838dce476a15f4b57ec50
Reviewed-on: https://chromium-review.googlesource.com/1205492Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589013}