- 31 Jul, 2017 30 commits
-
-
Sigbjorn Finne authored
TBR=haraken,jochen NOTRY=true Change-Id: I764c7f96d306867c8fd0e1dda4f498bfc1285f87 Reviewed-on: https://chromium-review.googlesource.com/593310Reviewed-by:
Sigbjørn Finne <sigbjornf@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sigbjørn Finne <sigbjornf@opera.com> Cr-Commit-Position: refs/heads/master@{#490722}
-
Xiaocheng Hu authored
This patch prunes a call site of the deprecated function by hoisting the layout update out from it. Bug: 698633 Change-Id: I483f06de2e1c3e0c4b99403ca9a4b2a48dae9517 Reviewed-on: https://chromium-review.googlesource.com/593208 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#490721}
-
Kent Tamura authored
We'd like to fix the root cause of these failing tests. They are still skipped because we know they will time out. This CL has no behavior changes. NOEXPORT=true TBR=kochi@chromium.org Bug: 749492 Change-Id: I4431045838e7ba1252db3a35ca3364fd6cb5e6e9 Reviewed-on: https://chromium-review.googlesource.com/593379 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490720}
-
Eric Seckler authored
Exposes a setting and an interface for enabling externally-controlled BeginFrames in ui::Compositor and adds a command line flag for the full-pipeline scheduling mode. Bug: 646774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I923b5ab66652c65c1384b9fe5075c0a427559fc6 Reviewed-on: https://chromium-review.googlesource.com/558252 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#490719}
-
Yutaka Hirano authored
It's used by no one. Bug: 748491 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I88c95aca41625d3600c64d1de379a24159c33fd2 Reviewed-on: https://chromium-review.googlesource.com/587701Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#490718}
-
Yuki Yamada authored
This patch Mojoifies WebContentSettingsClient used by shared worker. SharedWorkerContentSettingsProxy is created in browser, and then passed onto renderer. Inside blink, it gets some content settings information from browser via mojom::SharedWorkerContentSettingsProxy. Replaced by SharedWorkerContentSettingsProxy, EmbeddedSharedWorkerContentSettingsClientProxy was removed. There are no useful tests for indexeddb or filesystem, so I tested this patch by hand, Using some .js and called indexeddb.open and webkitRequestFileSystem. https://crbug.com/113738 is for adding indexeddb tests, and it is still available. Bug: 739092 Change-Id: I5523b3ba533707416452a56c5f04250a1117ba15 Reviewed-on: https://chromium-review.googlesource.com/562854Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#490717}
-
Bugs Nash authored
This patch deleted the duplicated methods accudentally introdued in https://chromium-review.googlesource.com/c/578538/ when they were supposed to be moved from CSSPropertyParser.cpp to CSSPropertyGridTemplateAreasUtils.cpp but instead they were copied. Bug: 668012 Change-Id: I3c7b32911fcc8ff64a200f1bdfb06cd17d15fd0a Reviewed-on: https://chromium-review.googlesource.com/593371Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#490716}
-
Eddy Mead authored
TBR=ericwilligers@chromium.org Bug: 750549 Change-Id: If67efe435530c714a3960c928a6e7c5bd71ca40e Reviewed-on: https://chromium-review.googlesource.com/593376Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490715}
-
Yutaka Hirano authored
Bug: 748491 Change-Id: I5e86bf7a56def07546b17362f1e0c71395512b58 Reviewed-on: https://chromium-review.googlesource.com/577470 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#490714}
-
Erik Chen authored
The original CL added more end-to-end tests. They set a limit of 1 GB as a "sanity check". On 32-bit Windows, each renderer has ~500MB of committed memory. Across multiple renderers, this easily exceeds the limit. This reland updates the "sanity checks" to be 4 GB instead. > The URLs are obtained by creating a new interface CoordinationUnitIntrospector > on the resource_coordinator service. The implementation of this interface crawls > all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by > looking at associated FrameCoordinationUnits. > > The interface for memory_instrumentation is modified slightly to include pid in > ProcessMemoryDump to allow correlation between the memory dump and the URLs > obtained from resource_coordinator. In a hypothetical future world where > memory_instrumentation and resource_coordinator live in the same service, this > can be removed. > > Bug:730783 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 > Reviewed-on: https://chromium-review.googlesource.com/578482 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490668} Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I98d979303b095ee386228ac93d234fe8c8367b3e Bug: TBR: thestig@chromium.org, oysteine@chromium.org, rkaplow@chromium.org, avi@chromium.org, primiano@chromium.org, dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/592539Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490713}
-
Yutaka Hirano authored
It should consult |domain_| to check nullity. Bug: 748491 Change-Id: I99a37ecc145c873c0ab191d005a1f15b47aeed7a Reviewed-on: https://chromium-review.googlesource.com/576015Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#490712}
-
Darren Shen authored
1. Moves: - build/scripts/{ => core/css}/css_properties.py 2. Adds several __init__.py files so that core/css is considered a package, which allows css_properties.py to be imported as a module by other files, 3. Updates any references to this file with its new path. 4. Fix linter errors. Bug: 732657 Change-Id: I2c15f79f7143c4d965252fbb7f6af4acdce719f0 Reviewed-on: https://chromium-review.googlesource.com/590828 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#490711}
-
Zhen Wang authored
Internal pages are deferred to load after other pages. Bug: 730098 Change-Id: I3b8f2dbbb1d7e2e4d858750432597e882ef60b9f Reviewed-on: https://chromium-review.googlesource.com/585241 Commit-Queue: Zhen Wang <zhenw@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#490710}
-
Giovanni Ortuño Urquidi authored
Rather than concatenating we use GURL::Resolve() to get an absolute URL based on the manifest URL and the url_template. Change-Id: Id74041fcca6f34a898fc8c9794fc0965a1f4ccd8 Reviewed-on: https://chromium-review.googlesource.com/587704 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#490709}
-
Matt Giuca authored
The ImageLoader now std::moves the ImageFamily into the callback, rather than holding onto a reference throughout the duration of the callback. Fixes a data race in ScheduleCreatePlatformShortcut where the ImageFamily could not be safely handed off to the other thread (because the ImageLoader was still holding onto a reference). Bug: 749342 Change-Id: I1452e47c892660e5fd06e27e3a0582240a5cbcec Reviewed-on: https://chromium-review.googlesource.com/590338Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#490708}
-
Qiang Xu authored
context: In crbug.com/490597, 2x image is used for HiDPI blur issue. Then there is a CL "Migrate LauncherSearchResult to use SetBadgeIcon", https://codereview.chromium.org/1200543003, which I think it removes the proper handling of the size of this 2x loading. changes: When custom icon is loaded, resize it to proper size. HiDPI screenshot: https://screenshot.googleplex.com/2rWk8akUx99 Test: tested that it works fine now, screenshot: https://screenshot.googleplex.com/u9BapUpenhu Bug: 723021 Change-Id: If18a59e7aaeed48e9a0e88409f8672d057eb986a Reviewed-on: https://chromium-review.googlesource.com/592415Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#490707}
-
Matt Menke authored
Bug: 715695 Change-Id: I093262cfefeca6b70eb09c9d94764f4ed4f786c2 Reviewed-on: https://chromium-review.googlesource.com/583632 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#490706}
-
Kent Tamura authored
According to the specification, relative URL of base[href] should be resolved with document's fallback base URL, not document's URL. Bug: 739504 Change-Id: I811e8b14d7130873a4ffa6d45a094407f9e8a098 Reviewed-on: https://chromium-review.googlesource.com/590632Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490705}
-
Matt Giuca authored
Image: - Adds move constructor/assignment. Not technically required as Image is cheaply copyable, but this allows more efficient moving without incrementing/decrementing the refcount. Also safer for multi-threaded usage. - Removes SwapRepresentations. Was unused, and superseded by std::move. ImageFamily: - Removes copy constructor/assignment. ImageFamily can be fairly heavyweight, so it's best to move it rather than copying. Also it is heavily used across threads and accidental ImageFamily copying is responsible for data races (https://crbug.com/749342). - Adds Clone method, an explicit copy operator for use if necessary. - Adds move constructor/assignment. This should be used where possible. BUG=600237,749342 Change-Id: I00482c8440d62edb8d9fb216c3de65bf4102d153 Reviewed-on: https://chromium-review.googlesource.com/588033Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#490704}
-
Kinuko Yasuda authored
Bug: 739603 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I4ea6792a6412df74225da50db214889bb1d02a26 Reviewed-on: https://chromium-review.googlesource.com/588875Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490703}
-
Nico Weber authored
Bug: 554717 Change-Id: I5f597f879b4cca5a2ce1702b635d7c81c5e620a9 Reviewed-on: https://chromium-review.googlesource.com/593154Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490702}
-
Kunihiko Sakamoto authored
This will be used to understand the effect of YieldBetweenContentScriptRuns experiment on page load time. Bug: 636655 Change-Id: I7978daa7361c73ba5b835dbc21402b8cb7d73ae3 Reviewed-on: https://chromium-review.googlesource.com/571246Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#490701}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: Idd978a50f79ec051645fa20fc4d45164487d7d0c Reviewed-on: https://chromium-review.googlesource.com/593215Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490700}
-
meade_UTC10 authored
This reverts commit fc83d355. Reason for revert: Seems to have broken various tests on content_browsertests failing on chromium.win/Win7 Tests (dbg)(1) webkit_tests failing on chromium.webkit/WebKit Win10 webkit_tests failing on chromium.webkit/WebKit Win7 (dbg) See http://crbug.com/750540 for more details Original change's description: > Using SwiftShader for Layout Tests on Windows > > Turing on SwiftShader for Layout Tests on Windows. > Added expectations for tests which will require rebaselining. > > Bug: 726075 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ida42b4f47061436d512230059f0ffd9240658b80 > Reviewed-on: https://chromium-review.googlesource.com/514443 > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490686} TBR=sugoi@chromium.org,kbr@chromium.org,capn@chromium.org Change-Id: Ie1c01eabb2b92cbe5cf988a7b67f0b3a76afcdf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726075, 750540 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/593068Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490699}
-
Jinsuk Kim authored
The reported crash indicates that WebContents object is null when WebContentsAccessibility object gets instantiated. This may happen if AccessibilityNodeProvider is requested after WebContents/CVC get destroyed. In which case we should not proceed to creating one but return null instead. BUG=749761 Change-Id: If74945442fd6d05f2f2090c6e0a6aca375fb04f2 Reviewed-on: https://chromium-review.googlesource.com/590887Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#490698}
-
Hiroki Nakagawa authored
This CL removes the RunningWorkerInstances set that was introduced for terminating all service workers for the leak detector[1], but no longer used. [1] https://codereview.chromium.org/413993002 Bug: 507224 Change-Id: Idcaee369cf5f4fc5c9221a0600ba8ec825369b44 Reviewed-on: https://chromium-review.googlesource.com/592995Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#490697}
-
Stuart Langley authored
I'm starting with the simplest of changes, which includes. - just changing the header file over and transitively including WebLocalFrameBase temporarily. - places where WebLocalFrameBase was being used as a local variable. I'll split this into multiple CL's to help it go through the CQ. Bug: 731490 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I40a62619be3ef4034c048f8d17e52404eccd74ab Reviewed-on: https://chromium-review.googlesource.com/590591Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#490696}
-
Matt Falkenhagen authored
Update expectation from timeout to failure after r490666. TBR=ananta NOTRY=true Bug: 715632 Change-Id: Ie7932b83bbd0e409da1ffc5d3acfad26c28f3efb Reviewed-on: https://chromium-review.googlesource.com/592999Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#490695}
-
Trent Apted authored
Arabic text rendering got fancy, so the test strings would no longer create text runs with a matching number of glyphs. Use a simpler string that just repeats the same character. Bug: 748512 Change-Id: Ia1b61d3cf564ffdc9ff22f8406e4072e06e323a4 Reviewed-on: https://chromium-review.googlesource.com/590345Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490694}
-
Trent Apted authored
One of the characters in the test got fancy causing a wild glyph to appear. Use a less fancy character. Bug: 748512 Change-Id: I22dfcf22f28326b0d9aaeea141d99704c91a8c84 Reviewed-on: https://chromium-review.googlesource.com/590339Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#490693}
-
- 30 Jul, 2017 10 commits
-
-
Koji Ishii authored
The :first-letter pseudo element may not be a child of the element in style/box tree. For example: <div><span>text</span></div> creates: <div> <span> <div:first-letter>t</div:first-letter> ext </span> </div> FirstLetterPseudoElement computes this correctly on creation, but inherited from <div> on RecalcStyle(). This patch fixes the inheritance on RecalcStyle() too. Inline layout code assumes that a text box has the same style as its parent inline box. The incorrect style on FirstLetterPseudoElement breaks this assumption. Bug: 450002, 507757, 739800 Change-Id: Icda675f5ffbb705c4b87f9d23cca34f24c4763ee Reviewed-on: https://chromium-review.googlesource.com/593067Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490692}
-
Bugs Nash authored
This patch - Changed CSSParserContext argument from * to & for null safety and readability in the remaining utils files in core/css/properties - Changed the CSSPropertyParserHelpers::ConsumeCommaSeparatedList parameter pack argument to a universal reference with perfect forwarding so that reference arguments can be passed through it. Bug: 668012 Change-Id: I5e607c9a1f8e26d7848092468d666f9879711941 Reviewed-on: https://chromium-review.googlesource.com/590910Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#490691}
-
Robert Hogan authored
Bug: 714862 Change-Id: Ic584853df872456a788b3ef45a06d8c346f50516 Reviewed-on: https://chromium-review.googlesource.com/593307Reviewed-by:
Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490690}
-
Zijie He authored
This is a reland of 62d23080 Original change's description: > Implement EvaluateCapability and its tests > > This change adds --type=evaluate_capability command line parameter to execute > host binary in "evaluate capability" mode. Meanwhile a helper function > int EvaluateCapabilityForkedly() has been added to execute the host binary to > evaluate certain functionality, and retrieves its output. > > Return value is too simple for the evaluation, e.g. for DirectX capturer, both > initialization result and DirectX version are required. To make it simple, in a > coming change, we can directly output the host attributes regarding to the > DirectX capturer into console, so the network process needs not to execute any > DirectX related logic. > > Bug: 741926 > Change-Id: Ief06bed7b9297318bd387106108eccd02180e066 > Reviewed-on: https://chromium-review.googlesource.com/575730 > Commit-Queue: Zijie He <zijiehe@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490121} Bug: 741926 Change-Id: I9b882afbc415613ecc3308e7e1b95806d0ae8051 TBR: joedow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/592009 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#490689}
-
Kenneth Russell authored
On current Android versions there is a race condition while sending the application to the background. The browser attempts to drain its graphics pipeline and cease rendering, but in the meantime one call to eglSwapBuffers fails. This causes the compositor's context to be lost, and since this is treated as a severe failure, it causes all active WebGL content to be blocked. To work around this problem but maintain strictness on other platforms, add a time-expiring driver bug workaround that applies to the current and next Android release. BUG=744678 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4eb1344f17b6b12cabf8964856e0645473797a8e Reviewed-on: https://chromium-review.googlesource.com/584037Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490688}
-
Jialiu Lin authored
Add function to handle warning on shown events, and warning completed events. These event handling covers UMA recording, updating security state, update cached verdicts, and etc. Bug: 741138 Change-Id: I5945a7d28244672e52bd00be67e17165b680a122 Reviewed-on: https://chromium-review.googlesource.com/585780 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#490687}
-
Alexis Hetu authored
Turing on SwiftShader for Layout Tests on Windows. Added expectations for tests which will require rebaselining. Bug: 726075 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ida42b4f47061436d512230059f0ffd9240658b80 Reviewed-on: https://chromium-review.googlesource.com/514443 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490686}
-
Nico Weber authored
This reverts commit 1d8d254c. Reason for revert: Fails on win7: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61933 Original change's description: > Plumb URLs through memory_instrumentation UKMs. > > The URLs are obtained by creating a new interface CoordinationUnitIntrospector > on the resource_coordinator service. The implementation of this interface crawls > all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by > looking at associated FrameCoordinationUnits. > > The interface for memory_instrumentation is modified slightly to include pid in > ProcessMemoryDump to allow correlation between the memory dump and the URLs > obtained from resource_coordinator. In a hypothetical future world where > memory_instrumentation and resource_coordinator live in the same service, this > can be removed. > > Bug:730783 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70 > Reviewed-on: https://chromium-review.googlesource.com/578482 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Oystein Eftevaag <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490668} TBR=avi@chromium.org,dcheng@chromium.org,thestig@chromium.org,primiano@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,oysteine@chromium.org Change-Id: I0120cea65f8e95f787d15579e427b9b3bab86187 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730783 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/593213Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490685}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c25437da5c6a..50b2084bd15e $ git log c25437da5..50b2084bd --date=short --no-merges --format='%ad %ae %s' 2017-07-29 fmalita Gradient stages cleanup Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I00a4ca54d2310622544c2d46bebf0c7607eaae9e Reviewed-on: https://chromium-review.googlesource.com/593094Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490684}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/77c6866668ac..c25437da5c6a $ git log 77c686666..c25437da5 --date=short --no-merges --format='%ad %ae %s' 2017-07-30 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: If097fa1c144652f2771683358781be930aeeb608 Reviewed-on: https://chromium-review.googlesource.com/592853Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490683}
-