- 23 Dec, 2020 16 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b21e1d48..407251b8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib067f4b538e9f1d6cf29c63a669eb8f512afee99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601537Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839015}
-
Peng Huang authored
I found the crash happens with NVidia driver, if an Intel GPU is being used, but vkGetPhysicalDeviceXcbPresentationSupportKHR() is called for NVidia device. Fix the problem by checking device id first, and don't call vkGetPhysicalDeviceXcbPresentationSupportKHR(), if device id doesn't match. Bug: 1153027 Change-Id: Ib5b3b5f168ebd7665c31c8996148301c34ce34a2 Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-p-pixel-2-skv-32,gpu-fyi-try-linux-intel-skv,gpu-fyi-try-linux-nvidia-skv Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601065 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839014}
-
Andrey Kosyakov authored
Rebaseline virtual/controls-refresh-hc/.../search-appearance-basic with actual results on Mac10.1{2,4} ... following https://chromium-review.googlesource.com/c/chromium/src/+/2588810 that caused some Mac builders to fail. TBR: masonfreed@chromium.org, sasebree@microsoft.com, rakina@chromium.org Bug: 1157191 Change-Id: I2da8b422b8a63c506002e5c4987dc06da92635ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601618Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#839013}
-
Nasko Oskov authored
This CL removes most PerNavigationMojoInterface references from the codebase. Most importantly, it removes the RenderFrameHostImpl::DidCommitPerNavigationMojoInterfaceNavigation which is no longer necessary and is quite long name to read. Bug: 1020175 Change-Id: I71f2d4a7e3f9df08e728bfed08ba67b2125d8068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600793Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#839012}
-
My Nguyen authored
Bug: 1157309 Change-Id: Icc6c3262202df4d69bc4deed1280bbdaa09319b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599574 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839011}
-
Adrian Taylor authored
This diagram may be helpful for contextual understanding of the detailed steps elsewhere in this how-to. Change-Id: Ib5fb340b214ba582d2fe5cbec32217e9e90291a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583206 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#839010}
-
Zach Trudo authored
Bug: chromium:1161038 Change-Id: I23787c9173517265c8ec2625f1987fcbcc136f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601476 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839009}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d91ce64b5aed..b0113192a709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106990 Tbr: caseq@google.com Change-Id: Ia4bf513f56722ad23516f47007ea0c2f14004350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601500Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839008}
-
Lan Wei authored
This reverts commit b63d9387. Reason for revert: ModeSelectionWindowCycleControllerTest.NoWindowInActiveDesk fails on Linux Chromium OS ASan LSan Tests. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/39122 Original change's description: > Bento: Support switching between two Alt-Tab modes. > > - Add a tab slider and update windows shown in Alt-Tab so that > "Current desk" mode only display windows in the active desk, while > "All desks" display all windows. > - Handle special cases: As before, entering Alt-Tab with less than two > windows aren't allowed. However, if users switch from the all-desks mode > to the current-desk mode resulting in zero or one window, > it should show "no recent items" or show a window consecutively. > - Hide behind Bento flag and make sure to overwrite > kLimitAltTabToActiveDesk in case of conflict, so the old flag works. > - Disable remapping Alt+LeftClick to a right click when using Alt-Tab. > - Ash unittests for switching between modes and special cases. > > Bug: 1142726 > Test: A manual test (a video in crbug) and unit tests > `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.*` > > Change-Id: Ia203358d0b658529a3090a292ae36850ea60a36a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581684 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838709} TBR=xdai@chromium.org,afakhry@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,cattalyya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142726 Change-Id: I26aeb2448fe7d989d8bc5a7c77a117808ee16ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601580Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#839007}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic2a457fdbaa848d70508edd87a78b272ba41e522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839006}
-
My Nguyen authored
Bug: 1157309, 1161062 Change-Id: I9c3cb7c1b77cef27df29117c49e9ae23db12a5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598085 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#839005}
-
Theresa Wellington authored
BUG=1161326 TBR=michaelbai@chromium.org Change-Id: I027ce1dfb1543c8e047b2d8d6e752d919a496ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601617Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#839004}
-
Austin Sullivan authored
Bug: N/A Change-Id: Id9961b338d1045692957ba7622d0db89f4d7a7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601583 Commit-Queue: Austin Sullivan <asully@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#839003}
-
Zhenyao Mo authored
BUG=1161303 TEST=bots R=magchen@chromium.org,kbr@chromium.org Change-Id: I1dfbb9a4cd15c7d8a9e1501c3fd697ae055e05bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600795Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839002}
-
Wenyu Fu authored
Make sure during screen orientation changes happens when the disclaimer is still on the screen. Change-Id: Icd6fa16de94b84c8acb8e4666ebfd27074629eca Bug: 1157611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600042Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839001}
-
David Bienvenu authored
When unittests.exe runs more than one of these tests, the second one fails because it creates an empty test factory for StatefulSSLHostStateDelegate. The PageInfoBubbleViewTests need a normal factory, so the empty test factory causes a check fail. Bug: 956719 Change-Id: If7d0b14574cf866512fe3c3fbe24b58bb66e69f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600265 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#839000}
-
- 22 Dec, 2020 24 commits
-
-
Shrek Shao authored
This reverts commit 99314be8. Reason for revert: culprit found. Findit incorrectly reports flakiness. Original change's description: > Suppress WebGL test conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html > > Suppress conformance/textures/webgl_canvas/tex-2d-rgb-rgb-unsigned_byte.html on > chromeos amd as RetryOnFailure > > TBR=kbr@chromium.org > > Bug: 1161258 > Change-Id: I9f9bcd2084c37fe87f422878dca63ce5d2e82647 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601185 > Reviewed-by: Shrek Shao <shrekshao@google.com> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#838975} TBR=kbr@chromium.org,shrekshao@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idbc2e4dc446544125c6f36d1e502bfc47e9e42b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1161258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601543Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#838999}
-
Wenbin Zhang authored
[benchmarking] disable system_health.memory_mobile/browse:social:pinterest_infinite_scroll:2019 on android go and pixel2 The story is consistently failing on those builders. Bug: chromium:1161268 Change-Id: Ib82acf22b2d5222c33f7dbe9400d0be89f64f728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600791 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838998}
-
Josiah K authored
Fixed: 1161313 Change-Id: Iaa0d22f1a59fd361e7bbb5436f268b11847b6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601538 Auto-Submit: Josiah Krutz <josiahk@google.com> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#838997}
-
Stephen McGruer authored
We are seeing issues on Windows + Python 3 where a high number of processes passed to multiprocessing.Pool causes the Pool to crash and manifest generation to hang. (Very similar or identical to https://bugs.python.org/issue40263). This is a temporary local patch to Blink's copy of WPT tooling, in order to land a workaround as quickly as possible. A proper upstream fix in WPT should be landed soon, so that we do not have to carry this patch for too long. Care should be taken in the meantime not to override this fix if/when we roll Blink tooling. Bug: 1160108 Change-Id: I8eda8d65caa8cd295ae444676f4628832225f55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601399Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#838996}
-
Alex Turner authored
Currently, TestNavigationObserver ignores all uncommitted navigations, even though they pass through DidFinishNavigation. This can be confusing and does not allow tests to wait for a navigation that will not commit. We thus add an option for whether to ignore uncommitted navigations. To preserve existing functionality, it defaults to true (i.e. ignoring them). This functionality will be used in crrev.com/c/2348150 to wait for a navigation to a URL blocked by the subresource filter. Bug: 1021572 Change-Id: Ic76f039eaa24cd41cae4cb63382060311e9860f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596094 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838995}
-
Lan Wei authored
webxr/xrSession_requestReferenceSpace_features.https.html is flaky on MAC bots Mac10.15 Tests. TBR=klausw@chromium.org Bug: 1161301 Change-Id: Ia885d0a6f10ea7c0b9262a9c8d4a886564bf1c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601066Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838994}
-
Lan Wei authored
SingleClientExtensionAppsSyncTest.StartWithSomePlatformApps is flaky on MAC bots Mac10.15 Tests. TBR= ericwilligers@chromium.org Bug: 1161309 Change-Id: I89aa193b5c1f7a90545776e53bb29bf0e258515a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601556 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838993}
-
Lukasz Anforowicz authored
The tests just document the current behavior: 1. When ActiveTab permission is granted, then CORS is relaxed for fetches from the extension background page in regular profile. 2. There are some minor issues with how incognito profile is handled. Bug: 1153952 Change-Id: Ic0574b0c452e67a1a1bf38afa9c7ca45810b6f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585673 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#838992}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/735ac97eb4dc..f202babd6a03 2020-12-22 johnstiles@google.com Update 'determinant' intrinsic to use $square(H)Mat. 2020-12-22 brianosman@google.com Remove 'flags' feature from particles 2020-12-22 michaelludwig@google.com Skip drawing line when half width underflows 2020-12-22 johnstiles@google.com Reland "Add support for range-based for loops to SkTHashSet/Map." 2020-12-22 mtklein@google.com force portable features 2020-12-22 michaelludwig@google.com Add halfWidth/halfHeight functions to SkRectPriv 2020-12-22 brianosman@google.com Simplify raincloud particle effect 2020-12-22 adlai@google.com Revert "Yank out old reduceOpsTaskSplitting code" 2020-12-22 johnstiles@google.com Elide return expression temp-var in vardecl-less blocks. 2020-12-22 brianosman@google.com SkSL: Hide non-square matrices from runtime effects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1146701,chromium:1160579 Tbr: bungeman@google.com Change-Id: Ib0515ff22c6817b79ba84f55e06a9b1ae0e07e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601448Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838991}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic74ddfbc2a56687bd8a1cb980de29a8a86faaa76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601328Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838990}
-
Theresa Wellington authored
BUG=1161272 TBR=meiliang@chromium.org Change-Id: Idc2d711ff2fe8e3e872912124b3b341824a2af7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601334 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#838989}
-
Jared Saul authored
- Cardholder name fix flow prompts are still useful - The Butter histogram's usefulness is less clear, but as it still shows the ratio of whether users have opted-in to Butter via the Autofill suggestions dropdown, IMO it can stay a little while longer. Fixed: 1160783, 1160784 Change-Id: Ie2f1c6b3e82b0f1d11c4648fadbb4db7033f911b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600357Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#838988}
-
Zhenyao Mo authored
The way we compute feature status and problems identified depends on a few global states for example, if gpu compositing is enabled at the time when we do the computing. So currently when we compute the info for hardware gpu, if we already fallback to SwiftShader, then the global states may have changed. This is not what we want. We want to capture a state of info where we were still using GPU acceleration. So the fix here is that we also cache these global states for the later computing. BUG=1154047 TEST=manual R=kbr@chromium.org Change-Id: Ie9abedafe28a36f635bbe8bff183ba52495f4404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594315 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#838987}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e1ecd9b7c6ef..0af374b04bee 2020-12-22 andoli@chromium.org [module.json extensions] Migrate profiler settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00b9861fb4a9a3e9fc01d9881da0ecdf3c89132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838986}
-
Jao-ke Chin-Lee authored
Previously, VA configuration was tied to VaapiDevice, meaning that the VAProfile was static per VaapiDevice. This also forced users of decode_test to specify the profile and codec, i.e. VP9Profile0, even though the decoder can deduce both. Separate out ScopedVAConfig and introduce SharedVAContext so that decoders can manage this configuration and the configuration can manage its own lifetime, allowing decode_test to be used on most streams that change profile or resolution mid-stream. BUG=chromium:1062407,b:175909299 TEST=./decode_test -video=resolution_change_500frames-vp9.ivf -out-prefix=res_change/frame on nautilus Change-Id: I32ad5dfab57851166ce31844f6609784fbcaf900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358989 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#838985}
-
Dominic Mazzoni authored
I suspect that in the AddNodeChildren() loop, soemthing is causing the current object to be deleted. Bug: 1158511, 1158385 Change-Id: Ic393b5163616dc6a4995c43d22ac2e2d627656c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596792 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#838984}
-
James Cook authored
The UX plan for UI language is to use a single shared locale for OS and browser. See bug. Pass the locale on the command line because Lacros needs it very early in startup, before zygote fork. This CL doesn't include the changes to browser WebUI settings. We'll need to add a link-out to OS settings, similar to how Chrome OS browser settings work today. Bug: 1139618 Change-Id: I0202ed54d4c4a4956ecb31f04ecde670aea5595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600316 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838983}
-
Xinghui Lu authored
Remove kill switch flags to reduce code complexity. Flags removed: kRealTimeUrlLookupEnabledForEP kRealTimeUrlLookupEnabledForEPWithToken kRealTimeUrlLookupNonMainframeEnabledForEP Bug: 1086752 Change-Id: I691dd054e336396d1efd897106dd9e1f6237c7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601320Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838982}
-
Lei Shi authored
Currently, the backward sentence navigation takes the user to the closest sentence start before the current position. If the user wants to go to the previous sentence, they have to click the backward button at the beginning of the current sentence before TTS speaking any word. This poses interaction challenges as the user has to compete with the TTS engine. After consolidating with our UXD, we plan to change the behavior of backward sentence navigation. Clicking the backward button will always go to the previous sentence, regardless of the user's position at the current sentence. However, we need to keep the behavior of the pause and resume feature, which brings the user back to the start of the current sentence. This CL modifies navigateToNextSentenceWithinNodeGroup_ and navigateToNextSentence_ to allow callers to set whether we will skip the current sentence when navigating backward. AX-Relnotes: N/A. Bug: 1143823 Change-Id: I71d05f62f38cb3dbba31b6375f11b537b611b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597178 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838981}
-
Rakina Zata Amni authored
Currently WebNavigationParams::FillStaticResponse will always result in a http_status_code of 0, even when the browser side got a HTTP response before committing (e.g. some cases with data URLs, error pages). This CL ensures that static responses will use the HTTP status code given by the browser side at commit time, by saving it in WebNavigationParams. Bug: 1155414, 1131832 Change-Id: I12658ccf0bec420168c5e14cb909da77fa104a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599779 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838980}
-
Rakina Zata Amni authored
The code that sets is_overriding_user_agent in RenderFrameImpl's MakeDidCommitProvisionalLoadParams depends only on the value from the CommitNavigationParams (and whether it's a main frame or not), meanwhile the currently-used NavigationRequest::IsOverridingUserAgent depends on |entry_overrides_ua_| as well, so the browser-calculated value might differ currently. Bug: 1155414 Change-Id: If285669f74b3fa7c3cd35389edcb414ea4a937ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596665Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#838979}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608638224-48eff614fc6cab6a979b2689e49e6c5a36101630.profdata to chrome-win64-master-1608649072-95a4cf9b59101d6f6ea631f49afe5baa9a8b257b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8687ecf52ba69180f7ebe8574dd78ac395f9e87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838978}
-
Christopher Cameron authored
ImageData::BufferBase()->Data() does not necessarily give the address of the start of the ImageData. For example, if the ImageData is created from a Uint8ClampedArray that is sub-allocated from another, say, Uint8Array, then this will not be the case (unless the creation offset is 0). The function ImageData::BufferBase() is used inappropriately in this way in many places. Remove the function. One of the heavier users of the function was ImageData::Crop, which, it turns out, isn't used. Delete it. Bug: 1158205 Change-Id: I4c06fec041083326222c5eb43f034a6d1cab7b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600243Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#838977}
-
Andrew Grieve authored
This reverts commit f8dfd440. Reason for reland: Removed detectCleartextNetwork() Original change's description: > Revert "Android: Disable detectUntaggedSockets StrictMode check." > > This reverts commit 90c1d6e9. > > Reason for revert: Should not add detectCleartextNetwork() > > Original change's description: > > Android: Disable detectUntaggedSockets StrictMode check. > > > > We don't tag our sockets, and this caused logspam on start-up. > > > > Bug: 770792 > > Change-Id: I23cc6494a7a3e61bcb8be761c877bf4a0345f921 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600033 > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#838953} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I2e90528bbd41c580e647cb17e65efa4900f900f5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 770792 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600035 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838962} Bug: 770792 Change-Id: I85b7f81303cdd9a29e647cbb8c8d5b7d034cddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601516 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838976}
-