GitLab

As part of page lifecycle, we need to notify the page that it is getting
STOPPED. This CL introduced window.onfreeze, a new callback that will
fire when the page is STOPPED. If the page is resumed and not killed,
then window.onresume is called.

Currently, the page is stopped on Android after being backgrounded for a
few minutes. More stopping scenarios are being added. When a page is
stopped, all the timers will stop firing, and any load activities will
be halted. The onfreeze is the last callback made to the page before
it is either resumed or killed. When the page re-enters the ACTIVE or
HIDDEN states, window.onresume is called.

This feature is currently under a "test" RuntimeEnabled flag.

Bug: 765401
Change-Id: I09486e4298a80f4a08c6c8d78bf060745e81d687
Reviewed-on: https://chromium-review.googlesource.com/764503Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524119}

Update the Security Overview Page in DevTools to MD.
Modified the strings and introduced a title value to
SecurityStyleExplanation. Updated tests to reflect
this change.

Screenshot: https://screenshot.googleplex.com/Qqjc0TmkaS5.png

Bug: 617311
Change-Id: If7893e2fd795c53e6a9fed0542f84bbe7006f59b
Reviewed-on: https://chromium-review.googlesource.com/772002Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524118}

This change configures Chrome to
- Download asset component version 1.y,
- Load and decode background.png/.jpeg,
- Only register assets component on Chromes (not Chromiums).

Bug: 793977, 793405, 793384
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33de68ac0c3317360c0e26ae4274242e87092ff5
Reviewed-on: https://chromium-review.googlesource.com/822835
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524117}

This reverts commit 5fc3b9d0.

Reason for revert: crashes, see crbug.com/794927.

Original change's description:
> [DevTools] Implement waitForDebugger for OOPIFs
> 
> Using NavigationThrottle for this. Since during throttling
> the navigation has not committed yet, we have to create
> agent host for soon-to-be-committed frame in advance.
> 
> Bug: 750901
> Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200
> Reviewed-on: https://chromium-review.googlesource.com/818076
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523835}

TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org

Change-Id: I367776fd716614f4fd113c2f88ed3bfcbc5ac5c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750901
Reviewed-on: https://chromium-review.googlesource.com/826496Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524116}

Bug: 598854
Change-Id: Ia8bf724deef748dafa262125bad8e8b1bdaf64bd
Reviewed-on: https://chromium-review.googlesource.com/826002Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524115}

Removes "help-" prefix from the classnames as none of those styles are
used on an actual help screens. Also, disables Ctrl+A on settings
screens.

Bug: 778585
Change-Id: I28bcd05122c1e06952db4597db2038d73f15e089
Reviewed-on: https://chromium-review.googlesource.com/822924Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524114}

This is a small follow-up to https://crrev.com//f41d2d3d4e8af.

Change-Id: I7d79d97a385fc964e39bd56f323dfe448cb82b89
Reviewed-on: https://chromium-review.googlesource.com/826268Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524113}

This changes about 50 files, mostly in ash, to use the new API.

There about 200 more files to update. A forwarding function is left for
backwards compatibility for these files.

Clarify usage of GridLayout::CreateAndInstall and fix
payment_sheet_view_controller.cc which was installing the layout
manager twice.

The only functional change should be in sidebar_widget.cc where some
calls are reordered.

Change-Id: Iab5bad2055cc561dbc9a92600da838660849944e
Reviewed-on: https://chromium-review.googlesource.com/825402
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524112}

If the process launch fails it ends up trying to track PID #0 which
causes a DCHECK.

Bug: 757946
Change-Id: If4558b1707aad237273127365c5b5be64d32f327
Reviewed-on: https://chromium-review.googlesource.com/826085Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524111}

This test was assuming that calling minimize() and maximize() followed
by restore() without waiting for onMinimized or onMaximized would
trigger onRestored. This is not the case on Mash, and is also a likely
cause of flake on other platforms.

Bug: 232330,678687,794771
Change-Id: I2a6a0f1e0b527583add555ed5ab8bfdc3a073df6
Reviewed-on: https://chromium-review.googlesource.com/821310Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524110}

Currently we have an issue that the Control group always read the
default configuration of parallel download defined in the code.

However, when tweaking the server config, we can use different slice
size, which will result in experiment groups comparing different sample
sets.

This CL adds a Finch parameter to alternatively disable parallel
download in an enable experiment group, and also read configs from
the server.


Bug: 794718
Change-Id: I9cf91233cbaf3dd22917af2e026c736803bd8e19
Reviewed-on: https://chromium-review.googlesource.com/825984
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524109}

This will allow certificates to be typed even if we send an empty
PEM certificate which the server can act on.

Bug: 778535
Test: unit_tests
Change-Id: Iadc2d94c4cdd558dc46086b7cea629f7f92e8ae7
Reviewed-on: https://chromium-review.googlesource.com/822164Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524108}

Bug: 765334
Change-Id: I8b88d07d40314fb3c4554530e3e1918f301b0202
Reviewed-on: https://chromium-review.googlesource.com/827035Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524107}

Change-Id: Ib01ff5242683a9d67c89558ab0c52d9a08d61196
Reviewed-on: https://chromium-review.googlesource.com/826263Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524106}

Create directly with std::make_unique instead.

TBR: boliu@chromium.org, tedchoc@chromium.org
Bug: 792192
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I97442118fef4efb6dd0be4e64b5f140499a469f2
Reviewed-on: https://chromium-review.googlesource.com/826428Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524105}

Bug: 
Change-Id: Ia17a468fdbb5b70ddac99594aa2c2a9903b55a4f
Reviewed-on: https://chromium-review.googlesource.com/825103Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524104}

https://skia.googlesource.com/skia.git/+log/63789ccc03f6..e9188850ec2f

$ git log 63789ccc0..e9188850e --date=short --no-merges --format='%ad %ae %s'
2017-12-14 kjlubick Revert "Revert "Disable extra CPUs during Nanobench""
2017-12-14 mtklein add back purgeResourcesNotUsedInMs() temporarily
2017-12-14 mtklein Revert "Disable extra CPUs during Nanobench"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I6fea8c36e32eb67487da8bda42201291d529f544
Reviewed-on: https://chromium-review.googlesource.com/827083Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524103}

Do not return ROLE_SYSTEM_WINDOW ourselves as that is a special MSAA
system role used to indicate a real native window object. It is
automatically created by oleacc.dll as a parent of the root of our
hierarchy, matching the HWND.

For AX_ROLE_WINDOW, we should expose something similar to what Firefox
exposes, namely ROLE_SYSTEM_APPLICATION.

This helps NVDA not read superfluous text when the user navigates
to the toolbar or location bar.

Bug: 794931
Change-Id: I123f07cb477304da1f016d65ea8c2b23b7a92ef4
Reviewed-on: https://chromium-review.googlesource.com/826866Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524102}

https://chromium.googlesource.com/catapult.git/+log/97e6e42e3e39..4b9d944868d0

$ git log 97e6e42e3..4b9d94486 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 simonhatch Dashboard - Remove call to GetOrCreateAncestors in /add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia440f4c31039dea476abad558c74f0c4b32b43b4
Reviewed-on: https://chromium-review.googlesource.com/826803
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524101}

This patch enables checker imaging subject to heuristics for images that
were explicit marked as decoding=async by the developer.

R=khushalsagar@chromium.org, chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I460402d0f0ff9eb0bbb1262f87b275f5410d5c2a
Reviewed-on: https://chromium-review.googlesource.com/825650
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524100}

This reverts commit 241cb0e4.

Reason for revert:
Internal Android ToT broken, please review and update
downstream usage before relanding.

Original change's description:
> [WebPayments] Drop trans. layer for Mojo structs
> 
> Full Title: Drop Translation Layer for Some PaymentRequest Mojo Structs
> 
> Currently we have C++ classes duplicating our Mojo structs; it turns out
> this is unnecessary and adds a lot of complexity. This change removes
> two of them (PaymentAddress, PaymentCurrencyAmount) as a first step
> towards removing all of them. To allow using these structs on iOS, which
> does not use WebKit, we have to move these back to the components
> directory, where they originally lived. My tentative plan is to move
> the remaining mojo structs to components, split between the
> payment_request_data file added in this CL, and a new
> payment_request_interface file for the bits which will not be included
> on iOS (where communication with the renderer does not use Mojo).
> 
> Bug: 775631
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I7e4a4b21fe8c75c37b95fb12658114d1994f4a66
> Reviewed-on: https://chromium-review.googlesource.com/738515
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524087}

TBR=palmer@chromium.org,dcheng@chromium.org,rouslan@chromium.org,sdefresne@chromium.org,tedchoc@chromium.org,tmartino@chromium.org,mahmadi@chromium.org

Change-Id: I02b048666c4b510ec98bacb8f52bfffbee00d18a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775631
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/826224Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524099}

The issue was in:
AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies()

AwContentsIoThreadClient::FromID(render_process_id, render_frame_id) was
used, but at this point a navigation request is not associated with a
renderer process yet. It caused the cookies not being sent with the
request.

The solution was to use
AwContentsIoThreadClient::FromID(frame_tree_node_id) instead.

Bug: 793648, 794939
Change-Id: I5bda7affab67645cfd64c105b06c8a628047dd79
Reviewed-on: https://chromium-review.googlesource.com/827018
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524098}

The Client interface was diluted down to a single method at this point.
Different implementations of overriding Delegate's Run() methods will
need different behaviors from ShouldQuitWhenIdle(). Making it easily
overrridable is key.

One such example behaviour is when overriding a MessageLoopForUI/IO.
When waiting inside a Run() with no more tasks, control needs to
remain in the hands of the overridden MessageLoop as it may receive
work first (from the system) and therefore shouldn't quit-when-idle
when the overriding Delegate is out of work (the overriding Delegate
can let it know to wake by posting a task to it if it gets work
first).

R=thestig@chromium.org

Bug: 708584
Change-Id: I27a449bc3be5858b0e8d4d6482714523ad5e2b67
Reviewed-on: https://chromium-review.googlesource.com/817962
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524097}

Bug: 598854
Change-Id: I9cfe27590794d63903347f50daa1698ee6961bb1
Reviewed-on: https://chromium-review.googlesource.com/826442
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524096}

Somewhere along the way we stopped listening to recycler
events, which breaks the mechanism that invalidates old
(outdated) requests for decoding. This CL reinstates
that.

Bug: 793934, 656015
Change-Id: I0df070c851bb75a1dccd1e7b5854c8846905ceb9
Reviewed-on: https://chromium-review.googlesource.com/827015Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524095}

With this change, rects can now have individually configurable corner
radii. This does not apply to textured quads, and the utility for this
is not as clear.

(Also converts a few arguments to const refs and updates shadow to set
the corner radius automatically).

Bug: 782703
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id49a1cce69dc59178c1b4a8ce15df8f8016bf709
Reviewed-on: https://chromium-review.googlesource.com/827026
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524094}

https://chromium-review.googlesource.com/c/chromium/src/+/727781 broke printing of DataRefs
This commit makes DataRef print like this:

(gdb) p container_style.box_data_
$2 = DataRef(scoped_refptr((blink::ComputedStyleBase::StyleBoxData *)0x1e6143288
170))

Bug: 763844
Change-Id: I6ebcdd2d32b032659d3cc00973859c23ccb8b693
Reviewed-on: https://chromium-review.googlesource.com/826262Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524093}

The default implementation simply calls the original method.

Bug: 793816
Change-Id: I2ac147d5318d6a04db2d9cec46659d574383b005
Reviewed-on: https://chromium-review.googlesource.com/824722
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524092}

In the conversion to SetAndDirty, a regression was introduced: the URL
was not marked as dirty when the color scheme changed. The result was
that a portion of the URL bar would update (eg, the security icon), but
the URL itself would not update. With this CL, we set dirtiness.

Bug: 794956
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I02fec20ede52eb165a19445a6b28b2b5bcb2ca4b
Reviewed-on: https://chromium-review.googlesource.com/827028Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524091}

Bug: 781409
Change-Id: I89a3561584e18dc56e411bceb0ee25d72e996989
Reviewed-on: https://chromium-review.googlesource.com/818331Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524090}

Currently there is a race condition between IPC messages from the
browser to the renderer, and the page load in the renderer. This CL
makes SearchBox (on the renderer side) accept those messages a bit
earlier, which should mitigate the problem somewhat (though it won't
actually fix it).

Bug: 793818, 794942
Change-Id: Iad3bf3afbc0d46093ee2eb06bcf60de99849991c
Reviewed-on: https://chromium-review.googlesource.com/827068
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524089}

Users are now able to turn on draw occlusion by set flag enable draw occlusion
to true in chrome://flags.

TEST: build to chrome os device and verify if draw occlusion is turned on when
the flag is set to true.

Bug: 672929
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ibfca7fd5f91a8f7c04ea20db62029b0ab3a78870
Reviewed-on: https://chromium-review.googlesource.com/826103
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524088}

Full Title: Drop Translation Layer for Some PaymentRequest Mojo Structs

Currently we have C++ classes duplicating our Mojo structs; it turns out
this is unnecessary and adds a lot of complexity. This change removes
two of them (PaymentAddress, PaymentCurrencyAmount) as a first step
towards removing all of them. To allow using these structs on iOS, which
does not use WebKit, we have to move these back to the components
directory, where they originally lived. My tentative plan is to move
the remaining mojo structs to components, split between the
payment_request_data file added in this CL, and a new
payment_request_interface file for the bits which will not be included
on iOS (where communication with the renderer does not use Mojo).

Bug: 775631
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7e4a4b21fe8c75c37b95fb12658114d1994f4a66
Reviewed-on: https://chromium-review.googlesource.com/738515
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524087}

This CL disable "Convert Enter-in-omnibox to a reload" when the
navigation entry are created by WebView.

Some WebView initiated navigation were misclassified as "reload".

Bug: 794020
Change-Id: I443bc00601c33c94005aec0eb4f1592f83b6f64b
Reviewed-on: https://chromium-review.googlesource.com/824682Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524086}

The mojo typemaps for BlinkCloneableMessage and BlinkTransferableMessage
specify that the structs are move-only, so the code in the mojo bindings
uses std::move. However, since the structs declare a custom constructor
(the constructor is defaulted in the .cpp, but the compiler can't see
this from the .h), no move constructor or move-assignment is generated,
and the structs are copied rather than being moved.

The mismatch causes extra reference increments / decrements. When the
underlying type uses thread-safe reference counter (like
SerializedScriptValue does), increments and decrements use atomic
operations, which are not cheap on ARM.

This CL adds move constructors and move-assignment operators to
BlinkCloneableMessage to allow moving, and adds DISALLOW_COPY_AND_ASSIGN
to prevent accidental copying.

This CL also adds DISALLOW_COPY_AND_ASSIGN to the browser-side
structures corresponding to Blink{Cloneable,Transferable}Message, to
make it obvious that they are move-only.

Bug: 794791
Change-Id: Iffe8f1e65bf9ccc2cd98082c341c2bdc3246fa33
Reviewed-on: https://chromium-review.googlesource.com/826260
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524085}

Bug: 794796
Change-Id: I28c6579ebe3062f342f19748b2b1b1b21e185104
Reviewed-on: https://chromium-review.googlesource.com/826684Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524084}

No intended behavior change.

Bug: 774209
Change-Id: Iffa593253058c5ab8a81712be216b903be23b0c4
Reviewed-on: https://chromium-review.googlesource.com/826173
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524083}

This fixes a problem where both Omnibox and fakebox could have visible
focus at the same time.

Bug: 792850
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4801641c1ee192ffef943ecb738abf41fecc348
Reviewed-on: https://chromium-review.googlesource.com/827076Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524082}

This reverts commit 1050c3ac.

Reason for revert: Did it's job.

Original change's description:
> Look for why ChromeOS bots are flakily using software compositing.
> 
> This adds some NOTREACHED() on ChromeOS to figure out why tests are
> disabling gpu compositing.
> 
> R=​zmo@chromium.org
> 
> Bug: 793303
> Change-Id: I6ee99fc334c34c292bcb1e3568108e422d43da4c
> Reviewed-on: https://chromium-review.googlesource.com/826382
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523958}

TBR=danakj@chromium.org,zmo@chromium.org

Change-Id: I439a4775e1dfa9329da9cbbd416a4bad11bd71e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793303
Reviewed-on: https://chromium-review.googlesource.com/827142Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524081}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2c617901..327c9d94

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I4680fca86bd30e7721b8de4dee8725e9797bb22a
Reviewed-on: https://chromium-review.googlesource.com/827024Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524080}