- 05 Jan, 2021 40 commits
-
-
David Van Cleve authored
A Trust Tokens issuance request is a request created by fetch(..., {trustToken: {type: 'token-request'}}) With the new "platform-provided trust tokens" expansion of the Trust Tokens feature, the request's destination origin can provide configuration indicating that the browser should divert the origin's Trust Tokens issuance requests to system-local providers, on platforms that support this behavior (currently Android). [1] In this case, there's no need to send an HTTP request directly to the destination URL provided in the fetch() call, so we return early via URLLoader::OnComplete(URLLoaderCompletionStatus). We provide a non-net::OK error code to this URLLoader::OnComplete call since we won't receive an HTTP response from the request's destination. Since this case is semantically a success, we don't want it to show up as an error in the DevTools console. This change gives it the same treatment as Trust Tokens redemption cache hits, making it return TRUST_TOKEN_OPERATION_SUCCESS_WITHOUT_SENDING_REQUEST from URLLoader. In order to support the DevTools browser test covering this behavior, this CL exposes some platform-provided issuance support fixtures from trust_token_browsertest.cc in the corresponding header file. [1]: https://bit.ly/platform-provided-trust-tokens Test: A DevTools browser test confirms the request shows as "finished" Bug: 1154847 Change-Id: I2d8a00b780f12faa16052d07ccba88c50dbde848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587436 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840198}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b54debc350a1..fc6b87192db6 2021-01-05 hta@webrtc.org Make the JsepSessionDesription clone() method copy candidates. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaed926c6f4ea9a85552735b7133838bf4ce6f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610816Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840197}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1fe7f95b0ecc..75eced6da617 2021-01-05 adithyas@chromium.org Revert "Portals: Fix for duplicate messages after activation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069487,chromium:1158210 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic073db99d1f38b5e919291a9e81436a5bfe7c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608790Reviewed-by:
-
Alison Maher authored
With CL:2587618, we no longer need to block forced colors mode from affecting Mac in blink. The reason being that we are tracking forced colors separately from high contrast in NativeTheme, so we don't need to worry about increased contrast accidentally triggering forced colors on Mac. There is work underway to add a devtools emulation feature for Windows high contrast to allow developers to test their webpages in forced colors mode without a Windows device. This change will likely allow for a proper emulation on Mac. This CL should not result in any functional changes (other than the fact that forcing high contrast will now affect Mac, which is why the forced colors tests now pass on Mac, and various related web tests needed to be rebaselined.) Bug: 1107431 Change-Id: Ie3a3547c927587dd638a53f6307c69aca9d99779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591489 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840195}
-
Austin Sullivan authored
Bug: N/A Change-Id: I403af0c25c2c3b1354cbb5f4fcd07dd9757c16ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602109 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#840194}
-
Benoit Lize authored
No need to call the destructor anywhere, and this is also dangerous in principle, since raw pointers to the partitions are captured and used everywhere in blink. Change-Id: I84f62502003ac2bb3da6d1c48e6e28f7e8c81fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607312Reviewed-by:
-
Jesse McKenna authored
This change removes some unneeded using-declarations from content/browser/renderer_host/. This doesn't cover all the files, just some instances I noticed. In a few places where usage was inconsistent, this unifies the usage. Change-Id: I15ab5d80c481efe913285b42f2d7e7fdaff4d913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606189Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#840192}
-
Peng Huang authored
Bug: 1161513 Change-Id: Ia0a82f44b878dbcb7589a2aec9ec597ff517660b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600390Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840191}
-
Lily Chen authored
Bug: 1161591 Change-Id: I7615a4cdd970ea42cc6a93ebacc5928d1febbda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610785 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840190}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101050600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/P17q_sHuEKbXoL-17YZCO_KTWxU2eHK2U4HqRas0jY8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/175636382 Tbr: help-app@grotations.appspotmail.com Change-Id: I794d15b5c064d29083a720f89ef7e48fad45e35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610267Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840189}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Change-Id: Idc37eba5389894123cee25c1cabb1119e63a8bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600238 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840188}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609837154-532701be902ffaddff8f4f0b9fc00b7f3e25a5e8.profdata to chrome-win32-master-1609847937-cf5cc478b4222d5ab5a9c5d5ace2908da8c23e42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9671c4c3efd709ecf2985b3e719d85bf7604dd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608789Reviewed-by:
-
Ryan Sleevi authored
The unit tests for certificate verification are dependent upon the system clock, because they interact with the system verifier, and as a result periodically expire and require re-generation in order to continue to function. Previously, all of the certificates generated via the Python tools were set to expire on Jan 1, 2021 by default, and have thus all expired. This regenerates the test certs, setting them to expire on November 3, 2021 (a non-holiday Wednesday). Bug: 1162837 Change-Id: I6fc5af79d95a641c15955ef2c6771cfa4d15c17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610066 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840186}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..ee8ca5255488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id337fd0fdc49bb5990876990545554c72e33b958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610864Reviewed-by:
-
Thomas Tellier authored
On the login and lock screen, the easy unlock icon and the capslock enabled icon share the same space. This CL introduces an animation that switches from one to another when both should be displayed. The one that just got enabled is immediately shown. After 2s, a transition is done to the other icon with a fade-out and fade-in effect of 0.5s each. This other icon is shown 2s and then we transition to the first one again. This cycle continues until one of the icon should not be shown. Bug: 1003885 Change-Id: I37711de090ba757153e0bfa0e5081c9660a8a525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587059Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#840184}
-
Alison Maher authored
In CL:2412972, it was recommended to split out the concepts of high contrast and forced colors mode inside NativeTheme. Doing so allows us to remove the |is_high_contrast_| variable in favor of |preferred_contrast_|. This also adds a |forced_colors_| variable to distinguish these concepts. I was planning to wait until https://github.com/w3c/csswg-drafts/issues/5433 had been resolved before making this refactor. However, this will likely clean up other areas that will make things like a forced colors devtools emulation cleaner to implement. This will be easy enough to update once the above issue has been resolved (if needed). _________________________________ To explain the distinction of high contrast/preferred contrast/forced colors mode in a bit more detail: - High contrast in most cases triggers a preferred contrast of "more". - Since we are tracking the preferred contrast in NativeTheme, we can remove the redundancy of also tracking if we are in high contrast. - On Windows, high contrast is a bit different in that it also triggers what we call forced colors mode. In forced colors mode, the preferred contrast level may be "more" or "less" depending on which foreground and background colors are being forced. Thus, we also need to track the forced colors state in NativeTheme to detect cases of Windows high contrast that are not considered more or less contrast, but some contrast level in between. _________________________________ This CL should not result in any functional changes. Bug: 1157686,1107431 Change-Id: Ia6799593359a3adb3a92b99de95ca7ebe6890334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587618Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#840183}
-
Arthur Hemery authored
IPAddressSpace is currently not inherited in many edge cases such as data or blob urls. We use the PolicyContainer to provide the inheritance model we're looking for. Bug: 1154729 Change-Id: I2a395be583017fd1130b465cec4a54149721f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571285Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#840182}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/666000a232e0..4f3fa1b39ec3 2021-01-05 benreich@chromium.org drivefs-uprev: Return UprevVersionedPackageResult instead of None If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I985598319e549bc7f26b2f058f08e4b76eeea253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608788Reviewed-by:
-
Elizabeth Popova authored
Prior to this change, an address label field with name "title" was misclassified as an honorific prefix, because the exclude check was performed after the honorific prefix has been parsed. Now address name fields are excluded prior to the honorific parsing. Bug: 1154727 Change-Id: If5b395b0560f556dfbafd619e336305577582dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602126Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#840180}
-
Alex Ilin authored
GAIA supports dark mode by adding a color_scheme=dark query param. This CL passes this parameter to the signed-in profile creation flow when Chrome is displayed in dark mode. Bug: 1126913 Change-Id: I6a2f024797f2571b16f435bc2e1ea4ba060177c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600897Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840179}
-
Garrett Beaty authored
This reverts commit 70ca76dc. Reason for revert: goma freeze is over Original change's description: > Add a presubmit to ensure our goma usage isn't modified during freeze. > > A generator is added that outputs some numbers representing our goma > usage. The values have no concrete meaning, but approximate the load > applied to goma for the project and the relative load for different > builders (with some numbers being very rough approximations). > > Changes that modify the generated file require a footer in the CL > description in order to submit. > > Bug: 1145230 > Change-Id: I6d58deee27e9bc6d220f87311a6266c220f03e51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556210 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831871} TBR=estaab@chromium.org,gbeaty@chromium.org,gatong@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145230 Change-Id: Ic21c76e1277282750a2a740d91e57d09f2ad192f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610927Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#840178}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88ee6a6370c5..472239462122 2021-01-05 fmayer@google.com Merge "Allow to target heaps registered during running profile." 2021-01-05 rsavitski@google.com Merge "client: move comment back to the relevant function" 2021-01-05 treehugger-gerrit@google.com Merge "client: fix return value when reporting is unsuccessful, add api test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I545402266af6405633ea0e2ae7ab18f0a3c8ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610884Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07dea8371353..b6ea6edc3f4e 2021-01-05 jdarpinian@chromium.org Remove tabs from volk.c/h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I2121b23cee5dad8bde25b878ca06f8766fffcb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610808Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3abec731..4a9c1b46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibeb3cf09954cd571ea2a98fcbca38a94dced26f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607069Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840175}
-
Omar Morsi authored
Before this CL, platform keys API tests should have been failed as there was a typo in the JS side. An error message with the unexpected variable name was printed to the console but the C++ side of the test wasn't failing. Note: This CL doesn't fully fix the flakiness mentioned by linked bug, but is a necessary step for fixing it. Bug: 1157137 Change-Id: Ib9787997707cd56b46ed1f328a5ad080e82971e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607887Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#840174}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609837154-ace0713e1aa3951abed358afe7726a9f9d3a73a1.profdata to chrome-win64-master-1609847937-c4d97125a43c3c1ad7fc53512c61f5ef8ccc043d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f771575230a1651b9c8b2a77946f864276be755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610813Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df49e6927b43..dc435fa60df6 2021-01-05 johnstiles@google.com Add SkSL error reporting when an undefined function is called. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ib6f6ed5c97520af67f5df31284482f5914b5c340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610812Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/9a644c7903ca..e6e704145b31 2021-01-05 bclayton@google.com Remove all Source{} smell from tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I62f2d733d28fb231c1fe906c948005219c74b7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610814Reviewed-by:
-
Andrew Grieve authored
Bug: 1029038 Change-Id: Ia9a0f0caaa30894d984f0aee91bcd2b492d2362d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607548 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#840170}
-
Robbie Gibson authored
This crash only appears when certain other flags are disabled and the thumb strip is enabled (I didn't go through to find out exactly which ones). The root cause is that with these flags disabled, the thumb strip is created before the BVC's view is loaded, so the tab strip view has not been created yet either. Bug: 1094335 Change-Id: If70a670f366145514998ca5e1713a18c7770f58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608832Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840169}
-
Jan Wilken Dörrie authored
This change modifies tools/boilerplate.py to also support no compile tests. This effectively generates the same code as it does for Cpp implementation files, but also adds the following no compile explanation: // This is a "No Compile Test" suite. // https://dev.chromium.org/developers/testing/no-compile-tests Bug: None Change-Id: I913d8e4673fdb4986f7d7e87a6fef15aae835daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595533 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840168}
-
Monica Basta authored
Initially profiles will be ordered alphabetically on the picker's main view. The order will be frozen to the initial order, profiles created will be added at the end of the list, profiles deleted will be moved out of the list. Any update to the profile local name/gaia name will not affect the order of profiles. Bug: 1161528 Change-Id: Ieaa6374a056ed353c35568409bf1cae631431ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601744Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#840167}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101050600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zfJMXSQTHiC63-8t2rDhq9Yzbr3EuSa6iu8LG7TeCO8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/174201860,b/174513972,b/175281316 Tbr: media-app@grotations.appspotmail.com Change-Id: I0478f2068075a998ec3e8cc5f80dda6b33f21cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610052Reviewed-by:
-
cfredric authored
Change-Id: I949eb8b83207b689b8d516391a86a5e0cbd03b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607555 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#840165}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..bc804095bcad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e2c52be940cab649d78be836fe95725f5ea7ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609600Reviewed-by:
-
Yunke Zhou authored
is_user_creation_enabled needs to reset to false on cancel action. Bug: 1163033 Change-Id: I1b1bd5643bb2829ba2af9a84eaaec6f5fee70d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610089Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#840163}
-
Sahel Sharify authored
This reverts commit 075822e5. Reason for revert: SingleClientTypedUrlsSyncTest.TwoVisits is still flaky on Android after the fix landed in crbug.com/1159404 Flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWgsSBUZsYWtlIk9jaHJvbWl1bUBhbmRyb2lkX3N5bmNfaW50ZWdyYXRpb25fdGVzdHNAU2luZ2xlQ2xpZW50VHlwZWRVcmxzU3luY1Rlc3QuVHdvVmlzaXRzDA Original change's description: > Revert "Disabled flaky SingleClientTypedUrlsSyncTest tests on Android" > > This reverts commit a23b68c3. > > Reason for revert: Tests are fixed in crbug.com/1159404 > > Original change's description: > > Disabled flaky SingleClientTypedUrlsSyncTest tests on Android > > > > This CL disabled the following tests on Android. > > > > * SingleClientTypedUrlsSyncTest.DeleteNonTyped > > * SingleClientTypedUrlsSyncTest.TwoVisits > > * SingleClientTypedUrlsSyncTest.DeleteTyped > > * SingleClientTypedUrlsSyncTest.Sanity > > > > TBR=mastiz@chromium.org > > > > Bug: 1159479 > > Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119 > > Reviewed-by: Salvador Guerrero <salg@google.com> > > Commit-Queue: Salvador Guerrero <salg@google.com> > > Cr-Commit-Position: refs/heads/master@{#837747} > > TBR=mastiz@chromium.org,salg@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I24bcdac6b58843f9ca7a1909f9720152d43845be > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1159479 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597744 > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Reviewed-by: Salvador Guerrero <salg@google.com> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838969} TBR=mastiz@chromium.org,salg@google.com,svenzheng@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1159479 Change-Id: I8c67dbd430b00805a5b6fac702aaf1c6400d151a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608930 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840162}
-
David Bokan authored
This feature has been enabled for many milestones and the flag has expired so remove both. Bug: 993629 Change-Id: I514c2bf842838b6708f3b17de4b3e905037922c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605880Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c6ff2556c8e6..74f1b6be4a91 2021-01-05 apodtele@gmail.com [builds/windows] Add SDF to VC2010 project. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5fd4c9aa1e3fcdb43ca6a27149b79b068e49e4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610466Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840160}
-
Elizabeth Popova authored
Some websites use a single field for an address with the expected address components listed in the label. Parsing of such field might fail if the name of the field is ambiguous. Added en, tr and ru regexes, which help to identify address line 1 or street address if the label contains street and at least one other address component, in any order. Bug: 1154727 Change-Id: I82d51ce285e3112ba554ae45332e2f710cdd6b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601370Reviewed-by:
-
