GitLab

Review URL: https://codereview.chromium.org/477193003

Cr-Commit-Position: refs/heads/master@{#291119}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386454
R=manzagop@chromium.org, newt@chromium.org
TBR=erikwright
TEST=SuggestionsServiceTest

Review URL: https://codereview.chromium.org/473123002

Cr-Commit-Position: refs/heads/master@{#291116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98

This channel needs to be made synchronous to safely support sending a
synchronous message from the plugin to the renderer for reporting exit status.
The overall change for that support is available for review at:
  https://codereview.chromium.org/484783002/

This change splits out the channel refactoring to make this easier to review.

BUG=397161
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/486383002

Cr-Commit-Position: refs/heads/master@{#291113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291113 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Only build various flash/pnacl/ppapi code when they are enabled. (patchset #7 of https://codereview.chromium.org/471263003/)

Reason for revert:
Suspected of breaking the disable_nacl build.

Original issue's description:
> Only build various flash/pnacl/ppapi code when they are enabled.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291069

TBR=dyen@chromium.org,viettrungluu@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/492323002

Cr-Commit-Position: refs/heads/master@{#291112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291112 0039d316-1c4b-4281-b951-d872f2087c98

The current random base address generation in the Android chromium linker is prone
to error.  It selects an address at random between 0x20000000 and 0x40000000 and
expects that this will be clear.  This is occasionally untrue for ARM, but very
often untrue for MIPS.  As a consequence, RELRO sharing is being turned off more
frequently than it could be.

This change removes the local random address generation code and instead replaces
it with code that speculatively maps a large region, captures the address returned
by mmap, then unmaps and returns the address.  The expectation is that this region
will remain free for use when the time comes for the crazy linker to map the browser
into it.  This generally holds because the time between these two actions is short
and little, if anything, loads or mmaps between them.  Worst case is that RELRO
sharing turns off as at present, but the probability of this happening should now
be much lower.

Note that capturing the address from mmap relies on Android ASLR being active for
mmap.  This is the default device state since ICS.  The revised random browser
load address is only as entropic as Android's ASLR.

BUG=397634

Review URL: https://codereview.chromium.org/470053003

Cr-Commit-Position: refs/heads/master@{#291111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291111 0039d316-1c4b-4281-b951-d872f2087c98

..as their ASCII codes are used in various layout tests. Mapped to
VKEY_ESCAPE and VKEY_BACK, respectively.

R=tkent@chromium.org
BUG=392517

Review URL: https://codereview.chromium.org/488053002

Cr-Commit-Position: refs/heads/master@{#291110}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291110 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291108}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291108 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Caused regression in static initializer count:

 # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x53                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x5a                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x9                                                                                             
  # webrtcvideoengine2.cc __divdi3@plt     

http://build.chromium.org/p/chromium/builders/Linux/builds/52540

Original issue's description:
> Roll webrtc 6905:6948.
> 
> TBR=hclam@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291082

TBR=hclam@chromium.org,grunell@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/495103003

Cr-Commit-Position: refs/heads/master@{#291106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/493143002

Cr-Commit-Position: refs/heads/master@{#291105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405816

Review URL: https://codereview.chromium.org/494023002

Cr-Commit-Position: refs/heads/master@{#291104}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/492293002

Cr-Commit-Position: refs/heads/master@{#291103}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291103 0039d316-1c4b-4281-b951-d872f2087c98

This moves the management of the global NexeLoadManager map inside the
NexeLoadManager class. This makes it so that a NexeLoadManager can be looked up
from a PP_Instance from the TrustedPluginChannel class, which is needed as part
of reporting exit status over Chromium IPC.

The change for moving exit status reporting to Chromium IPC  is
available for review at:
  https://codereview.chromium.org/484783002/

BUG=397161
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/484303002

Cr-Commit-Position: refs/heads/master@{#291102}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291102 0039d316-1c4b-4281-b951-d872f2087c98

When on demand raster is not allowed, when tiles are OOM, checkerboard
or solid color quad should be produced rather than nothing.

Add a unittest for this exact same scenario.

BUG=402321

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289480

Review URL: https://codereview.chromium.org/468983002

Cr-Commit-Position: refs/heads/master@{#291101}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291101 0039d316-1c4b-4281-b951-d872f2087c98

Bisecting Official Google Chrome builds was broken due to change of
base URL from http://master.chrome.corp.google.com/official_builds/
to https://console.developers.google.com/storage/chrome-unsigned/desktop-W15K3Y/.

BUG=384336
NOTRY=True

Review URL: https://codereview.chromium.org/492853002

Cr-Commit-Position: refs/heads/master@{#291099}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291099 0039d316-1c4b-4281-b951-d872f2087c98

They were mostly unused. Move remaining uses to calls to GetChildID,
though we'll possibly need to adjust them later.

BUG=376003

Review URL: https://codereview.chromium.org/481593002

Cr-Commit-Position: refs/heads/master@{#291098}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291098 0039d316-1c4b-4281-b951-d872f2087c98

Remove the unneeded PAGE_ACTION_COUNT_CHANGED notification.
Replace the PAGE_ACTION_VISIBILITY_CHANGED notification with a
PAGE_ACTIONS_UPDATED notification, which is sent once per
update (instead of once per page action).
Added bonuses:
- consistent notification behavior across cocoa/views
- less cruft in ui code

BUG=405356

Review URL: https://codereview.chromium.org/475813004

Cr-Commit-Position: refs/heads/master@{#291097}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291097 0039d316-1c4b-4281-b951-d872f2087c98

(specifically, everything except the omnibox's search engine)

Remove the settings search box.
Remove the enableResetProfileSettings JS variable, in place of "isGuest".

BUG=402153

Review URL: https://codereview.chromium.org/467363003

Cr-Commit-Position: refs/heads/master@{#291096}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291096 0039d316-1c4b-4281-b951-d872f2087c98

This removes the eager class registration from RegisterNatives when possible.

BUG=402003
TBR=sievers@chromium.org, brettw@chromium.org, torne@chromium.org

Review URL: https://codereview.chromium.org/491043002

Cr-Commit-Position: refs/heads/master@{#291095}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291095 0039d316-1c4b-4281-b951-d872f2087c98

Add Reapply() to declarative action interface. This is needed for RequestContentScript to work correctly from one matching page to the next.

BUG=377978

Review URL: https://codereview.chromium.org/491913003

Cr-Commit-Position: refs/heads/master@{#291094}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291094 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Service Worker: Handle same-scope, new script registration (patchset #8 of https://codereview.chromium.org/472103003/)

Reason for revert:
Broke unregister-and-register-new-script.html.  This must be done as a three-sided patch.

Original issue's description:
> Service Worker: Handle same-scope, new script registration
> 
> Before this patch, register() would delete an existing registration at
> the scope if the script URL didn't match, and register a new one. This
> overwriting creates a scenario where old tabs have a different
> controller than new tabs, which the Service Worker spec avoids.
> 
> This patch implements the spec steps for same-scope, new script
> register(). That means:
> 
> - If the existing registration is uninstalling, wait for that to
> complete before doing anything.
> - Create a new worker which becomes the installing worker of the
> existing registration.
> 
> BUG=398355
> TEST=https://codereview.chromium.org/480943002/
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291078

TBR=michaeln@chromium.org,nhiroki@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398355

Review URL: https://codereview.chromium.org/484783003

Cr-Commit-Position: refs/heads/master@{#291092}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291092 0039d316-1c4b-4281-b951-d872f2087c98

This is a prerequisite to allowing a URLRequestJob to transparently wrap
a URLRequest, so AppCache can override the response for failing and
redirected requests without the NetworkDelegate or URLRequest::Delegate
being aware of the underlying request.

Also consolidate the URLRequest constructors, and make most code create
URLRequests through the URLRequestContext's CreateRequest function,
rather than through its constructor.

TBR=battre@chromium.org
BUG=161547

Review URL: https://codereview.chromium.org/407093011

Cr-Commit-Position: refs/heads/master@{#291090}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366886
R=kevers@chromium.org
TEST:
    Open any non-maximized window covering at least the lower portion
    of the screen (so that normally on-screen keyboard would obscure
    part of the window).
    Turn on accessibility keyboard.
    Click on a text box, notice that keyboard shows up and window is
    resized so keyboard does not obscure any part of it.
    Click outside the text box (defocus), keyboard disappears and window
    bounds are restored to state before the keyboard showed up.

Review URL: https://codereview.chromium.org/468923002

Cr-Commit-Position: refs/heads/master@{#291087}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291087 0039d316-1c4b-4281-b951-d872f2087c98

Replace packed_relocationss_offset by packed_relocations_offset.
Fixes compile error from logged variable, invisible where CRAZY_DEBUG
is zero (default).

BUG=385553

Review URL: https://codereview.chromium.org/488123002

Cr-Commit-Position: refs/heads/master@{#291086}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291086 0039d316-1c4b-4281-b951-d872f2087c98

This includes some necessary ONC translation fixes.

BUG=279351
R=armansito@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/482243002

Cr-Commit-Position: refs/heads/master@{#291085}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291085 0039d316-1c4b-4281-b951-d872f2087c98

R=mmenke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/495953002

Cr-Commit-Position: refs/heads/master@{#291084}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291084 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291083}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291083 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/497463002

Cr-Commit-Position: refs/heads/master@{#291082}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291082 0039d316-1c4b-4281-b951-d872f2087c98

R=atwilson@chromium.org

Review URL: https://codereview.chromium.org/492553002

Cr-Commit-Position: refs/heads/master@{#291081}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378338

Review URL: https://codereview.chromium.org/491913002

Cr-Commit-Position: refs/heads/master@{#291080}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291080 0039d316-1c4b-4281-b951-d872f2087c98

Both tabbing and up/down arrows should navigate through all the 
visible controls.

I've changed the EditablePhotoButton to actually be a button and 
not just an image, so that tabbing and pressing enter actually 
works.

BUG=405057

Review URL: https://codereview.chromium.org/476763007

Cr-Commit-Position: refs/heads/master@{#291079}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291079 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, register() would delete an existing registration at
the scope if the script URL didn't match, and register a new one. This
overwriting creates a scenario where old tabs have a different
controller than new tabs, which the Service Worker spec avoids.

This patch implements the spec steps for same-scope, new script
register(). That means:

- If the existing registration is uninstalling, wait for that to
complete before doing anything.
- Create a new worker which becomes the installing worker of the
existing registration.

BUG=398355
TEST=https://codereview.chromium.org/480943002/

Review URL: https://codereview.chromium.org/472103003

Cr-Commit-Position: refs/heads/master@{#291078}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291078 0039d316-1c4b-4281-b951-d872f2087c98

This is an instrumented version of the patch that will be reverted in a few days.
This is meant to catch crashes in edge cases and log enough for us to repro
them.

BUG=99379, 369661
TEST=this is gonna crash for a few people

Review URL: https://codereview.chromium.org/493853002

Cr-Commit-Position: refs/heads/master@{#291077}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291077 0039d316-1c4b-4281-b951-d872f2087c98

Was broken in r286486 / https://codereview.chromium.org/403343002.

NOTRY=true

BUG=405899

Review URL: https://codereview.chromium.org/490203002

Cr-Commit-Position: refs/heads/master@{#291073}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402509
TEST=Manual, see bug
NOTRY=true

Review URL: https://codereview.chromium.org/465803002

Cr-Commit-Position: refs/heads/master@{#291072}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291072 0039d316-1c4b-4281-b951-d872f2087c98

This change is the first part in a series of changes to allow better display
configuration and tracking of windows/surfaces.

The browser process uses PlatformWindows to keep track of display surfaces.
The window then has an underlying surface to display content. The surface (in our
context SurfaceOzoneEGL) is created on the GPU process and is associated with
the window via an AcceleratedWidget handle. Each surface is then associated with
a HardwareDisplayController in order to scanout the contents to the monitor.
Since the surface is assumed to be in the window's coordinate system, the GPU
side has no knowledge of how to map a surface to the configured displays. The
NativeWindowDelegate is meant to IPC window information from the browser process
to the GPU process such that we can map surfaces to display controllers.

BUG=392478
NOTRY=true

Review URL: https://codereview.chromium.org/479713002

Cr-Commit-Position: refs/heads/master@{#291071}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291071 0039d316-1c4b-4281-b951-d872f2087c98

r283338 causes this bug because the fix overwrites the buffer no matter what.
The compositor needs to completely overwrite, while Blink needs to blend. It's
because the compositor reuses the buffer resource and Blink draws the video
frame on the existing GraphicsContext.

BUG=401027

Review URL: https://codereview.chromium.org/441303002

Cr-Commit-Position: refs/heads/master@{#291070}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291070 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/471263003

Cr-Commit-Position: refs/heads/master@{#291069}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291069 0039d316-1c4b-4281-b951-d872f2087c98

This re-rasters GPU-rasterized layers during scale animations in order to
keep content crisp, but only for layers that don't have text (since
re-rastering text at different scales leads to expensive glyph texture
uploads at each scale).

BUG=395760,372391

Review URL: https://codereview.chromium.org/422233008

Cr-Commit-Position: refs/heads/master@{#291068}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405681

Review URL: https://codereview.chromium.org/473453003

Cr-Commit-Position: refs/heads/master@{#291062}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291062 0039d316-1c4b-4281-b951-d872f2087c98

Use a callback to return the released picture from rendering_helper. So we don't
need the RenderingHelper::Client interface and thus simplify the code.

BUG=None
TEST=Run the vda_unittest on lumpy and ARM CrOS device.

Review URL: https://codereview.chromium.org/462413004

Cr-Commit-Position: refs/heads/master@{#291061}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291061 0039d316-1c4b-4281-b951-d872f2087c98