GitLab

The new translate UX uses bubbles instead of infobars.
Views uses the new UX by default, Mac will soon too.
(IDRs x-plat API should be removed after Mac switches)

Remove code unused since r248162 (4 months ago).
Stub out ChromeTranslateClient::CreateInfoBar for Views.

This should simplify Elliot's WIP MenuButton CL:
https://codereview.chromium.org/298813002
(these applied TextButtonBorders to MenuButtons instances)

BUG=276181,288554,241691,383235,155363
TEST=No Translate behavior changes; no complaints.
R=sky@chromium.org,pkasting@chromium.org,toyoshim@chromium.org
TBR=hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/325483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276567 0039d316-1c4b-4281-b951-d872f2087c98

The original r276450 was reverted in r276476 for leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954
Fixed here by calling AddChildView(title_) on Tab (duh).

Add a Label view to Tab for displaying the title.
Remove Tab::PaintTitle, bounds and font members.
Remove unnecessary Tab::Get[Title|Icon]Bounds helpers.
Update the text on Tab::SetData, not during paint.
Use gfx::DirectionalityMode, remove the Label enum.

Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment.
Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD.
Always flip left/right in Label::SetHorizontalAlignment.
Have Tab and MessageBoxView use ALIGN_TO_HEAD.

Update comments and tests, related minor cleanup.

TODO: Make Label cache RenderText objects.
TODO: Make RenderText support ALIGN_TO_HEAD.

BUG=240037
TEST=No visible Views tab title changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/329813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/323763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380987

Review URL: https://codereview.chromium.org/327943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276564 0039d316-1c4b-4281-b951-d872f2087c98

Rename HistoryService::NotifyRenderProcessHostDestruction to
ClearCachedDataForContextID.

BUG=371827
R=sdefresne
TBR=sky (chrome/test/base/testing_profile.cc)

Review URL: https://codereview.chromium.org/322983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383153

Review URL: https://codereview.chromium.org/329723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276562 0039d316-1c4b-4281-b951-d872f2087c98

The idea here is to elminate the ambiguity about who owns what and protect
about misuse by callers.

BUG=381710

Review URL: https://codereview.chromium.org/318143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276561 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276560 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grd[p] to work well with the
translation tools.

This patch should precede using upstream libaddressinput to ensure that
the upstream libaddressinput has the correct strings well ahead of using
it in Chrome.

Although the strings include postal code examples and links for error
messages, these features are optional and can be turned off if
undesired.

BUG=327046

Review URL: https://codereview.chromium.org/304223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276559 0039d316-1c4b-4281-b951-d872f2087c98

Blink-side change: https://codereview.chromium.org/324003002/

BUG=380988

Review URL: https://codereview.chromium.org/328973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276558 0039d316-1c4b-4281-b951-d872f2087c98

Changed the layout of the App Info Dialog according to UI feedback. This
includes removing the tabs, and replacing it with a single, scrollable
dialog that has all the information in a single pane.

BUG=364681,266739

Review URL: https://codereview.chromium.org/327743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276557 0039d316-1c4b-4281-b951-d872f2087c98

This is to get a baseline in tests so we can track coverage of future
CLs.

With this CL, 182 views_unittests pass (up from 125), but that's
incidental.

BUG=378134

Review URL: https://codereview.chromium.org/328103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:373548
TEST=the warnings are gone.

Review URL: https://codereview.chromium.org/318833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/325133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276554 0039d316-1c4b-4281-b951-d872f2087c98

Create ActionRunner wrapper API over TapAction and ClickElementAction. Add EvaluateJavaScript to ActionRunner.

Replace all existing use cases.

BUG=361809

Review URL: https://codereview.chromium.org/323833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276553 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds MediaOzonePlatform, a new Ozone component for abstracting media
and related. In particular it adds CreateVideoDecodeAccelerator method so Ozone
implementations can use that for abstracting video decoding acceleration (i.e.
GPU based video decoding). Eventually MediaOzonePlatform will be used as well
for many windowing systems abstractions related to media, e.g. video encode,
audio, etc. We will add support for these others as needed.

Media platform is called and created on demand whenever a video playback is set
to play. Different than ui::OzonePlatform methods, the one added in here is 
non-pure virtual so the implementations can decide themselves whether a video 
implementation is actually wanted, based on its hardware capabilities.

This work is aimed at internal implementations like Ozone-DRI, Ozone-test but
also for externals like Ozone-Wayland. Different targets like Chromium Browser,
Chrome OS, ChromeCast and others can now take advantage of it.

BUG=380884
TEST=manually on Ozone-Wayland, using:

 $ export GYP_DEFINES='chromeos=0 use_ozone=1 proprietary_codecs=1 ffmpeg_branding=Chrome'
 $ ninja -j16 -C out/Release content

and to run:

 ~/git/chromium/src/out/Debug$ ./chrome --no-sandbox --user-data-dir=/tmp/chrome --ignore-gpu-blacklist ../../third_party/WebKit/PerformanceTests/resources/bear-1280x720.mp4  --vmodule=*/ozone/ui*=3 --v=0

additionally, in Release builds you can start chrome with --disable-accelerated-video-decode to compare the results.

Review URL: https://codereview.chromium.org/269673005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276552 0039d316-1c4b-4281-b951-d872f2087c98

This is initial work package to reflect this change, making it possible to add hi-resolution resources in the future (if needed).

Review URL: https://codereview.chromium.org/327503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276551 0039d316-1c4b-4281-b951-d872f2087c98

Some touch devices report either zero or unreasonably small touch sizes. While
this doesn't present a problem for gesture detection, it does affect the
behavior of the touch-derived gestures. For example, tap disambiguation is
prevented if the tap gesture's size is sufficiently small. As a workaround,
provide a platform-specific minimum gesture bounds length in GestureProvider.
On Android, this value is the same as was used before the unified gesture
detector, and on Aura we simply use half the default touch size.

BUG=379876

Review URL: https://codereview.chromium.org/321563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380143
R=sdefresne
TBR=shess (add sql to DEPS)

Review URL: https://codereview.chromium.org/322113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276549 0039d316-1c4b-4281-b951-d872f2087c98

It should be in namespace views::internal.

BUG=378134

Review URL: https://codereview.chromium.org/325163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383251
TEST=run the test.
R=fukino@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/325953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/328183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276546 0039d316-1c4b-4281-b951-d872f2087c98

R=peria
BUG=380615
NOTRY=true

Review URL: https://codereview.chromium.org/329953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276539 0039d316-1c4b-4281-b951-d872f2087c98

Based on patch 290083004. Third party IMEs provide a privacy risk as they can monitor everything you type. The patch provides an additional measure of security by prompting the user for confirmation with a warning of the potential risks.

BUG=367861

Review URL: https://codereview.chromium.org/325633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276535 0039d316-1c4b-4281-b951-d872f2087c98

ViewTest.RecreateLayers creates a layer hierarchy that includes child
widgets and pulls an aura dependency into view_unittest.cc.

This CL moves the test into a new file - view_unittest_aura.cc to
isolate the aura dependency and allow view_unittest.cc to compile on
MacViews.

After this, an additional 56 views_unittests are compiling (39 pass).

BUG=378134
TEST=views_unittests

Review URL: https://codereview.chromium.org/329473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276534 0039d316-1c4b-4281-b951-d872f2087c98

Move search_engine_type.h from chrome/browser/search_engines to components/search_engines
Move prepopulated_engines* to components/search_engines

TBR=asvitkine@chromium.org for the comment fix in tools/metrics/histograms/histograms.xml
BUG=371535
TEST=git cl try

Review URL: https://codereview.chromium.org/330433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276533 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276532 0039d316-1c4b-4281-b951-d872f2087c98

Python 2.7.x includes pySerial version 2.5 as a distribution package. This conflicts with
our repository version of pySerial i.e. 2.7. The submodule serial.tools.* was included in
pySerial after 2.6 as per [1].

The utility function util.AddDirToPythonPath(...) appends the path at the end of the path
list. Due to this, the python interpreter picks up the pySerial library from system include
path at /usr/lib/python2.7/dist-packages/serial. This CL modifies AddDirToPythonPath(...) API to always prepend the path.

[1] http://pyserial.sourceforge.net/pyserial_api.html#module-serial.tools.list_ports

NOTRY=true

Review URL: https://codereview.chromium.org/321773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276531 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/5713352a64936428d37a721382d021f4a9002172..b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749
TBR=scroggo@google.com
NOTRY=true
BUG=

win_chromium_64 sync failure unrelated to this CL
NOTRY=True

Review URL: https://codereview.chromium.org/328163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276530 0039d316-1c4b-4281-b951-d872f2087c98

TODO and should address the dead isolate issue in bug 382179.

BUG=382179
R=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/327953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382675
NOTRY=True

Review URL: https://codereview.chromium.org/334533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383491
R=mukai@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276527 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=fmalita, robertphillips

BUG=crbug.com/383435

Review URL: https://codereview.chromium.org/327293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276526 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: https://codereview.chromium.org/326123003/

BUG=382178
NOTRY=true
R=msw

Review URL: https://codereview.chromium.org/323403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276525 0039d316-1c4b-4281-b951-d872f2087c98

Add an interface to allow embedders to navigate embedded views.
This only supports local/pushState-style navigation right now.

BUG=
R=darin@chromium.org, davemoore@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/327523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276521 0039d316-1c4b-4281-b951-d872f2087c98

Patch 2 in the series of renaming WebFontFamily to WebFallbackFont,
at the same time, fixing the sandbox support IPC to transmit filename
and ttcIndex. Depends on step 1 of the rename, r175858 in Blink.

BUG=382411
R=eae,behdad,jln,piman

Review URL: https://codereview.chromium.org/327633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276520 0039d316-1c4b-4281-b951-d872f2087c98

RenderingHelper is now responsible for controlling the rendering fps. There is no need for the ThrottleVDAClient to do the same thing.

BUG=None
TEST=Run the program on peach-pit

Review URL: https://codereview.chromium.org/294663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276519 0039d316-1c4b-4281-b951-d872f2087c98

This makes the way that we invoke dex more consistent (and easier to
change).

Review URL: https://codereview.chromium.org/317423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276518 0039d316-1c4b-4281-b951-d872f2087c98

Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked.

Existing implementation calls SetScreenOrientationForTesting and sends screen
orientation events even when the test screen orientation is locked.

BUG=162827

Review URL: https://codereview.chromium.org/302553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276517 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276505 0039d316-1c4b-4281-b951-d872f2087c98