- 21 Jun, 2018 40 commits
-
-
Ryan Tseng authored
Bug: 790329, 790336, 790324, 790332, 790304, 790314 Bug: 790298, 790289, 790297, 815386 TBR: tandrii Change-Id: I591ff27163844629bd5692b647aa1e16c3578b10 Reviewed-on: https://chromium-review.googlesource.com/1110751Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569436}
-
Ryan Tseng authored
4 core -> 24 core. Bug: 790381, 790383 TBR: tandrii Change-Id: I1f80d45bddd904fc186a00cd1db50f436770173d Reviewed-on: https://chromium-review.googlesource.com/1110998Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569435}
-
Ryan Tseng authored
Bug: 840631 TBR: tandrii Change-Id: I85ea736f70f7241734d37dc0e6f897ca04575b5f Reviewed-on: https://chromium-review.googlesource.com/1111022Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569434}
-
Francois Doray authored
For some reason, ResourceCoordinatorTabHelper::DidFinishNavigation() currently skips updating the frame tree and notifying the PageResourceCoordinator of main frame navigation commit when there is a navigation to an error page. This causes multiple problems: - The error page stays in the LOADING state forever. - The main frame URL is not updated in PageCoordinationUnitImpl. A navigation to an error page is just like a navigation to a normal page (the error page has a main frame, a renderer process), so there is no reason to have special case for it in ResourceCoordinatorTabHelper::DidFinishNavigation(). Bug: 855180 Change-Id: Ifbe52ce714ef04af574e00041f8b970c13c08f5d Reviewed-on: https://chromium-review.googlesource.com/1110697Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569433}
-
Jun Choi authored
This CL changes chrome://enable-webauthentication-ctap2-support flag to be enabled by default. Bug: 798573 Change-Id: I0eb29e0cffacf88d6cccbc09281a713c1eab94c3 Reviewed-on: https://chromium-review.googlesource.com/1110547 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#569432}
-
Sergey Ulanov authored
makesdk.go script has been moved in Fuchsia. Update local-sdk.py accordingly. Change-Id: I3e336d7c35db2555a50bea2a58c39a5b50779044 Reviewed-on: https://chromium-review.googlesource.com/1110952Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569431}
-
dpapad authored
Bug: 845746 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I402268fc66478b76e11e09a31227dff1569ddb35 Reviewed-on: https://chromium-review.googlesource.com/1107039Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569430}
-
Mike Dougherty authored
Initialize NSError with the designated initializer to prevent the following message from being printing to the console. -[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I94ac7664f7254126a5e2095d7c22c76497615c04 Reviewed-on: https://chromium-review.googlesource.com/1110490Reviewed-by:Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#569429}
-
David Grogan authored
This reverts commit ae116dff. Reason for revert: fast/events/wheel/wheelevent-in-text-node.html leaks memory as caught by https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_Leak/20616/layout-test-results/results.html Original change's description: > fast/events/wheel/* layout tests use gpu benchmarking. > > This cl changes the layouttests in fast/events/wheel to use gpu benchmarking > for sending events rather than event sender. > > The cl excludes the following tests for the following reasons: > > To change these tests we need to implement touchpad fling (swipe) in GPU > benchmarking: > -mainthread-touchpad-fling-latching.html > -wheel-fling-cancel.html > > These tests are skipped since they are related to wheel events only rather > than scrolling: > -wheelevent-constructor.html > -wheelevent-ctrl.html > -wheelevent-document-createevent.html > -wheelevent-handler-count.html > > This test will be changed in a different cl among with tests that need > platform specific wheel DOM event expectation. > -wheelevent-in-scrolling-div.html > > Bug: 846424 > Change-Id: I086e6a7f4f62dce61a838d616a471bd030139e93 > Reviewed-on: https://chromium-review.googlesource.com/1103149 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569371} TBR=bokan@chromium.org,sahel@chromium.org Change-Id: I02765feb066ba06534d0d6385432c64b21d0aaa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Reviewed-on: https://chromium-review.googlesource.com/1110860Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569428}
-
Becca Hughes authored
Add a DisplayCutoutClient mojo interface that is bound to a frame and called from the browser. This will set safe-area* CSS env() variables that websites can use to layout their content based on the safe area. DisplayCutoutClient will be called from Android in a future CL. BUG=847652 Change-Id: I6180aa5337e182fd1794586c47caef0f19fab718 Reviewed-on: https://chromium-review.googlesource.com/1083291Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569427}
-
Ryan Hamilton authored
Change-Id: Ie696c5ccaee3c9aba76065383ea04b976f002c7c Reviewed-on: https://chromium-review.googlesource.com/1110887Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569426}
-
Ryan Hansberry authored
This injects a ClientChannel into ProximityAuthMonitor, which is used if the chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used to get the current RSSI of the connected remote device. In the future, the "rolling average RSSI" that is calculated in ProximityAuthMonitor will be moved to the SecureChannel API, and returned by it. However, to reduce immediate migration work, that logic is kept in ProximityAuthMonitor for now. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 824568, 752273 Change-Id: I8d6485a5a0018fe43595b880c25a2fa9af5a1b75 Reviewed-on: https://chromium-review.googlesource.com/1106616 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569425}
-
Hector Carmona authored
Add WebUI at chrome://welcome/apps. WebUI is only shown when NuxGoogleApps feature is enabled. Bug: 832938 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I46721ac4474a4335d9c0dfdb977e09622ae0ac1c Reviewed-on: https://chromium-review.googlesource.com/1066503 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569424}
-
Stephen Martinis authored
Makes the isolated script test wrapper script know that metrics_python_tests is a typ based test suite, so that it passes the proper command line argument to it. Bug: 533481 Change-Id: Ifd45f947409989174e1da046be6a8342931f82eb Reviewed-on: https://chromium-review.googlesource.com/1109400Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569423}
-
Dominic Mazzoni authored
When a frame is hidden, replace its accessibility tree with just the root, and suppress all accessibility events in that tree while it's hidden. By keeping the root in the tree, this allows us to propagate the change to the browser process and free up resources there too. The goal is that having lots of tabs open shouldn't significantly impact your experience. It may add a slight delay when switching to a tab. Bug: 854411 Change-Id: I78b45e8f5772f0c9745ee59952f27f6ba3557bbc Reviewed-on: https://chromium-review.googlesource.com/1107207 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569422}
-
Hector Carmona authored
Bug: 854560 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I48820701f46e82e27a488f1b2b5a7feaaa20e436 Reviewed-on: https://chromium-review.googlesource.com/1108752Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#569421}
-
Xianzhu Wang authored
Bug: 854848 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb Reviewed-on: https://chromium-review.googlesource.com/1109500Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569420}
-
Will Harris authored
BUG=767906 Change-Id: I79dfb0509a1acc532a97750b4609e8bd6e3a438e Reviewed-on: https://chromium-review.googlesource.com/1110356 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569419}
-
Xiyuan Xia authored
- Add RunDragLoop and CancelDragLoop to WindowServiceDelegate interface; - WindowServiceDelegateImpl use ash::DragDropController to provide the actual impl; - WindowTree implements PerformDragDrop and CancelDragDrop via the WindowServiceDelegate; Bug: 837716 Test: WindowServiceDelegateImplTest.*Drag*, WindowTreeTest2.*Drag* Change-Id: Id5d609d30dd53171b01bfeec60e4547f7a61b4c3 Reviewed-on: https://chromium-review.googlesource.com/1110669 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569418}
-
Mounir Lamouri authored
Bug: 855051, 853609 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieedad00a60f3a64cf256771dc234953a928b5073 Reviewed-on: https://chromium-review.googlesource.com/1110667Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569417}
-
Michael Spang authored
Chrome OS does not have the VK_KHR_surface or VK_KHR_swapchain extensions. Move them to implementation specific code to allow initialization of vulkan on Chrome OS. Bug: 851997 Test: vulkan ozone_demo on linux x11 Change-Id: I5355a1f7e6d5215b98aba2defc8e4d631f6a964e Reviewed-on: https://chromium-review.googlesource.com/1104860 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569416}
-
Sean O'Brien authored
To prevent poor quality touches on hana, add a filter for low pressure touches, such as those generated by a pencil. Finger presses are above the chosen threshold and aren't affected. If a contact ever exceeds the presure threshold, all remaining events for that contact are sent. CQ-DEPEND=CL:1093584 BUG=b:69232663 TEST=manual testing on hana with pressure filter enabled Change-Id: Ic2d56eb656e318ee46744ef37f6055d8573a2261 Reviewed-on: https://chromium-review.googlesource.com/1096126Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#569415}
-
Mathieu Perreault authored
For privacy reasons, the native code will have to choose which icon is served within a single source (so the implementer cannot deduct history). The priority order is the local favicon, the server favicon or a letter+circle fallback. This CL implements the first and the last of those, and further CLs will improve the logic. Bug: 853780 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6f56d02f3c953964e4968f191b8fb3177998c962 Reviewed-on: https://chromium-review.googlesource.com/1105508 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569414}
-
Scott Violet authored
Adds registering the ui::mojom::Arc interface. Adds early to AccessibilityController::UpdateVirtualKeyboardFromPref. BUG=837686 TEST=none Change-Id: If417134ed26931a050e9bfdfd4b267d8ee819b9a Reviewed-on: https://chromium-review.googlesource.com/1111012Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569413}
-
Xiaohan Wang authored
This is more consistent with how other capabilities are passed along. Bug: 848532 Test: No new functionality Change-Id: Ib0ec5f979c9d183950fcaa6424729a027c5e5ef5 Reviewed-on: https://chromium-review.googlesource.com/1109739Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569412}
-
Theresa authored
Update fieldtrial testing config for experiment with scroll-to-load disabled. BUG= Change-Id: Ibb8c76592c12addd3c2f807fe9d338665f30e0c0 Reviewed-on: https://chromium-review.googlesource.com/1110850 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569411}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53842b6cbc1f..7a75f465f541 git log 53842b6cbc1f..7a75f465f541 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 simonhatch@chromium.org Revert "Dashboard - Raise error on duplicate histograms in /add_histograms" 2018-06-21 ckitagawa@chromium.org [Build] Filter HealthyDevices by ABI 2018-06-21 simonhatch@chromium.org Dashboard - Properly attach ownership data to alerts. 2018-06-21 benjhayden@chromium.org Add dashboard/dashboard/spa/OWNERS Created with: gclient setdep -r src/third_party/catapult@7a75f465f541 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853280 TBR=sullivan@chromium.org Change-Id: I15c924f040d46935274f8527d60f55c926f6e850 Reviewed-on: https://chromium-review.googlesource.com/1110301Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569410}
-
Guido Urdaneta authored
These utility sets are very specific to constraints processing, but they have generic-looking names such as DiscreteSet and NumericRangeSet, which might cause issues if actually generic sets with those names want to be added elsewhere. Bug: 731166 Change-Id: I5a5fcec7d1a83417b007621b496b22acba509352 Reviewed-on: https://chromium-review.googlesource.com/1101201 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569409}
-
Jay Civelli authored
This impacted a lot of APIs that now need to be provided with a SharedURLLoaderFactory. Note that in many of these APIs we still need also the net::URLRequestContextGetter as other GAIA requests still use the networ API directly. Once all GAIA code uses the network service, all APIs will be changed to only take the SharedURLLoaderFactory. Many tests that simulate URL responses had to be changed and use a TestURLLoaderFactory. In some instances, we need the TestURLLoaderFactory for the OAuth token but still mock the URLRequests directly for other operations. Also: - split up OAuth2AccessTokenFetcherImplTest.MakeGetAccessTokenBody into smaller tests - exposing ways to simulate URL responses directly in TestURLLoaderFactory as it was required by some tests Bug: 840396 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6d1d1081238aa5e1d8dc5f1469e4c752c93729fc Reviewed-on: https://chromium-review.googlesource.com/1096309 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#569408}
-
Pedro Amaral authored
If the BottomToolbar is destroyed before native is initialized there will be a null pointer exception. This CL adds a null check to prevent this. Bug: 854342 Change-Id: Ic0a82574e87bce7f46b20d3621796fad09c119a5 Reviewed-on: https://chromium-review.googlesource.com/1107053 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#569407}
-
Fady Samuel authored
If a SurfaceLayer is given an invalid SurfaceId then it should not block on that invalid SurfaceId and the specified deadline should play no part in the deadline of the CompositorFrame. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I71c31315ff0dbcd0ab9697e98c5f58aa3691bf67 Reviewed-on: https://chromium-review.googlesource.com/1110028Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569406}
-
Frank Kastenholz authored
Update flags https://chromium-review.googlesource.com/c/1108077 -------------------------------------------------- Fix include guard name https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Add net/third_party/quic/core/quic-debug_info_provider_interface.h Adds this file into the git commit history https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Do not set send alarm if write blocked. Do not set send alarm in the end of quic packet processing if it's write blocked. Protected by FLAGS_quic_reloadable_flag_quic_no_send_alarm_in_process_packet_if_write_blocked. Merge internal change: 200989386 https://chromium-review.googlesource.com/c/1106902/ -------------------------------------------------- Validate largest observed field in ACK frames. In QUIC, validate largest observed in received ack frame by comparing with largest sent packet instead of largest created packet. Protected by FLAGS_quic_reloadable_flag_quic_validate_ack_largest_observed. Merge internal change: 200744974 https://chromium-review.googlesource.com/c/1106899/ -------------------------------------------------- Add two flag protected CHECKs for oob access into sent packet manager's unacked_packets. Protected by FLAGS_quic_reloadable_flag_quic_extra_checks_in_ack_processing. Since bandaid does not have logs or core dumps, CHECK failure is the only way we can think of to get more information(from deathrattle report) to debug b/110029150. Do not intend to verify this flag, we only need to turn it on on bandaid from liveflag. Merge internal change: 200621124 https://chromium-review.googlesource.com/c/1106672/ -------------------------------------------------- Clean up QUIC Frame Generation and Parsing Clean up left-over stuff in the generation and parsing of QUIC Frames - Remove the IETF_TEMP_ frame types that were allocated to the IETF framer for testing purposes, - Remove code that uses/references/expects the IETF_TEMP types - Close connection (and/or do a QUIC_BUG) if we attempt to generate a GO AWAY or STOP WAITING in version 99. These frames are not valid in Version 99 - Close connection (and/or do a QUIC_BUG) if we attempt to generate an APPLICATION_CLOSE, NEW_CONNECTION_ID, MAX_STREAM_ID, STREAM_ID_BLOCKED, PATH_RESPONSE, PATH_CHALLENGE, or STOP_SENDING frame while NOT in version 99. These frames are IETF only. N/A - affected code all protected by the version 99 flag. Merge internal change: 200443164 https://chromium-review.googlesource.com/c/1106669/ -------------------------------------------------- Fix the flaky QuartcConnectionTest.DisconnectClosesRemote 1) We were removing packet writer before the connection was destructed (ownership was probably moved at some point in time). 2) QuartcThreadSafeSession::CloseConnectionSync was not closing a session, which led to the destruction of QuicConnection on the main thread, which led to a race condition. Reinstituted session_ = nullptr and added checks in other delegates. Also added a check in a destructor. 3) Changed "CancelImpl" to "Cancel" in the QuartcAlarm so that the deadline is resetted. Fix ordering of destructors in QuartcSession. Merge internal change: 200439184 https://chromium-review.googlesource.com/c/1106666/ -------------------------------------------------- Add underflow checks in IETF ACK frame processing. Add checks for underflows when stepping through the additional ack blocks for IETF ACK frames N/A Code is executed only if version-99 negotiated, which does not happen. This addresses issues found in Chromium Fuzz Testing - numbers 850476, 850554 Merge internal change: 200395378 https://chromium-review.googlesource.com/c/1106662/ -------------------------------------------------- Increase the default stream/session flow control limits. The default limit of 16KB causes blocking on sender and prevents us from even reaching BWE! This change fixes the delay and dropped frames in Quartc, and should have a significant impact on video quality. Increase the default stream & session flow control limits for quartc quic connection. Merge internal change: 200269081 https://chromium-review.googlesource.com/c/1106661/ -------------------------------------------------- Allow parsing/serializing a CryptoHandshakeMessage in QUIC's TransportParameters The CryptoHandshakeMessage in TransportParameters carries 3 values from QuicConfig: silent close, initial roundtrip time, and connection options. It also contains UAID. This provides support for gQUIC specific parameters in the TLS handshake as a stopgap until they either get added to IETF QUIC or removed from gQUIC. More Transport Parameters in QUIC; proected by --quic_supports_tls_handshake Merge internal change: 200258885 https://chromium-review.googlesource.com/c/1106660/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_no_mspc. Merge internal change: 200126339 https://chromium-review.googlesource.com/c/1106658/ -------------------------------------------------- Set bytes for QUIC connection id to 0. The ICE transport provides unique 5-tuples for each connection, so it's possible to omit the QUIC connection id from packet headers. This should save overhead. n/a (quartc only) Merge internal change: 200118909 https://chromium-review.googlesource.com/c/1106520/ -------------------------------------------------- Remove third_party/quic/http/ as this code is now unused. n/a - unused code Merge internal change: 200099282 https://chromium-review.googlesource.com/c/1106305/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_enable_server_proxy2. Merge internal change: 200091805 https://chromium-review.googlesource.com/c/1106297/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_enable_h2_deframer. Merge internal change: 200089857 https://chromium-review.googlesource.com/c/1106219/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_version_manager_dedupe_transport_versions Merge internal change: 200085914 https://chromium-review.googlesource.com/c/1106004/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_incremental_loss_detection. Merge internal change: 200057466 https://chromium-review.googlesource.com/c/1106002/ -------------------------------------------------- Deprecate FLAGS_quic_reloadable_flag_quic_respect_ietf_header. Merge internal change: 200055473 https://chromium-review.googlesource.com/c/1106000/ -------------------------------------------------- Replace flag quic_reloadable_flag_quic_enable_pcc with ..._pcc2 Replace the old pcc enable flag with a new one, so that we can check that the new codes are indeed running in experiment. Changes flag quic_reloadable_flag_quic_enable_pcc to quic_reloadable_flag_quic_enable_pcc2 Merge internal change: 200046441 https://chromium-review.googlesource.com/c/1105999/ -------------------------------------------------- In QUIC, move time wait list manager ProcessPacket from OnUnauthenticatedHeader to OnUnauthenticatedPublicHeader because packet number is not needed for public reset anymore. No function change expected. Not protected. Also remove unused version fields. Merge internal change: 200037571 R=rch@chromium.org Change-Id: I5e76d4b8627c0c2810c7468dad38086f16f82211 https: //chromium-review.googlesource.com/c/1105997/ Reviewed-on: https://chromium-review.googlesource.com/1108373 Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569405}
-
Sarah Hu authored
We should re-position the dialog when tablet mode is changed, and when display metrics is changed. Bug: 841074, 837005 Change-Id: I11299070a947e2fc4f4f494d2bbac4c94c27746e Reviewed-on: https://chromium-review.googlesource.com/1110487Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569404}
-
chrome://flagsDaniele Castagna authored
This patch adds a multi-value entry in about://flags that will help enabling/disabling HW overlay strategies used to promote quads to HW overlays. Bug: 854677 Change-Id: Ibaedb02084a0b6aea490637bd6c4456caa63e29d Reviewed-on: https://chromium-review.googlesource.com/1108520 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569403}
-
Robert Liao authored
MacOS does not handle zero-sized windows well. BUG=854267 Change-Id: I3da67cef7abdc035ca6378d5cb31dc68a097ee67 Reviewed-on: https://chromium-review.googlesource.com/1109200Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569402}
-
Robert Ma authored
All asserts need to be in a step func. Unfortunately this makes the tests more verbose. Found in https://github.com/web-platform-tests/wpt/pull/8748#issuecomment-398954260. Change-Id: Ib15270d6093ea094b0f8c387cc4370f5154cf5dd Reviewed-on: https://chromium-review.googlesource.com/1109689 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#569401}
-
Nico Weber authored
This makes the fyi bots run viz_gtests instead of viz_fyi_gtests which removes a few test binaries, but since those weren't run on any other desktop bot, it probably wasn't intentional that they run on mac anyways. Bug: 843511 Change-Id: Ieb132304f3e6b3869c1c2238ec509ed5a95174ab Reviewed-on: https://chromium-review.googlesource.com/1108360Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569400}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bcd66f54de12..3d8131535e6b git log bcd66f54de12..3d8131535e6b --date=short --no-merges --format='%ad %ae %s' 2018-06-21 tsepez@chromium.org Pass output parameters as pointers in ijs_event_context 2018-06-21 tsepez@chromium.org Remove WideString::c_str() calls where possible. 2018-06-21 tsepez@chromium.org Avoid const-refs to implicitly constructed strings. Created with: gclient setdep -r src/third_party/pdfium@3d8131535e6b The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic8232f5102b620e309927cb2b89866ff19f7251b Reviewed-on: https://chromium-review.googlesource.com/1110457Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569399}
-
David Tseng authored
Test: ChromeVox menus (Search+.) works again. It was breaking the page due to this missing message id. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id2a5539d29d46343472829b5e4b5d8deefe06e94 Reviewed-on: https://chromium-review.googlesource.com/1107165Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569398}
-
Yue Li authored
- Add two more screens for the flow. - Update proto definitions Bug: b/78190629 Test: Manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic9a849e3184ea5b09e0f0f338a018caf2193d829 Reviewed-on: https://chromium-review.googlesource.com/1105469 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569397}
-