- 19 Oct, 2018 40 commits
-
-
Ryan Sturm authored
This CL moves previews triggering from the IO thread (ChromeResourceDispatcherHostDelegate) to the UI thread (ChromeContentBrowserClient). The new call sites occur in NavigationRequest and update the previews_state in CommonNavigationParams held by the NavigationRequest directly. This means PreviewsDeciderImpl is being moved to the UI thread. Significant changes: - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of profile IO data. - PreviewsUserData is now entirely a UI thread notion. For now, we use PreviewsUITabHelper to manage its lifetime, but it could move to NavigationHandle (if NavigationHandle already supported UserData, that solution would be ideal). - ChromeNavigationData is update to remove PreviewsUserData and PreviewsState (the latter has moved into PreviewsUserData and there is a notion of Allowed PreviewsState and committed PreviewsState) - Offline Previews committed checks use the OfflinePreviewsTabHelper instead of PreviewsUserData now that we are on the same thread. - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well as cleanup to remove PreviewsState from being passed back out of the loader code into NavigationRequest. - There is a TODO to re-evaluate PreviewsState during redirects, which will *not* be plumbed into the network service, so DataReductionProxy Previews will not be updated. Bug: 842233 Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb Reviewed-on: https://chromium-review.googlesource.com/c/1266196 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#601298}
-
Chris Palmer authored
Clear Site Data has shipped. Bug: None Change-Id: If6a15404905a8086fc195ceb1cb2ec6a66a95909 Reviewed-on: https://chromium-review.googlesource.com/c/1292250Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#601297}
-
chrome://accessibilityJames Wallace-Lee authored
In chrome://accessibility, the "Chrome Native UI" section behaves like the "Pages" section. Browser windows are listed individually using the .row class the Pages list uses. -AccessibilityUIMessageHandler::RequestNativeUITree takes a session ID as an argument and returns the accessibility tree for a single browser window. -The TargetDescriptor dictionary includes a field for a browser window's session id, and a "type" field that is either "page" for a WebContents or "browser" for a Browser. -In accessibility.js, showTree and other functions handle both browser windows and pages, since they can check |data|'s type field. -Elements in a .row element are given ids based on the row's id + a description of the element: '<id>:title', 'showTree', 'copyTree', 'hideTree', 'tree'. Bug: 842895 Change-Id: I7ef7b4edb884ff097fdaefc41ba97a813a7b49e1 Reviewed-on: https://chromium-review.googlesource.com/c/1260009 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601296}
-
Joe Downing authored
This reverts commit 64646172. Reason for revert: LoggingTest.LogMessageMarkersOnStack is failing on several builders and this test was introduced in this CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/72386 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12371 Example error message: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932209218566904752/+/steps/base_unittests/0/logs/LoggingTest.LogMessageMarkersOnStack/0 Original change's description: > Add start & end markers around |str_stack| for use by Crash service. > > Crash can locate particular entries in a stack by scanning for start & > end markers with unusual values. We add start & end markers around the > |str_stack| copy of the LogMessage string, created when we're about to > crash the process due to a FATAL level log message. > > Bug: 802393 > Change-Id: I8fd462cc515ddbefb8c7b34363eea848171aa776 > Reviewed-on: https://chromium-review.googlesource.com/c/1201344 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601236} TBR=ajwong@chromium.org,dcheng@chromium.org,wez@chromium.org Change-Id: If00343894caa467887191fbb09a4c80233cc94b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802393 Reviewed-on: https://chromium-review.googlesource.com/c/1292595Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601295}
-
Will Harris authored
As stated in BrowserChildProcessHostImpl::OnChildDisconnected: "OnChildDisconnected may be called without OnChannelConnected, so stop the early exit watcher so GetTerminationStatus can close the process handle" This test previously did not take this into account and always expected a connected notification before a disconnected notification, so the test can be fixed by just removing this assumption. BUG=879555 Change-Id: I68ce0d27765a6b5387d57bf7af10b84c8fb240ac Reviewed-on: https://chromium-review.googlesource.com/c/1286910Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601294}
-
Yi Gu authored
For worklet animations that run via the main thread, the console log from the worklet may not get back to the main thread within 2 frames. To fix this, we can either wait longer, i.e. wait an extra frame, or not rely on the console log from the worklet as what we do in this patch. Bug: 887659 Change-Id: Ifb8619f571f51a7f5abe132a2c65d7a58f59d600 Reviewed-on: https://chromium-review.googlesource.com/c/1289430Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601293}
-
Marc-Antoine Ruel authored
As part of issue 894048 we'll probably unmap them and have another mean to map the binaries, but in the meantime this is the first step towards migrating to the Go binaries. R=iannucci@chromium.org Bug: 894045 Change-Id: I40c22997e8948a23a2a56e368b1cea55df0d5ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1286748Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601292}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cdebbeb8cca2..af3d6cc8910f git log cdebbeb8cca2..af3d6cc8910f --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thestig@chromium.org Roll v8/ 604c50c84..626844157 (516 commits) Created with: gclient setdep -r src/third_party/pdfium@af3d6cc8910f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9bb62c4420cf39885fd1a9b7ed40c7ae897f5938 Reviewed-on: https://chromium-review.googlesource.com/c/1292289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601291}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/715afb0cea5a..8edf3557ca17 git log 715afb0cea5a..8edf3557ca17 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Revert "Add custom target to wrap around custom commands. (#1986)" (#1996) 2018-10-19 sheredom@gmail.com Add validaton for SPV_KHR_8bit_storage + convert to/from floats. (#1990) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@8edf3557ca17 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia844635eeb30bb5a5aa5fb961650fb6144e49797 Reviewed-on: https://chromium-review.googlesource.com/c/1291756Reviewed-by:
-
Kevin McNee authored
The code for this was mostly already written, but its use was commented out, so the callbacks weren't being run. Also, we now use Bind{Once,Repeating} for these callbacks. Bug: 892889 Change-Id: I544de97a511286236cc9c4ad7a89e094aed202f5 Reviewed-on: https://chromium-review.googlesource.com/c/1283729Reviewed-by:Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#601289}
-
Christian Biesinger authored
This is a precondition for the next step I want to do, which is initialize fragments by passing the builder to their constructor, like we already do for constraint spaces. R=eae@chromium.org Change-Id: I626fe15da8d9643a3152f7a1cb0d4e556fb0d22a Reviewed-on: https://chromium-review.googlesource.com/c/1289720 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601288}
-
Weidong Guo authored
Changes: When an active window exists, clicking on shelf item to activate another window should not run slide down animation. Bug: 896908 Change-Id: Ifd037b139da44bac3d05c3c88dd5c7f044f7d898 Reviewed-on: https://chromium-review.googlesource.com/c/1292050 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601287}
-
Matthew Denton authored
Fixes the comments on RecvFrom and SendTo in udp_socket_posix.h and udp_socket_win.h to more accurately reflect who is responsible for keeping some of the function parameters alive. Namely, the sockets always take a reference to the provided IOBuffer in the case of asynch IO. And the SendTo function also creates a copy of the provided IPAddress if necessary, while RecvFrom take a raw pointer to the IPAddress and the caller is in charge of keeping it alive. Change-Id: I080557b8c69c9035eace94a0359ec5ce09c4cf0d Reviewed-on: https://chromium-review.googlesource.com/c/1290089Reviewed-by:
-
Dmitry Gozman authored
For window.open('') we start navigation to an empty url, which goes to RenderFrameImpl::DecidePolicyForNavigation. There we could in some cases decide to go to the browser process instead of committing locally: embedder can decide to fork process, chrome app window can use browser_handles_all_top_level_requests preference. This might trigger erroneous beforeunload/unload handlers if the process touches dom window synchronously before the navigation is processed in browser. Bug: 896379 Change-Id: If62c0e470b1ce8bc060f7378ba54d2b5930291ea Reviewed-on: https://chromium-review.googlesource.com/c/1291360Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601285}
-
Joe Downing authored
This reverts commit abc48df4. Reason for revert: Speculative revert due to MacSandbox* test failures in content_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29903 failures: MacSandboxTest.FileAccess MacSandboxTest.UrandomAccess MacSandboxTest.OpenSSLAccess MacSandboxTest.ClipboardAccess Failure log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932209461845513232/+/steps/content_unittests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/MacSandboxTest.ClipboardAccess/0 Original change's description: > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > The nacl loader process, used only on macOS, currently tries to load an > invalid profile type under the V2 sandbox. This loads the correct type. > This also adds necessary IOKit resource access to the nacl sandbox profile. > > Bug: 892554 > Change-Id: I3118c00a17502efdd88545ef35e81e3a480d2f15 > Reviewed-on: https://chromium-review.googlesource.com/c/1289070 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601244} TBR=dschuff@chromium.org,kerrnel@chromium.org,rsesek@chromium.org Change-Id: I6825d62c07e111781530bfcb45618782a1570799 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892554 Reviewed-on: https://chromium-review.googlesource.com/c/1292525Reviewed-by:
-
Kyungyoung Heo authored
Add build/build_config.h to using OS macro without presubmit warning. Bug: 810841 Change-Id: I81fc8bfdbcb539983d17b72d6541ee4119ea9410 Reviewed-on: https://chromium-review.googlesource.com/c/1278457 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#601283}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/82d432980cff..1cb20deb746a git log 82d432980cff..1cb20deb746a --date=short --no-merges --format='%ad %ae %s' 2018-10-19 niklas.enbom@webrtc.org Revert "Make sure Chromium will pick the correct field_trial/metric impl." 2018-10-19 nisse@webrtc.org Replace _stricmp with absl::EqualsIgnoreCase 2018-10-19 yvesg@webrtc.org Mute failed tests when no sanitizer defects. 2018-10-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c66210d3..b1cb8571 (601019:601125) 2018-10-19 sakal@webrtc.org Set renderThreadHandler to null on uncaught exception in EglRenderer. 2018-10-19 mbonadei@webrtc.org Prefix flag macros with WEBRTC_. 2018-10-19 mbonadei@webrtc.org Make sure Chromium will pick the correct field_trial/metric impl. 2018-10-19 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 5). 2018-10-19 nisse@webrtc.org Move the SocketStream class to test target 2018-10-19 mbonadei@webrtc.org Adding missing #include on absl/memory/memory.h. Created with: gclient setdep -r src/third_party/webrtc@1cb20deb746a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/117400268,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic76c1f589b49e57dcc0d65351edf8bbd3256e1c1 Reviewed-on: https://chromium-review.googlesource.com/c/1291790Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a31f315c7410..a4f1ca269765 git log a31f315c7410..a4f1ca269765 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 bpastene@chromium.org cros_run_vm_test: Don't raise an exception when a host-cmd exits non-zero. Created with: gclient setdep -r src/third_party/chromite@a4f1ca269765 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1c16d668d8fa98be9d16b73431a06db82b2dac28 Reviewed-on: https://chromium-review.googlesource.com/c/1291846Reviewed-by:
-
Xiaoqian Dai authored
Let TabDragController::RevertDrag() to handle the case if the dragged tab is not dragged far enough and needs to be merged back to its source window's tabstrip. This CL also moved the bounds update of source window to SplitViewController::TabDraggedWindowObserver after the drag ends. This CL also reverts the change in https://chromium-review.googlesource.com/c/chromium/src/+/1266495 since after this CL, the reason to split the one function ClearTabDraggingInfo() into two functions no longer exists. Bug: 892517 Change-Id: I412efa82cbba8629d750859865e11ab21d020637 Reviewed-on: https://chromium-review.googlesource.com/c/1290269Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f44307feaae..245ff8c6a020 Created with: gclient setdep -r src-internal@245ff8c6a020 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:893729,chromium:895202 TBR=mmoss@chromium.org Change-Id: I9ac7b67e2cb019cd823c8ec2fabed1023f808a72 Reviewed-on: https://chromium-review.googlesource.com/c/1292229Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601279}
-
Jared Saul authored
This is a retry/relanding of https://chromium-review.googlesource.com/c/chromium/src/+/1269524. We're having a *very* hard time reproducing the flakes that the trybots experienced, but I've made some improvements to attempt to reduce possible race conditions in the browsertests. Patch set 1 is the original CL; patch set 2 contains the new changes. (When a card accrues 3 strikes, future offers to save for that card should show the omnibox save icon, but NOT pop up the bubble. On Android, no offer to save is shown at all.) TBR=mahmadi@chromium.org Bug: 884817 Change-Id: If641cff300cab6122bfd0a52942376b8b6449fed Reviewed-on: https://chromium-review.googlesource.com/c/1292169 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#601278}
-
Ovidio Henriquez authored
This change updates the WebUsbAllowDevicesForUrls policy entry in policy_templates.json to have the future property set to true. This prevents the policy from being in documentation and the generated ADMX and linux.json file until the policy is visible in Site settings. Design document: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: Ib2c9a04fd992d8c6c88a52ec9c954a48ff9a673d Reviewed-on: https://chromium-review.googlesource.com/c/1262082 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601277}
-
Stephen Martinis authored
It appears that some return statements were accidentally omitted during an earlier refactor. This CL adds a few of them back. Bug: 896175 Change-Id: I218d8ae6fa347fea775d606b5aa04064662ff7e6 Reviewed-on: https://chromium-review.googlesource.com/c/1291787Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#601276}
-
chrome://connnection-helpCarlos IL authored
Added the Symantec cert error code to the bundled connection help that shows when clicking the 'Learn More' link in an interstitial triggers another interstitial. In this case the link is in the section with other cert errors instead of separate, since if the Symantec error shows up in the Chrome support site it is likely due to a captive portal or an extension, not due to the support site using Symantec certs. Change-Id: I3a0889e2e5f683d120f2bdf4a4ce76dae75fc225 Reviewed-on: https://chromium-review.googlesource.com/c/1292005 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#601275}
-
Alexander Alekseev authored
Bug: 896645 Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02 Reviewed-on: https://chromium-review.googlesource.com/c/1290200Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#601274}
-
Dan Harrington authored
Helper script to construct a gtest_filter. Change-Id: I370a36c96d9f6f4e3beb450dd1ca26a65154e56f Reviewed-on: https://chromium-review.googlesource.com/c/1265025 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601273}
-
Michael Giuffrida authored
Fixes the placeholder to match the version in chromium_strings.grd. Bug: 895201 Change-Id: I31e1aec017661597cad41f9d9a1fff6601000b3a Reviewed-on: https://chromium-review.googlesource.com/c/1288908Reviewed-by:
-
Ned Nguyen authored
This is a reland of 5f74e543. The original reland is in patch set 1, fixes are in subsequent patchset. The fix implements: If --release or --debug is specified and there are both more than one target dirs, it would try to choose the dir that match the configuration on args.gn Original change's description: >Automatically pick a target directory which exists for run_web_tests.py script > > This also updates how we compute the default for 'configuration'. First, we try to look for the > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the > value of configuration using the target value. > > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. > > > Bug: 893618 > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 > Reviewed-on: https://chromium-review.googlesource.com/c/1281043 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#600760} Bug: 893618 Change-Id: I386b8261fc4abddd51a5b4f290c5eb3ac6ce5361 Reviewed-on: https://chromium-review.googlesource.com/c/1289308 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Joe Downing authored
This reverts commit 66a392fa. Reason for revert: Causing component_unittest failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/23527 failing tests: SyncableServiceBasedBridgeTest.ShouldDecryptPreviousDirectoryDataAfterRestart SyncableServiceBasedBridgeTest.ShouldDecryptInitialRemoteData SyncableServiceBasedBridgeTest.ShouldDecryptForRemoteDeletion Original change's description: > Add encryption support to pseudo-USS > > This patch extends SyncableServiceBasedBridge (core to pseudo-USS) > with support for encryption, via a newly introduced interface > (ModelCryptographer), which needs to be usable in the model thread > (where the bridge lives). > > This should unblock the migration of PASSWORDS to pseudo-USS, because > password data must be encrypted at all times. This is a first step of > a proposal described in a dedicated section in the Design Doc: > https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot > > Actual usage of this functionality will be introduced in follow-up > patches. > > Bug: 870624 > Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1288594 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601254} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: Iab6463f9541ca242facdc8c5217f1cf4c114ba49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870624 Reviewed-on: https://chromium-review.googlesource.com/c/1292512Reviewed-by:
-
Dianna Hu authored
The motivation is to prepare HpackVarintDecoder to conditionally support 62 bit integers as required by the QPACK specs. This will of course have to be flag protected. HpackVarintDecoder::MaxExtensionBytes() and MaxOffset() would need to return different values depending on the value of the flag. It's a lot easier to get rid of them instead. In HpackVarintDecoder::Resume(), use a locally defined const instead of MaxOffset(). In MarkDone() et al., use numeric_limits::max() instead of |MaxOffset() + 7|. This value is so large that it does not matter if HpackVarintDecoder is in up-to-28-bit-mode or up-to-62-bit-mode. Avoid using a method to cut down on clutter in release builds. In HpackVarintDecoderTest.ValueTooLarge, hardcode the large value. It does not hurt to reduce logic in tests anyway. This CL lands server change 214703557 by bnc. BUG=488484 Change-Id: Ie12bfda99b478549bcc5b126be54e51804c0d85c Reviewed-on: https://chromium-review.googlesource.com/c/1291592 Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601269}
-
Kenneth Russell authored
This reverts commit a337f08f. Reason for revert: this CL only re-enables the test on Windows; the failure seen was on macOS, which is a different platform and had a preexisting flaky expectation for this test. Investigation will continue on the bug into the flakiness on that platform. Original change's description: > Revert "Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash" > > This reverts commit 8bd7e583. > > Reason for revert: Still flaky :( https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/166516 > > Original change's description: > > Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash > > > > This was flaky, but should be fixed. > > > > Bug: 878258 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0 > > Reviewed-on: https://chromium-review.googlesource.com/c/1285526 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600813} > > TBR=kbr@chromium.org,enne@chromium.org > > Change-Id: I0dd172bd7db86982f9b1bf49e2a57c059958d348 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 878258 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1290950 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601098} TBR=kbr@chromium.org,enne@chromium.org,dullweber@chromium.org Change-Id: If1ca9d7ae9ef2122150edfa9d965e0a9cd5c442a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1292431Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601268}
-
Yue Cen authored
Bug: 885219 Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b Reviewed-on: https://chromium-review.googlesource.com/c/1290196Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601267}
-
Joe Downing authored
TBR=dtseng@chromium.org BUG=897249 Change-Id: I53918bf9b8c88f9ed2b5772c3e8258a70689fb2b Reviewed-on: https://chromium-review.googlesource.com/c/1292270Reviewed-by:
-
Dave Tapuska authored
Use appropriate types in scheduler code. BUG=879657 Change-Id: I51e83b9fd5e6ec48706110bc4ae832d2075e89ca Reviewed-on: https://chromium-review.googlesource.com/c/1287956 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601265}
-
Yuchen Liu authored
This is not supported by the SDK. Change-Id: I23a9affcdd4b69280b3b9dec978179eca54b790e Reviewed-on: https://chromium-review.googlesource.com/c/1289683Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601264}
-
Dianna Hu authored
These tests use HpackVarintEncoder to generate test data, hence they are in fact round trip tests. This CL lands server change 214689001 by bnc. BUG=488484 Change-Id: I27eb50471a83d44cfc21d7fa42fde1c1a7ef25c4 Reviewed-on: https://chromium-review.googlesource.com/c/1291809Reviewed-by:
-
Ben Pastene authored
Most of this should be unnecessary now that the GN rules for the tests list the pylibs as data. See https://chromium-review.googlesource.com/c/chromium/src/+/1291711/2 for an example CQ run of a change that touched //build/android/ w/ this patch applied. It ran all the tests on the android bots, but was mostly a no-op for the other bots. R=jbudorick, dpranke Change-Id: I25ba6260652508994144eb3d8e4bd7304a863e88 Reviewed-on: https://chromium-review.googlesource.com/c/1291782Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601262}
-
Jamie Madill authored
The decoder microbenchmarks suffer from fairly high variance. This should decrease the variance while not changing the absolute total. Also add a mode for a fast test run on the bots with DCHECK enabled. The test time on the perf bots should still be within one minute. Bug: angleproject:2763 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idf5fb0f4cb32205c8c640415b5e6ff22efa5b7b1 Reviewed-on: https://chromium-review.googlesource.com/c/1286753 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601261}
-
Nate Chapin authored
In the vein of WorkerTaskQueue, this provides an API for farming work out to a pool of background threads. However, it is built on top of the Worklet API, and also supposes addModule() to load and register tasks. Classes with a process() function can be created and registered via the global scope's registerTask() function. taskWorklet.postTask() can take a |name| string (rather than a function), look up whether a task was registered with that name, and call the appropriate process(). Bug: 879306 Change-Id: I7f7c23c3482be3641fde6b78d11f3152c437a460 Reviewed-on: https://chromium-review.googlesource.com/c/1278961 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601260}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf5c51bcd364..42bb3604bce4 git log cf5c51bcd364..42bb3604bce4 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 mtklein@google.com Revert "re-enable effect deserialization for flutter" 2018-10-19 mtklein@google.com override getTypeName() instead of using table 2018-10-19 brianosman@google.com Un-plumb dstColorSpace through GrTextureProducer 2018-10-19 egdaniel@google.com Reland "Revert "Use OpenGL sampler objects when available."" 2018-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a9999ce938be..9e4d040cb93c (1 commits) 2018-10-19 brianosman@google.com Remove unused dstColorSpace from getROPixels 2018-10-19 michaelludwig@google.com Consolidate aa resolution for per-edge aa quads 2018-10-19 halcanary@google.com SkTArray: behave a little more like std::vector 2018-10-19 brianosman@google.com When checking color type in image shaders, trust SkBitmapProvider, not image 2018-10-19 halcanary@google.com SkBitSet: cleanup. Remove unused fn, more general exporter. 2018-10-19 michaelludwig@google.com Add quad type and persp/aa utilities to GrQuad 2018-10-19 mtklein@google.com clean up flattenable macro cruft 2018-10-19 brianosman@google.com Remove unused SkBitmapProvider functions 2018-10-19 brianosman@google.com Remove unused SkBitmapCacheDesc factory 2018-10-19 egdaniel@google.com Add ability for an SkDevice to handle the drawing of an SkDrawable. 2018-10-19 egdaniel@google.com Revert "ccpr: Unregister path listeners when their cache entries are evicted" 2018-10-19 bsalomon@google.com Revert "Revert "Use OpenGL sampler objects when available."" 2018-10-19 kjlubick@google.com [canvaskit] Disable effect_deserialization Created with: gclient setdep -r src/third_party/skia@42bb3604bce4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I0a44a1c4c93d163f25c8f32c7283eadc1f2ad6bd Reviewed-on: https://chromium-review.googlesource.com/c/1291911Reviewed-by:
-
