Commits · 3114e51a51ce584dd1223a473e59f7374f05a8b4 · eriksson monteiro / tangled

25 Jul, 2012 40 commits

[Chromoting] Update uninstaller to facilitate testing automation. · 3114e51a

garykac@chromium.org authored Jul 25, 2012

With this change, if launched from shell as root, the uninstaller will:
* Not show any confirmation UX
* Not prompt for admin elevation

Also in this cl, cleanup some of the shared Mac constants by pushing
more into into constants_mac and fixing up the naming style. This
required minor updates to the prefpane and daemon controller.

BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10807061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148442 0039d316-1c4b-4281-b951-d872f2087c98

3114e51a

Enabled Selection (ctrl-A) on login password · 0812b714

harrym@chromium.org authored Jul 25, 2012


BUG=125863
TEST=Tested change on linux build /w chromeos=1


Review URL: https://chromiumcodereview.appspot.com/10796115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148441 0039d316-1c4b-4281-b951-d872f2087c98

0812b714

Enables internal filesystem types via Isolated filesystems. · d6afd119

kinuko@chromium.org authored Jul 25, 2012

 * cracks isolated path in FileSystemURL ctor
 * FileUtils no longer need to crack the isolated path by themselves
 * Make IsolatedFileUtil inherit from LocalFileUtil
 * Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil

BUG=134078,138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10810053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148440 0039d316-1c4b-4281-b951-d872f2087c98

d6afd119

Make Window::ContainsPoint and Window::ContainsPointInRoot const. · e43526b4

yusukes@chromium.org authored Jul 25, 2012

BUG=None
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10823015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148439 0039d316-1c4b-4281-b951-d872f2087c98

e43526b4

Converts SearchViewController to use live NTP content instead of placeholder · b404c01d

dhollowa@chromium.org authored Jul 25, 2012

Converts SearchViewController to use live NTP content using views::WebView
instead of placeholder solid rect views::View.

TEST=Launch CrOS/Aura with --enabled-instant-extended-api, observe interactive "Most Visited" section on NTP
BUG=133529
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10787028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148438 0039d316-1c4b-4281-b951-d872f2087c98

b404c01d

Fixed coverity defects pertaining to pass-by-value use where pass-by-reference is preferred · 6574d79e

orenb@chromium.org authored Jul 25, 2012

CID_COUNT=3
CID=(104210, 104215),104237,104238
BUG=
TEST=
TBR=jln,bolms,brettw

Review URL: https://chromiumcodereview.appspot.com/10825016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148437 0039d316-1c4b-4281-b951-d872f2087c98

6574d79e

Add new test file for codec config change tests. · 7f806f9f

acolwell@chromium.org authored Jul 25, 2012

BUG=122913
TEST=None
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148436 0039d316-1c4b-4281-b951-d872f2087c98

7f806f9f

Remove ui_resources_default_100_percent.rc and theme_resources_default_100_percent.rc · be3b5002

benrg@chromium.org authored Jul 25, 2012

These files (included in chrome.dll on Windows) have the same contents as the
corresponding .pak files. Aside from wasting space, this indirectly caused bug
137715 (the Windows resources take precedence over .pak file resources even
when not at default_100_percent).

Some day we may consider using Windows resources instead of paks (for all
scales), but right now we don't need these RC files.


BUG=137715,137917
TEST=trybots, visual inspection

Review URL: https://chromiumcodereview.appspot.com/10820003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148435 0039d316-1c4b-4281-b951-d872f2087c98

be3b5002

Added extra DCHECK() to eliminate possible NULL deref. · 356a1774

khorimoto@chromium.org authored Jul 25, 2012

CID=104002
BUG=
TEST=
TBR=ben

Review URL: https://chromiumcodereview.appspot.com/10822022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148434 0039d316-1c4b-4281-b951-d872f2087c98

356a1774

Coverity: Initialize member variables. · bfc7dbe6

jhawkins@chromium.org authored Jul 25, 2012

CID_COUNT=6
CID=102321,102647,102678,102810,103294,103381
BUG=none
TEST=none
R=tbreisacher@chromium.org
TBR=mirandac@chromium.org, jam@chromium.org,dcheng@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148433 0039d316-1c4b-4281-b951-d872f2087c98

bfc7dbe6

Coverity: Initialize member variables. · f80131d4

jhawkins@chromium.org authored Jul 25, 2012

CID_COUNT=6
CID=103934,104157,[104037,104088,104089,104091],104223,104241,104263
BUG=none
TEST=none
R=tbreisacher
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/10830013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148432 0039d316-1c4b-4281-b951-d872f2087c98

f80131d4

Change NaClIPCAdapter to save translated descriptors to the rewritten message. · 1c2e0c43

bbudge@chromium.org authored Jul 25, 2012

BUG=116317
TEST=manual
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148431 0039d316-1c4b-4281-b951-d872f2087c98

1c2e0c43

Coverity: Initialize member variables. · f1a9c52b

jhawkins@chromium.org authored Jul 25, 2012

CID_COUNT=12
CID=104349,104361,104373,104374,104399,104420,104421,104422,104466,104476,
    104532,104538
BUG=none
TEST=none
R=groby
TBR=brettw,satorux,mnissler

Review URL: https://chromiumcodereview.appspot.com/10833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148430 0039d316-1c4b-4281-b951-d872f2087c98

f1a9c52b

Disable ExtensionApiTest.Rlz which has become too flaky · 1629eeea

atwilson@chromium.org authored Jul 25, 2012

TBR=rogerta@chromium.org
BUG=137834
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10829017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148429 0039d316-1c4b-4281-b951-d872f2087c98

1629eeea

Revert "Revert 148383 - Move the keyboard overlay view to ash." · 729b4851

mazda@chromium.org authored Jul 25, 2012

The original CL broke win_aura, which is fixed in this CL.

This reverts commit b36e6617.

TBR=ben@chromium.org
BUG=124222
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10824023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148428 0039d316-1c4b-4281-b951-d872f2087c98

729b4851

PPAPI/NaCl: Make ImageData for NaCl just use shared memory · 16b7b278

dmichael@chromium.org authored Jul 25, 2012

BUG=116317
TEST=
TBR=ben@chromium.org
ben for ui/gfx OWNERS

Review URL: https://chromiumcodereview.appspot.com/10790063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148427 0039d316-1c4b-4281-b951-d872f2087c98

16b7b278

Try renabling IndexedDBLayoutTest.RegressionTests now that those tests run... · 16c10d7d

jam@chromium.org authored Jul 25, 2012

Try renabling IndexedDBLayoutTest.RegressionTests now that those tests run under content_browsertests.

BUG=123685
Review URL: https://chromiumcodereview.appspot.com/10821020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148426 0039d316-1c4b-4281-b951-d872f2087c98

16c10d7d

Delete duplicate chrome/test/data/media files that were copied in r148190 in... · dce31fa4

jam@chromium.org authored Jul 25, 2012

Delete duplicate chrome/test/data/media files that were copied in r148190 in preparation for r148349.

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10828015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148425 0039d316-1c4b-4281-b951-d872f2087c98

dce31fa4

Remove use-after-free bug. · 8c5e41d2

tbreisacher@chromium.org authored Jul 25, 2012

CID=104376
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10821018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148424 0039d316-1c4b-4281-b951-d872f2087c98

8c5e41d2

Modify the PPB_Audio_Shared code for NaCl. · 420ade41

bbudge@chromium.org authored Jul 25, 2012

BUG=116317
TEST=none

This adds code for the NaCl untrusted build of the PPAPI proxy. The NaCl IRT can't
create threads that call back into user code, so the Audio thread must be created
using a special NaCl API.
Review URL: https://chromiumcodereview.appspot.com/10809079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148423 0039d316-1c4b-4281-b951-d872f2087c98

420ade41

Delete chrome/test/data/workers since it's not used anymore. It was copied in... · cb017d1e

jam@chromium.org authored Jul 25, 2012

Delete chrome/test/data/workers since it's not used anymore. It was copied in r148205 in preparation for r148349.

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10821016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148422 0039d316-1c4b-4281-b951-d872f2087c98

cb017d1e

Update .DEPS.git · 61fe6c4a

chrome-admin@google.com authored Jul 25, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148421 0039d316-1c4b-4281-b951-d872f2087c98

61fe6c4a

Coverity: Fully initialize the |trace_| member variable. · e645c7af

jhawkins@chromium.org authored Jul 25, 2012

Also changed the type of |count_| to size_t since it's a size variable.

CID_COUNT=1
CID=13504
BUG=none
TEST=none
R=brettw


Review URL: https://chromiumcodereview.appspot.com/10834006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148420 0039d316-1c4b-4281-b951-d872f2087c98

e645c7af

WK roll: 123543->123635 · c6d3499b

atwilson@chromium.org authored Jul 25, 2012

TBR=tomhudson@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10833015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148419 0039d316-1c4b-4281-b951-d872f2087c98

c6d3499b

Always use chromium threads for IO in remoting host · ead49409

sergeyu@chromium.org authored Jul 25, 2012

BUG=137140


Review URL: https://chromiumcodereview.appspot.com/10808094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148418 0039d316-1c4b-4281-b951-d872f2087c98

ead49409

Add compositor thread mode to latency tests · e18d4aca

jbates@chromium.org authored Jul 25, 2012

BUG=138883

Review URL: https://chromiumcodereview.appspot.com/10829015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148417 0039d316-1c4b-4281-b951-d872f2087c98

e18d4aca

Extensions Docs Server: Samples search and icons · f18fb478

cduvall@chromium.org authored Jul 25, 2012

Added the search feature to the samples page, and also added icons next to the
samples.

BUG=131095

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148260

Review URL: https://chromiumcodereview.appspot.com/10809062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148416 0039d316-1c4b-4281-b951-d872f2087c98

f18fb478

Add threaded-compositor test mode to throughput_tests · 545f1c28

jbates@chromium.org authored Jul 25, 2012

BUG=138880

Review URL: https://chromiumcodereview.appspot.com/10823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148415 0039d316-1c4b-4281-b951-d872f2087c98

545f1c28

Revert 148413 - Add new fields to GPU benchmarking API. · 33cd6997

dtu@chromium.org authored Jul 25, 2012

Add droppedFrameCount, totalPaintTime, and totalRasterizeTime to chrome.gpuBenchmarking.renderingStats().

BUG=chromium:130790, chromium:137756
TEST=Launch Chrome with --enable-gpu-benchmarking and per-tile painting, open a tab to a composited page, and type chrome.gpuBenchmarking.renderingStats(). All the above fields should be present.

Review URL: https://chromiumcodereview.appspot.com/10823023

TBR=dtu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148414 0039d316-1c4b-4281-b951-d872f2087c98

33cd6997

Add new fields to GPU benchmarking API. · 1f8a23d7

dtu@chromium.org authored Jul 25, 2012

Add droppedFrameCount, totalPaintTime, and totalRasterizeTime to chrome.gpuBenchmarking.renderingStats().

Review URL: https://chromiumcodereview.appspot.com/10823023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148413 0039d316-1c4b-4281-b951-d872f2087c98

1f8a23d7

Add a clarifying comment to the memory layout navigation. (Inspired by Coverity CID 100022) · 5ace0a8f

gbillock@chromium.org authored Jul 25, 2012

R=tommi@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10826014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148412 0039d316-1c4b-4281-b951-d872f2087c98

5ace0a8f

Add owners for chrome/browser/media_gallery · 55705ebb

vandebo@chromium.org authored Jul 25, 2012

BUG=NONE
TEST=NONE
NOTRY=TRUE


Review URL: https://chromiumcodereview.appspot.com/10832016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148411 0039d316-1c4b-4281-b951-d872f2087c98

55705ebb

Fix invalid header guards in jingle_session(_manager)?.h · 88660de2

sergeyu@chromium.org authored Jul 25, 2012

Review URL: https://chromiumcodereview.appspot.com/10825017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148410 0039d316-1c4b-4281-b951-d872f2087c98

88660de2

Add new resource files for the new slider control ui. · b76470e2

jennyz@google.com authored Jul 25, 2012

BUG=124097
TEST=NONE
TBR=oshima@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148409 0039d316-1c4b-4281-b951-d872f2087c98

b76470e2

Added hover feedback on touch to launcher buttons. · 8072483e

kgr@chromium.org authored Jul 25, 2012

BUG=131186
TEST=


Review URL: https://chromiumcodereview.appspot.com/10702102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148408 0039d316-1c4b-4281-b951-d872f2087c98

8072483e

CPM: API changes for API/UI integration. · 50caa012

mtytel@chromium.org authored Jul 25, 2012

BUG=130212
TEST=


Review URL: https://chromiumcodereview.appspot.com/10797056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148407 0039d316-1c4b-4281-b951-d872f2087c98

50caa012

Remove more set noparents · 1aa497c7

ben@chromium.org authored Jul 25, 2012

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10824025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148406 0039d316-1c4b-4281-b951-d872f2087c98

1aa497c7

Revert 144488 - For unit tests, track additions to AtExitManager and warn. · fe992bf0

scottbyer@chromium.org authored Jul 25, 2012

While trying to bullet proof a unit test, I had trouble getting very far when
running all tests in shuffle mode. Tracked that back to a few other tests doing
stuff that accessed Singleton()s outside of a test-scoped
ShadowingAtExitManager. Seemed to me that should be an invariant around any
unit test, so created this towards that end, hopefully helping stabilize out
unit_tests a bit more.

BUG=133403


Review URL: https://chromiumcodereview.appspot.com/10582012

TBR=scottbyer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98

fe992bf0

Changed FirstPotentialDefaultEngine histogram to log whether or not we are... · c9236ae7

stevet@chromium.org authored Jul 25, 2012

Changed FirstPotentialDefaultEngine histogram to log whether or not we are syncing function is called by FindNewDSP outside of a current sync cycle.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10790153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148404 0039d316-1c4b-4281-b951-d872f2087c98

c9236ae7

Extensions Docs Server: api_index.html, experimental.html · 8c6a893d

cduvall@chromium.org authored Jul 25, 2012

Implemented the api_index.html and experimental.html pages using an
api_list_data_source.

BUG=131095

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147995

Review URL: https://chromiumcodereview.appspot.com/10815042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148403 0039d316-1c4b-4281-b951-d872f2087c98

8c6a893d