GitLab

Add Sharing Highlights android specific flag and dummy icon to Sharing
Hub.

screenshot:
default - https://screenshot.googleplex.com/doZDXMtS1wM.png
dark - https://screenshot.googleplex.com/ch3op4EHiOX.png

Bug: 1102382
Change-Id: Ia82579c95f0782b0ca5b5f2bacd9dd4d42f188fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295779
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788412}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8db0c721..7e3ef3c4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If2436035671b2710e2c6fd60ab96584286bc5665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298265Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788411}

This fixes some easy instances of the privacy_mode_enabled boolean.
Rather than reconstruct the enum out of QuicServerId's boolean, use the
Chromium accessor. (The Chromium accessor currently reconstructs things
itself, but I'm hoping we can change that. Either way, this avoids some
duplicated code.)

Where privacy_mode_enabled was logged as a boolean, I've switched to a
string rperesentation pulled out of url_request_netlog_params.cc. Also
I've filled in a few missing parts of QuicSessionKey in one of the log
events and sync'd up with the comments in net/log.

Bug: 1103350
Change-Id: I6906fa802f6ebb0a8b6c187519df68a74a1d3b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296629
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788410}

https://chromium.googlesource.com/external/leveldb.git/+log/5bd5f0f67a5e..c46e79c76012

$ git log 5bd5f0f67..c46e79c76 --date=short --no-merges --format='%ad %ae %s'
2020-07-11 wzk784533 avoid unnecessary memory copy

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: Ie3bc5ceb4539ddc92da2f6439b6790aebf728e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296799
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788409}

https://chromium.googlesource.com/angle/angle.git/+log/e5c184751160..4ad0f250a010

2020-07-14 jmadill@chromium.org Revert "Vulkan: Enable VK_KHR_get_memory_requirements2 extension"
2020-07-14 timvp@google.com Update README.md to indicate GLES 3.1 conformance
2020-07-14 lehoangq@gmail.com Metal: Create a dedicated class for Window Surface.
2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 2a164e9680a5 to 858b13a1220a (1 revision)
2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from d704d1bc0e11 to 0bc4c2ae7012 (1 revision)
2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad65826a2ab1 to cd0af6456eb1 (5 revisions)
2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4e13c90944e9 to fe24a54808c2 (3 revisions)
2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 68bfbc219497 to 521eaacef67a (1 revision)
2020-07-14 syoussefi@chromium.org Vulkan: Fix resolve draw path
2020-07-13 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension
2020-07-13 enga@chromium.org Revert "Refactor DisplayGbm::generateConfigs"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1105208,chromium:1105609
Tbr: jonahr@google.com
Change-Id: I94d94d763cfd0df6de4a23f1d876f42ae3b963dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298286Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788408}

Added the ClipboardDataEndpoint destination trying
to read the clipboard data as a as a parameter for all
ui::Clipboard Read*() functions. This destination is intended
to be used only on ChromeOS and Test platforms.
This CL adds this plumbing. Implementation of filtering will
be done in following CLs.

Bug: 1096456
Change-Id: If689ed3e38fc92c0ec50c043bf67312e59aeaa55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266901
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788407}

We plan to ship with this disabled in M86, so turn
all the old API surface off sooner rather than later to give
people using the origin trial more time to adapt.

Bug: 853326
Change-Id: Iacc74d13715bad6d5baaba1e24fd353e002aec16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246904Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788406}

Start running browser test
WebSocketBrowserTest.SendCloseFrameWhenTabIsClosed on Windows
again. This was flaking on the bots 2 years ago but doesn't fail when
run locally. Experimentally re-enable it to see if it is still flaky.

BUG=616958

Change-Id: I2f927e47593ba5e2e2541a4843db37327129792a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282840Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788405}

This is part of a greater effort to cleanup callbacks in
chromeos/network.

Bug: 1007660
Change-Id: Iab7825de0892295d2758082764775d645915ef29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290548
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Hugo Benichi <hugobenichi@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788404}

The rewriter used to recognize that //v8 is in a separate git repository
and treated it as third-party.  After this CL, the rewriter knows about
additional, similar paths that 1) are in a separate git repository and
2) do not contain a "third_party" substring.

Bug: 1069567
Change-Id: I6ff1a8e10ec3a4b8bae4521aaebe88aed7714be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296826Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788403}

This includes an IWYU fix for <alogrithm>.
TBR=kvitekp@chromium.org

Change-Id: If016f6b1e8e4ef92a04c36c99aeed5b21032b9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298170Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788402}

This is no longer needed. A follow-up patch will delete the
factory itself.

Bug: 1092155
Change-Id: I436c065c844eb7ce07f8918f5c093c15c6c2b409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296274Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788401}

Bug: internal b/159937174
Test: CQ, build chromecast
Merge-With: eureka-internal/423679
Change-Id: I993eea66d26b410f7bacffac9b971f986fd01ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293105
Commit-Queue: JinJie Chen <jinjiechen@google.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788400}

This change makes chrome://apps compatible with Trusted Types
mitigation by combination of removing usage of dangerous sinks, and
assigning TrustedHTML to dangerous sinks either with emptyHTML or
creating Trusted Type policies. This change also renames variable
names according to guidelines.

Bug: 41905
Change-Id: I7aea389a8d23849fb5bc89d12a10e46d3c2fddcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239707
Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788399}

Move the annotations bar to a separate element.

Also delegate some logic related to the ink controller to this new
element from the pdf_viewer, instead of relying on events and
getters to pass data back from the viewer down to the annotations bar
and back. Specifically:
- Pass the ink controller to the annotations bar via polymer bindings
- Listen for annotation-undo-state events and call redo/undo directly
  from the annotations bar, instead of doing this in the viewer.
- Add a new loaded event in the ink controller, so that the annotations
  bar can listen for this event to update the annotation tool when the
  ink controller loads, instead of needing to access the tool from
  the pdf viewer.

Bug: 1100431
Change-Id: Ifb4219d1df321d84666091f3707686a544f96e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285479
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788398}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dcda36de8344..4290f3d1534f

2020-07-14 aerotwist@chromium.org [TypeScript] Fix formatter_worker/HTMLFormatter types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1098730
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3fcee98f0f1c574656089624ff0be4ca1a43fee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298247Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788397}

This was IOSurface-specific for no good reason. Move it to the common
GLImage code.

TBR=geofflang

Bug: 894929
Change-Id: If39c03985ebf0e3db72fd96534a903975cac0ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296568Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788396}

This CL replaces old resource reader in
ServiceWorkerInstalledScriptReader. The new mojo-based reader gives a
data pipe for reading response body so ServiceWorkerInstalledScriptReader
no longer needs to have helper functions that converted a net::IOBuffer
to a data pipe.

Bug: 1055677
Change-Id: I3d0edafa4ea6fcb80bcb0167c5d54d0afef43138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282552Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788395}

This CL reduces the estimated pre-processed size of partition_alloc.h
by 160KB.

This CL has no behavior changes. This CL affects 8,400+ compilation
units.

Bug: 242216
Change-Id: I7cfa2a79f8ed7604fcd71fef2ec21cfa11b295a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297026
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788394}

Bug: 1101058
Change-Id: Ic2bb25d5652a77c401471f067c76feef7e740303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277977
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788393}

This is a wrapper of ServiceWorkerStorage::GetRegisteredOrigins().

Bug: 1055677
Change-Id: Ifca679ed80a0b06c6e30bab824275b8b6b5a8137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291922Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788392}

This reverts commit c670ba45.

Reason for revert: Test is still broken, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57063

Original change's description:
> Reland "Turn on Media History by default"
> 
> This is a reland of ccf0e2f9
> 
> Fixes TSAN issue in the constructor of sql::Database
> by moving it to the main thread.
> 
> Original change's description:
> > Turn on Media History by default
> >
> > BUG=1024351
> >
> > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224
> > Auto-Submit: Becca Hughes <beccahughes@chromium.org>
> > Commit-Queue: Tommy Steimel <steimel@chromium.org>
> > Reviewed-by: Tommy Steimel <steimel@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#787954}
> 
> Bug: 1024351
> Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788312}

TBR=beccahughes@chromium.org,steimel@chromium.org

Change-Id: I49684e84563a84f09c8436d55371c88122129132
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1024351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297209Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#788391}

https://quiche.googlesource.com/quiche.git/+log/a5812a0bf342..ad56e3f17dd1

$ git log a5812a0bf..ad56e3f17 --date=short --no-merges --format='%ad %ae %s'
2020-07-14 quiche-dev Consolidates bool members of quicspdysession to reduce wasted padding.
2020-07-14 wub In bbr2sender::adjustnetworkparameters, 1) do not inject a bandwidth sample to max bandwidth filter, and 2) update pacing rate after cwnd is updated. protected by --gfe2_reloadable_flag_quic_bbr2_improve_adjust_network_parameters.
2020-07-14 bnc Minor improvements to quic/core/http:end_to_end_test
2020-07-14 dschinazi Deprecate Q048 and Q049
2020-07-14 bnc Fix hpack error code mapping to quicerrorcode.  not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ieb4bc409e7d0c6a569107588453dac88c29e27b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298167
Commit-Queue: Nick Harper <nharper@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788390}

Bug: 1085419
Change-Id: I32f6f41bc6f4650b313cf3834bd4ac57c5a196f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298058
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788389}

in /chrome/android/java/src/org/chromium/chrome/browser/language

This CL was uploaded by git cl split.

R=jiameng@chromium.org

Bug: 1071603
Change-Id: Ie57f00678c08c9356ce815d3b5cc9b7d4e9d4eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290920
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788388}

R=akihiroota@chromium.org, dmazzoni@chromium.org

Bug: 1102990
Change-Id: I4c5c31cef91a1aeefd35cff34efc1a408c7f6b40
AX-Relnotes: ChromeVox now plays a sound when a pass through gesture (double tap and hold) is performed.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296889Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788387}

Change-Id: I6d0169f8f83ca8604daea50cf708ec78a9cfdace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295940
Auto-Submit: ssid <ssid@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788386}

The existing query APIs IsDecoderConfigSupported() and
GetVideoEncodeAcceleratorSupportedProfiles() are fallible because the
list of supported profiles may not have been retrieved from the GPU
process yet.

This CL adds APIs to check if the supported profiles have been fetched
and to register to be notified when they have been.

Bug: 1047994, 1105258
Change-Id: Ib4b9cce8599c00218cb72912186a893a91a65f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249103
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788385}

As described in https://crbug.com/988938#c11, we suspect that the
flakiness might have been fixed already and we just need to reenable the
tests (and monitor the Flake Portal).

Bug: 988938
Change-Id: I5ab97ddc8aaa5eabc4a3ea9b61d4551075920cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292997
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788384}

Show pin enrollment screen in OOBE flow for supervised
account when tablet mode is on by adding an account type
checking to DiscoverScreen.

Bug: 1093458
Change-Id: Id0d93344261238c4f02578261a17251c9df835ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265359
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788383}

This patch fulfills the various TODOs in the attached bug by deleting
the entire class, since it is effectively no longer used outside of
unit testing.

Bug: 1015477

Change-Id: I1ff22b0d9c8357c8bf75286f2f247fb2092d0eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296010Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788382}

This reverts commit 64ecc629.

Reason for revert: Need more powerful mac machines

Original change's description:
> Add mac-official builder
> 
> Bug: 1072012
> Change-Id: I2c1842c0406f7278b5bd303a8df21d8d1dfa0e23
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292513
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
> Cr-Commit-Position: refs/heads/master@{#788317}

TBR=gbeaty@chromium.org,kimstephanie@google.com

Change-Id: Iae6b6479623d430663061c907e9e17807756d5c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1072012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298323Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#788381}

SessionMessageWindow::OnWndProc() returns true without setting the
LRESULT* result out function parameter.  The caller then uses
|result|, which contains an uninitialized value.

The fix updates SessionMessageWindow::OnWndProc() to always return
false, which makes the caller use DefWindowProc() to set |result|.

Bug: 1058556
Change-Id: I2d1876049e27e9043e9b3a690ffc6697369ea255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295980Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Steve Becker <stevebe@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#788380}

The main frame can change over the life of the TestRunner, if we swap
the frame on navigation. Instead, bind the current frame, via the
TestRunnerBindings. This means the FindInProcessMainWindowMainFrame()
is only used for
a) TestRunner::SetMockScreenOrientation() which is a bug to be fixed
b) TestRunner::FinishTest() (and callers to it).

That means we no longer rely on the main frame being stable or
consistent in order to be correct. FinishTest() will do the right
thing and find the main frame's process.

The last issue is that the "main window" is only set on the RenderView
(well, the RenderView's BlinkTestRunner) at the start of the test, so
if swapping the main frame also changes to a different RenderView then
it will not know it's the main window.

Either the browser needs to keep the "main window" bit up to date or
we can move the BlinkTestRunner::TestFinished() code up to the browser
process, where it can invoke the right things in the right renderer.
The tricky bit is.. the synchronous layout at the end of the test done
in the renderer. But this only matters if the frame is already in the
main frame's process.

R=avi@chromium.org

Bug: 1069111
Change-Id: Iae77bbabeeb074ba1595e7652f07f31cb556a1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298053
Auto-Submit: danakj <danakj@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788379}

not subclass of LayoutBlock. TablesNG, and Video tag need it.

NGBlockNode: :FirstChild needs to handle LayoutBox subclasses that are
Change-Id: Iba678185e713d478b8831203ee3e87615ce443ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296481Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788378}

'Page' is a much more widely known term then renderer.

This also fixes the tests so they work with older implementations.

BUG=1072442
TEST=NavigationTest.*PageInitiated*

Change-Id: I9c02cc2c4107a0527e2a7564ae96e486e3db8b73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298223Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788377}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316a44100fb7..61e9eac61475

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jianli@google.com,pmonette@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1099917,chromium:1101531,chromium:1105180
Tbr: jianli@google.com,pmonette@google.com
Change-Id: I1cf9150e2a5cb8b0a1fa02503259e13b97e034c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298037Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#788376}

With the move to Single File Components, we are now able to use
eslint-plugin-vue to its full capacity. Almost all the code changes in
this CL are generated by `eslint --fix`. The only two style violations
that I manually fixed:

* Invalid use of `this` in templates
* Adding types to props

Bug: 1093962
Change-Id: I97126621b7721f6b81e745b8f6a5aecc29705f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293161
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788375}

This reverts commit 9819cecd.

Reason for revert: 
https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/6434

Original change's description:
> Avoid testRunner.eventSender in
> paint/invalidation/table/table-overflow-scroll-in-overflow-scroll-scrolled.html
> 
> Bug: 1047176
> Change-Id: Iba4344ebc6d44f6e122c3871cb0fee5454553a9a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297100
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788218}

TBR=wangxianzhu@chromium.org,lanwei@chromium.org

Change-Id: I10e2320a515fa2b5162248ac32667b0e1a622077
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1047176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298347Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788374}

This reverts commit 1d114582.

Reason for revert: it is breaking the Android tests https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%209%29/27588

Original change's description:
> Fix sequence checker asserts in CrxDownloader.
> 
> The code crashes because there is a race condition between
> the main sequence and another task runner when the instances
> of the CrxDownloader are destroyed.
> 
> On the main sequence, the CrxDownloader is being used to
> download a file, then the reference to this instance
> is released. The CrxDownloader is using a task runner
> to run a blocking task, which validate the file it has just
> downloaded. This task runner receives a closure which holds a
> reference to the CrxDownloader.
> The reference is released after the task is run, and therefore,
> it results in a race when the dtor of CrxDownloader is being
> invoked.
> 
> Besides removing the offending sequence checkers of the
> destructors of the CrxDownloader classes, this CL changes
> where the timer of the BackgroundDownloader is destroyed.
> The timer has sequence affinity and it must always
> be destroyed on the main sequence.
> 
> Bug: 1105289,1105460
> Change-Id: I78e002502ce6f5501c78d1e849f51b47bf3dc092
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297696
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#788330}

TBR=sorin@chromium.org,waffles@chromium.org

Change-Id: I87c30dbc1542c14e18c69c0806f138508f99bf9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1105289, 1105460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298439Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788373}