- 11 Aug, 2018 40 commits
-
-
David Roger authored
This is a reland of: https://chromium-review.googlesource.com/1170202 which was reverted because of missing svg icon. The user events UI toggle should be grayed out and turned off when there is a passphrase or when history sync is disabled. Note that this is purely a UI change: the internal sync datatype is not really turned off in that case, and we assume that the Sync engines will correctly stop syncing user events in these cases, even if the preference is still ON. Bug: 865522, 865537 Change-Id: I745f048b3ca301231f57c04b82d0d9d82a6f3b90 Reviewed-on: https://chromium-review.googlesource.com/1170825Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#582433}
-
Peter Kasting authored
This reverts commit 8e4127dd. Reason for revert: Part 1 of trying to revert the history throttling changes, to see if https://bugs.chromium.org/p/chromium/issues/detail?id=870861 improves. Original change's description: > Change the history state throttle interval from 60 to 120 Hz. > > This is a bit more lenient and may enable some callers, including a flaky test, > to get (more of) what they need. The test's root problem seems to be data races > (see issue 847326), however. > > Bug: 870861 > Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c > Reviewed-on: https://chromium-review.googlesource.com/1171825 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582415} TBR=palmer@chromium.org,dcheng@chromium.org,kinuko@chromium.org Change-Id: I9fb7b5b0f8ebff8b6d6c5a772745cfd2c10ef51a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870861 Reviewed-on: https://chromium-review.googlesource.com/1171708Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582432}
-
Cheng-Yu Lee authored
Bug: 868249 Change-Id: Ie99e4c4ac7738c369a9b54bf2621a2c16dc8bc1d Reviewed-on: https://chromium-review.googlesource.com/1168222Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582431}
-
Findit authored
This reverts commit b3392d98. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 582403 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzMzkyZDk4OGFlMjNkYzUyZDliMzg2YWY0N2RjNmE1M2EyZDIyYzgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28575 Sample Failed Step: unit_tests Original change's description: > Add vector of intervals range checking to Time Restrictions policy > > * Add function GetEndOfCurrent interval to obtain the last end of the > interval which contains the current time. > * Add function MaterializeIntervalsToLocalTimezone, which materializes > the given intervals to the current local timezone. > * Add function TimeIsInsideCrosSettingsIntervals, which checks if the > current time is inside the intervals set in cros settings. It then > returns the localized string of the end of the interval that contains > the current time. > > BUG=chromium:852860 > TEST=added unittests > > Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3 > Reviewed-on: https://chromium-review.googlesource.com/1132676 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582403} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:852860 Change-Id: I1663fc559003d938270da4b8fd7e85719b8e9e01 Reviewed-on: https://chromium-review.googlesource.com/1172003 Cr-Commit-Position: refs/heads/master@{#582430}
-
Peter Kasting authored
This reverts commit 5eeadd14. Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0 Original change's description: > Remove unnecessary tab key press from Focus_AdvanceFocus test > > The associated bug which required this extra tab is fixed. > > Bug: 147644 > Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343 > Reviewed-on: https://chromium-review.googlesource.com/1170986 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582240} TBR=ekaramad@chromium.org,mcnee@chromium.org Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 147644 Reviewed-on: https://chromium-review.googlesource.com/1172002Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582429}
-
Yuwei Huang authored
Previously AudioStub is owned by the the (Remoting|Jni)Client class and being passed to ChromotingSession as a WeakPtr. The AudioStub is not used after it is passed to ChromotingSession and it is a burden for the *Client class to manage its lifetime. This CL fixes this by making ChromotingSession own the AudioStub. Bug: 868088 Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e Reviewed-on: https://chromium-review.googlesource.com/1171840Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#582428}
-
Findit authored
This reverts commit b092ae62. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 582411 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwOTJhZTYyMmI5YWIzODU2ZDY0ZDNlY2E1NDNlNGVjYjI0M2JlNzcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7241 Sample Failed Step: ash_content_unittests Original change's description: > chromeos: add SingleProcessMash mode > > This makes Ash create an Env if passed SingleProcessMash. In addition this > makes all window creation go through a factory that ensures the right env is > supplied. > > See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit > for more details. > > This also adds the feature to ui/base. > > BUG=847992 > TEST=covered by tests > > Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb > Reviewed-on: https://chromium-review.googlesource.com/1168282 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582411} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=847992 Change-Id: I9e2e3c0d92dc7b51f08fa35a2dfacd5ca8af57f2 Reviewed-on: https://chromium-review.googlesource.com/1171706 Cr-Commit-Position: refs/heads/master@{#582427}
-
Julie Jeongeun Kim authored
When 'CreateTooltipWidget' creates 'Widget' for tooltip and initializes it, it needs its bounds at InitParams. If it doesn't have the bounds information, some platform widgets get crashed and DesktopWindowTreeHostX11 keeps |sanitized_params| to avoid this case. This patch delivers the bounds for the tooltip widget and adds DCHECK to find what causes the empty bounds. Bug: 849585 Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0 Reviewed-on: https://chromium-review.googlesource.com/1086820Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#582426}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I4cabb60493cd431bb673a5459e1283c615c6c0ec Reviewed-on: https://chromium-review.googlesource.com/1171982Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582425}
-
Peter Kasting authored
This reverts commit 3b8db25c. Reason for revert: Checking to see whether this caused https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477343009904/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings/0 and similar. Original change's description: > Make //content layer default to --site-per-process mode on desktop. > > After this CL site-per-process is the default in all layers on desktop > platforms, except: > > - Layout Tests which still run with no isolation by default > (see https://crbug.com/856734#c5 for the explanation why) > > - //content embedders that don't want to use site-per-process: //chromecast > > - //content embedders that don't yet support site-per-process, but will > need to migrate eventually: //headless > > > Also note that even after this CL: > > - //content on Android still defaults to no isolation. > This is compatible with not_site_per_process_* test steps > because such steps are not run on Android bots... > > - //chrome layer ChromeContentBrowserClient controls usage of > site-per-process in the Chrome browser and continues to be controlled > by a field trial (note that Android is not covered by the field trial > or by testing/variations/fieldtrial_testing_config.json). > > > Bug: 856734 > Change-Id: Iebd46e5502583f84a4b0a7c2ee8d8b0e081c6ff2 > Reviewed-on: https://chromium-review.googlesource.com/1153981 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Stephen Lanham <slan@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582223} TBR=thakis@chromium.org,boliu@chromium.org,skyostil@chromium.org,alexmos@chromium.org,slan@chromium.org,lukasza@chromium.org Change-Id: Ieca3a36422b0f90dccc0040eeece799523c954e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856734 Reviewed-on: https://chromium-review.googlesource.com/1171705Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582424}
-
Peter Kasting authored
This reverts commit 1e3c1743. Reason for revert: Breaks Mac tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477492727648/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/TextSuggestionsTouchBarControllerTest.Offset/0 Original change's description: > [Mac] Add Offset to TextSuggestionsTouchBarController Text Selection > > When the text surrounding the current selection gets too long, only > part of it is received by TextSuggestionsTouchBarController. The > location of the received text within the total block of text is > denoted by an offset. Previously, TextSuggestionsTouchBarController > did not take this offset into account, causing crashes when the > selection range was past the end of the received text. > > The offset is passed along with the text and selection range. The > selection range within the received text is calculated using the > offset and received selection range. The editing word range is stored > both as the range within the received text and the range within the > total text for checking when to ignore text selection updates. > > RenderWidgetHostView::GetOffsetForSurroundingText() was added to > retrieve the offset on WebContents update. > > Browser tests were modified to account for the new offset parameter. A > new browser test, TextSuggestionsTouchBarController.Offset, was added > to test that the controller properly handles offsets. > > Bug: 717553 > Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c > Reviewed-on: https://chromium-review.googlesource.com/1169597 > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582205} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: If0acdd0494b5270c4b4e221e16b8e901ce2cacc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1171704Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582423}
-
Ned Nguyen authored
This also add this check to PRESUBMIT perf_json_config_validator script Bug: 873389 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I16fd762e567d5a41d75a221456e12e14a03f0b85 Reviewed-on: https://chromium-review.googlesource.com/1171578Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582422}
-
Wez authored
Bug: 808287 Change-Id: Ic699462759818049666babb0587939e4ca687643 Reviewed-on: https://chromium-review.googlesource.com/1167555Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#582421}
-
Stephen Martinis authored
They seem to need longer timeout for now. Hopefully will be temporary. TBR=bpastene Bug: 853248 Change-Id: I6665013085631c69e6d78fe1f43f195e12d3295c Reviewed-on: https://chromium-review.googlesource.com/1171909Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#582420}
-
Peter Kasting authored
Bug: 622387, 871692 Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065 TBR: mgiuca Reviewed-on: https://chromium-review.googlesource.com/1171852Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582419}
-
Yafei Duan authored
Implement live page sharing: - Adding a new temporary client namespace for the usage of live page sharing, which has a limit of one page per url and expiration period as one hour. - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow of save page, get page and share page. Bug: 870895 Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246 Reviewed-on: https://chromium-review.googlesource.com/1162827Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#582418}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07 git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support. 2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend 2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-10 timliang@google.com only set color index if using dual source blending in Metal gpu backend 2018-08-10 kjlubick@google.com [PathKit] Add various path effects 2018-08-10 mtklein@google.com clean up SK_LEGACY_CONVERT_PIXELS_IMPL 2018-08-10 caryclark@skia.org fix text blob example errors 2018-08-10 caryclark@skia.org fix bookmaker check for enum size 2018-08-10 liyuqian@google.com Reland "Update ShouldUseAAA with our better complexity estimation" 2018-08-10 timliang@google.com enabled gms and most unit tests for Metal gpu backend 2018-08-10 mtklein@google.com switch ubsan to blacklist 2018-08-10 bungeman@google.com Change generateAdvance to never chain. 2018-08-10 caryclark@skia.org refresh generated includes 2018-08-10 fmalita@chromium.org [sksg] Simplify ScopedRenderContext 2018-08-10 caryclark@skia.org new batch of docs 2018-08-10 timliang@google.com implemented GrMtlGpuCommandBuffer for draws in Metal gpu backend 2018-08-10 mtklein@google.com add bounds sanitizer to ASAN/UBSAN bots 2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd662d210afc..c47cd435bf6f (1 commits) Created with: gclient setdep -r src/third_party/skia@f3ca1c6abb07 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264 Reviewed-on: https://chromium-review.googlesource.com/1171445Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582417}
-
Joe Mason authored
This is required to typemap chrome_cleaner::PUPData. R=rockot Bug: 830892 Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e Reviewed-on: https://chromium-review.googlesource.com/1171736 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582416}
-
Chris Palmer authored
This is a bit more lenient and may enable some callers, including a flaky test, to get (more of) what they need. The test's root problem seems to be data races (see issue 847326), however. Bug: 870861 Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c Reviewed-on: https://chromium-review.googlesource.com/1171825Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#582415}
-
Kai Ninomiya authored
This is needed because re-recording archives (using record_wpr) causes these files to get re-alphabetized automatically. This commit lets us re-record an archive without producing an unreadable diff. Doing this also removes the duplicate key "androidpolice_mobile_sync_scroll_2018" from rendering_mobile.json. Tangentially, also delete the unused archive rendering_mobile_007.wprgo.sha1. Bug: 872551, 867368 Change-Id: Ib15c9c0a8600e7fa510a146ad896aa92e4f9de45 Reviewed-on: https://chromium-review.googlesource.com/1171677Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582414}
-
siyua authored
This is the 1st CL adding view skeleton. For project details please refer to go/ib-paradise. Bug: 852904 Change-Id: Icc10a2598bb15659a6478fc2dbf2734094111494 Reviewed-on: https://chromium-review.googlesource.com/1149514 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#582413}
-
Antoine Labour authored
This generalizes the FlushParams to contain sync tokens + IPC::Message instead of ad-hoc fields transformed into Messages on the receiving side. This allows any Message (that doesn't have handles) to be included into the list, and simplifies the service-side handling. Existing AsyncFlush and DestroyTransferBuffer messages are now serialized client-side, and CreateSharedImage/DestroySharedImage are converted to this mechanism, to avoid extra IPCs per tile. Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib11298c03e249f49aec8e710a3db4195aea33e81 Reviewed-on: https://chromium-review.googlesource.com/1168731Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582412}
-
Scott Violet authored
This makes Ash create an Env if passed SingleProcessMash. In addition this makes all window creation go through a factory that ensures the right env is supplied. See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit for more details. This also adds the feature to ui/base. BUG=847992 TEST=covered by tests Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb Reviewed-on: https://chromium-review.googlesource.com/1168282 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582411}
-
Jun Mukai authored
Previously window_finder_chromeos (for mash) looks through the list of the toplevel browser windows, but it is too simple and doesn't work well on several cases. This CL moves the window finding code to ash, and let WindowTree notify the list of windows at the cursor to the client upon window moving. BUG=867074 TEST=ash_unittests Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee Reviewed-on: https://chromium-review.googlesource.com/1159346 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582410}
-
Matthew Cary authored
Bug: 873380 Change-Id: Iaa194b57f57985a6bc851a2b826555a6d087a57c Reviewed-on: https://chromium-review.googlesource.com/1171234 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582409}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/284b5e0c60ac..6a4e31b4882f git log 284b5e0c60ac..6a4e31b4882f --date=short --no-merges --format='%ad %ae %s' 2018-08-10 ehmaldonado@chromium.org gclient_scm: Add option to specify the branch the patch is based on. Created with: gclient setdep -r src/third_party/depot_tools@6a4e31b4882f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870279 TBR=agable@chromium.org Change-Id: I4563fb1540b017267659c6d67ca8dcbf6f3feb8f Reviewed-on: https://chromium-review.googlesource.com/1171443Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582408}
-
Wenzhao Zang authored
Bug: 873340 Change-Id: Ia5979ba5305b154a27689157db573f8bc6803801 Reviewed-on: https://chromium-review.googlesource.com/1171790Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582407}
-
Stephen Martinis authored
This reverts commit 2db41802. Reason for revert: Bots are purple, will reland and make sure they're green later. Original change's description: > Add debug chromium bots > > These are mirrors of the existing release bots > > Bug: 867725 > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d > Reviewed-on: https://chromium-review.googlesource.com/1159172 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582390} TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,kbr@chromium.org,nodir@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: I28a27093f09db79c83239070325254df6a1a0dca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867725 Reviewed-on: https://chromium-review.googlesource.com/1171430Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#582406}
-
Lei Zhang authored
- Make some methods const. - Update some comments. - Remove an unimplemented method declaration. - Remove an unused method parameter. Change-Id: I678d740f4915b4d55d5be5fdc6482b7bac18778b Reviewed-on: https://chromium-review.googlesource.com/1170401 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#582405}
-
John Chen authored
The previous change (r581945) to update version string used by ChromeDriver in release branches didn't work, because the top-most commit doesn't have the necessary branch info. This CL adds the same commit filter used to generate the version string shown by Chrome. Bug: chromedriver:2080 Change-Id: I4d7b57a139968d3e5e0f1ebad26d6ed648ab5d72 Reviewed-on: https://chromium-review.googlesource.com/1171843Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582404}
-
Adolfo Victoria authored
* Add function GetEndOfCurrent interval to obtain the last end of the interval which contains the current time. * Add function MaterializeIntervalsToLocalTimezone, which materializes the given intervals to the current local timezone. * Add function TimeIsInsideCrosSettingsIntervals, which checks if the current time is inside the intervals set in cros settings. It then returns the localized string of the end of the interval that contains the current time. BUG=chromium:852860 TEST=added unittests Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3 Reviewed-on: https://chromium-review.googlesource.com/1132676Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#582403}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/077cd858b2d4..ea926a362b77 git log 077cd858b2d4..ea926a362b77 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 jmadill@chromium.org Add angle_perftests README file. 2018-08-10 jmadill@chromium.org D3D: Use angle::Result error pattern. 2018-08-10 jmadill@chromium.org Fix AMD detection in angle_end2end_tests. Created with: gclient setdep -r src/third_party/angle@ea926a362b77 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I66ef52bae109017756c16854706a5a4b95d73c23 Reviewed-on: https://chromium-review.googlesource.com/1171403Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582402}
-
Emil A Eklund authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/2b76767bf572364d3d647cdd139f2044a7ad06b2..b6fdcf4f8bd09e065c767939125861c9dc8ff18f Tbr: drott@chromium.org Change-Id: Ie65cb46846224bd90ffa86517a946c44f321f2c7 Reviewed-on: https://chromium-review.googlesource.com/1170170Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582401}
-
Tatiana Buldina authored
Fix a test failure in Python test case testWindowMinimize, and clean up code related to not supported version. Change-Id: I076cdc90cdaca322bc64530c6bb9eabe6ae9069a Reviewed-on: https://chromium-review.googlesource.com/1171805Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#582400}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5a4110982f31..21cd5a309631 git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for reruns. Created with: gclient setdep -r src/third_party/catapult@21cd5a309631 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:873331 TBR=sullivan@chromium.org Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93 Reviewed-on: https://chromium-review.googlesource.com/1171404Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582399}
-
Dale Curtis authored
Prevents any calls into the native bridge once release() has been called on MediaCodecBridge. I've also reordered some member variables of the bridge to match their lifetime. BUG=873094 TEST=none Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0 Reviewed-on: https://chromium-review.googlesource.com/1171836Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#582398}
-
Zhenyao Mo authored
Excluding some large size data in third_party/catapult/ that are not needed in running the telemetry tests. R=kbr@chromium.org,nednguyen@chromium.org Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578 Bug: 872521 Reviewed-on: https://chromium-review.googlesource.com/1166261Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582397}
-
Cathy Li authored
Bug: 873124 Change-Id: I5f5f5af481e9f8e31a1dab141b9b4dac93acc121 Reviewed-on: https://chromium-review.googlesource.com/1171742Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#582396}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5429bacaf530263c0fe78c4403624d6773d12866 Reviewed-on: https://chromium-review.googlesource.com/1171858Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#582395}
-
Sebastien Marchand authored
This moves the PageAlmostIdle and SiteCharacteristicsDatabase features to their own experiment so they can easily be shipped to Beta only. Change-Id: I56c65e4ffb8b389b502a8c03d661ca2c26a66abe Reviewed-on: https://chromium-review.googlesource.com/1168107Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#582394}
-