GitLab

A few simple changes/typos that require correction which were detected
when merging changes into trunk.

Change-Id: Ib088ca4a1741e642e3d912d010e4e77ba5fb72b0
Reviewed-on: https://chromium-review.googlesource.com/962357
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543155}

Previously, history.{push,replace}State spam failed silently, causing developer
confusion.

This change also introduces the --disable-pushstate-throttle flag to allow users
to disable the throttling.

This work was primarily authored by Trent Willis <trentmwillis@gmail.com>.

R=creis@chromium.org, dcheng@chromium.org

Bug: 769592, 794923
Change-Id: I969456b190d535f8dee3e03b5c4f4f36730d6b38
Reviewed-on: https://chromium-review.googlesource.com/851000
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543154}

This change adds a composited version of the bottom toolbar. The layer
is not specific to the bottom sheet and can be used for any bottom UI.
The layer is not added to the hierarchy in this patch.

BUG=815324

Change-Id: I309f392c975ed7099aaf7562461625bd7c886a2d
Reviewed-on: https://chromium-review.googlesource.com/935742
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543153}

FormTracker::FormControlDidChangeImpl is post task when render frame
could be gone.

Bug: 820773
Change-Id: I234d4b44a27903ea2e4c4b9f83fab63ec9accb00
Reviewed-on: https://chromium-review.googlesource.com/962921
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543152}

On Windows, fullscreen widgets kill themselves when losing focus,
which means that if they hang, the mere act of trying to display
the "hung page" dialog will kill the hung page.

Watch the widget to avoid a crash in this case.

This shouldn't be (and isn't) crashing on the Mac in this way, but
this makes the parallel changes on the Mac for symmetry.

BUG=811737
TEST=as in bug

Change-Id: I81f1797c3f5473b21eee2eed6c660e0f3acd1352
Reviewed-on: https://chromium-review.googlesource.com/961461Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543151}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6d54e48b2b8..a8985aa3f68b

$ git log d6d54e48b..a8985aa3f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5ebdf66c2a651c0d1755ef91e818f2356a076067
Reviewed-on: https://chromium-review.googlesource.com/962926
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543150}

Spec : https://mccanny.users.x20web.corp.google.com/www/wm-motion/index.html#overview-freeform
We do not want to move the headers when entering tablet mode, they
should already be at their final destination.

Test: manual
Bug: 812004
Change-Id: Id5ab7e7e4f56da7ecf4c83f76ffa01aa49d6e661
Reviewed-on: https://chromium-review.googlesource.com/958223Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543149}

This reverts commit bd5fdccd.

Reason for revert: #testRender is still flaky with this test disabled

Original change's description:
> Disable NewTabPageTest#testOpenMostVisitedItemInIncognitoTab
> 
> This test appears to be causing NewTabPageTest#testRender to flake.
> Spectulatively disabling.
> 
> BUG=813589
> 
> Change-Id: I0bdd566c14d1e6d3521e00e097e55a9f079e76a1
> Reviewed-on: https://chromium-review.googlesource.com/954333
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541799}

TBR=bauerb@chromium.org,twellington@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813589
Change-Id: Idcace61dcf6b0a98c94fddee83bea9d2563ff1c0
Reviewed-on: https://chromium-review.googlesource.com/958007Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543148}

system_webview_shell_page_cycler_apk.

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821914
Change-Id: I268530f8624710dd626a4578002a98b858e36008
Reviewed-on: https://chromium-review.googlesource.com/962829
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543147}

TBR=ntfschr

Bug: 821697
Change-Id: I61515e735a542cf94dcb00c50263ea512d66fcea
Reviewed-on: https://chromium-review.googlesource.com/963081Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543146}

Previously, a long title would bump the close button
off the edge of the cell. This change allows the title
to be compressed.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I10d88d9e90f24cd4051d1cc0161801fe6d11ae32
Reviewed-on: https://chromium-review.googlesource.com/962939Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543145}

In most cases, linear layouts expand to contain all children. However,
in some cases, we want elements to fit into a specified space.  In this
case, one element can now be tagged as allowing sizing by its parent,
and LinearLayout can be configured to adjust that size according to the
other elements it needs to fit.

The first concrete example of this is a URL bar, where the text field
consumes all remaining space after any icons or indicators are added.

BUG=806886

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib9261c3b882f248aec2269a660cad9e9c6d8bbbf
Reviewed-on: https://chromium-review.googlesource.com/962712
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543144}

We don't need to use the stay_hidden animation to hide the preview
window on O+ because we use the vrmode configuration to disable the
preview window when launching the Activity in VR.

This also sped up VR entry significantly enough to expose a race
condition where if you hide the controls before the render has had time
to produce a frame, the java and native code disagree on the state of
the controls, but the native code defaults to thinking the previous
state is controls hidden, and so drops the message.

Bug: 817934, 806004
Change-Id: I6f4caaaf29c1fede7f21376d21d5ab86c5010523
Reviewed-on: https://chromium-review.googlesource.com/961265Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543143}

Blobs and filesystem URLs are considered "local" schemes by blink;
they can only be requested from processes with permission to
commit them.

Adding this means that we block extension filesystem: URLs via FilterURL
rather than ShouldAllowOpenURL, meaning that the WebAccessibleResource
UMAs don't trigger. Update test expectations to reflect this.

Add a test that exercises an interesting 'noopener' corner case.

Change-Id: Ie0473a4d4034ceb03e6098d524f16ef8d215398e
Bug: 821586, 821596
Reviewed-on: https://chromium-review.googlesource.com/961126Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543142}

Before this patch, missing HTTP Link header for payment method manifest
would result in the following error messages in console:

  Unable to make a HEAD request to https://foo for payment method manifest.
   is not a valid payment method manifest URL.

This patch hides the second error message when the payment method
manifest URL is empty.

After this patch, missing HTTP Link header for payment method manifest
results in the following error message in console:

  Unable to make a HEAD request to https://foo for payment method manifest.

Bug: NONE
Change-Id: I83adced7779b692e81395c660e706f18269c1357
Reviewed-on: https://chromium-review.googlesource.com/962879Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543141}

Using wpt-import in Chromium d0517519.
With Chromium commits locally applied on WPT:
35d044cf "[css-grid] Add support for calc() in gutter properties"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13842

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

TBR=leon.han@intel.com

No-Export: true
Change-Id: Ia8b798489def72227c20fb76045a34461a9938a2
Reviewed-on: https://chromium-review.googlesource.com/962641
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543140}

Convert to feature which is enabled by default.

Test: manual
Bug: 821608
Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
Reviewed-on: https://chromium-review.googlesource.com/961721Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543139}

https://chromium.googlesource.com/catapult.git/+log/f73167a6894a..b1242f4c6f85

$ git log f73167a68..b1242f4c6 --date=short --no-merges --format='%ad %ae %s'
2018-03-13 dtu [pinpoint] Show the user on the Job page.
2018-03-14 perezju Revert "[Telemetry] Use correct WebView apk for --browser android-webview"
2018-03-09 perezju [Telemetry] Use correct WebView apk for --browser android-webview

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8a9cbdd2a3ae2c618c4fd3725746add050fecebd
Reviewed-on: https://chromium-review.googlesource.com/962868Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543138}

Remove the Speech and BiDI logic in RenderWidgetHostViewMac and
use the logic TextServiceContextMenu instead.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/923548

This is a reland of https://codereview.chromium.org/2164483006

BUG: 617436
Change-Id: I56b7427342951fea5c7f9ef25cb3b6c98e8addd8
Reviewed-on: https://chromium-review.googlesource.com/957869
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543137}

Also addresses rsesek's comment on --use-gl=angle on Mac:
 - Put ANGLE libraries in Libraries/ instead of dumping them in
Contents.
 - Use a better name for the temporary copies of the libraries before
bundle_data.

Also fix a compile error for a newly introduced gfx::BufferFormat.

BUG=chromium:757974

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0f8ca4ed88ba45e97afce545982065699203a232
Reviewed-on: https://chromium-review.googlesource.com/959045
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543136}

It is possible to make chrome switch layouts mid-animation. This
patch kills running animations in LayoutManager#startShowing to avoid
starting new animations in a bad state.

BUG=818017,820899

Change-Id: Ie591beedbf855a2ffd31baf849a334dd5230742b
Reviewed-on: https://chromium-review.googlesource.com/958333Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543135}

As above. Removes all relevant code, and layout-tests for this feature.

See intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ

Bug: 818691
Change-Id: Idd0ca424071aadc7cb5ba9924888452ff1fab340
Reviewed-on: https://chromium-review.googlesource.com/956275
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543134}

Moves this service into the canonical location for services within
//components.

A followup CL will rename the service from "patch_service" to "patch".

TBR=dcheng@chromium.org
NOPRESUBMIT=true

Change-Id: I36207005323653f85d7be5841b0ecf60a29fdc85
Reviewed-on: https://chromium-review.googlesource.com/955648Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543133}

This reverts commit 59685821
to reland commit ebc4d82a.

The BUILD.gn file has been updated to use the correct output name
("chromium-app-shell-*" instead of "google-app-shell-*") to fix the
"confirm compile no-op" step on non-official builders.

Original change's description:
> Build non-official app_shell installer on Linux
>
> This causes the app_shell .deb installer to be built on non-ASAN/MSAN
> Linux CQ and waterfall bots, so regressions that break the installer
> build can be caught before hitting the official builders.
>
> The Chrome installer was enabled for non-official Linux builders in
> https://bugs.chromium.org/p/chromium/issues/detail?id=758654#c32.
>
> Bug: 714465
> Change-Id: Ifb6908b756d9ffc292fc131396c424d66f841a2a
> Reviewed-on: https://chromium-review.googlesource.com/956756
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542382}

Bug: 714465
Change-Id: I63b76c36cd8552b39bc7eb0c85808af31758115b
Reviewed-on: https://chromium-review.googlesource.com/961802Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543132}

ResourceDownloader uses BrowserThread::UI to post tasks to the delegate.
This introduces dependency on content/
Let delegate pass a TaskRunner to ResourceDownloader solves the issue.

BUG=803135

Change-Id: I44ebce8c72d65f99f90009ac9ca20709300cb2cd
Reviewed-on: https://chromium-review.googlesource.com/961528Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543131}

https://pdfium.googlesource.com/pdfium.git/+log/7a1aa5f65911..2c3cfa734d03

$ git log 7a1aa5f65..2c3cfa734 --date=short --no-merges --format='%ad %ae %s'
2018-03-14 ralf.sippl Fix blend mode in generated AP

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic7823b93fbfaadcb52e20bd10f04bf2ad4866a0a
Reviewed-on: https://chromium-review.googlesource.com/962708Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543130}

Bug: 819885
Change-Id: I6c93d4fb98a6804797f434e87f75c3a991d27607
Reviewed-on: https://chromium-review.googlesource.com/956690Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543129}

Bug: 820539
Change-Id: I0856f63795bc9428eb83ca36cf3d8ff91c6629e3
Reviewed-on: https://chromium-review.googlesource.com/957465
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543128}

Replaces LBCI with a slimmer class - WebOmniboxEditControllerImpl - to
interface with omnibox components API. Reimplements LBCI's logic in
WOECImpl, OmniboxCoordinator. Forks necessary classes to support this.

The classes replacing LBCI only implement logic that is necessary for
UI Refresh, dropping:
- Security icons (To be implemented in LocationBarMediator/VController)
- Showing page info popup (to be implemented elsewhere)
- Hint text (To be implemented in the LBViewController)

With this CL, the omnibox loses the location icon, but otherwise the
app is functional, with working omnibox and popup.

Bug: 821801, 821799
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3cdc064acc3bb642d2f60d4a47d61cf4ce60da8d
Reviewed-on: https://chromium-review.googlesource.com/941131
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543127}

Case:
1. Start any js browser_test
2. Open dev tools
3. All test js files will be listed all together without any host or
   folders

It's not very convenient behavior for debugging tests. For example it's
very difficult to map them to local files with vscode or webstorm.

Suggestion is to add absolute path to test files. This will group them
in dev tools in correct tree and automaticly map in external debugger.

Change-Id: If30c27e395c9cfc100469b740936c0f4e615b0ba
Reviewed-on: https://chromium-review.googlesource.com/947944Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543126}

Change-Id: I6c3920ca92cf05b41fe69c74936cc0578841847f

Bug: chromium:821851
Change-Id: I6c3920ca92cf05b41fe69c74936cc0578841847f
Reviewed-on: https://chromium-review.googlesource.com/952296
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543125}

https://webrtc.googlesource.com/src.git/+log/08c5cb075293..31791e7e2c2c

$ git log 08c5cb075..31791e7e2 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5c11b10a49a491c08c906118f16252e58f027bc0
Reviewed-on: https://chromium-review.googlesource.com/962864
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543124}

Certain platform implementation of HttpUrlConnection sometimes throw a
URISyntaxError, despite HttpUrlConnection not defining it as a throwable
exception, as part of its interface.

This CL fixes the issue.

Bug: 820130
Change-Id: I86602cf4a93fa8fccf19fbb4470e2cde48ba14b5
Reviewed-on: https://chromium-review.googlesource.com/957585Reviewed-by: Anthony Berent <aberent@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543123}

This CL adds the CustomTabs "client" APIs for parallel request:
- Enable and query parallel request state
- Get the URL and requested origin from the Intent

Bug: 816837
Change-Id: I6c5cc86453a941f08f118be6229bf3a2c497d344
Reviewed-on: https://chromium-review.googlesource.com/962761Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543122}

Since this feature is CrOS-only.

Bug: none
Test: none
Change-Id: I85efa428462e6073c7da284b5282e287158c29e5
Reviewed-on: https://chromium-review.googlesource.com/961664Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543121}

After trying multiple methods in which to select the download location
(including a full-fledged folder selector, surfacing only the
cannonical directories like Music or Pictures), we decided on giving the
user only the option to select between internal and external
directories (ie. Downloads from internal storage vs. SD card). This CL
implements the user interface for this.

Some of the structural changes include:
- Implementing Spinners for preferences and the dialog, using styles
that are generic but match with the different context.
- Consolidating DownloadDirectoryList functionality into
DownloadDirectoryAdapter.
- Modifying DownloadDirectoryAdapter to be an ArrayAdapter and using it
as the adapter for the Spinners, keeping things uniform.

Screenshots are as follows:

Downloads preferences:
https://drive.google.com/open?id=1CNJG8e4M9Q3Seps5QyA6Sx45bOUewO0y
https://drive.google.com/open?id=1UnCCIGwdYeh5iOV1Cb2S4X9hjS-YV5s8

Download location dialog:
https://drive.google.com/open?id=1szZlaMiqGyWD6RoVU1B8fSoDqOjLl-KH
https://drive.google.com/open?id=1pKAATJMwaWoetHxGoiW4CqdqLiXj3kPx

Bug: 792775
Change-Id: Ie4aabed98f900d260298d98fe9dc172438bbb719
Reviewed-on: https://chromium-review.googlesource.com/959384Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543120}

This function is shared with the upcoming RTCRtpSender.setParameters().

Bug: 803494
Change-Id: I4ec8412c63ee4abd98ffc458df73bc9b45e72e87
Reviewed-on: https://chromium-review.googlesource.com/962604
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543119}

This reverts commit 1f31a184.

Reason for revert: "WebMediaPlayerMSTest.StopsCreatingHardwareFramesWhenHiddenOrClosed" is flaky. https://bugs.chromium.org/p/chromium/issues/detail?id=821839

Original change's description:
> Stop using GpuMemoryBufferVideoFramePool when WebMediaPlayerMS is hidden
> 
> This CL adds calls to track when WebMediaPlayerMS is hidden or shown, so
> that in the time period we can skip creating GMB backed frames. For that
> time period, frames aren't going to be displayed, so copying them to GMBs
> is extra work which should be avoided.
> 
> Bug: 653200
> Change-Id: I67e55c7f1150b434d82321ac90a08c7c3e3e6336
> Reviewed-on: https://chromium-review.googlesource.com/954339
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542950}

TBR=sandersd@chromium.org,dcastagna@chromium.org,emircan@chromium.org

Change-Id: Ib88d6f0419271bf7d5e65b1b017eef1e12aeecbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 653200
Reviewed-on: https://chromium-review.googlesource.com/962824Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543118}

During exporting passwords, a progressbar is shown. The UI
requirements (go/lcfve) are: once shown, the progress bar needs to
stay up for at least one second to avoid flickering. This CL
implements the artificial delay.

Bug: 817370
Change-Id: I60729b86b1a684d6031dda2863842b0e056bce7a
Reviewed-on: https://chromium-review.googlesource.com/951586
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543117}

Change-Id: I2273d2a446545496c9edc624c172914b1bc5f901
Reviewed-on: https://chromium-review.googlesource.com/962359Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543116}