GitLab

Removes unused code in processing arguments of callback
functions and callback interfaces.

Change-Id: I5a98a011ef5c42c69b9f9016579a19942cbad01f
Reviewed-on: https://chromium-review.googlesource.com/1067569Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561437}

They are contained in net::HttpResponseHeaders which is also contained
in the struct.

Bug: 721400
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I11b438790fc351ba9097bb44415c5c5c4ca923c3
Reviewed-on: https://chromium-review.googlesource.com/1071327
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561436}

This adds an understanding of ::part to InvalidationSet.

Changes RuleFeatureSet to set invalidates_parts and
tree_boundary_crossing for ::part selectors.

Bug: 805271
Change-Id: I905b7f5a700acfc08bd9a01d4cda12a0de4eac18
Reviewed-on: https://chromium-review.googlesource.com/1068299
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561435}

When Chrome fails to load a signed exchange, the error page shows ERR_FAILED.
It is difficult to know the failed reason.
After this CL, the error page shows ERR_INVALID_SIGNED_EXCHANGE.

> This site can’t be reached
> The webpage at https://example.com/example.sxg might be temporarily down or it may
> have moved permanently to a new web address.
> ERR_INVALID_SIGNED_EXCHANGE

Bug: 830505
Change-Id: Ifcc60a9a353b4f3c29711bc27fb94322761dbdfb
Reviewed-on: https://chromium-review.googlesource.com/1065396
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561434}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cfd1ec50..0503463a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I5b6d371881e6392b3a6441217a4aacb9990a5d76
Reviewed-on: https://chromium-review.googlesource.com/1070796Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561433}

This patch changes "merge-start-list.html" to utilize |selection_test()|
for ease of maintenance.

Bug: 679977, 707656
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4cb1f79ae6df06a47114550e7af32439d994a186
Reviewed-on: https://chromium-review.googlesource.com/1071155Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561432}

Although not all fields are currently implemented, this should be
stable and give users enough to experiment with.

Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/VvBUUo7h0L4/gCBrvQMLCAAJ

Bug: 803494
Change-Id: I7b3c61a84c1706991603ea539eeaf5f22fb4e918
Reviewed-on: https://chromium-review.googlesource.com/1070277Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561431}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ibb6a087acc07871e2f92fb16823fb9315bdd0098
Reviewed-on: https://chromium-review.googlesource.com/1071241Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561430}

This patch adds assert_selection tests converted from
editing/selection/move-left-right.html.
Here is generator: crrev.com/c/1032319

This patch includes #31-#43 tests in original 43 tests.

Bug: 679977
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic4a9f93f275d8d6466984440564230f9636d729b
Reviewed-on: https://chromium-review.googlesource.com/1063511Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561429}

Legacy layout is buggy here, so the expected rendering was wrong. Also
wrote a new wpt test for this. When calculating intrinsic size, the
legacy engine makes room for whitespace that is to be collapsed.

Bug: 845902
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I77087577aad68dc249ca33a8ac8a79ef4f35469e
Reviewed-on: https://chromium-review.googlesource.com/1070270Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561428}

Pass the current tab as the opener when opening a new tab.
This allow selection the previous current tab when the
tab is closed via "pull-to-close" action or via the new
"close" action in the UI refresh.

The current tab is passed when tab is opened via ([*]
denotes that this behaviour is added by this CL):
- open tab in background
- "New Tab" menu action [*]
- captive portal detection [*]
- search by image [*]

Bug: 661988
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79
Reviewed-on: https://chromium-review.googlesource.com/1068680Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561427}

https://skia.googlesource.com/skia.git/+log/27f5a0df4a28..8517631bf410

$ git log 27f5a0df4..8517631bf --date=short --no-merges --format='%ad %ae %s'
2018-05-24 angle-skia-autoroll Roll third_party/externals/angle2/ 586750168..b001528ff (4 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: Ic59d9bc073c68ce102eeb6f51d74731be60cadc4
Reviewed-on: https://chromium-review.googlesource.com/1071235
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561426}

The layout and the strings of the sync confirmation
dialog and the consent bump are updated to match the
mocks under:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr6xZArjQ0C0km5svyrm3ZWaI

Main changes:
 - Add new illustration on top of the dialog.
 - Add account picture.
 - Add settings button.
 - Update/add strings.

Screenshot of sync confirmation dialog:
https://drive.google.com/file/d/1hLL7JijPMqId63Emst_-Neap5YzksjDU/view?usp=sharing
Screenshots of consent bump:
https://drive.google.com/file/d/1YIUwtY421r5kCeowUIWXmurHKoO4-J0r/view?usp=sharing
https://drive.google.com/file/d/1DbNOb9TJsrnkvZLsRHNiP2xZH-BCGYwi/view?usp=sharing

Bug: 823967, 819909, 801342
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic3da556e78b9d22ac1eececed599da8743fd2f17
Reviewed-on: https://chromium-review.googlesource.com/1021812Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561425}

Split write barrier into fast and slow parts:
- The fast part only checks whether any Oilpan heap is currently marking. This
  check is only approximate as it does not consider the current ThreadState. In
  general, we expect this check to be enough to allow bailing out of the barrier.
- The slow version checks whether the current ThreadState is marking and whether
  the values actually require a write barrier.

This way we emit only a short instruction sequence for the fast cases and avoid
poluting the regular instruction sequences.

Verified locally on the microbenchmark blink_perf.parser query-selector-deep
which showed a 42% regression. Scores (higher is better):
- ToT: 8932
- Without barrier: 15188
- With this CL: 13352

Bug: chromium:844576, chromium:757440
Change-Id: Ie8ebbf95fef0ff59ad8f1a111dd5daecfabc4109
Reviewed-on: https://chromium-review.googlesource.com/1071272
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561424}

Similar to frames, the shared worker needs a factory bundle in order to
load non-NetworkService URLs like chrome-extension://.

This fixes the remaining test failure but we're still missing test
coverage. I think the factory bundle needs to be propagated to
ServiceWorkerSubresourceLoaderFactory for use with network fallback.

Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d
Reviewed-on: https://chromium-review.googlesource.com/1069956
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561423}

|ChromeOSOAuth2TokenServiceDelegate| loads tokens at startup and calls
|FireRefreshTokensLoaded| before some token service observers may have
had a chance to register themselves. This causes them to miss the
|OnRefreshTokensLoaded| callback.

For now, the solution is to respect the temporal coupling between
|OAuth2TokenServiceDelegate::LoadCredentials| and
|OAuth2TokenService::AddObserver|, i.e. |LoadCredentials| is called
only when all observers have been added. Ideally, it should be an
observer's responsibility to check whether it has been initialized 'too
late' and may have missed the |OnRefreshTokensLoaded| notification.

Bug: 820046
Change-Id: I3ac67798d165afe230fa29e03ec7af75a9a093a9
Reviewed-on: https://chromium-review.googlesource.com/1069353
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561422}

r560826 added chrome/apps/printing_strings.grdp, and the duplicate file
name made part of the translation pipeline unhappy. Rename the file in
components/, to be consistent with the solution for
bookmark_strings.grdp.

BUG=846106

Change-Id: Iacfb38c3ea4f9e234e25ddb2163081539af9c1d2
Reviewed-on: https://chromium-review.googlesource.com/1070872Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561421}

https://chromium.googlesource.com/angle/angle.git/+log/b001528ffa00..2a12b3d585a8

$ git log b001528ff..2a12b3d58 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 jiajia.qin ES31: Add struct uniform block support in compute shader for D3D

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I96c49978656f736a511efc4ccb0057cc0fd7196c
Reviewed-on: https://chromium-review.googlesource.com/1071236Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561420}

Before, OnRefreshTokenRevoked triggered a notification to observers, and
OnCredentialsRejectedByClient caused us to invalidate the credentials in the
SyncEngine.
In both cases, it actually seems better to do both of these things, so this CL
merges the two.

Bug: 842697
Change-Id: I81fd4578731c282284fa40cbbb0be0e1cd102656
Reviewed-on: https://chromium-review.googlesource.com/1068880
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561419}

Clear all persistents on thread termination, because when we have a bug and it leaves a Persistent behind, it will not be a stale pointer and just causes null dereference.

Since we disabled PersistentHeapCollections on non-main threads we can assume all PersistentNode::Self() can be cast to Persistent<DummyGCBase>

Bug: 831117
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib55b280f8e7c5d966ce43d3f60f2af873cd50739
Reviewed-on: https://chromium-review.googlesource.com/1025547
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561418}

I can't repro the failures anywhere outside of the real environment.

BUG=818832
R=martiniss@chromium.org

Change-Id: I9ccaa3bf5f7e357f879c4d804310d34b0e1abaaa
Reviewed-on: https://chromium-review.googlesource.com/1070192Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561417}

Bug: 842613
Change-Id: I71bc2e6b2188e454d45f23c91ab27aa546cb8068
Reviewed-on: https://chromium-review.googlesource.com/1056992Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561416}

TBR=fhorschig@chromium.org,rdevlin.cronin@chromium.org

Bug: 846172
Change-Id: Ie06f83131d4f60b9c3465a8d1b77bcfce45ff19f
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1070955Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561415}

Fixes vertical offset when the pop over is shown below

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd98e7ca6b3a4e117e1b3315893c178e0ded543f
Reviewed-on: https://chromium-review.googlesource.com/1068733
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561414}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71e81d76d2fc..74cfbb05fcd9

$ git log 71e81d76d..74cfbb05f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:none


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5631b600211b84a85a7d7bbcd709be916d543089
Reviewed-on: https://chromium-review.googlesource.com/1071234
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561413}

Bug: 772558, 846211
Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
Reviewed-on: https://chromium-review.googlesource.com/1070532
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561412}

AudioSyncReader::shared_memory_region() is never called more than once. If we
return a region from this function by value, we don't have to duplicate the
region.

This is a follow-up to https://crrev.com/c/1068928

Bug: 844508
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I22ac7f9bae926ed418c025ac0a8487b98659817a
Reviewed-on: https://chromium-review.googlesource.com/1069352Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561411}

https://pdfium.googlesource.com/pdfium.git/+log/602f06cfb107..18f7fbca4612

$ git log 602f06cfb..18f7fbca4 --date=short --no-merges --format='%ad %ae %s'
2018-05-24 thestig Mark some pointers as non-const in CPDF_NameTree.
2018-05-24 thestig Improve constness for more CPDF_Objects pointers.
2018-05-23 thestig Remove GetBits32().
2018-05-23 thestig Avoid repeated calculations in CFX_BitStream::GetBits().
2018-05-23 thestig Add unit test for CFX_BitStream.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia95af36aa7ddcdf1ae8e677e1cdc454719f0a97b
Reviewed-on: https://chromium-review.googlesource.com/1071167Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561410}

This is an early prototype to show a manual fill option to the user.
- Using showcase so designers and PMs can play with it.
- Currently the iPad and iPhone specific code is separated in two demos
  to allow quick experimentation.
- iPhone Screenshots
  - https://drive.google.com/file/d/1PbwOiCadB0xRdT9-no-wy8mhfwBv9NCL
  - https://drive.google.com/file/d/1uTqpQVmpHFIZC7mr3LM7RF24xAdxYbjh
- iPad Screenshoots
  - https://drive.google.com/file/d/1Y5yUSO-0Dv6bsx3_F6LV41Us95TKKIlL
  - https://drive.google.com/file/d/19Va4ku9-vvE9doZ6naSUr4iicovfmcOg

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0475b630641152fe57d4c246608f75e94d2619fd
Reviewed-on: https://chromium-review.googlesource.com/956486
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561409}

The feature is behind a flag and I'm fairly sure this is an issue with the test itself,
so I'm disabling it for TSan while investigating.

Tbr: primiano@chromium.org
Bug: 846204
Change-Id: Ie0e05a35ceef124722e3cef545a2bc945a5b7849
Reviewed-on: https://chromium-review.googlesource.com/1071075Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561408}

Implementations of WebMIDIAccessor in //content holds an raw pointer to
MIDIAccessorClient, however, the pointer may be invalid between GC marking
and its sweeping.

This CL removes the pointer by clearing WebMIDIAccessor itself on the
context destruction.

Bug: 846182
Change-Id: I857769a34b6c64e48b0540a117b29c94194ed611
Reviewed-on: https://chromium-review.googlesource.com/1071157Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561407}

Move anonymous namespace union ThreadRef to non anonymous namespace
to avoid this warning in GCC:
/../../../chromium-68.0.3432.3/base/debug/activity_tracker.cc:605:31:
warning: 'base::debug::ThreadActivityTracker::Header' has a field
'base::debug::ThreadActivityTracker::Header::thread_ref' whose type
uses the anonymous namespace [-Wsubobject-linkage]
 struct ThreadActivityTracker::Header {

It is discouraged to use in a public type a type declared in an
anonymous namespace. It should not be a problem in our case as it
is only used internally in activity_tracker.cc, but GCC will still
complain in jumbo build as the .cc is used as an include.

Change-Id: I121af0053b5ee51661be99ae4470512909416859
Reviewed-on: https://chromium-review.googlesource.com/1066001
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561406}

BUG=None
TEST=None

Change-Id: Idb4c7792493141c7b95ea8f240b197991c67b3e9
Reviewed-on: https://chromium-review.googlesource.com/1070954Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561405}

https://skia.googlesource.com/skia.git/+log/13235d8966e4..27f5a0df4a28

$ git log 13235d896..27f5a0df4 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 khushalsagar Reland fonts: Cleanup cache miss logging for font remoting.
2018-05-23 khushalsagar Reland fonts: Add support for distance field text to font remoting.
2018-05-23 csmartdalton ccpr: Handle winding and even-odd in the same shader

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I84f83ee900d04da9d48d1423f56d6f4ed1f90992
Reviewed-on: https://chromium-review.googlesource.com/1071121Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561404}

Change-Id: I881f3cd54a59b5aedfb3cfb9e2e49925768509bd
Reviewed-on: https://chromium-review.googlesource.com/1071152Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561403}

TBR=fhorschig@chromium.org,fdoray@chromium.org

Bug: 846121
Change-Id: I8056ceedd453daf33f210cae953deb10a148cc26
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1071329Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561402}

This CL lets ServiceWorkerProviderHost get the resource context from
ServiceWorkerContextWrapper directly, rather than getting from
ServiceWorkerDispatcherHost, then we no longer need to keep a resource
context in each ServiceWorkerDispatcherHost.

BUG=845341

Change-Id: Ia6dd603055607b3e2d53f5bbc7d5095c9514f954
Reviewed-on: https://chromium-review.googlesource.com/1068268Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#561401}

Blink had a bug that sync XHR would timeout after 10 seconds. Add a
regression test to make sure the issue does not reoccur.

BUG=844268

Change-Id: I161e133582b719102a02349828cd4d9a08773785
Reviewed-on: https://chromium-review.googlesource.com/1070089
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561400}

This CL makes the following modifications to the download notification
text:
- Moves time remaining (if known) to the subText/contentInfo.
- Changes the contentText to display percent downloaded, bytes
downloaded, or files downloaded.  The current primary usage will be of
bytes downloaded, which will have the format "XX KB / YY MB" or "XX KB /
?" if the total is unknown.

BUG=845324

Change-Id: Iaf331b6d31c21863ee0a653399d3226e1816dbbd
Reviewed-on: https://chromium-review.googlesource.com/1068127
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561399}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ib56847fac69d87b3a296023749357470af80566e
Reviewed-on: https://chromium-review.googlesource.com/1071348Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561398}