GitLab

If an extension is disabled after it is uninstalled, the extension is not enabled
when it is reinstalled. ThemeService was disabling theme extensions after they
were uninstalled if the extension was uninstalled as a result of the
NOTIFICATION_BROWSER_THEME_CHANGED notification. This bug was causing installing
a theme via the Chrome Web Store to sometimes not work.

BUG=468280
TEST=ThemeServiceTest.UninstallThemeOnThemeChangeNotification

Review URL: https://codereview.chromium.org/1319073005

Cr-Commit-Position: refs/heads/master@{#348780}

This patch moves the render_font_warmup_win files into a common
location so that other content processes, especially PPAPI can
share the code. This is needed as a warmup to pushing win32k lockdown
to other content processes.

BUG=523278

Review URL: https://codereview.chromium.org/1326623002

Cr-Commit-Position: refs/heads/master@{#348779}

This CL puts a little extra space between the list and the buttons.
It also makes the items paper-icon-items so they line up better.

BUG=531750

Review URL: https://codereview.chromium.org/1338363003

Cr-Commit-Position: refs/heads/master@{#348778}

Cr-Commit-Position: refs/heads/master@{#348777}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f26e8c0..dfec292

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1332213004

Cr-Commit-Position: refs/heads/master@{#348776}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0faed58..5dd918b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Commits in this roll:
5dd918b fmalita@chromium.org Suppress test_imagegenerator_factory
2bcab82 reed@google.com remove code from SK_SUPPORT_LEGACY_NEWFROMGENERATOR, eliminates caller of deprecated SkInstallDiscardablePixelRef
48392b7 reed@google.com fix leaked generator
cd56f81 fmalita@chromium.org SkImageSource
506c802 bsalomon@google.com Add helper for creating leaf FPs inside GrFP::TestCreate functions
07344a5 mtklein@chromium.org Revert of SkPx: new approach to fixed-point SIMD (patchset #9 id:160001 of https://codereview.chromium.org/1317233005/ )
ec00d94 egdaniel@google.com Move some of the adding stencil attachment logic of Gpu and into Render Target.
37497dc rmistry@google.com Update SkWhitelistChecksums.cpp with the checksums of the fonts on the CT slave machines.
82c93b4 mtklein@chromium.org SkPx: new approach to fixed-point SIMD
b5b6032 bsalomon@google.com Test that GrFragmentProcessors work without input colors.
0faed58 mtklein@chromium.org cmake_build: support SKIA_OUT and BUILDTYPE
59ce45f bsalomon@google.com Revert of Test that GrFragmentProcessors work without input colors. (patchset #2 id:20001 of https://codereview.chromium.org/1341853002/ )
72c58e7 bsalomon@google.com Test that GrFragmentProcessors work without input colors.
3833daa robertphillips@google.com Fix GPU-only snapping bug in mask blur rendering
efd50da reed@google.com impl preroll for all image backends
5a744b7 mtklein@chromium.org Have SkVarAlloc::alloc() use sk_malloc_throw.
a46ada5 mtklein@chromium.org SkValidatingReadBuffer: make sure we don't call readTypeface().
8725e53 reed@google.com fix leak in test

Review URL: https://codereview.chromium.org/1346453006

Cr-Commit-Position: refs/heads/master@{#348775}

Refactor AndroidVideoDecodeAccelerator into a class that manages the MediaCodec buffers, but delegates handling the SurfaceTexture to BackingStrategy implementations.  The AndroidCopyingBackingStrategy class implements the texture copy into the picture buffer, as it did in previous versions.

BUG=507834

Review URL: https://codereview.chromium.org/1313913003

Cr-Commit-Position: refs/heads/master@{#348774}

Instead of listening to unreliable WebContentsObserver events, we now
make use of the FaviconDriverObserver.

R=nick@chromium.org
BUG=530486,528924

Review URL: https://codereview.chromium.org/1338023002

Cr-Commit-Position: refs/heads/master@{#348773}

This is a spin-off of https://codereview.chromium.org/1294243004/
This exposes the helper functions converting enum types from a blink type to its
corresponding content type.

BUG=440463

Review URL: https://codereview.chromium.org/1317833005

Cr-Commit-Position: refs/heads/master@{#348772}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4edabd3..f26e8c0

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1339133003

Cr-Commit-Position: refs/heads/master@{#348771}

BUG=354284

Review URL: https://codereview.chromium.org/1338063002

Cr-Commit-Position: refs/heads/master@{#348770}

Without this the background thread created by the FontLoader outlives
the HTMLViewer, which leads to random shutdown crashes.

BUG=531120
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1341073004

Cr-Commit-Position: refs/heads/master@{#348769}

TBR=scottmg@chromium.org
BUG=529769, 472900, crashpad:51

Review URL: https://codereview.chromium.org/1345613002

Cr-Commit-Position: refs/heads/master@{#348768}

This removes the Rect::operator RectF(), and adds an explicit conversion
constructor on RectF instead.

R=sky@chromium.org
BUG=342848

Review URL: https://codereview.chromium.org/1315053003

Cr-Commit-Position: refs/heads/master@{#348767}

This is achieved by setting the correct FBO before each kModeDraw and
hardware renderer won't reset it at the end of the draw so that
kModeProcess between kModeDraws also has the correct FBO.

This CL is to solve a bug where kModeProcess could run some GL commands
that binds the wrong FBO, and the following kModeDraw is messed up.

BUG=527113

Review URL: https://codereview.chromium.org/1335033004

Cr-Commit-Position: refs/heads/master@{#348766}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0657feb..4edabd3

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1340983004

Cr-Commit-Position: refs/heads/master@{#348765}

grd files that are sent off for translation cannot contain the
use_name_for_id attribute as described in the bug. This removes
use_name_for_id from ios_strings.grd to fix the extract strings step.

This will need to be fixed for real as a follow-up, either by making
IDS_IOS_ACCEPT_LANGUAGES and IDS_IOS_DEFAULT_ENCODING regular
translatable strings, or by moving them into a separate file as is done
with all the locale_settings_<platform>.grd files.

BUG=531718
TBR=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/1341533006

Cr-Commit-Position: refs/heads/master@{#348764}

BUG=523040
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1296673004

Cr-Commit-Position: refs/heads/master@{#348763}

This CL uses the finch trial group name to set WebKit settings for the android autoplay gesture override experiment.  Most of the code for the experiment itself is in https://codereview.chromium.org/1179223002/ .  The present CL will not build without it.

Summary of the experiment: Our goal is to decide if the requirement for a user gesture can be relaxed on android, to allow some media to autoplay without always requiring the user to interact with it manuall.  The finch experiment will let us try various combinations of heuristics for when to autoplay without a user gesture.  We record metrics based on user behavior, such as "manually started playback", "manually stopped playback", etc.

These options are composible, so we just use the trial group name to specify the options directly.  This lets us try different combinations after we get some initial data from the experiment.

BUG=487345, 402044

Review URL: https://codereview.chromium.org/1331203003

Cr-Commit-Position: refs/heads/master@{#348762}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f8eb3135..d2261936

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1338993007

Cr-Commit-Position: refs/heads/master@{#348761}

This CL:
- removes the scripts for syncing and relevant comments.
- adds a note in README.chromium that it has been forked from the Mojo repo.

BUG=None

Review URL: https://codereview.chromium.org/1338793003

Cr-Commit-Position: refs/heads/master@{#348760}

It's simply an overlook in previous CLs.

BUG=429053
TEST=gpu_unittests, webgl2_conformance
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1341133002

Cr-Commit-Position: refs/heads/master@{#348759}

This library is used by Chrome on Chrome OS to allocate accelerated
graphics buffers. The version avaiable on Ubuntu is too old, and as a
result we can't run unit tests for the gbm platform code on developer
workstations or on the waterfall.

This adds the library to third_party and fixes up the build files to use
either the OS copy (for Chrome OS release builds) or gardened copy (for
testing on the waterfall) depending on the value of "use_system_minigbm".

BUG=530712
TEST=
  GYP_DEFINES="use_ozone=1 chromeos=1 ozone_platform_gbm=1 use_system_minigbm=0" gclient runhooks
  ninja -C out/Release ozone_unittests
  ./out/Release/ozone_unittests

  gn gen out_gn_ozone --args='target_os="chromeos" use_ozone=true ozone_platform_gbm=true use_system_minigbm=false'
  ninja -C out_gn_ozone ozone_unittests
  ./out_gn_ozone/Release/ozone_unittests

Review URL: https://codereview.chromium.org/1341473003

Cr-Commit-Position: refs/heads/master@{#348758}

Match the native Android TextView handles by using the same PopupWindow
visibility type, namely, TYPE_APPLICATION_SUB_PANEL.

BUG=528365

Review URL: https://codereview.chromium.org/1339433003

Cr-Commit-Position: refs/heads/master@{#348757}

If user edited title and url at the same time, url didn't get saved.
The reason is that we save title first, then UI is refreshed by
bookmark observer, which resets the url edit text to the original url.

BUG=530794

Review URL: https://codereview.chromium.org/1341793004

Cr-Commit-Position: refs/heads/master@{#348756}

When opening a tab in the background on Svelte devices, tabs are
marked as "frozen" without actually being frozen (no saved state).

* Make CompositorViewHolder load these tabs properly instead of
  trying to unfreeze them.

* Make Tab#unfreezeContents() protected so that nothing can handle
  this.

* Clear out pointers when destroying the objects and clean up
  destruction, in general.

* Stop destroying some TabObservers twice.

* Add a test to catch this.

* Moves process killing to the end of destroy() instead of the middle.

BUG=495877

Review URL: https://codereview.chromium.org/1337113007

Cr-Commit-Position: refs/heads/master@{#348755}

0 configs already ran on Swarming
43 used to run locally and were converted:
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: ClangToTLinuxASan tester
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester
- chromium.webkit.json: WebKit Linux
- chromium.webkit.json: WebKit Linux (dbg)
- chromium.webkit.json: WebKit Linux 32
- chromium.webkit.json: WebKit Linux Leak
- chromium.webkit.json: WebKit Linux Oilpan
- chromium.webkit.json: WebKit Linux Oilpan (dbg)
- chromium.webkit.json: WebKit Linux Oilpan Leak
- chromium.webkit.json: WebKit Linux Trusty
- chromium.webkit.json: WebKit Mac Oilpan
- chromium.webkit.json: WebKit Mac Oilpan (dbg)
- chromium.webkit.json: WebKit Mac10.10
- chromium.webkit.json: WebKit Mac10.6
- chromium.webkit.json: WebKit Mac10.6 (dbg)
- chromium.webkit.json: WebKit Mac10.7
- chromium.webkit.json: WebKit Mac10.7 (dbg)
- chromium.webkit.json: WebKit Mac10.8
- chromium.webkit.json: WebKit Mac10.9
- chromium.webkit.json: WebKit Mac10.9 (retina)
- chromium.webkit.json: WebKit Win Oilpan
- chromium.webkit.json: WebKit Win Oilpan (dbg)
- chromium.webkit.json: WebKit Win x64 Builder
- chromium.webkit.json: WebKit Win x64 Builder (dbg)
- chromium.webkit.json: WebKit Win10
- chromium.webkit.json: WebKit Win7
- chromium.webkit.json: WebKit Win7 (dbg)
- chromium.webkit.json: WebKit XP

Ran:
  ./manage.py --convert blink_platform_unittests

R=maruel@chromium.org,dpranke@chromium.org
BUG=98637, 524758

Review URL: https://codereview.chromium.org/1311253006

Cr-Commit-Position: refs/heads/master@{#348754}

GN does not allow tabs, so the mode should always set
indent-tabs-mode to nil (off), regardless of the user's
global setting.

R=erg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1341943002

Cr-Commit-Position: refs/heads/master@{#348753}

BUG=512899

Review URL: https://codereview.chromium.org/1312463005

Cr-Commit-Position: refs/heads/master@{#348752}

devToolsConnection.onDisconnect should be
devToolsConnection.onDisconnect.addListener.

BUG=526882
R=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1339173002

Cr-Commit-Position: refs/heads/master@{#348751}

BUG=491352

Review URL: https://codereview.chromium.org/1336883004

Cr-Commit-Position: refs/heads/master@{#348750}

BUG=530687

Review URL: https://codereview.chromium.org/1343843002

Cr-Commit-Position: refs/heads/master@{#348749}

BUG=internal b/19210655

Review URL: https://codereview.chromium.org/1336763008

Cr-Commit-Position: refs/heads/master@{#348748}

BUG=504872

Review URL: https://codereview.chromium.org/1345573002

Cr-Commit-Position: refs/heads/master@{#348747}

This patch changes a DCHECK used to validate
WKBackForwardListItems before using them to an if check.
This fixes a crash caused by QuickBack.

BUG=529890

Review URL: https://codereview.chromium.org/1307103004

Cr-Commit-Position: refs/heads/master@{#348746}

This is to help debug https://crbug.com/289715 and try to get a stack trace
earlier.

BUG=289715

Review URL: https://codereview.chromium.org/1337113004

Cr-Commit-Position: refs/heads/master@{#348745}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/995b4bd..0faed58

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Commits in this roll:
0faed58 mtklein@chromium.org cmake_build: support SKIA_OUT and BUILDTYPE
59ce45f bsalomon@google.com Revert of Test that GrFragmentProcessors work without input colors. (patchset #2 id:20001 of https://codereview.chromium.org/1341853002/ )
72c58e7 bsalomon@google.com Test that GrFragmentProcessors work without input colors.
3833daa robertphillips@google.com Fix GPU-only snapping bug in mask blur rendering
efd50da reed@google.com impl preroll for all image backends
5a744b7 mtklein@chromium.org Have SkVarAlloc::alloc() use sk_malloc_throw.
a46ada5 mtklein@chromium.org SkValidatingReadBuffer: make sure we don't call readTypeface().
8725e53 reed@google.com fix leak in test

Review URL: https://codereview.chromium.org/1336143004

Cr-Commit-Position: refs/heads/master@{#348744}

Unfortunately the flaky suppression isn't working in this situation.
Filed Issue 530373 about that.

BUG=524717
TBR=bajones@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/1336793002

Cr-Commit-Position: refs/heads/master@{#348743}

removing jeremyim from OWNERS and histogram owners.

BUG=

Review URL: https://codereview.chromium.org/1326683005

Cr-Commit-Position: refs/heads/master@{#348742}

In document mode, multiple activities could be used concurrently.
So registering and unregistering a receiver could happen on different ones,
which causes Chrome crash.

BUG=530097

Review URL: https://codereview.chromium.org/1338813004

Cr-Commit-Position: refs/heads/master@{#348741}