- 10 Sep, 2020 12 commits
-
-
Richard Li authored
When playing a SDR video after playing a HDR video, GPU process will crash on Intel platform. The root cause is Chrome sets different color space in VP without reset VP, which will cause something wrong happens in VP. This CL provides a fix that VP will reset when input/output color space changes. What's more, color space will be set to VP only when it changes, which reduces frequency of calling VideoProcessorSetStream/*Output*/ColorSpace1() Bug: 1121061 Change-Id: I096e5fb47593e0df034452719029a3750850bc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371478 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805571}
-
Richard Li authored
media::HDRMetadata is going to be moved to ui/gl/, so its corresponding mojom bind should be move to that path. This is a preparation for passing HDRMetadata to SwapChainPresenter. Bug: 1122910 Change-Id: Id62709d95acc7517578cc37e940f0dca9a3f6d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389103Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#805570}
-
Melissa Zhang authored
This CL fixes a bug where sometimes target text height obscures a section of the text. Bug: 1097623 Change-Id: I70c4841de68a831f13bd074c1a9bff569a779500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399164Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805569}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 3 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: Id33a88a789bb1322519f11b3e861c3cbe93280db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401703Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805568}
-
John Abd-El-Malek authored
Only disable auto reloads for SSL or safe browsing interstitials instead of all errors with custom error pages. r773251 disabled auto reload for any interstitial that has custom HTML, since it wanted to disable them for SSL and SB. The code was componentized in r791935 and shared later with WebLayer. However not every embedder wants to disable auto retries just because they provide a custom error page. Instead make the disabling explicit to check for SSL errors or when the client code blocks a request (SB). Bug: 1126205 Change-Id: I949c94ae2d47c1fe7d30c9b2e58133b615a74fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401944Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#805567}
-
Daniel Classon authored
Adds browser proxies for the A11y Page, Manage A11y Subpage, and Text to Speech subpage. Allows the future creation of test browser proxies to create tests for deep linking in the A11y pages. Bug: 1084154 Change-Id: I83e4b69fac1b07b8e2a2c9813ac57be1642a0e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399570 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805566}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cee574832664..9a7b0a2dc5a3 2020-09-09 jonahr@google.com Workaround bogus MscRate reported by some XWayland drivers. 2020-09-09 shrekshao@google.com Suppress AtomicCounterBufferRangeRead failure on Nexus6P If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1042393 Tbr: ianelliott@google.com Change-Id: If7c2e4bf057e63316de695b51e946050533f023c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805565}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows DataTransferManagerInterop APIs within tests, as well as basic unit tests to validate the test class behaviors. Bug: 1035527 Change-Id: I926078f3b54b350c622adb40fc84fe3614fa89d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397315 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805564}
-
Chris Lu authored
Each OverlayInteractionHandler needs its own distinct RequestConfig, because the handler's callback installer tie its callbacks to the RequestConfig. Thus, if two InteractionHandlers have the same config, then the banner action response will trigger both handler's callback methods. This creates a behavior where presenting the modal from a banner adds two modal requests into the queue. Bug: 1124587 Change-Id: I83b807017e754ea3935090cdf6e7c3a46b8ef2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397977 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805563}
-
Patrick To authored
WebGL2 already supports makeXRCompatible() from the implementation in WebGLRenderingContextBase, but has a separate factory create method to handle the context attributes. This change handles the xrCompatible flag in a similar way to WebGL1. Web tests for WebGL2 will be added before enabling xr compatibility by default. Bug: 1087356 Change-Id: Ie80755663485aa2cf98129d4e4f264154ae1ad2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402129Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805562}
-
John Rummell authored
Don't allow calls to proceed once the associated content has been destroyed. Bug: 1121414 Test: example in the bug no longer crashes Change-Id: I3bdeb86f2020f684958b624fcc30438babfb5004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378889Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805561}
-
Samuel Huang authored
Building Trichrome results in multiple .mapping files. This CL changes generate_commit_size_analysis.py to take multiple .mapping file inputs using repeated --mapping-name arguments. Bug: 1040645 Change-Id: If40081b50ac630504a85d3593de9631cb0977b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401949Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805560}
-
- 09 Sep, 2020 28 commits
-
-
Gang Wu authored
We should use app:chromeDrawableTint to tint TextViewWithCompoundDrawables instead of android:drawableTint. android:drawableTint works on API level 23 and above. But somehow not work for PNG drawables in API 23, and TextViewWithCompoundDrawables provide app:chromeDrawableTint to tint, so we can use it to handle the issue. Bug: 1126035 Change-Id: Iebc9b0d0ccf9ca8510bd03d8285d19b2ba705cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402102Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805559}
-
Kent Tamura authored
webcodecs:unit_tests had a circular dependency with controller:blink_unittests_sources. This CL moves out controller:blink_bindings_test_sources from controller:blink_unittests_sources and adds controller:blink_bindings_test_sources dependency to webcodecs:unit_tests to remove the circular dependency. This CL has no behavior changes. Bug: 800764 Change-Id: Ie578dfe442f2ee111f19abb7496e41a27ff66b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400644 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#805558}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the JPEG decode accelerator, used e.g. for MJPEG camera stream decoding. This was verified via chrome:tracing while capturing HD on kohaku and reks (Braswell) in the link [1]. Similarly to what is seen in the previous CL, the combination of SubmitBuffer() calls on ToT is ~10% slower than the batched SubmitBuffers(). A key difference is that since JPEG is way simpler than e.g. VP9, the submitting time is comparable to the ExecuteBuffers_Locked(), so this CL has some minor overall decode-time savings. But still the target here is to reduce contention on the lock and libva for video conferencing cases with multiple remote participants a la Meet. [1] webrtc.github.io/samples/src/content/getusermedia/resolution/ Cq-Depend: chromium:2393629 Bug: b/166646505 Change-Id: I183cc151de24d8fdbdc62e0172be296dacbf26f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393525 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805557}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the VP8 decode accelerator. This is verified via chrome:tracing and codepen.io/full/qzYXba that plays 4 1280x572 VP8 videos at the same time. Tracing is captured for a few seconds, basically the SubmitBuffers() call takes ~0.312ms/call versus the individual SubmitBuffer() calls ~0.072ms -- which gives an aggregate of 0.360ms, or savings of about ~20%. Since decoding itself takes about the same as SubmitBuffers on my BSW device (reks), batching gives ~10% reduction in decode time. Bug: b/166646505 Change-Id: I11c5570bea1c049fe0e9af75239bd60ac906a843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401512 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805556}
-
David Tseng authored
See go/chromevox-touch_gestures Some gestures, e.g. swipe two fingers left, do not have an explicit command. Others, like three finger swipe up/down, have commands which are not also keyboard commands. In Learn Mode, these gestures are not fullyd escribed beyond just the physical gesture description. Add these descriptions now in this change. R=akihiroota@chromium.org Bug: 1124454 Test: browser_tests --gtest_filter=ChromeVoxLearnMode*.Gesture* AX-Relnotes: ChromeVox Learn Mode now describes all new gestures and what they do. Change-Id: I19fd3b39aa15f9df0daa864c4f99f69173d4baa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386377 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805555}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/2382064. Bug: 1108793 Change-Id: Iba5aaedcf026907760bc9300846a5d45c0dfe6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398998Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805554}
-
Rakib M. Hasan authored
Follow up to crrev.com/c/2369641. This builder will be in the chromium.android console. It will run WPT on Weblayer for now. More browsers will be tested in this builder. Bug: 1050760 Change-Id: Ia1166f707e4b49dfa654ff199bb9539bb0a8d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386600Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805553}
-
Evan Stade authored
Since KitKat support is deprecated, >= L checks can be removed and < L code can be removed. Bug: none Change-Id: I123e3c1d5d33d7cf031d7c248d12a8002c2209da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393156 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#805552}
-
David Van Cleve authored
This reverts commit d4fb5657. Reason for revert: MacOSVersionNumber seems broken on 10.12: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests Original change's description: > Update Crashpad to fc97e5cbb21d for macOS 11 and mac-arm64 support > > Update Crashpad to fc97e5cbb21dc7f4d4679b86792dd2717818bd80 > > 7547d0aa874f android: Remove orderfile configs from handler trampoline > b4724081350e fuchsia: Remove run_tests.py functionality > ebab28f30d33 Remove a variable-length array* to enable compiling with > -Wvla > 1509aadd6364 Remove a variable-length array to enable compiling with > -Wvla > 45ca490687af Build with -Wvla, forbidding stack-allocated variable- > length arrays > 59e8120e7ada [Wconversion] Suppress warnings on Fuchsia > 71695216f9bb ios: Fix Xcode project buildgen > dc9f3a58aabb fuchsia: Fix Wconversion on Mac/iOS builds > 364fdd65a01e fuchsia: Fix Wconversion on Mac/iOS builds (take two) > bdf94713241b mac: Switch from <AvailabilityMacros.h> to <Availability.h> > 56937e1df569 mac: 11.0 SDK support > b3d84e0d0571 mac: System libraries are no longer found on disk on macOS > 11 > df3bc64246ab mac: Be more positive > c4acae9f961a fuchsia: fix configs clobbering in GN template > 3965bc7d7894 Refactor OS_LINUX usage for coming LaCrOs update > 5412beb63386 mac: Replace MacOSXMinorVersion with MacOSVersionNumber > e0d8a0aa01ac mac-arm64: Cope with signal handling quirks > abfc89bb9b70 mac-arm64: Set expectations for tests that crash via > __builtin_trap > ca83774eea9c mac-arm64: Make MacModelAndBoard use target-type instead of > board-id > f8563cb8626a mac-arm64: Omit the cl_kernels workaround on this platform > 0bc3826129d5 mac-arm64: Allow target_cpu = "mac_universal" to create > universal builds > df12d57e97b4 mac: Don’t build 32-bit ProcessReaderMac support where it’s > unusable > ca88ff1edb8e mac-arm64: Don’t attempt to determine the CPU frequency > fc97e5cbb21d mac: Work around broken {CTL_KERN, KERN_PROCARGS2} sysctl > in 11.0db6 > > Bug: crashpad:345,crashpad:347,crashpad:352,crashpad:355,chromium:1103944 > Change-Id: I3c1f59d3c5bd2886916ea80228be765aafb4f63d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399518 > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Mark Mentovai <mark@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805417} TBR=rsesek@chromium.org,mark@chromium.org Change-Id: I69ec022aaebff58e4225114fb1c2f164990b6f48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crashpad:345 Bug: crashpad:347 Bug: crashpad:352 Bug: crashpad:355 Bug: chromium:1103944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401271Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805551}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ica9e835c591950ed66312f82b55fab3e79d6b5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401704Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805550}
-
Lukasz Anforowicz authored
This CL deduplicates code that used to be repeated in FileURLLoaderFactory and ContentURLLoaderFactory: the overridden Clone, private OnDisconnect method and |receivers_| field. In the future, other aspects of URLLoaderFactory implementation (e.g. handling of CORS and/or helpers for responding with file contents) may hopefully also be moved into NonNetworkURLLoaderFactoryBase. Bug: 1106995, 1105256 Change-Id: I7b8783bc4020d914fb7bdd9f56e2e9698fd9a615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357559 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805549}
-
Sunny Sachanandani authored
This reverts commit 1364e616. Reason for revert: Increased crash rate - see crbug.com/1125954 Original change's description: > Reland "media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation" > > This is a reland of b71115a3 > > Relanding after triaging Gold failures on gpu.fyi bots in previous > attempt. > > Original change's description: > > media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation > > > > Avoid a CPU side copy to account for mismatched strides between the > > decoded video frame and GPU texture created for uploading the frame. > > GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D, > > and is part of the GL_EXT_unpack_subimage extension implemented by the > > command buffer on the client side. > > > > Also includes a pixel test with a VP8 video with a GL incompatible > > stride that doesn't match the video's coded size (992 vs 962). > > > > Bug: 1077211 > > Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803696} > > TBR=dalecurtis@chromium.org,zmo@chromium.org > > Bug: 1077211, 1124215 > Change-Id: I43a97e72cdd0ba633d4b374a2319fbc7dc7252f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390958 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803960} TBR=dalecurtis@chromium.org,zmo@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1077211, 1125954 Change-Id: I9c77f5e7694385ccdbbadcddf738135a18ca6412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402124Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#805548}
-
Lukasz Anforowicz authored
This CL introduces ContentURLLoaderFactory::Create static method that allows creating a ContentURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<ContentURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing ContentURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Ia2c41c798b242e2547f22b0e7079ee444b15cbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337577 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805547}
-
Carlos IL authored
This also removes the stale 'DirectCompositionGpuVSync' experiment from testing config since a size presubmit was failing. This was the only stale experiment found in the json file (found using cleanup.py from crbug.com/1053702). Bug: 1042877 Change-Id: I632e19f837c7566849cc3d4477732084765ffa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399133 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#805546}
-
Raphael Kubo da Costa authored
These tests were essentially verifying IDL compliance for some methods, which is not very relevant in this context. Change-Id: Ib103418bf03b8843eda90ae291dceb224cf9e4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398918 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805545}
-
Aaron Leventhal authored
This old code contains a TODO to remove the code once this was fixed: https://bugs.webkit.org/show_bug.cgi?id=73460 (fixed in 2012) Change-Id: Ide14aae549125407c2b4d4c35b6163f0d211095c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401061Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805544}
-
Brandon Wylie authored
This reverts commit 8315bbca. Reason for revert: Doesn't support multi-window Original change's description: > Remove ChromeActivity reference from AutoCompleteMediator > > ChromeActivity is used in AutocompleteMediator to provide the current > TabModelSelector. This dependency should instead be acquired through > direct constructor injection. > > Bug: 1123209,1097292,1113364 > Change-Id: I95c8a58f06f250b6397ec7926b2262b5b2b4298b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382958 > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tomasz Wiszkowski <ender@google.com> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804419} TBR=tedchoc@chromium.org,wylieb@chromium.org,pnoland@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123209 Bug: 1097292 Bug: 1113364 Change-Id: Ib990eba5cc00f7b5209c90b5371385dfe5af9283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402087Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805543}
-
John Lee authored
Bug: 1048812 Change-Id: I4253e49562b4d0afb07dcccebc6f6e4ce0cc5e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393157 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#805542}
-
Yicheng Li authored
1. Adjust title font size and margins according to style guide 2. Left align title, right align cancel button. 3. Apply round corners. 4. Enable title to be read out in accessibility use cases. 5. Enable fingerprint label to be read in accessibility use cases. Bug: b:156258540, b:144861739 Change-Id: I2d5970da96e31f9df162ccbe74db8d95fdd49ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393249Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#805541}
-
evliu authored
Disable flaky external/wpt/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries.html TBR=evliu@google.com Bug: 1126649 Change-Id: I1465651fe037270e70e6033b5a173bdde98b1e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402115Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#805540}
-
minch authored
Restart the chrome to let the color mode changes take effect. This is added to provide a method for UX to do color audit, which will be helpful for us to correct the incorrect colors in each color mode. Will do colors live update in the next step. Bug: 1106012 Change-Id: I451efd94e648680a55bf6f1f77cc9d92209d67ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392935Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#805539}
-
Tomasz Wiszkowski authored
This change addresses the case where a native URL is presented with a clear omnibox text on mobile devices, eg. - chrome://history or - chrome://bookmarks and ensures that no suggestion is offered when the text is cleared. The default match is produced by AutocompleteProviderClient, which does not use the current URL, but instead the text presented in the omnibox, and with the Omnibox text being empty, the default match carries no URL. Bug: 1125046 Change-Id: I56c11def20ed79a9852a578bbf75dd6578d4e26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401331 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#805538}
-
Yuke Liao authored
This CL supports setting up mojo connection between lacros and ash in testing and debugging environment, and it is done via a unix domain socket. Unix domain socket is only used in testing, not production because it allows a random process to connect to ash-chrome as long as it knows the socket path. Currently, only one lacros-chrome is allowed to connect to ash-chrome, so in the testing environment, test launcher will run tests serially, and will change to run in parallel once ash-chrome supports multiple clients. Bug: 1120582 Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805537}
-
Lachlan Ford authored
Implemented the HP Revergb G2 and Samsung Odyssey interaction profiles for WebXR. Change-Id: Icb80280e5c68e90aadd0f8dda033a41712a18306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398917 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#805536}
-
Hiroki Nakagawa authored
The second param of PrerenderManager::IsWebContentsPrerendering() is not used. Bug: n/a Change-Id: Ib108820f1ea6a652301bc18958c0e370d2f88a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400647Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#805535}
-
Kyle Horimoto authored
This CL: (1) Updates the BleScanner::Observer interface so that scan results also include the associated ConnectionMedium. (2) Changes BleConnectionManagerImpl's observer callback so that it ignores non-BLE scan results (which preserves its existing functionality). (3) Updates BleScannerImpl to handle Nearby scan results. Bug: 1106937 Change-Id: Idd35b4e09ec70e55bfd353841b73ecc7aba2c0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401804 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805534}
-
Tom Anderson authored
This CL removes <X11/Xlib.h> from //ui/gfx/x/x11.h. What was provided by Xlib.h is now provided with inline declarations. The intent is that I'll incrementally remove declarations from x11.h until there's nothing left, at which point the dependency on Xlib will be removed and therefore x11.h can be removed. Doing it this way will ensure no additional usages of Xlib are introduced, and it gives a nice way of tracking progress as usages are removed. * All Xlib macros are now gone, so it's safe to remove the XProto "undef" files. * For some usages of Xlib (events in particular), it's easier to port to XProto now rather than add declarations to x11.h. * ui/gfx/x/keysyms/keysyms.h is added in its own directory because it's needed by xkbcommon code, which is also built on ChromeOS, but ui/gfx/x/BUIDL.gn asserts that the platform is desktop Linux. BUG=1066670 R=sky Change-Id: If8679721548d45bdea48bcd8a898191b3f87eb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392140 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805533}
-
Jonathan Backer authored
This was mostly used for GrVkResourceProvider::backgroundReset. Sampling profiles of Chrome on Pixel 3 and S10E suggest that it costs more CPU time post the task than it does to execute it. Change-Id: Id415eb60207b0eb724ad1308875ab9d251ea5ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402078Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#805532}
-