GitLab

Also eliminates references to progress-dots which were removed
with the old UI.

Bug: 647411
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie7bc4ec3c5b506c637dbffa103e74ac8f133742d
Reviewed-on: https://chromium-review.googlesource.com/1080227
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567833}

During unit tests, or if the default search provider is disabled by
policy, there may not be any default search provider.

Previously, when we went to fetch the favicon for the search provider,
we did not account for the defaults search provider being potentially
null, and this CL  fixes that.

Bug: 852630
Change-Id: I8637c684b1df286ac06506138b86b3237190ebb6
Reviewed-on: https://chromium-review.googlesource.com/1102882
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567832}

A simple typo prevented this from working.
My manual testing didn't notice because the default value
matches my desktop.

Bug: 823547
Change-Id: I9a497380c17a85437b8486e0160f6df7a1429922
Reviewed-on: https://chromium-review.googlesource.com/1103231
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567831}

Currently we check whether ticking mutator is needed and if so we
collect mutator input state. There are duplicated logic in the two
operations above. This patch is to skip the first check and collect
input state directly. Then mutate if the input state is not empty.

Bug: 791279
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib4c7b92ca0b545b42d75b91bc3fd7f9296034d74
Reviewed-on: https://chromium-review.googlesource.com/1103013
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567830}

This CL supports alt+shift+i to open the feedback dialog in views login
screen.

Bug: 852242
Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d
Reviewed-on: https://chromium-review.googlesource.com/1102035Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567829}

Privacy requested this on the design recently. The idea is that with a
large enough variance, a first party cannot embed a third party to
determine the exact number of bytes in a response.

Bug: 853243
Change-Id: I9a7f851eabc6f99d8aae35dc6398a09263043d0c
Reviewed-on: https://chromium-review.googlesource.com/1102908Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567828}

Bug: 533481
Change-Id: I0ff00a6aeb20853d26f83b893e0eab1c1fa46b48
Reviewed-on: https://chromium-review.googlesource.com/1100295Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567827}

Make ApiHelperFor* classes final and remove @TargetApi annotations in
WebViewContentsClientAdapter.

Bug: 791099
Change-Id: Idc0c0aa04e31ceae06646d237e51600d9844f327
Reviewed-on: https://chromium-review.googlesource.com/1103298
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567826}

BUG=853311

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I52c732677d85ad0d102a9868eff3107e75dad3e0
Reviewed-on: https://chromium-review.googlesource.com/1103017Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567825}

|next_state_active_policy| should be checked instead of
|active_policy|.

Bug: 843671
Change-Id: I071494804252330e8e03f1fcdbbcc2667b39fb50
Reviewed-on: https://chromium-review.googlesource.com/1102983Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567824}

Looking at UMA for the P2P file sharing feature, the file move fails
more often than it should.  Add some UMA to find out why.

Bug: 758690

Change-Id: Ifbf549ef2bb17d40c4190451d8089d3c42019f74
Reviewed-on: https://chromium-review.googlesource.com/1101402
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567823}

- self.navigationController.navigationBarHidden = YES; wasn't being set or propagated to these VC's
anymore. This causes both the native navBar and MDCAppBar to be added to the view hierarchy.

On top of making tests fail, there was a large top inset on legacy Editors added by the native
navBar.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3b5196516c7b9c242cfef4ef89a01299c2ae0087
Reviewed-on: https://chromium-review.googlesource.com/1103295
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567822}

Do not try migrate back to default network if it's disconnected.
Remove Connection Migration V1 tests and add equivalent test coverage
in V2 to test session is migrated when a new network is connected after
write error. The new V2 tests are also regression tests which verifies
session doesn't attempt to migrate back if default network is
disconnected.

Bug: 818259, 843299
Change-Id: I54c793b8110eb134d4eeaa3ec7d6d129fdd6aeef
Reviewed-on: https://chromium-review.googlesource.com/1102109Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567821}

This reverts commit aecf63d0.

Reason for revert: it broke everything.

Original change's description:
> libyuv_r1711 roll for AR30/AB30 in ConvertToARGB
> 
> Includes a fix for negative height on NV12
> 
> BUG=libyuv:799, libyuv:446
> TESTED=try bots build
> 
> Change-Id: I4c822d35ce801b2bbc5d2936877116c56a47dedf
> Reviewed-on: https://chromium-review.googlesource.com/1097601
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567817}

TBR=mcasas@chromium.org,fbarchard@chromium.org

Change-Id: Ic02b94abffe0f6018fc39114eccf4c0ebd670490
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: libyuv:799, libyuv:446
Reviewed-on: https://chromium-review.googlesource.com/1103397Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567820}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia5856aa00ac100d236a1fc7a9710bde8c98d6504
Reviewed-on: https://chromium-review.googlesource.com/1103382Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567819}

https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md
has been updated to state "If encryptionScheme from the application is null
or missing, the encryptionScheme fields in the returned configuration must
be null." So updating Chrome to match this.

BUG=852978
TEST=updated LayoutTest passes

Change-Id: I7c5c39b93018fdc8208df5f25c0ef6c4f60e83f5
Reviewed-on: https://chromium-review.googlesource.com/1102000Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567818}

Includes a fix for negative height on NV12

BUG=libyuv:799, libyuv:446
TESTED=try bots build

Change-Id: I4c822d35ce801b2bbc5d2936877116c56a47dedf
Reviewed-on: https://chromium-review.googlesource.com/1097601Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567817}

Small change to the DCHECK log I recently added to dump more and clearer
information about the snapshot.

Bug: 852616
Change-Id: I584f01d711bb885d6da2918d84c364059541843f
Reviewed-on: https://chromium-review.googlesource.com/1101975Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567816}

VR tests were never intended to run on tablets since strapping one to
your face isn't an expected use case, so remove
chrome_public_test_vr_apk from '* Tablet Tester' bots.

Bug: 853250
Change-Id: I82f40d4f35950ec9cbe96aa3903fb49d553f0577
Reviewed-on: https://chromium-review.googlesource.com/1102901Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567815}

Legacy hit tests inline elements and nodes in the way that:
- Enter inline boxes from block flow only when HitTestAction is
  kHitTestForeground (LineBoxList::HitTest)
- When entering atomic inline from an inline box, hit test all phases
  regardless of the HitTestAction for parent (InlineBox::NodeAtPoint)
- After hit testing the children of an InlineFlowBox, the InlineFlowBox
  itself is also hit tested (InlineFlowBox::NodeAtPoint). This applies
  even when the the InlineFlowBox is a RootInlineBox (i.e., line box).

This patch replicates the above behaviors in NG. Since NG treats line
boxes differently from normal inline boxes, this patch introduces
NGBoxFragmentPainter::HitTestLineBoxFragment() for relevant handling.

Note: this patch doesn't handled culled inlines.

One test related to vertical-rl writing mode is regressed due to passing
incorrect accumulated offset to legacy. This will be fixed later.

Bug: 851075
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5eceb4fe5c8270bc17407212ae2fe7c3841daf90
Reviewed-on: https://chromium-review.googlesource.com/1093577
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567814}

Mojo doesn't allow removing an uncalled mojo callback while the message pipe is
still open.

On Android, SpellCheckerSessionBridge::RequestTextCheck() discards an incoming
request if it fails to initialize the Java object. In this case, this patch replies
the request with empty result so Mojo requirements are ensured.

Bug: 848483
Change-Id: Ic4e1528dd65d152ad522aa3eb49c76f90a4e66b9
Reviewed-on: https://chromium-review.googlesource.com/1093962Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567813}

TabStripModel is not re-entrant safe. Re-entrancy causes subtle bugs. This will
make it easier to catch those bugs.

Bug: 852997
Change-Id: I70e106b6a3c6f130afda14c493f17f97c8fe26ff
Reviewed-on: https://chromium-review.googlesource.com/1101844Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567812}

TBR=mariakhomenko@chromium.org

Bug: 851444
Change-Id: I13bb7f55dcc0ca4b6e7a0428b8ed71a8ddacb18a
Reviewed-on: https://chromium-review.googlesource.com/1103277Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567811}

TBR=robliao@chromium.org
NOTRY=true
BUG=853360

Change-Id: I5c3a4ee9a99af7cda1103d7def48685496462b49
Reviewed-on: https://chromium-review.googlesource.com/1103308Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567810}

We recently enabled Vulkan build by default. However, in the Vulkan code
is "mips" which is #define mips 1 on MIPS builds.

It is easy enough to just rename this instance to mip_levels. It is also
more descriptive anyway. And then it fixes builds targetting MIPS chips.

BUG=853174

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I45b75b4deaa8c95fba47e8958d9283c49a5f405f
Reviewed-on: https://chromium-review.googlesource.com/1102672Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567809}

The original CL stopped requesting chrome dumps for
RequestPrivateMemoryFootprint, but there was a block in
QueuedRequestDispatcher::Finalize that assumed that the chrome dumps did exist.

> Most clients only need private memory footprint, but the existing methods would
> still query all the MemoryDumpProviders and then filter the results. This CL
> adds a new method that avoids querying MemoryDumpProviders.
>
> Bug: 851712
> Reviewed-on: https://chromium-review.googlesource.com/1098623
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567417}

Bug: 851712
Change-Id: Ibac7c2189ea74f2029458ba3088159259aab5096
TBR: dcheng@chromium.org, thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1102724Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567808}

When adding an Window to an existing overview grid through
WindowSelector::AddItem(), we should only update its bounds when
necessary. Otherwise we may see a flash and the animation might not look
right. This is because the to-be-added window's bounds might not
consistent with its window state (which might be caused by several
reasons, e.g., tab dragging, tapping on the divider to resize snapped
windows, etc), so updating its window bounds before adding to overview
window grid may cause the window do the bounds change animation first,
and the followed by the overview transform animation.

Bug: 823769
Change-Id: I4a56349991663a20974c7bdc5c800b919241fcd4
Reviewed-on: https://chromium-review.googlesource.com/1102033
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567807}

Bug: 840952
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I58379298fe27ccebb75c043a1e1bd507efeb6baa
Reviewed-on: https://chromium-review.googlesource.com/1080798
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567806}

Purging will no longer infinitely loop when there are areas &
namespaces that are still bound, and cloning a session storage
namespace from browser commands will clone immediately and not wait
for a 'clone' from the renderer (which never comes).

Opening areas after purging also re-opens the correct storage area,
instead of opening a new storage area.

Bug: 848694, 848980, 849400
Change-Id: I63790d26efe9fad871e9127ef129c772848e7e56
Reviewed-on: https://chromium-review.googlesource.com/1098154Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567805}

In Refresh, FrameTopBorderThickness is 1 dip larger when the browser
is restored. OpaqueBrowserFrameViewLayoutTest needed to account for this
increase.

Bug: 846410
Change-Id: I4595c4d52ef955de53ef8f487fb181fb109d5f76
Reviewed-on: https://chromium-review.googlesource.com/1100382Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567804}

This CL improves accessibility of cr-input by automatically generating
aria-label on <input>, taking a best guess based on cr-input's aria-label,
label, or placeholders.

Bug: 832177
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6847f16fa5ddca89691aca271ea077974ff5211e
Reviewed-on: https://chromium-review.googlesource.com/1097942
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567803}

In Refresh, when the omnibox receives focus it moves. The test was
assuming it would stay put, so this patch refreshes the click location
after the first click.

Bug: 846410
Change-Id: Iea0fe695efed257d679f87c55146b948f3360e0d
Reviewed-on: https://chromium-review.googlesource.com/1102117Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567802}

The wifi disabled message would show on toggle wifi off, but remain
when toggling wifi back on.

Test: manual
Bug: 823236
Change-Id: Ib232a917e45fea83a72792d0fbf30374661477d2
Reviewed-on: https://chromium-review.googlesource.com/1102896Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567801}

Per discussion with API owner, we want the behavior for invalid
params to be a bit stricter.  Prior to this change, if someone
called the API with at least one valid DomString, then we would
allow lock to be set.  This made sense when we were translating
the key_codes param into native key codes (where we couldn't
determine the difference between 'invalid for this platform' and
'invalid key for all platforms'.  Now that we use DomCodes, we
can do better validation.

The second change is to cancel any current keyboard lock requests
if the API is called with invalid params.  The scenario here
involves lock() being called correctly (request is registered) and
then a second lock call being made w/ invalid params.  Since we
reject the promise in this case, it didn't make sense to keep the
lock request since the intention by the caller was to override the
initial call.  In practice, we don't think this will occur often
but it is a case we wanted to handle better.

BUG=680809

Change-Id: I0ca54cca262761133739ab1d43f22e219792ca7c
Reviewed-on: https://chromium-review.googlesource.com/1099762
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567800}

This CL revives some of the checks from r512959 to ensure that most
extension URLs only commit in the correct extension processes.
There are several exceptions that must be accounted for.

BUG=770239, 840857

Change-Id: Id3dd2a7814041186d4de6f61e2dee440939b57d9
Reviewed-on: https://chromium-review.googlesource.com/1025075
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567799}

host_->GetView() might be null.

Bug: 852264
Change-Id: I18af8aecdff6574a00283bae590aa6edacfbef94
Reviewed-on: https://chromium-review.googlesource.com/1100968Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567798}

Bug: 798612
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie9bb7d1af812a96f11058c928cb32fa6491d96db
Reviewed-on: https://chromium-review.googlesource.com/981079
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567797}

Creates connections to remote devices over Bluetooth, using either the
listener role (BLE scans only) or the initiator role (a combination of BLE
advertising and scanning).

When a connection is attempted, it remains active until either an
AuthenticatedChannel is returned successfully or until the request is
explicitly removed via one of the Cancel*() functions.

Bug: 824568, 752273
Change-Id: Icda1cde32e3d4455742c1570df15b82979cd0ace
Reviewed-on: https://chromium-review.googlesource.com/1100133
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567796}

* Default Mac to 4 cores
* Add recipe names to non chromium recipes

Bug: 840631
Change-Id: Ib90206c80f41efa9e9d6aaed6977b39101a8f5a0
Reviewed-on: https://chromium-review.googlesource.com/1103221Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567795}

This reverts most of commit a51e3935.
The thread configuration for --enable-features=Mus doesn't exist anymore
and fixing mus introduced a different race for the non-mus configuration.
Since mus is no longer the plan of record, revert the initialization
order changes but keep logging and code cleanup.

Bug: 840474
Change-Id: Ifec0e3dd9601e3895d0549109be5d10387f3b8b4
Reviewed-on: https://chromium-review.googlesource.com/1101139Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567794}