- 11 Nov, 2020 40 commits
-
-
Leonard Grey authored
Styling still WIP. This change enables the UI to show a prompt chip when a composite command is selected. - Selecting a composite command clears the input and shows a chip with a prompt - Backspace over the prompt when the input is empty informs the backend that the prompt was cancelled, restores the previous user input, and requeries Bug: 1014639 Change-Id: I3fff2bf6cacab28b473c8ddee3a7a41fbb6df945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530796Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#826338}
-
Nico Weber authored
TBR=mstensho Bug: 1147315 Change-Id: I915e4a97e47e02a657fe67d4534694c59bf2552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533017Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826337}
-
Peter Kotwicz authored
This CL adds exported deps for: - org.checkerframework:checker-compat-qual - org.codehaus.mojo:animal-sniffer-annotations This is in preparation to switching to the maven version of guava in order to avoid conflicts with the internal version of guava. BUG=1144019 Change-Id: I4a2c49445f0ae389d508b7bcaac3da9b88935c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527262Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826336}
-
Antonio Gomes authored
This is a reland of 73e9db73 Differs from the original CL by adding a `DEFINE_EXPORTED_UI_CLASS_PROPERTY_TYPE` declaration needed for linking. Original change's description: > Move DefaultFrameHeader to //chromeos/ui/frame/ > > This header/class is directly used by BrowserNonClientFrameViewAsh. > This steps goes one step closed to allow this class to be shared > with Lacros. > > BUG=1113900 > R=jamescook@chromium.org, oshima@chromium.org > > Change-Id: I185560a34265e6ff13c48b48634faf6826f2236a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529570 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825896} R=jamescook@chromium.org Bug: 1113900 Change-Id: Ic0049f5024832104600d6b4e83cb86f1986db120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530292 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#826335}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6f52c21..48a46dd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99064aad8bcae0e1279efbf0100d92258707cb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532673Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826334}
-
Peter Kasting authored
This fixes an insufficient line height issue and improves text contrast. Bug: 1138840 Change-Id: I90030ad6e63dc0642378da26f34a9012c255decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521285 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826333}
-
Kent Tamura authored
crrev.com/804045 changed the intrinsic height of the slider container to 'min-height'. It caused a positioning error in a case where the slider height is shorter than the container's min-height. This CL fixes it by specifying 'align-self: unsafe center' to the slider container. Bug: 1146385 Change-Id: I52313ba86e65799338adff4136be33f020919363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526855 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826332}
-
Jinsuk Kim authored
The reported failing test is a new one that's supposed to run on phone only, but was not annotated accordingly. This CL fixes that. Bug: 1147228 Change-Id: I61d8d0f68bd11fd3112a02a8b272237708010c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526663 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#826331}
-
Aaron Leventhal authored
What's happening is that as the search field goes from empty to having text, the shadow generic container inside of the input goes from not being in the tree to being in the tree. But in AXNodeObject::ChildrenChanged(), we use LastKnownIsIncludedInTree() and we can't update it to a new value. So we think it's still not included in the tree, and update the parent's children. But we also need to update its children too. Originally backed out because it was suspected to be related to test timeouts here: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/76067 Relanding so that we can prove it one way or another. I suspect it was not related. NOTRY=true Bug: 1146214 Change-Id: Idb814ec95f6f04460dda81439b164e214a7ef14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533157Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826330}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5acf6a857b48..bd3792de72cb 2020-11-11 bsalomon@google.com Add SkYUVAInfo-based promise texture image factory 2020-11-11 adlai@google.com Use SkSpan to clean up GrOnFlushCallbackObject API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I0a2d98a55a6a1a5f8d29b0719d256b9e8043554f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826329}
-
chrome://policyGuillaume Jenkins authored
Some existing policy tests load the chrome://policy page and ensure that it loaded correctly by checking for the checkbox label at the top of the page. This doesn't help catch Web UI issues that happen when displaying the policy table further down the page. This CL changes the selector so it looks for the policy table header, which should help catch more WebUI problems in the future. Bug: 1147191 Change-Id: Ib6c0a7c13d689d12f62eca5c88873bb31e749891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530173Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#826328}
-
Muhammad Hasan Khan authored
Bug: None Change-Id: I72263ea0706df61d7349f0d403e7d1750607d250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530194Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#826327}
-
Liquan (Max) Gu authored
Changes: * Replaced `mPaymentUiService.getPaymentRequestUI() == null` with `mIsCurrentPaymentRequestShowing` as the way to check for 'update- without-show". * Renamed "parseAndValidateDetailsForSkipToGPayHelper" as "parseAndValidateDetailsFurtherIfNeeded" because PRService needs to call it, and PRService does not know about skip-to-gpay. * Moved the main logic of CPRService#updateWith into PRService, with the remaining part called onPaymentDetailsUpdated() left in CPRService. * Since "invokedPaymentApp.updateWith()" is moved into PRService, PRService delegates the dependency MethodChecker. Bug: 1131059 Change-Id: If305338491240b16d230e3ab6b43d0c64c256de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530312 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826326}
-
Chris Lu authored
UXR suggested a new string for the Location Permissions modal that will show before triggering the native location prompt. The modal is a part of an experiment changing the location permissions user experience. Bug: 1138603 Change-Id: I3c9e010785b436b4d6ed506037518df58f591c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530738Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#826325}
-
Natalie Chouinard authored
Toasts with messages that extend beyond a single line should be wrapped to multiple lines rather than truncated. Bug: 1143402 Change-Id: I605f814a03f95628aae0deb5cb7970d0ac66af71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530893Reviewed-by:
-
Yue Zhang authored
Prior to this CL, the tabs created through actions in StartSurface (e.g. clicking MV tiles, using fake box, etc) cannot have parent tabs. This becomes a problem when TabGroup is enabled, as we use parent-children relationship of tabs to maintain TabGroup. This CL fixes this issue by passing down a parent tab supplier to components in StartSurface, so that we can create tabs with parent tabs if needed in StartSurface. Bug: 1119256 Change-Id: Idcc4aafc89a91b1617c7eb14bcc3f448652fbc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444392Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826323}
-
Bailey Berro authored
This change adds the memory test to the SystemRoutineController. Bug: 1128204 Change-Id: I9910664a1f5dd6f5c37f000ea5c965242d9583db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488709Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#826322}
-
Vladimir Levin authored
This patch renames the two functions to indicate that they are used in test environments only. R=danakj@chromium.org Change-Id: I6c76733f2791df4763df2d6ebcf4fc38557aafd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523445 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#826321}
-
Steven Valdez authored
This adds support for the V2 versions, updates the DST and removes verification of the Trust Token redemption records. Bug: 1138432 Change-Id: I3fde214b47d60853e81d9f802c52ea3333745537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527602 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#826320}
-
Leo Lai authored
According to the current program flow, this to-be-removed branch seems a useless special handling. This CL might affect how UserSessionManager utilitzes tpm manager client in the near future. BUG=b:172748724 TEST=unittests. Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#826319}
-
Filip Gorski authored
Moves the Embedder interface from OmniboxSuggestionsDropdown to a separate file with the name: OmniboxSuggestionsDropdownEmbedder. This interface used to be a standalone thing to begin with and we moved it inside for the period of refactoring. It makes sense to have it standalone, because that is the only part that embedder needs to implement/know of to effectively integrate with the dropdown. Bug: 1075602 Change-Id: Iee75626462b88b343790dbebc31477b9ae33e54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530894Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#826318}
-
Nico Weber authored
After the 2nd-to-last clang roll, release component builds make chrome crash on launch due to CFG. Disable CFG for component builds until we roll in a fix. This does not affect shipping chrome, which doesn't use component builds. CFG was already disabled in debug component builds. Bug: 1147194,1147445 Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#826317}
-
S. Ganesh authored
All the new library/class/interface ids in the BUILD file are now dynamically generated by midl, based off the product name and current version. Bug: 1109612 Change-Id: I3f0806c7266184c78fd61ff25ac511834dc2ed56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530525Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826316}
-
Guillaume Jenkins authored
Enables CBCM by default on Chrome branded build (the --enable-chrome-browser-cloud-management command-line switch is still needed for Chromium builds). Because the logic for checking whether CBCM is enabled or not is now back to being the same on all platforms, this change also removes the IsEnabled delegate method and brings the check back to the core CBCMController class. As a result, the command switch declaration was moved to components so it can be shared between platforms. Bug: 1111435, 1097161 Change-Id: I5f15f06885b4deb3974616667273706931df6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522981 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826315}
-
danakj authored
Convert RenderWidgetHostNSView mojom to use ui::Cursor instead of WebCursor. Then WebCursor is no longer used, which was previously using the SkBitmap param traits.. R=dcheng@chromium.org TBR=inferno@chromium.org Bug: 1144462 Change-Id: I5f06739475e5421ba5f6acdca985bf0e03182744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523334Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826314}
-
Liquan (Max) Gu authored
Context: Currently, "waitForUpdatedPaymentDetails" is used in the payment codebase to mean two things: (1) an action: whether show() should be blocked from showing the payment details until the merchant passes in the payment details with show()'s PaymentDetailsUpdate promise. (2) a state: whether the payment details is now pending for update - once the details is received, the state is reset to false. These two meanings makes it ambiguous for code readers. To clarify it, this CL create mIsShowWaitingForUpdatedPaymentDetails to make it clear when it represents a state (meaning #2). Also, "isShow" makes it easier to read when this variable appears out of the scope of show(), e.g., in PaymentUiService for example. This CL also renames initializeWithUpdatedDetails() as continueShow() to make the control logic explicit. Changes: * Renamed some waitForUpdatedPaymentDetails as isShowWaitingForUpdatedPaymentDetails when it means a state. * Renamed initializeWithUpdatedDetails as continueShow. * Documents about show()'s PaymentDetailsUpdate promise in updateWith(). Bug: 1131059 Change-Id: I6c6b99ce5149c22fc6d7d4327e1eae0dacd10e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529618Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826313}
-
Roman Sorokin authored
Also modify test to verify the behavior. Bug: b/168759134 Change-Id: Ic04de90bb393efba4ad262090305e8232f398a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532075 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826312}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e42693daf419..850ce5aaee72 2020-11-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-11 kimjae@chromium.org portage_util: Compile regex once for efficiency 2020-11-10 bmgordon@chromium.org cros_sdk: Switch use_image off by default 2020-11-10 juahurta@google.com cros_branch: Remove cros_branch 2020-11-10 ahassani@chromium.org dev_server_wrapper.py: Deprecate unused functions 2020-11-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-09 seanabraham@chromium.org constants: update skylab package pin 2020-11-09 engeg@google.com service/payload.py: full images can be signed 2020-11-09 lamontjones@chromium.org api: freshen python bindings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia404b8d63725813a2bc11d3409b16fcfa70c3a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532920Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/q6S1Q6V4_M64y2wv8AI6ZmwjOFY46EgVtPz9XcWJVRsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/172266988 Tbr: help-app@grotations.appspotmail.com Change-Id: I69944115874ce5dc239930c58a3c0f7df80ca01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826310}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d4297e6b205..dfff133590c2 2020-11-11 treehugger-gerrit@google.com Merge "test: don't run KernelAddressSymbolization test on user builds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idabd307466bc11ff023ea23281cce451377fa404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532626Reviewed-by:
-
Fredrik Söderqvist authored
The |needs_boundaries_update_| flag isn't really used for anything since we always update the boundaries/object bounding box regardless. Hence it doesn't add anything that the return value of UpdateBoundingBox() doesn't already convey. In ImageChanged() only check if the image dimensions changed without updating the oBB, but rather leave that to the layout that will be triggered. Bug: 1028061 Change-Id: I418e49952bbd808ceecc44bfa27b7ce07f8d698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532459Reviewed-by:
-
Steven Bingler authored
Two histograms will be added, one for localhost and one for non-localhost navigations. These will be used to help determine how cookies are used in the wild. These histograms, unlike their "scheme" omnibox counterpart, will collect values on copy/paste. The values collect are a subset of the full TCP port range for performance reason. A number of "interesting" values were chosen + 5 more incremental values for each. Both the desktop and Android builds were tested using chrome://histograms. Bug: 1141135 Change-Id: I70dd3f6833519bbf74300a0807c7326c90117c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518252 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#826307}
-
Leo Lai authored
we are obsoleting `TpmIsBeingOwned()`, which is not really necessary anyway; even if `TpmIsBeingOwned()` returns `true`, triggering the TPM initilaization again is just no-ops at ChromeOS side. BUG=b:172775884 TEST=TBD if untitests needed. Change-Id: If4240a0c8a9a7485d77856e1e5c346c89407c09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532155 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#826306}
-
Guillaume Jenkins authored
Donates the Search In Chrome intent to SiriKit every time a search is performed in the Omnibox. The donation is performed on the IO thread to avoid blocking the UI thread. This also updates the intents definition file to make the Search in Chrome intent available for Siri suggestions, which was previously disabled and prevented intent donation. Bug: 1146116 Change-Id: I6f7beb004a7f38d3a6297c8e7c171675fef2277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521202 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#826305}
-
Dave Tapuska authored
This collapses two implementations into a common one in the base class. BUG=1097816 Change-Id: I31a9edbe6af04450c12521a7a9b68907df8fb18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526172 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3630044b6610..17f22b43ebf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com,mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: wjmaclean@google.com,mstensho@google.com Change-Id: I2c1809a7c00f644279a76621ee8d7beea717c679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532914Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I90dab70bbcf3bd89ac7b02cd4dbb05e9c5828970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502669 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The goal of the UI is to notify the user if the recoverability of the account that holds the sync data is not good enough, and the user may run into data loss. To fix this case, the user can press the button in the profile menu. The actual action corresponding to this button is not introduced yet in this patch but instead TODOs have been added, to be addressed in follow-up patches. All logic is behind a feature toggle in lower layers (SyncServiceCrypto) and disabled by default. Change-Id: I86977e710b6109d86f2384b235dbeafaebd762fb Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461326 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#826301}
-
Scott Violet authored
To do otherwise results in accessing random data. BUG=1147430 TEST=none Change-Id: Icedacbaac64cad3fc903e6423c6f9aad8c1e8cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531118 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Chris Sharp authored
Bug: 1146509 Change-Id: I67d27099b546bc913807f516ec807f36bd74f9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523491 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826299}
-
