- 05 Nov, 2020 40 commits
-
-
Xing Liu authored
This CL sets up the class structure for bookmark bottom sheet. Details will be added in following CLs. A instrumentation test is also added, which only contains a simple test to check the bottom sheet opened with a title text view. Bug: 1128074,1133496 Change-Id: I02d7a488ffa46e9ee4f6993003dfade8e7fbb3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473078 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#824564}
-
Sigurdur Asgeirsson authored
This moves users of ScopedObserver to either base::ScopedObservation or base::ScopedMultiSourceObservation in the performance_manager. Bug: 1145565 Change-Id: Ide766fc0139134ebc6f9cdfff58864fccb1b78f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520246 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#824563}
-
Samuel Huang authored
Previously, generate_commit_size_analysis.py takes: * --apk-name for SuperSize "main file" input (.apk or .minimal.apks). * --mapping-name for "mapping file" input. This worked fine for Monochrome. However, for Trichrome, the SuperSize "main file" is now an .ssargs file that specifies 3 "container files", which for Monochrome, coincided with the "main file". To centralize the specification of all these files from BUILD files, we define "size config JSON" file to specify the following: * Mapping files (as a list). * Arguments to be passed to resource_sizes.py (which already supports Trichrome). * Supersize main file, which can be {.apk, .minimal.apks, .ssargs}. * Version numeric string (for late ruse). This CL adds size config JSON support. Details: * Add GN template "android_resource_size_config" to specify size config JSON files. Files are generated during "gn gen", and written to config/ under Chromium output dir. * Add GN targets to generate size config JSON files for Monochrome and Trichrome * resource_size_config_monochrome_public_minimal_apks -> config/MonochromePublic_size_config.json * resource_size_config_trichrome -> config/Trichrome_size_config.json * In generate_commit_size_analysis.py: * Add --size-config-json to specify size config JSON path. * If specified, the file is copied to the staging dir. * If the "main file" is .ssargs, then it's also copied to the staging dir. * Add Trichrome support to call resource_sizes.py * In trybot_commit_size_checker.py: * Add --size-config-json-name to specify size config JSON *filename*, which will be searched in {before, after} dirs. * If specified, "mapping files" are directly extracted from the size config JSON files for "ForTest" symbol extraction. * This will replace the --apk-name argument. With this CL, size config JSON files and supports are available but unused. Usages will be added in follow-up work. Bug: 1040645 Change-Id: Ie3328ac413af3a15cd1cbb0957881da7d2d1f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518126 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824562}
-
Andrew Xu authored
This CL does two things: (1) Ignore the MenuItemView instance in accessibility events handling. Then we can customize accessibility behaviors of the multipaste menu in ClipboardHistoryItemView class. (2) When the delete button gets the pseudo focus, the accessibility side is notified. Bug: 1145773 Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824561}
-
Chan Li authored
Re-enable the experiment on try builders, because: - led issue (crbug.com/1141272) has been fixed - web test runner/sink integration makes blink_web_tests on win builders slow issue (crbug.com/1141606) has been worked around - now blink_web_tests are handled be result_adapter. Bug: 1108016 Change-Id: I9cacc5da63f4197ce6c22d9fa3181ee65375e14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521834Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824560}
-
Victor Costan authored
Before this CL, AppCacheServiceImpl owned (as much as a ref-counted class can be owned) AppCacheQuotaClient directly, via a scoped_refptr. This introduces the following complexity: * AppCacheQuotaClient (a complex class) is constructed on the UI thread, and accessed later on the IO thread. * AppCacheStorageImpl and AppCacheStorageImpl (two complex classes) live on the UI thread, but are responsible for thread-hopping to the IO thread when accessing AppCacheQuotaClient. * The owning reference for AppCacheQuotaClient lives in the UI thread, which forces AppCacheQuotaClient to inherit from RefCountedThreadSafe. This is the main reason why QuotaClient is ref-counted. This CL introduces a QuotaClientHolder class that's internal to AppCacheServiceImpl. This class lives on the UI thread, and takes on the responsibility for all thread-hopping needed to access AppCacheQuotaClient exclusively on the IO thread. Changing QuotaClient's ownership model away from ref-counting is left for future CLs, in the interest of keeping this CL manageable. This CL does not introduce any behavior changes. Bug: 1016065 Change-Id: I46d7029d054a674c9252fe4b975fef17cabde010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519742Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824559}
-
Gayane Petrosyan authored
Bug: 1145890 Change-Id: I6c8cc8b063640dd4bcb4b388515bc391cee68966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521046Reviewed-by:
-
Charlene Yan authored
Flake portal shows it regularly flakes on Win10 and it has failed on the Mac10.15 builder. TBR=smcgruer@chromium.org Bug: 1146083 Change-Id: Ic9caa365766bc4d3752eeebc95975ff4bb24cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521350Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824557}
-
Antonio Gomes authored
This CL ensures that the WL client (Chromium/Wayland, Lacros) tells the WL server (Exo) the higher Aura Shell protocol version it supports, instead of the lower. With this in place, code is safe against similar crashes observed in bugs 1145642 and 1145695, where the Client (Lacros) was telling the server (Exo) it supports a version higher than it actually does. BUG=1145642, 1145695 Change-Id: Ia471748f0f3066eea901c189c06da3c1137c1cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518443 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#824556}
-
Robert Ogden authored
Mostly adds testing to ensure the UA header is set correctly, and uses the content API for the UA string instead. Change-Id: Id54ec973dc6837b92aa19cde3149e1097423374d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521351 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#824555}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604577537-33195dde368ac3649b204ac4f693c7d7b8d917b5.profdata to chrome-linux-master-1604599166-2d84463f431e41489c0f9ff841daf3c0f07e3415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If6a68ec0817d5c2d8373285e90dcc41dd3ae5383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824554}
-
Nick Burris authored
Add documentation with tips for debugging and reproducing flaky Gtests. Bug: 1127370 Change-Id: I6b47b31cd109fe1e7bafc3b828221012a9ec95ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508298Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604577537-36e0dad6a87a9c5b37b85a7b6521b35cfbf49108.profdata to chrome-mac-master-1604599166-f98e71683e0c124b3da263294d166e72d717216d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1fa7b4d9b6ad1310cbe6ecee10f59680fcdf3bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521773Reviewed-by:
-
Matthew Mourgos authored
This CL adds fade in/out animation for showing/hiding the clipboard nudge. The nudge scales down when fading in and scales up in size when fading out. Bug: 1143809 Change-Id: I4c299c9c6264efcefdc6b9d35fd7a1563f8cb0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511350 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5081a2b12d65..59917fa054ac 2020-11-05 jegarc@microsoft.com Check that block sections exists before add a blank style rule 2020-11-05 jacktfranklin@chromium.org New DataGrid component. 2020-11-05 aerotwist@chromium.org Support fake connections to the backend 2020-11-05 tvanderlippe@chromium.org Use TypeScript-authored files in accessibility/ 2020-11-05 aerotwist@chromium.org Fix WebAudioModel 2020-11-05 tvanderlippe@chromium.org Typecheck accessibility/AccessibilitySubPane.js with TypeScript 2020-11-05 jacktfranklin@chromium.org Wrap scrubber in overflow wrapper on animation timeline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125966,chromium:1142611 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25a9a9b7ac77a7c715d1d60a22f1e009fddc2821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521038Reviewed-by:
-
manukh authored
Currently, bookmark suggestions are limited to title & URL matches. E.g the input 'planets jupiter' won't suggest a bookmark titled 'jupiter' in a directory 'planets'. This is the 4th of 5 CLs implementing bookmark-paths which will allow inputs to match bookmark paths (without contributing to the bookmark suggestion's score). This CL updates TitledUrlIndex::GetResultsMatching to (optionally) include bookmarks that match the path. This won't include bookmarks that *only* match the path. E.g., this would allow the bookmark 'path/title' to match the query 'path title' but not the query 'path'. Bug: 1129524 Change-Id: I745009139dde14c49e7a958ff5a105d0b39bdeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441153 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824549}
-
Tibor Goldschwendt authored
Product images should sit on top of a light gray background. Before this CL, we only supported this for images with a transparent background. This CL adds support for images with a white background by: - Placing the image in a white box, - Making the image and the box slightly transparent, and - Placing the box on top of a dark gray background. The colors and transparency are chosen such that the white box and the dark gray background mix to the same light gray we showed for images with transparent backgrounds before. See crbug/1145763 for screenshots. Fixed: 1145763 Change-Id: Ib07bfd99b6a0d30192113e1ceb1a542d076138a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520319 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824548}
-
Thomas Tellier authored
Bug: 889595 Change-Id: If3fb95f74b9582c14c574a5cf7f46658ba4d0661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519977Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#824547}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83b6c1ebd54d..ac59b0e049f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8c16694c456beb96ccbf8d29a87c221ada57e267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521042Reviewed-by:
-
Mason Freed authored
This usage breaks when Custom Elements v0 is turned off, so this CL updates to a ElementCreationOptions object. Existing tests, plus the work [1] to remove custom elements v0 for WebUI, should catch issues with this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2512381 Bug: 1110954 Change-Id: Ia44ce07366edd34d916d78c93ab5c0b786ba223b Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519385 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#824545}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a673d02458b1b7d897084266b93d5c610e36bd17..1607f54fed72c6589d560254626909a64124f091 The following commits have update notes: 40f49428d Reland "Check AlgorithmIdentifier parameters for RSA and ECDSA signatures."" Bug: none Change-Id: I57e009feeec8b4220e7d2c0fafbed8a1cb3d934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521079 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#824544}
-
David Bienvenu authored
Not doing so caused issues with playing videos in full screen mode on older versions of Windows, when we stopped removing WS_THICKFRAME in crrev.com/c/1972258. Bug: 1014720,1141059 Change-Id: I57b01051c457b35b37c465ce3b38d60bf896c32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510354Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824543}
-
Stephen McGruer authored
This also adds a small section for WPT specifically. Bug: 1127369, 1127368 Change-Id: Ie74413558fe47bd02f1ae29665327c68bf82ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508433 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#824542}
-
Yusuf Sengul authored
Bug: 1142584 Change-Id: Icdae6303b0b04df7c1f0ecc4abe6705cd85f3946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518450Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#824541}
-
Mitsuru Oshima authored
* Changed FPSGraphPageView to observe the PresentationFeedback * Reset the data when refresh rate changes because the data before change is not relevant anymore. Bug: None Change-Id: I4e0d8ef860b99255e2c6ad10d8f845a1e18c0ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517779Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824540}
-
Sigurdur Asgeirsson authored
This is the first step in replacing ScopedObserver. The new class is functionally identical, but has slightly more descriptive member and class names. Now also with a test. Bug: 1145565 Change-Id: I5416d7873396238c829fcf31a55cfe0ef5bac1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519763 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#824539}
-
Andrew Grieve authored
Found this because a test run failed to fetch remote deps: https://ci.chromium.org/p/chrome/builders/ci/test-phone/19818 These tests are meant to use local versions of deps, but had forgotten to call devil_chromium.Initialize(), which enables this. Also consolidates sys.path initialization in the main runner. Bug: 1115604 Change-Id: Ia0f6e916c2b212d4d785ced72a07c6ec6b72101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518124Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824538}
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the HostContentSettingsMap. This CL does not include Observer and Providers. They will be cleaned separately. Bug: 1134547 Change-Id: I8147ea47d6947d9066280f6d61bfe0eb8abfc641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500161Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#824537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b4aa6d8ae29..26705ac9bdf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com,xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: smcgruer@google.com,xialinyan@google.com Change-Id: I1dc589174bd5a5d9da18b05612c00c5b32c9497e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521040Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824536}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ac59b0e049f7..5689d6741bc4 2020-11-05 hjd@google.com Merge "ui: Fix iteration on empty queries and null queries" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id7f34848e3cd69c3be0ab0edfb923bb33c7869b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521037Reviewed-by:
-
Elad Alon authored
This is the second step in implementing getCurrentBrowsingContextMedia behind a runtime flag. TL;DR: This is an API for capturing the current tab. Explainer: https://docs.google.com/document/d/1CIQH2ygvw7eTGO__Pcds_D46Gcn-iPAqESQqOsHHfkI Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Next steps: * Implement the confirmation-box. * Implement unit-tests that rely on the confirmation-box. Bug: 1136942 Change-Id: I8b25baa85565999ec44ed2f1b0bd1e19d6f148c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502628Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824534}
-
Morten Stenshorne authored
This introduces full PositionForPoint() support to NGPhysicalBoxFragment. Its behavior differs slightly from that in legacy PositionForPoint(): if the point isn't within any of the child fragments, we'll use the nearest one (*really* the nearest one). We kind of do something similar in LayoutBlock::PositionForPoint() too, but not very accurately. LayoutBlock is very block-offset centric (hardly cares about inline offsets at all), which is certainly fine there, but that won't work with e.g. multicol, table cells, or some flex items. Additionally, LayoutBlock::PositionForPoint() doesn't really pick the nearest child, but rather sort of the first child whose block-end border edge is past the point. Not sure if anyone depends on this behavior, or if what we do now in NGPhysicalBoxFragment is an improvement. HitTestResult stores the NGBoxFragment that we hit. This will be a NGBoxFragment that's generated from the inner node itself, unless the inner node is text or non-atomic inline content, in which case it will be the NGBoxFragment of the containing block of the inner node. For now, this functionality is gated on LayoutNGBlockFragmentation, because it causes at least one test to regress: editing/selection/selectstart-event-crash.html This fixes 6 caretRangeFromPoint tests, but I think it actually fixes more than that (looks like there are some deliberate changes regarding which character we hit when pointing above/below the first/last line in LayoutNG, which prevents additional tests from passing). Will look into that as a follow-up. Bug: 829028 Change-Id: I0cc86ecd7e89254c998218ea442944f991b36151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515399Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824533}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ef10de40. With Chromium commits locally applied on WPT: a48c8c20 "[Critical-CH] Add check for unsafe HTTP methods" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I7bbee8c9cf18823e8fd09af7e84050a1878df674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521490Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824532}
-
Leonard Grey authored
Now checks commander::IsEnabled before adding the accelerator in AcceleratorsCocoa This is a reland of ac3031b8 Original change's description: > Commander: make accessible via hotkey or Mac menu item > > Only enabled via the `--enable-commander` flag. Visuals still WIP, and > not many commands are hooked up. Hotkey (Ctrl-Space) is probably > temporary. > > Bug: 1014639 > Change-Id: Ibb9ae8ad61d18cbb1d7bb6f0e6df9d8e5135f64a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508331 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824156} Bug: 1014639 Change-Id: I77b77ce759b67c28658d3d6a3f9c9c9671eb7876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519606Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824531}
-
Devlin Cronin authored
s/render_view_id/render_frame_id Bug: None Change-Id: I2af5bb805e83df835e4cd011ae3f01f4092fb71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519928 Auto-Submit: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824530}
-
Sebastien Marchand authored
This currently will affect the Windows and Linux builds. Mac isn't using LLD and is unaffected by this despite using PGO. This results in a ~3% perf gain on Speedometer. One side effect of this change is that we no longer use the explicit orderfile on Windows, since we now use the PGO profiles for binary layout. These orderfiles and the associated logic will be removed in a follow up CL. Bug: 1113282 Change-Id: I868cbe8202ec3a58bb5e56a534e51590caa07157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519756 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824529}
-
Andre Le authored
Update strings in ash and settings to match the finalized strings. Screenshot: https://screenshot.googleplex.com/9cL3Tgpcc32GCUK https://screenshot.googleplex.com/8Sh9naEynbxcsfJ https://screenshot.googleplex.com/36S9sebanwfmfZS https://screenshot.googleplex.com/4WLBHUFN8rmZbNE https://screenshot.googleplex.com/BuSim7d7cvQPFG6 https://screenshot.googleplex.com/9jAkWjLYmHEJyRp https://screenshot.googleplex.com/9JiPk3S7L7w2tjC https://screenshot.googleplex.com/862pdYr9XPuRRsL BUG=1106937,1126208,1144844 Change-Id: I5c03cd00cf6383ad67a8e9fc15a18b68cd50c1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518362 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#824528}
-
Bo Liu authored
Remove SkiaOutputSurfaceDependency change to pass SkSurfaceCharacterization for secondary cb only. Instead use the new skia API to create the characterization directly from passed in info. Needed to add a OutputSurface::Capabilities for secondary cb, which will probably be useful in the future. Also need to fix in webview to ensure the SkSurfaceProps matches viz. Bug: 1144921 Change-Id: I948964a0caa82dba5ef671acafd8c776c403d7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521196 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824527}
-
Moe Ahmadi authored
This Feature param controls the position, with respect to the NTP MV tiles, at which the repeatable queries must be inserted. The available variations are either at the start or at the end of the MV tiles. These two variations are added to about:flags entry for the repeatable queries. Fixed: 1138578 Change-Id: I65a5216ac77756027e7240d921abaa1ba9b96ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520420 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824526}
-
Peng Huang authored
Bug: 1135386 Change-Id: I6ec8af5ba5a56adccf45de5b4524e9039047c96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519593 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#824525}
-
