- 27 Aug, 2020 40 commits
-
-
arthursonzogni authored
Add a basic WPT test where the reported: body.type is: "access-from-coop-page-to-other" This is very similar to the previous tests about "access-to-coop-page-from-other" added in: https://chromium-review.googlesource.com/c/chromium/src/+/2367098 Bug: 1090273 Change-Id: I3b558ed91cbeb48a47d700b9ade0dd9be612962b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374529Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802146}
-
Kuo-Hsin Yang authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/fa27bc456b38..ded752ca0c0b $ git log fa27bc456..ded752ca0 --date=short --no-merges --format='%ad %ae %s' 2020-08-21 chenghaoyang Revert "system_api: Add DBus Method and Token to Bootstrap PowerManager's Mojo" 2020-08-24 tomhughes system_api: run clang-format on all files 2020-05-05 vovoy system_api: Add D-Bus service constants for MemoryPressure 2020-08-18 ahassani system_api: Add a new state for update_engine 2020-08-19 hugobenichi patchpanel: improve general documentation 2020-06-19 nverne vm_tools: Support collecting logs from crosvm Created with: roll-dep src/third_party/cros_system_api Bug: b/149833548 Change-Id: Ib9b66273324ea121682f64326f4d715aa6bd0ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377832Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802145}
-
Yoshisato Yanagisawa authored
This reverts commit 012f9ce6. Reason for revert: can be cause of https://bugs.chromium.org/p/chromium/issues/detail?id=1122461 Original change's description: > Enable task service account on builders using "chromium-ci-builder@" > > With Goma builders, we have confirmed that > chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com > works as without using task service account for Goma. > Let me migrate the builders. > > Bug: 1105814 > Change-Id: Ic4dedf38c59f358909014d4f8b0c9379914bcb2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378780 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802101} TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,yekuang@google.com Change-Id: I7f75e78ef9eb6f5439d38dcd9b3333ea1ab3a841 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379332Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802144}
-
Clemens Arbesser authored
Bug: b/166452732 Change-Id: Ie9ba16bebae0fdfb0adc7dbbbb082baf9f3ed3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377714Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#802143}
-
dpapad authored
Changes summary: - Introduce new LoadTestUrl method, and register a TestDataSource instance. - Replace LoadFile/LoadResource calls in WebUIResourceBrowserTest with LoadTestUrl - Move LoadFile/AddLibrary methods to WebUIResourceBrowserTestV0 - WebUIResourceBrowserTestV0 no longer subclasses WebUIResourceBrowserTest This allows using <script> or JS module imports to pull in dependencies, instead of concatenating JS strings in C++ and injecting them to the page. Moreover, this has other advantages - JS code lives in .js files, and is checked by ESLint and clang-format - paves the way for eliminating duplication of those tests between module and non-module versions - possible alternative to js2gtest in the future Bug: 1119707 Change-Id: Ib94c11afa32fcb47b98a8202cdc3082de6cdc275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374508Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#802142}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68c8ed7aec14..97013e85adfc 2020-08-27 timvp@google.com Revert "Vulkan: Only count descriptor set resources once" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If91f45f8d3c3e39a40383750008832636529fdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802141}
-
Andrei-Laurențiu Olteanu authored
ConvertPtr method is used by Probe and Diagnostics services. To avoid duplicated code, this method is moved to a common place. Move Probe and Diagnostics to the same namespace. Bug: b:162051831, b:158658869 Change-Id: I5b735eee3ef4c0aa9a58762c0aac074226646763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362934 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#802140}
-
Nick Diego Yamane authored
During Chrome's tab dragging, when a browser window is quickly snapped in and out, its surface and xdg surface might get destroyed before the wl_data_device::enter event is processed for the drag offer for that give surface. If that happens, the offer object must be destroyed right away, as there will be no wl_data_device::leave event for that surface (where it would destroyed otherwise) and some compositors usually assume there is no active data offer when a new surface is entered. Such behavior has been observed in Exosphere compositor, for example [1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/exo/data_device.cc;l=77;drc=abf7a4e9b3d2151e0c5c05cf8603e9029f4e006d R=msisov@igalia.com Bug: 896640 Change-Id: I88668d44ccdc1507fdebc4fdbe2b676d8848c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378620 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802139}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6c0f0157c6f..e3d6db4c3fac 2020-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0839d38f to e3029d74 (465 revisions) 2020-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3c2454b82c05 to 68c8ed7aec14 (11 revisions) 2020-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 622558b02e1a to 1f48854dae26 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1115621 Tbr: mtklein@google.com Change-Id: If194c61620c8930ef9c5c2a8d6a745e53d44fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802138}
-
Morten Stenshorne authored
At some point, they were most likely just crashing when DCHECKs were enabled, but this is no longer the case. TBR=kojii@chromium.org Change-Id: I345d58860d0b6c5023310b14b9f38c71c045a67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377868Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#802137}
-
Chloe Pelling authored
Introduces a UILockController owned by Seat which listens for keypress events, and minimizes the focused non-immersive fullscreen window. The intention is for UILockController to also release other kinds of "lock" (such as pointer lock) in future, probably via a publish-subscribe mechanism exposed by Seat. Caveats: * UX is not final. Minimizing may not be the right action; using it for now since switching to windowed mode currently causes incorrect rendering for some games. * We'll need UI to communicate this affordance to users. Bug: b/161952658 Change-Id: Ibbfa28d473e5b152dc59dcb5fda0c2c99496dd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315718 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#802136}
-
Chih-Yu Huang authored
This reverts commit d361d269. We postpone the VD migration at ARC++, so the mojo struct for media::VideoFrame is not used now. BUG=b:136716638 TEST=ninja chrome TEST=./testing/xvfb.py ./out/Debug/components_unittests --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I428b0effb6427d5c106cf2584b6af626ce4953a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377263 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#802135}
-
Kuo Jen Wei authored
Bug: 1113514 Test: tast run <DUT> "camera.CCA*" Change-Id: I6134faa821936a7e130d319c6709cba414728e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303331 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802134}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.6-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2f3f3b12c4cb7c2d8f1d3cfdcd566235ab5ede58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378184Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802133}
-
David Jean authored
Reverse case of problem solved in cl 2359137. Closing chrome with window in landscape and restarting in portrait leads in blank areas. Bug: 1113187 Change-Id: Ie0155d49cf50e23ff0cd95c9afc49598080a5162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377807Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#802132}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.6-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0cea433004e8766299d2ae16ed9f5ce7c8f1b828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802131}
-
Daniil Lunev authored
Wait for the Mojo service discovery for 5 seconds and abort if timeouts. That shall prevent issues like b/165076656 Bug: b:151176984 Change-Id: I9cc03c6909b27aab98a209cb241ad961aaab52ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373827 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#802130}
-
Daniil Lunev authored
The Storage Dimensions data depends on a certain service to be present in the image. Add a feature flag so it can be propagated from the login manager based on USE flags in the system image. BUG=b:151176984 TEST=build Change-Id: I5dd0f9324904884a948b953e2c6154c98b57cef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371869Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#802129}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/184443e8d779..82b1c03b6876 2020-08-27 thestig@chromium.org Make cpdf_interactiveform.cpp ordering better match header. 2020-08-27 thestig@chromium.org Remove more dead code in cpdf_interactiveform.cpp. 2020-08-27 thestig@chromium.org Shuffle code in cpdf_interactiveform.cpp. 2020-08-27 thestig@chromium.org Pack CFX_FillRenderOptions tighter. 2020-08-27 tsepez@chromium.org Remove std::move() in xfa/fxfa/layout missed in GC conversion. 2020-08-27 tsepez@chromium.org Add move-assign tests for cppgc::Member<> and cppgc::Persistent<>. 2020-08-26 thestig@chromium.org Make CFX_FillRenderOptions construction constexpr. 2020-08-26 thestig@chromium.org Make CFX_TextRenderOptions construction constexpr. 2020-08-26 thestig@chromium.org Remove dead code in cpdf_interactiveform.cpp. 2020-08-26 thestig@chromium.org Move CPDF_InteractiveForm::AddNativeFont() to an anonymous namespace. 2020-08-26 thestig@chromium.org Simplify AddStandardFont(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I79f82bc47f97bdb6e033aedc1b7d1717b9e98fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802128}
-
Chih-Yu Huang authored
This reverts commit 2a59da47. We postpone the VD migration at ARC++, so the mojo struct for media::VideoFrame is not used now. BUG=b:136716638 TEST=ninja chrome TEST=./testing/xvfb.py ./out/Debug/components_unittests --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I9159afa69b42bc5798e18de75591b63302860f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377262 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#802127}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e3029d74. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I60765c0e890dd4cc5302d3ec451143441b2e23be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376726Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802126}
-
James Vecore authored
This CL adds a device visibility section to the Nearby Share settings subpage: http://screen/b48f122d-345a-4756-ba16-ede15986ad5b.png The device visibility can be configured in a pop-up dialog when the user clicks the “View device visibility” button. This dialog re-uses the shared Polymer component nearby-contact-visibility: http://screen/1036bee4-0f95-45fc-a5de-8e52169541df.png Sharing this component within os-settings requires a significant number of changes to the build system. Previously the shared components of Nearby were being excluded from the optimize_webui bundling, but this was no longer possible once a more complex component was added because all transitive dependencies would have to be excluded as well, defeating the point of the bundling. Adding the components to the bundling process requires unpacking the shared resources into a sub-folder of the os-settings unpack folders and ensuring all paths are resolved correctly when building the bundles. The way the resources are shared between chrome://os-settings and chrome://nearby (by registering the resources in both webuis) requires lots of small but painful to get right build tweaks once the files are included in the bundling process. Most of this CL is just getting this sharing configured correctly and making sure tests and closure compiler happy for both Polymer 2 and 3. Bug: b:154863670 Change-Id: I1185edb62aa3c60e071c16ffbe29c4a63317331b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363662 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802125}
-
Wei Lee authored
There are many things we want to setup before starting the app (e.g. Error handling, Test coordination). Therefore, we change to land on init.js and then dynamically load main.js so that we can load other .js files only when we finish the essential setup. Bug: 980846 Test: CCA works normally Change-Id: I5a0bf0c305a06562a4bde54422459376f9a2321e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352261 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802124}
-
Gang Wu authored
Clipboard feature(image search) still in rolling out stage, we still need this metrics to track feature usages. Bug: 1109937 Change-Id: I453439eff7dd85a71c03b4ea4a75fbb46db5694a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372595Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802123}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/167cbab7ee8e..447a462be3f9 2020-08-27 chrche@microsoft.com [Elements] Update hideSearchHighlights codepath If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121459 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I844a0ca5129880d51c7564cb9594b66f948ee15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802122}
-
Sara Kato authored
On an alert event, 2 alert events are sometimes generated. The first alert events will read "Alert", while the second wil contain the actual contents of the alert. This CL prevents such "Alert" messages from being announced. Such as case is when a notification in chat app is received, ChromeVox will read "Alert" "Alert <message>". With this CL, ChromeVox will read "Alert <message>"". AX-Relnotes: None Test: ChromeVoxBackgroundTest.Alert[No]Announcement Test: manual. Confirm "Alert" for chat notification is read once. Bug: b:162993006 Change-Id: Ibc661dca9df96da937af165099718f710593fac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341231 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#802121}
-
Zhuoyu Qian authored
This CL rename ResourceLoaderOptions member |world| to |world_for_csp|. BUG=896041 Change-Id: Icaff36c438cbcd2cad86d2825efba3967824543a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377165Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#802120}
-
Andres Calderon Jaramillo authored
This CL is a workaround to prevent too many videos from being hardware decoded simultaneously using V4L2 until we can figure out how to address some crashes in pages with lots of small videos. Bug: 1097956 Test: https://imgur.com/t/funny_gifs on kukui Change-Id: Icdc57331f367b62d8c2ec360744aecba1d4c9586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372926 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#802119}
-
Wei Lee authored
This await is missing in https://crrev.com/c/2237545. Bug: b/166523553 Test: Launch CCA through Hangouts and video can be reviewed after capturing Change-Id: Idb9fe667bb887f42f094acfe88b9c45470967590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377019 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#802118}
-
Xianzhu Wang authored
The blink runtime feature doesn't work by itself because the main feature is implemented in Chromium. Bug: 1121839 Change-Id: If66d1deb62d0d2cc0c6354c86729cd2472e1bca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378751 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#802117}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-86.0.4240.6-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie7a53ef186d2eaa5a15a51768384c4e9f34156a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378182Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802116}
-
Robin Lewis authored
Bug: 1119561 Change-Id: I0c4b5826cb4ed3e4bc18893f696f80089ad82f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365755 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#802115}
-
Henrik Boström authored
This reverts commit 3dbd8ec2. Reason for revert: I don't think this is the culprit and it looks like this test has been flaking for a couple of weeks, see: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnJ0Yy9wcm90b2NvbC9jcnlwdG8tc3VpdGUuaHR0cHMuaHRtbAw More details here: https://bugs.chromium.org/p/chromium/issues/detail?id=1122106 Original change's description: > [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time." > > This reverts commit 3bc91ccc. > > Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329 > > Original change's description: > > [Perfect Negotiation] Surface session descriptions at the right time. > > > > This fixes another timing related issue that blocks Perfect Negotiation. > > > > Before this CL, current/pending local/remote description attributes do > > blocking-invokes on the webrtc thread, fetching the most up-to-date > > states. This can prematurely expose the result of "in-parallel" > > operations that have not surfaced yet, such as: > > - setLocalDescription > > - setRemoteDescription > > - addIceCandidate > > > > This CL fixes that by copying the SDP states when any of these > > operations complete on the WebRTC thread and carry them over in the > > PostTask to the main thread. Here, we store these snapshots in > > "internal slots" (variables living on the main thread). With this CL, > > reading SDP attributes from RTCPeerConnection is non-blocking and > > spec-compliant. > > > > WPT test coverage added for the exact timing of SLD/SRD and other test > > expectations are updated. addIceCandidate updating the SDP is already > > covered by old WPTs. > > > > Bug: chromium:1110347 > > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801798} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1110347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715 > Reviewed-by: Amr Aboelkher <amraboelkher@google.com> > Commit-Queue: Amr Aboelkher <amraboelkher@google.com> > Cr-Commit-Position: refs/heads/master@{#801822} TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com Change-Id: Ia0f82e0d1b4660cf0d3641aaa446127092c6e6f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379192Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802114}
-
Sven Zheng authored
It's been ~1 week on CI/CQ and the builder is stable. Bug: 1104291 Change-Id: I546734d0719faa1d48db4910ff2db14b11b7bdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378617Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802113}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f729a8b7cc84..788aa6fd2c18 2020-08-27 jleconte@google.com Monorail links in group_report by group_id page are missing project ids. 2020-08-27 landrey@webrtc.org Implement /uploads/<token> api If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773,chromium:1114056 Tbr: skyostil@google.com Change-Id: I086f47b3fab9cf2bcc201319495de95b4e6a93d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802112}
-
Chih-Yu Huang authored
This reverts commit a1921808. We postpone the VD migration at ARC++, so the mojo struct for media::DecoderBuffer is not used now. BUG=b:136716638 TEST=ninja chrome TEST=./testing/xvfb.py ./out/Debug/components_unittests --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I783480520c82793bd41af3b904011969c37d4adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377261Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802111}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/398ecf1876f1..e6c0f0157c6f 2020-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from c3e3c30b0d7f to 8c012e879646 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ibb9093339a14a93c6b4b69ef0ba1af326f7f6b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802110}
-
Xianzhu Wang authored
This CL (temporarily) explicitly enables SubresourceWebBundles for web tests. Two tests under webexposed/ are rebaselined. virtual/subresource-web-bundles is removed. This is to seperate the change of web test expectations from crrev.com/c/2375886 which will enable the feature for web tests by adjusting the application order of blink feature status and chromium feature status. Bug: 1121839 Change-Id: I21da03bc90e456fbf606056f03351dd5f72e2161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378711Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802109}
-
Maksim Sisov (GMT+3) authored
This reverts commit 75363679. Reason for revert: Looks like it broke linux trusty bot Original change's description: > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > This is a reland of f985905e. > > This change broke our headless build: > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > assert(ozone_platform_x11) > ^----- > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > "//ui/events/platform/x11",. > > Fix: > Don't include x11 build for headless case. > > Original change's description: > > X11 and Ozone: enable use_x11 and use_ozone > > > > This is the final change that enables use_x11 > > and use_ozone for Linux builds and (as it was > > before) excludes X11 for chromeos, chromecast, > > lacros. > > > > in order to run ozone/X11/wayland, one must pass > > —enable-features=UseOzonePlatform > > —ozone-platform=x11 or wayland. otherwise, > > non-ozone/X11 is used. > > > > it’s also possible to completely disable X11 > > so that clients, who need that kind of build can > > continue to have that. > > > > Bug: 1085700 > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801523} > > Bug: 1085700 > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801692} TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I6c4e523808341b75c0f734492ac71cb2b9767617 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377814Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69ed1bc0165a..167cbab7ee8e 2020-08-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifde1a09a963a8f921d33ae13e14b65b5e820f2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802107}
-