- 28 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a8c4e3a48ffd..c5f1be68e3ff git log a8c4e3a48ffd..c5f1be68e3ff --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c5f1be68e3ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iae99589d8abefd835ece32e87a07ca93063f9e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709839}
-
A Olsen authored
During SAML flow, we might get extra information about when the password expires from the SAML IdP, which we store so we can then warn the user when their password expires. However, this information is no longer relevant - and will never be updated by the SAML IdP - if the user no longer uses SAML to log in. In that, case, we should simply delete it. We should also delete it if the feature that uses it is turned off - if an admin decides this feature is not useful to them and turns it off, then we should clear the data. Later if they decide to try and out the feature again, they shouldn't need to worry about data reappearing that has been stored since last time they had the feature enabled - that data could be very stale since it will not have been kept up to date. Stale data can lead to spurious password-expiry notifications. Bug: 930109 Change-Id: Ia2f6abba306adea8b64a5f756579826ded8ffc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866750Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709838}
-
Peter E Conn authored
The factory doesn't do anything at the moment, but I'm going to move downstream over to use this method before further changes. Bug: 1018672 Change-Id: I35092af3d0659733eca3587d33ef064c49ca4f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881166Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#709837}
-
Alice Wang authored
This CL fixes the disabled BookmarkPersonalizedSigninPromoTest related to launching SigninActivity in different scenarios. A SigninActivityLauncher is created to setup the intent and launch the SigninActivity with different account settings. Bug: 789531 Change-Id: I09ff0419fb268b2482984c3d0bd3c5cb3227860a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868878Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709836}
-
Mohamed Amir Yosef authored
The name PasswordGenerationState is kinda misleading. The class does more than keeping the state of the generation. It also modifies the underlying password store. Change-Id: If21a78b11268fe7a4a2d2c8adea9c769bb4351f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882311Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#709835}
-
Mihai Sardarescu authored
This CL restricts the concatenation of the Gaia email and the local profile name to Chrome instances with kProfileMenuRevamp enabled. This should simplify the finch configuration for rolling out the profile menu revamp and at the same time reduce the risk as users using the old profile menu will not be affected by the profile name being the concatenation of the Gaia email and the local profile name. Bug: 1018202 Change-Id: I4c28dba17e2c3d8e13b2efeeedcd788909f550e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879291Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#709834}
-
Yuki Shiino authored
Introduces ease-to-use APIs to ExtendedAttributes. Bug: 839389 Change-Id: I8f23ec9f9d6b7dddb9b17720ed2963e16fbd8cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882252Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709833}
-
Mathias Carlen authored
Before this patch the direct action list_assistant_action was used to start autofill assistant and to return available actions. That is misleading and this patch disconnects that by renaming list_assistant_action to fetch_website_actions and return a success bool instead of a list of actions. Out of scope for this patch: the next step will be to tie the availability of the fetch_website_actions action to controller state and to remove perform_assistant_action entirely. Bug: b/138833619 Change-Id: I279e5bc2e6d13a48151d5c161483a2b9662dd940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873752 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e38e11986f00..c189ace20a43 git log e38e11986f00..c189ace20a43 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 04c3c4c8..d68d92fb (709704:709806) Created with: gclient setdep -r src/third_party/webrtc@c189ace20a43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Id48fa26113d190e49da2854a64b222949d604b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709831}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95a736bd3347..076f869ce5ac git log 95a736bd3347..076f869ce5ac --date=short --no-merges --format='%ad %ae %s' 2019-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits) Created with: gclient setdep -r src/third_party/angle@076f869ce5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I6e247ee432f54a85246564a13c3bd06f8ad75f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709830}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3132a118c708a85cb193379b147f8f09bf8564e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882247Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709829}
-
Yoshifumi Inoue authored
This patch chagnes |ComputeNGLocal{Caret,Selection}Rect()| to utilize |NGInlineCursor| instead of |NGPaintFragment| for prepration of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I040c946dd405237e145af4702669304eecfe34ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877505 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709828}
-
Yutaka Hirano authored
This is (1) in https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/. Bug: 1018050 Change-Id: I52536cb0e97ac3c60da30a946a30ee005b1a861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880892 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709827}
-
Minggang Wang authored
The case, CreateTasksForOffTheRecordProfile, becomes flaky recently and has been disabled on asan. This patch enables it again by cleaning up the default browser before the test is going to start. Bug: 1016901 Change-Id: I52ddb58956a881409c70bb21132db066d271809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880536Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#709826}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |ClosestLeafChildForPoint()| in |NGPhysicalLineBoxFragment| for improving code health. This patch is follow-up of the patch[1] which gets rid of clients of |ClosestLeafChildForPoint()|. [1] http://crrev.com/c/1875856 Introduce NGInlineCursor version of ClosestLeafChildForPoint() for AbstractLineBox Change-Id: Ia626b7e77ac415c6d2164072b50f3b34fcbe6b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877874 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709825}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01b1f63d641b..428b5de64a08 git log 01b1f63d641b..428b5de64a08 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77fba58c9658..95a736bd3347 (17 commits) Created with: gclient setdep -r src/third_party/skia@428b5de64a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: Ibe66e17f8c6a4b1175cddd4d4de65a5441b7e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709824}
-
Alex Danilo authored
Adds an error marker that can be used on summary panel items to indicate that there are error panel items in the collapsed summary view. Note, this is just the implementation of the error marker itself, follow up CL will add usage of them. Includes unit test for the error marker. Bug: 1014771 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I86698cb97fc0f7af19ac2177e8781873e3d21776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882196Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709823}
-
Chinglin Yu authored
During shutdown of JankMonitor, when the monitor timer is fired after MetricSource has shut down, the timer dereferences the null pointer and crashes. Fix the crash by nulling out the pointers after the monitor timer shut down. Bug: 1015425 Test: JankMonitorShutdownTest.ShutdownRace_TimerFired Change-Id: Icd9073e4527e0ac01c373fe486d88aa0985a5841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868772 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709822}
-
Koji Ishii authored
This patch fixes ellipsis by implementing IsHiddenForPaint(). Fixes ~50 failures. Bug: 982194 Change-Id: Icabef1450f9c80132cd56db55d0ab73ad72c8ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880894Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709821}
-
Nicolas Ouellet-payeur authored
Now that the "python_script" backend is stable, there's no huge incentive to keep maintaining the "clang_tool" backend. win-annotator-rel started getting compilation errors with clang_tool recently [1], so we might as well disable it. At the same time, this will make the waterfall bot run much faster, which should reduce the rate of task timeouts on Windows. [1] https://ci.chromium.org/p/chromium/builders/ci/win-annotator-rel/1917 Bug: 909867 Change-Id: Ib52cac4a32a41fe11da13fbee2ce85a2b1947c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881307 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#709820}
-
Meredith Lane authored
This reverts commit 538de13d. Reason for revert: Causing flaky failures (https://crbug.com/1018097) Original change's description: > [PM] Freeze Origin Trial - Remove the unknown state > > Most frames won't set a freeze origin trial policy and so making > kDefault the default state when a frame gets created will reduce the > number of IPC calls. This could cause pages to be frozen before all > their frames have reported their policy, a following CL will unfreeze > frozen pages that receive an opt-out OT token. > > Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708808} TBR=fdoray@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic0208aa6045e0e65aef59f8103688865ddb63de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882203Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709819}
-
Makoto Shimazu authored
I found a setter of block_mixed_plugin_content is not called from anywhere so removed the param as preparation of Loader's Onion Soup. Bug: 860403 Change-Id: I2a47e70f7c551727d918888977548142214b1725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883349Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709818}
-
Fergal Daly authored
These are passing on bot-run: - linux - https://chromium-swarm.appspot.com/task?id=4829cfd28750da10 - android - https://chromium-swarm.appspot.com/task?id=4829d1fa07219910 Bug: 1007276 Change-Id: Id2d577a4bd0d87b89afe767dea0faab7a91e18f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883428Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709817}
-
Joel Hockey authored
Change-Id: I26af9df08105a4c8d6f8c25baac4cf87f2076d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880498 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709816}
-
Koji Ishii authored
Following bot results are included. 56 58 60 61 63 64 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I287bb0f0ca8fd6edff21df76771dc57fa8457b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882254 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709815}
-
gogerald authored
Bug: 1017909 Change-Id: I90dd2cbf84d904cc60ea9bf676a5f255839281ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879951 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709814}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I71ac5f0fcec853cc3d46431c657b359541660800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709813}
-
Yoshifumi Inoue authored
This patch Introduces |NGInlineCursor| version of |ClosestLeafChildForPoint()| for |AbstractLineBox| to reduce usage of |NGPhysicalLineBoxFragment| and |NGPaintFragment| for prepration of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Id57b707d4a84fec794f275be6dc8a42e9465d3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875856 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709812}
-
Yun Liu authored
Bug: 985574 Change-Id: I1d5f51adbe51d6022c0b74c71267b89da27958d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872770 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709811}
-
Fabrice de Gans-Riberi authored
* Convert internationalized domain names in the provided hosts_filter to Punycode. * Add validation for host names in rules. Bug: 1012954 Change-Id: Ib14d35f764ce8cc17936226ac4cad81385f6ab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857189Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709810}
-
Peter Kasting authored
Bug: 82078 Change-Id: Iaf572972b0285c020621899345f8c1ab7263b2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881781 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#709809}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c5920efc293..e44b5225dbfd git log 7c5920efc293..e44b5225dbfd --date=short --no-merges --format='%ad %ae %s' 2019-10-28 simonhatch@chromium.org Pinpoint - Make story or storyTags required, but not both. Created with: gclient setdep -r src/third_party/catapult@e44b5225dbfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1016372 Change-Id: I769ecaf78274cec91b16078bff694de65c4e1a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62160f2f358a..01b1f63d641b git log 62160f2f358a..01b1f63d641b --date=short --no-merges --format='%ad %ae %s' 2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6d69aae0e1ab..1737a30e3e34 (2 commits) Created with: gclient setdep -r src/third_party/skia@01b1f63d641b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: Ie3023be2a0e63a6a8d2ec2e3a0ff32b870496d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709807}
-
Archie Pusaka authored
Makes the verbose bluetooth option persist across device reboot by adding a new preference flag. Bug: 1004572 Change-Id: Ibdb278c9b4a326368a591463223e0d1241f2b115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810451Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709806}
-
David Grogan authored
We were including border+padding in a few places where we shouldn't. I still need to figure out whether the max-cross size should include borders when it is influencing content size suggestion in min main size calculations when the item has an aspect ratio. Bug: 845235 Change-Id: Ic25f44f6dbf4da5750acc6b51b2f08f43bb0d983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881774 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709805}
-
Kent Tamura authored
IsShadowHostDelegatesFocus() defined in focus_controller.cc simplifies the code in other files too. This CL makes it Element::DelegatesFocus(). This CL has no behavior changes. Bug: 1014094 Change-Id: Ia72f71578432fd48ccfeb71fb6ecd3370f5e97e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882257 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#709804}
-
Koji Ishii authored
This patch fixes positions of line items when the block is RTL. Because the position of lines maybe decided after children are positioned, this patch applies different transform to children of lines from children of blocks. This patch fixes ~250 failures. Bug: 982194 Change-Id: I35871694ab2cd40f111fb3d338a67cdce2e0982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881006Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7568fa8a28d9..7c5920efc293 git log 7568fa8a28d9..7c5920efc293 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 dberris@google.com Refactor the evaluators module Created with: gclient setdep -r src/third_party/catapult@7c5920efc293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:988912 Change-Id: I8ef5076e075f6bf1100199def657eaee498a555f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709802}
-
Hirokazu Honda authored
Bug: 1011281 Test: image_processor_test --save_images on atlas Change-Id: Ia5f6b106a2bbcc86cbb79cffb46a230b06011eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864758 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#709801}
-
Koji Ishii authored
This is a reland of crrev.com/c/1882249 because the path names of some -expected.png were too long on Windows. * 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org Change-Id: If1d67fb4a9d496c564bfe6246cc57e46288c565b Bug: 1018587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882259 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709800}
-