GitLab

https://chromium.googlesource.com/angle/angle.git/+log/d042fba..cbcb96f

BUG=765919

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ie29f5ce96fd63f1c1f9c51a5646cfa5da12d17f6
Reviewed-on: https://chromium-review.googlesource.com/726756Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510135}

This extends what we did for ChromeHome at
https://chromium-review.googlesource.com/520712: when moving focus from
an EditText to non-editable placeholder does not automatically hide
keyboard, but restart input with TYPE_NULL, which results in a visual
glitch such as flickering of number panel on keyboard app. This can be
prevented by hiding soft input ourselves.

BUG=708259

Change-Id: I05d3714202381e42af04b3fa4ed1bf4452908beb
Reviewed-on: https://chromium-review.googlesource.com/728389Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510134}

For low frequencies, use a 3-point or 5-point Lagrange interpolation
scheme to improve the accuracy of the oscillator instead of using
simple linear interpolation.

For a typical context, the linear interpolator is used if the
frequency >= 3.2 Hz; the 3-point, for 3.2 > frequency > 1.7 Hz; and
the 5-point for all other cases.  Thus, typical use-cases are not
impaired by this change.

Some benchmark results from running an oscillator for 1000 seconds in an
offline context.  This is the time measured from startRendering()
until the promise is delivered.  The SNR is the measured SNR between
the test signal and a reference 440 Hz signal.  The linear time was
the same before and after this CL.

linear:
time: 1844.6 ms, stddev: 154.4
SNR: 27.7 dB

3-point:
time: 2426.5 ms, stddev: 265.0
SNR: 37.2 dB

5-point:
time: 2752.6 ms, stddev: 215.1
SNR: 59.3 dB

7-point (for reference, not used now):
time: 3239.4 ms, stddev: 263.8
SNR: 82.5 dB

Bug: 773507
Test: Oscillator/osc-440hz.html
Change-Id: Ib49fab4fb27738f4f02bd41f8adcc2e3b2dd2137
Reviewed-on: https://chromium-review.googlesource.com/713576
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510133}

https://chromium.googlesource.com/catapult.git/+log/2713d6d5f30d..22e74ebb13a5

$ git log 2713d6d5f..22e74ebb1 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 perezju [devil] Fix forwarder.py to work on newer psutil versions

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I051f3d3dd2a4fa73b0020b3d4f742492d5beba06
Reviewed-on: https://chromium-review.googlesource.com/727662
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510132}

TBR=dtseng@chromium.org
Bug: 773866

Original change

Reviewed-on: https://chromium-review.googlesource.com/723606
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509911}
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
Reviewed-on: https://chromium-review.googlesource.com/728302Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510131}

This patch adds LayoutNG alternatives of LayoutText::ContainsCaretOffset for
both "common" LayoutText and ::first-letter LayoutTextFragments, with an
extensive set of unit tests.

Bug: 771398
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I59b17046c271bf8c5c1fb4fdf7421b37a3183073
Reviewed-on: https://chromium-review.googlesource.com/724262Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510130}

Without network service, pausing a download is handled by DownloadRequestCore.
It defers reading the response until download is resumed.
With network service enabled, we can pause download by stopping reading from the data pipe.

BUG=715630

Change-Id: I231d273828a82a401a9cd3d2773fd75a3166cfbd
Reviewed-on: https://chromium-review.googlesource.com/726302
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510129}

Changes:
Change the role of app list folder to GENERIC_CONTAINER from BUTTON.

BUG=776238

Change-Id: I3c0395678478c873e7328d1cb26bfe1d78043286
Reviewed-on: https://chromium-review.googlesource.com/727562Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510128}

This fixes TestRunner.navigate(...) which is used by a handful of tests
currently and will be needed by more because of the new test structure.

This migrates debug-inlined-scripts-fragment-id.js to verify that this
method works.

Bug: 667560
Change-Id: I658736139aed90e20836cebea016f20ddfa8d9fb
Reviewed-on: https://chromium-review.googlesource.com/727471Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510127}

Otherwise |screen_orientation_| might not have the correct screen
orientation. For example:
- In landscape mode, enter overview mode, drag a window around but do
not snap it. The phantom window should show on left/right side of the
screen.
- Rotate the device to portrait mode
- Drag the window around again. The phantom window should show on the
top/bottom side of the screen. But instead it still shows on left/right
side of the screen.

Bug: 725683
Change-Id: I3f4710648c5c8f988b8561af3fd6f46d62c6e429
Reviewed-on: https://chromium-review.googlesource.com/726273Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510126}

BUG=717658

Change-Id: Idcd6aa2367b82c132f50b41a69a67406ee367a5f
Reviewed-on: https://chromium-review.googlesource.com/724861Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510125}

Before this CL we were checking if the primary surface info is set for
window->layer() to see if that window is a child surface. However, we
were checking at the wrong layer and there's no clean way to get the
layer that we actually set the primary surface info on.

local_surface_id should be set only for child surfaces so checking if
that is valid should be sufficient to determine whether a window is a
child surface or not and get the value if necessary.

Bug: 732395
Test: aura_unittests
Change-Id: I29ba755392f294dbada7378ebb862e8ac844dfd7
Reviewed-on: https://chromium-review.googlesource.com/726843
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510124}

Inlines the cache check and value retrieval in LocalNameUpper. This
appears to improve Node::nodeName by 6% in RuntimeCallStats.  

Bug: 
Change-Id: I0b96d6989365ed731f92750ed238d1d3adc9420d
Reviewed-on: https://chromium-review.googlesource.com/721466
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510123}

If |loggedIntentUrlParam| is in the AndroidManifest, we want to rewrite the URL
to |start_url| appended with the original URL as a query parameter defined in
|loggedIntentUrlParam|. The site for the WebAPK will know that the request is
comming from a WebAPK, and doesn't redirect the url to a url which is out of the
scope of the requested WebAPK. Otherwise, the url will be loaded in a CCT on top
of the WebApkActivity.

Bug: 775605
Change-Id: I6f24ea2c13c239812d2ba1d51d4898c1cd191856
Reviewed-on: https://chromium-review.googlesource.com/723846
Commit-Queue: Xi Han <hanxi@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510122}

This adds TestVrShellDelegate, which extends VrShellDelegate and does
two things:
1. Removes the need for @VisibleForTesting annotations in
  VrShellDelegate.
2. Allows us to have test-only code for VrShellDelegate without
  affecting production code if necessary.

Bug: 775259
Change-Id: I1bb4beed2d88ba774a3fe28fa6799e0b8bee1113
Reviewed-on: https://chromium-review.googlesource.com/723769Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510121}

This eliminates a lot of the code duplication between the new and legacy
integration test frameworks by making cache-storage-test.js a small
wrapper to load the new application_test_runner modules.

This also ports a couple changes that were made in cache-storage.js
and didn't get copied over.

Bug: 667560
Change-Id: Idf2d025de175f51ab6aafb9b24bd730990cab95a
Reviewed-on: https://chromium-review.googlesource.com/726890Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510120}

The BTree leaf structure contains a length and embedded string. Check
that the length of the embedded string is not larger than node
containing the leaf.

Bug: 776307
Test: Covered by fuzzer.
Change-Id: I2c39c55b42da34bcc8cb26c481e269b66b19811d
Reviewed-on: https://chromium-review.googlesource.com/728084Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510119}

Metric reporting is in WebRTC in this CL:
https://webrtc-review.googlesource.com/c/src/+/12260

Bug: webrtc:8355
Change-Id: I8e053a456f758940f76b1660e9c515ada909719c
Reviewed-on: https://chromium-review.googlesource.com/727883Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510118}

This CL adds an interface to allow consumers to subscribe/unsubscribe
to network change events.

- mojom::NetworkChangeManager
  Listens to net::NetworkChangeNotifier and propagate notifications to
  mojom::NetworkChangeManagerClient.
  NetworkService will have a pointer to the impl of this interface.

- mojom::NetworkChangeManagerClient
  The implementation of this interface(content::NetworkConnectionTracker)
  receives notifications from mojom::NetworkChangeManager, and then sends
  those down to its observers.

Design doc:
https://docs.google.com/document/d/1kBp_vTIH-1Jx4M9DN7mnqRRyUmeHe3BZ1NqTbsJ4_S8/edit

Bug: 754709
Change-Id: Ia98dc41da9bb618fd00adfd6412d70d839cd13bb
Reviewed-on: https://chromium-review.googlesource.com/644352
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510117}

The new backend reuses most of ALSA backend. There are two parts that
are different:
 - Added new AudioOutputStreamFuchsia to be used instead of
   AudioOutputStreamAlsa.
 - Added stub for SystemVolumeControl.

Bug: 772488
Change-Id: Icacb070323f30c3d7e6a50bd1f5cf5a58c4251f9
Reviewed-on: https://chromium-review.googlesource.com/722323
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510116}

Step 1 of ye ol' 7 step plan:
https://chromium-review.googlesource.com/c/chromium/src/+/726314#message-4899c168cc8c4d3ec18d1442a7697fe9645ee185

Bug: 758256
Change-Id: I1002527dae80f0af3ac670914bf0c8b4d1dab6d9
Reviewed-on: https://chromium-review.googlesource.com/727140Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510115}

Change-Id: Ic70101aa4d68e82dd77aaaa85a20dae95be39a08
Reviewed-on: https://chromium-review.googlesource.com/725820Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510114}

We get utility process crashes on Windows (via Crashpad) but we
don't get them on Linux or Chrome OS (via Breakpad). Enable breakpad
for utility processes as well.

utility process, see crash uploader logging its upload attempt

Bug: 776022
Test: run chrome --enable-crash-reporting-for-testing and crash the
Change-Id: Iaaec05ab856bb1c2515e0798a7c2caf6adacc5d3
Reviewed-on: https://chromium-review.googlesource.com/726852Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510113}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/17c3128d..ae262c24

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Iee0a4358765c7ec483cb0262bf82c1cf1b631ac8
Reviewed-on: https://chromium-review.googlesource.com/728179Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510112}

If owning a tpm was interrupted after TpmCanAttemptOwnership was
issued but before the tpm was owned, the tpm could forever remain
uninitialized. Re-issue the command on each boot if cryptohomed
does not report that the tpm is ready to make sure the signal is
not missed. The command is relatively cheap in any case - it launches
an async thread that checks if all initializations are done, and
performs only the missing stages.

R=alemate@chromium.org

Bug: b/66923649
Change-Id: I3be0c4c8ee8fd2c21ddab930346c1a1deb069135
Reviewed-on: https://chromium-review.googlesource.com/688763Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrey Pronin <apronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510111}

When trying to send a platform handle represented as a file descriptor
cross-process on Fuchsia, we attempt to transfer the FD in-place which
is more efficient than the usual clone + send + close pattern. In some
cases the transfer operation fails, however, so we have to make a fresh
clone to transfer.

This is a re-land of jamesr@'s original fix (
https://chromium-review.googlesource.com/c/chromium/src/+/727027) with
a correction to the checking of the transfer() & clone() results.

Bug: 776163, 776242
Change-Id: Ie06a8e2e9d914b74fbc0002b32ab4fbfaa936f48
Reviewed-on: https://chromium-review.googlesource.com/727257Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510110}

This CL makes ManagedDisplayMode copyable and not ref-counted
-- this ref-counted-ness was probably so to allow for two
find-like methods of DisplayManager to encode in the return value
the found-or-not; this CL changed those two signatures in
DisplayManager to return a boolean and take an argument:

bool GetActiveModeForDisplayId(int64_t display_id,
                               ManagedDisplayMode* mode)
bool GetSelectedModeForDisplayId(int64_t display_id,
                                 ManagedDisplayMode* mode)

The rest is just a lot of updating all call sites.

No new functionality is intended.

Sizeof(ManagedDisplayMode)= 28B with ref count, 24B w/o

Bug: 771345
Change-Id: I975635db2a0709389a29c3350da32d846a9fe8ef
Reviewed-on: https://chromium-review.googlesource.com/719996Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510109}

Added support for squashing layers and threaded scrolling layers.

BUG=771643

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iab0ecf45816be33c2a69d743a8cbd13689234402
Reviewed-on: https://chromium-review.googlesource.com/724187Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510108}

This test expectations file was missed in r509907 because it is not run
during the CQ.

TBR=timvolodine@chromium.org

Bug: 776341
Change-Id: Ifa0adf443f331cfc76ac1e4a026c3fd921c7227a
Reviewed-on: https://chromium-review.googlesource.com/728342Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510107}

Bug: 640116
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I58306d25a385a75275bb06d1c2bea45160823b17
Reviewed-on: https://chromium-review.googlesource.com/722072Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510106}

This change ensures that the ARC user preference for SMS Connect is false
if the feature flag is disabled, and the user-set preference (default: true)
when the feature flag is enabled.

Bug: 718617
Change-Id: I8389cf0082b29c3356d760acf44c83d8b8cf0848
Reviewed-on: https://chromium-review.googlesource.com/726322Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: John Heroy <jheroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510105}

The test was broken because of changed layer tree dump format.
Updated according to the current format and composited scrolling
behavior.

Bug: 639427
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de
Reviewed-on: https://chromium-review.googlesource.com/726974Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510104}

WTF::RefPtr used to have a scoped_refptr, but RefPtr is an alias of
scoped_refptr now. This updates the member access in the pretty printer
to fix the WTF::String printing.
Also, this CL drops OwnPtr and RefPtr pretty printer that are no longer
needed.

Bug: 763844
Change-Id: Ifb9418d6f5487a4ebc97c2c7b6c0b563746299a7
Reviewed-on: https://chromium-review.googlesource.com/727781Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510103}

We do not need the feature any more since the experiment of not
compositing small scrollers is done. See crbug.com/684631.

Bug: 775643
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f0d6c82ffd4d3813630b74ed20f4d44d7fd166f
Reviewed-on: https://chromium-review.googlesource.com/723982Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510102}

On iOS 11 WKWebView does not repaint after crash and reload. Recreating
web view fixes the issue.

It seems like the problem is not reproducible if web view scroll view
remain in the default position, but it's impossible to check if web view
was scrolled once the renderer has crashed. Recreating web view should
not have visible performance implications, so it will be more reliable to
purge it unconditionally if renderer has crashed.

Bug: 770914
Change-Id: I84feede9e54e4371aaf36b47db0fc9878e7518a9
Reviewed-on: https://chromium-review.googlesource.com/727401
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510101}

Bug: 760556
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5a892956e3b3247d1c01d42f1c6a04bb4a9ec8b1
Reviewed-on: https://chromium-review.googlesource.com/727023Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510100}

Inspecting the code revealed that ContextualSearchController -panel
property was never set, and that the delegate passed to initializer
was always a mock with no method mocked.

It follows that _panelView, _searchResultView and _headerView are
always nil, and the delegate method always returned default value
and were doing nothing. Remove all code that can be proved to be
dead based on those observation and the fact that calling a method
on nil received does nothing and return the default value for the
method selector.

Bug: 775332
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9fbd18c97e1f19f91384bb54d3102e2509f4ccb0
Reviewed-on: https://chromium-review.googlesource.com/727472Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510099}

The spec suggests showing a broken image icon when and <img> element
has an alt text attribute but no src attribute. To avoid this, we
set the alt text only when we set the src of the img element.

BUG=773985
TEST=manual

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3884e736a8a7b0e3fa40ea483882d20916a81a00
Reviewed-on: https://chromium-review.googlesource.com/727107Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510098}

IsLabelValid checks if an inferred label is valid or not.
A valid label does not contain only special characters.
Special characters are " *:-()\u2013" as defined in
FormOrFieldsetsToFormData in form_autofill_util.cc.

Bug: 762970
Change-Id: Id44b9efc2500de638c54336ac589c68127d33be9
Reviewed-on: https://chromium-review.googlesource.com/722699
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510097}

Bug: 775895
Change-Id: I1c1c59425bea8a8690b8e8706a4e0c7ce96033bf
Reviewed-on: https://chromium-review.googlesource.com/727196Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510096}