- 27 Sep, 2018 40 commits
-
-
erikchen authored
X events have a timestamp which is only well defined relative to the X11 Server time. The previous computation for timestamp for X11 events was making the assumption that Server time and Chrome time were the same. This assumption is not always true -- this is likely the root cause of "bad" timestamps observed in https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 This CL changes event timestamp computation to make a roundtrip to the X11 Server to get an accurate base::TimeTicks. This logic was lifted out of the responsiveness calculator, which was already doing this computation. The latter will subsequently be changed to use the computation in this CL. Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1249383Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594844}
-
Jao-ke Chin-Lee authored
BUG=790343 Change-Id: Ifb62914414b09eed794387ab5073fc973532f162 Reviewed-on: https://chromium-review.googlesource.com/1249807Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#594843}
-
Ryan Cui authored
Bug: 888188 Change-Id: I9056c918ceda50d5c50d7dfbadef5c22f7e80d34 Reviewed-on: https://chromium-review.googlesource.com/1246948Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594842}
-
Donn Denman authored
When Contextual Search selects a word in response to tap there's a potential race condition between two messages in the SelectionClient interface: onSelectionChanged and selectWordAroundCaretAck. In cases where the Ack is called first the selection controller doesn't have a valid word and asserts. This change extracts the word from the surrounding text and updates the selection controller to ensure that it knows about the selected word. BUG=889657 Change-Id: Ifbc65d199b179df31fed65ae4b0b06dc13cf6213 Reviewed-on: https://chromium-review.googlesource.com/1248021Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594841}
-
Jonathan Metzman authored
Since we can't rely on no_sanitize attributes on Windows, use the gn configs to ensure LF isn't instrumented with ASAN. This fix is hopefully temporary, ideally we can get clang-cl to respect the no_sanitize attribute. Bug: 883948 Change-Id: Ia4854d5f5b9148d175fa2f5f90bd9b34f064e064 Reviewed-on: https://chromium-review.googlesource.com/1249150Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594840}
-
David Trainor authored
Add a separate asynchronous loading view for downloads and integrate it into the image class. This includes the following view classes for downloads home: - AsyncImageView - SquareAsyncImageView - ForegroundRoundedCornerImageView Each of these will be used for different components in the future downloads home UI. BUG=868554 Change-Id: I1b5afbaba85be701e607f1f97ae705b4ae83095d Reviewed-on: https://chromium-review.googlesource.com/1240507Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#594839}
-
Devlin Cronin authored
Add a unittest to verify that permissions.contains() and permissions.getAll() correctly return the current permissions for an extension, even if it's affected by the runtime host permissions feature. Bug: 889654 Change-Id: I1ec42ed12208647cbee5784e4908a196e4b69994 Reviewed-on: https://chromium-review.googlesource.com/1247226Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594838}
-
Chris Harrelson authored
This improves BGPT testing, and slims GraphicsLayer a bit. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77d5108dd2309de33a52ca90e3592c2d22ea28a0 Reviewed-on: https://chromium-review.googlesource.com/1247037 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594837}
-
Yue Li authored
Added histograms for: - Assistant Service start time - Get settings request time - Count number of timout triggers Also update the timeout to 15s. Bug: b/116466382 Test: Manual Test Change-Id: I0bf23962e28b61cb08970d11e47b702eb1c721f9 Reviewed-on: https://chromium-review.googlesource.com/1246664Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Sebastien Seguin-Gagnon authored
The issue here was the autocomplete feature, not autofill. Autocomplete is disabled when the attribute is set to off. Bug: 869516 Change-Id: Ib18953ed5e147cf6bab87b2c389ac75e83be13cd Reviewed-on: https://chromium-review.googlesource.com/1249506 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#594835}
-
Randy Rossi authored
This CL moves common logic between chrome & chromecast into a common ui/views class. Chrome/Chromecast specific logic differences are handled in a delegate class. Name/scope of this delegate may change as we refactor move duplicate code out. Part of an on going effort to eliminate duplicate code introduced when automation API was added to Chromecast. Test: Manual verification on chromecast (estelle) and chromeos (tidus) Bug: 837773 Change-Id: Ia73513b09550d089daf09c89dd1fdda11bcacd4a Reviewed-on: https://chromium-review.googlesource.com/1234363Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594834}
-
John Chen authored
Getting size of full screen window now works correctly on all desktop platforms. Re-enable Python-based ChromeDriverTest.testWindowFullScreen. Bug: chromedriver:1945 Change-Id: I57a4b4003b37d174a8a9a5573453fd861845b948 Reviewed-on: https://chromium-review.googlesource.com/1249831Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594833}
-
Peter Wen authored
Switch stability proto's renderer crash count to include all renderer crashes that result in a minidump rather than just foreground. Pros: - Align renderer crash counting with GPU crash counting - Closer alignment with crashes that are uploaded - Every crash resulting in a minidump is a candidate to be uploaded - Background renderer crashes are real crashes and should be fixed Cons: - Foreground renderer crashes are certain to cause a bad user experience while background crashes do not necessarily do so. We are testing this out and keeping the rest of the crash pipeline the same so that we can continue to compare old vs new metrics. If it does not result in poor prioritization, this change will stick. Full context: http://g/clank-crash/hZJyq3PJC3g Bug: 839017 Change-Id: Iab8d6bdae993fbe3d41932719b9cecc5a6c450b8 Reviewed-on: https://chromium-review.googlesource.com/1246462Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Ryan Sturm authored
This CL adds logic to dismiss the heavy page capping InfoBar after 8 seconds of no requests being finished on the page. The actual time is field trial configurable. This also adds a browser test to check this behavior. Bug: 888817 Change-Id: I7332918b4590f2f8cd70db365af8dce60f26956c Reviewed-on: https://chromium-review.googlesource.com/1242173Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#594831}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4e651334d46b..7a4e890f252c git log 4e651334d46b..7a4e890f252c --date=short --no-merges --format='%ad %ae %s' 2018-09-27 simonhatch@chromium.org Re-enable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2 Created with: gclient setdep -r src/third_party/catapult@7a4e890f252c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:888947 TBR=sullivan@chromium.org Change-Id: I122717fbc2aebcff1d1d190b2a75049b420c2d07 Reviewed-on: https://chromium-review.googlesource.com/1249634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594830}
-
Lei Zhang authored
Change-Id: I6b5262ccf903b69dbf3e0a5c937e38a0c9b2e886 Reviewed-on: https://chromium-review.googlesource.com/1244879Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594829}
-
Yuriy Taraday authored
According to manual, it must be either NULL or pointer to an extension-specific structure. Also GCC barks on skipping fields in initialisers (8 times as 8 fields follow skipped pNext): ../../gpu/vulkan/vulkan_swap_chain.cc:94:3: sorry, unimplemented: non-trivial designated initializers not supported Change-Id: I744b9dc84c24b927ec1172f4044f9ca7fbf64029 Reviewed-on: https://chromium-review.googlesource.com/1226600Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594828}
-
Erik Chen authored
This is a source of webkit_layout_test flakiness on Windows. Bug: 889608 Change-Id: Ib31cd068620d0c1917aaa85ce2ec7038ccd4236e Reviewed-on: https://chromium-review.googlesource.com/1249385 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594827}
-
Gemene Narcis authored
This CL introduces a few improvements to HttpCredentialCleaner: (1) A fix in removing the protocol from signon_realm, (2) refactoring the unittest to use parameters, (3) minor style fixes. More details about (1): HttpCredentialCleaner removes the protocol (HTTP or HTTPS) form the signon_realm in order to compare the signon_realm of HTTP credentials with the signon_realm of HTTPS credentials. Until now, a GURL was created from the signon_realm of the form and then the protocol was extracted from that GURL, resulting the signon_realm excluding protocol. This can cause problems when the auth realm contains characters that are forbidden in an url. This will lead in creating an invalid url, and the resulting signon_realm with protocol exluded will be an empty string. This CL will avoid conversion from the signon_realm string to the GURL and use other way to remove the protocol from the signon_realm. More details about (2): Unitests for this class were changed from one single test into a bunch of parametrised tests in order to make debug easier in case of failing test in the future. Bug: 871140 Change-Id: Ic606d250f50806ae3a3fa07a480fcb01f5551c97 Reviewed-on: https://chromium-review.googlesource.com/1249104 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74a2dc070e4e..b15eae0a955c Created with: gclient setdep -r src-internal@b15eae0a955c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0df584d7e8c24ef676c34f8573b2bb6ff688eb65 Reviewed-on: https://chromium-review.googlesource.com/1249635Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594825}
-
Mike Wasserman authored
Partial revert of https://codereview.chromium.org/1918183003 PointerWatcher is no longer needed with Ash hosting the Window Service. Bug: 872450 Test: No regressions with clicks inside/outside system tray bubbles. Change-Id: I987ee0aab77cd2c0efcd1106c7c30e0663349654 Reviewed-on: https://chromium-review.googlesource.com/1249902Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#594824}
-
Peter Kotwicz authored
This CL renames the HostBrowserLauncherParams getter methods to have the HostBrowserLauncherParams#getStartUrl() format instead of the HostBrowserLauncherParams#startUrl() format. BUG=None Change-Id: I29f76346bfe80198711488a047e41833655595cf Reviewed-on: https://chromium-review.googlesource.com/1244363 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594823}
-
Martin Kreichgauer authored
Splitting this off from the implementation so we can submit strings earlier. Bug: 879548 Change-Id: I180391d203f1fcd98a04f42a89373eb42b33341f Reviewed-on: https://chromium-review.googlesource.com/1246821 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#594822}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/227d4e10276c..dbdd151b1cb9 git log 227d4e10276c..dbdd151b1cb9 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 benjaminwagner@google.com Revert "bump NDK packages to r18" 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4241ad731a8a..40a6005e7a14 (3 commits) 2018-09-27 brianosman@google.com Remove redundant SkImage virtuals 2018-09-27 brianosman@google.com Revert "Reland "Implement an explicit binary search-based analytic gradient colorizer"" 2018-09-27 bsalomon@google.com Revert "Change how GrTextureOp computes outset vertices." 2018-09-27 mtklein@google.com only build stats bar chart when it'll be printed 2018-09-27 fmalita@chromium.org [skottie] External font loader tweaks 2018-09-27 michaelludwig@google.com Reland "Implement an explicit binary search-based analytic gradient colorizer" 2018-09-27 mtklein@google.com bump NDK packages to r18 2018-09-27 mtklein@google.com add test that setLastPt() invalidates path bounds 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 115e8a2625f5..122919bddd98 (1 commits) 2018-09-27 mtklein@google.com invalidate pathref bounds when we attach an editor 2018-09-27 mtklein@google.com update SkPathRef bounds validation 2018-09-27 ethannicholas@google.com fixed SPIR-V interface variable declarations 2018-09-27 bsalomon@google.com Change how GrTextureOp computes outset vertices. Created with: gclient setdep -r src/third_party/skia@dbdd151b1cb9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254,chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254 TBR=bsalomon@chromium.org Change-Id: I01c18efde9921a36f3185d80d3950f46ff3e73ce Reviewed-on: https://chromium-review.googlesource.com/1249507Reviewed-by:
-
manuk authored
[about-omnibox] Performance refactoring of omnibox.js: split refresh method, extract inlined dom elements, and improved html output clearing. 1. Split `refresh` into `refreshAllResults` and `refreshNewResult` for performance reasons as explained in the comments (tldr, refreshing entire output is unnecessary when we only need to add to the output). 2. Extract variables for inlined expressions to retrieve document elements. 3. Use `Element.removeChild` instead of `Element.innerHTML = ` to clear output Change-Id: Ia7085d97537c5f445c950ecb50f35e5880b6124a Reviewed-on: https://chromium-review.googlesource.com/1246295 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#594820}
-
Thomas Tangl authored
The text of the accept button on the welcome page is changed from "Sign in" to "Turn on sync...". Screenshot: https://drive.google.com/file/d/1dFMRqbKazetzouP8MzScMG_lTk5vrd2G/view?usp=sharing Bug: 889949 Change-Id: I5053b940af365da5a59d434227fa54468919187e Reviewed-on: https://chromium-review.googlesource.com/1249272Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#594819}
-
erikchen authored
Change-Id: Ie364d434a3b4976ba74251c453e117d1e65c3d98 Reviewed-on: https://chromium-review.googlesource.com/1246864Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594818}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/122919bddd98..beb0c946de6d git log 122919bddd98..beb0c946de6d --date=short --no-merges --format='%ad %ae %s' 2018-09-27 geofflang@chromium.org Vulkan: Make sure the default uniform info arrays match indices. Created with: gclient setdep -r src/third_party/angle@beb0c946de6d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I8f18ddc41d556ba4f90e3cd7a4da02ed79445934 Reviewed-on: https://chromium-review.googlesource.com/1249508Reviewed-by:
-
Alexey Kozyatinskiy authored
We can not replace it with our regular void (a = ...) here, so let's just ignore it. R=lushnikov@chromium.org Bug: chromium:805249 Change-Id: I859ca107a15a0284a7c6a2ed0e32fe0c11d4734f Reviewed-on: https://chromium-review.googlesource.com/1249539 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#594816}
-
David Tseng authored
ChromeVox's expectations with regard to tab switch recovery have changed. Namely: - selection events appear to be fired unexpectedly on tabs at various points - ChromeVox range is no longer over the root web area when a hit test result comes back even when we do want to recover This change adjusts accordingly to TOT and adds tests for both tab switching and refresh recovery to ensure we don't regress again. Bug: 887185 Change-Id: I3081830457fb62c14456368a819b00765659a824 Reviewed-on: https://chromium-review.googlesource.com/1246366Reviewed-by:
-
Joel Einbinder authored
Bug: 872438 Change-Id: I72790fccc75bc4ac0bdf457cbb960a53019ab974 Reviewed-on: https://chromium-review.googlesource.com/1182614Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#594814}
-
Oksana Zhuravlova authored
This change adds examples for can_connect_to_other_services_with_any_instance_name and can_create_other_service_instances options, as well as capability specs. Bug: 866967 Change-Id: Iae17a8514a1a3be44b890a4c296a57085302174d Reviewed-on: https://chromium-review.googlesource.com/1244823 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594813}
-
Cathy Li authored
Context menu actions were added by https://chromium-review.googlesource.com/c/chromium/src/+/1242295 Bug: 867488 Change-Id: I2a83800e985dd7b62402f049cf9b0707c04e0b7a Reviewed-on: https://chromium-review.googlesource.com/1248126 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594812}
-
edchin authored
Previously, WKWebView snapshots were defaulting to the size of the web view, rather than the visible frame size. This caused the snapshot to look out of place when animating. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I533f570c996320ab9ae1d33cffe05a63303f7f36 Reviewed-on: https://chromium-review.googlesource.com/1247881 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594811}
-
Brian Salomon authored
Allows https://skia-review.googlesource.com/c/skia/+/154501 to land. Bug: skia:8262 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic1a9a6753814a5e6dbdfd057f6a96dbcb152e3b6 Reviewed-on: https://chromium-review.googlesource.com/1224660Reviewed-by:
-
Raymond Toy authored
This virtual method is not needed. The derived classes don't all support this method, and indeed it is invalid for an OfflineAudioContext because the offline context requires a time argument. Bug: 889694 Test: internal change Change-Id: I9ee9aa6279693f90b4a91bfa34f3f584e5f3654d Reviewed-on: https://chromium-review.googlesource.com/1247683Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594809}
-
Mathias Carlen authored
Before this patch, the client and server protos differed in the precondition field numbering. This resulted in fields being empty. This patch fixes that. After this patch, preconditions have properly populated fields after parsing. R=rouslan@chromium.org Bug: 806868 Change-Id: Iec4dcfe6ad9668394a9b16b11719f185dd259e47 Reviewed-on: https://chromium-review.googlesource.com/1249208Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594808}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eea0489c. With Chromium commits locally applied on WPT: 16f78349 "Move target-in-different-window.html into wpt/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25392 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I774d9e8d0121856b060462ed10c7966746e395f5 Reviewed-on: https://chromium-review.googlesource.com/1249525 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594807}
-
Jakub Pawlowski authored
Change-Id: Ia6b77632aab5df842c8878fba6fc96bf405a28de Reviewed-on: https://chromium-review.googlesource.com/1249488Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594806}
-
David Bertoni authored
Bug: 827288 Change-Id: Ic500608906e7c7c428e3042c5ffcf29f31899beb Reviewed-on: https://chromium-review.googlesource.com/1207576 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594805}
-
