- 13 Nov, 2020 40 commits
-
-
Nate Fischer authored
This reverts commit 6d24e357. Reason for revert: launcher icons cause problems for work profile (crbug/1148909) Original change's description: > [AW][Dev-UI] always include icon resource > > Standalone & Trichrome WebView now unconditionally includes > LauncherActivity (defined in DeveloperUiLauncherManifest), and > conditionally set the enabled state to true/false based on GN args > (webview_devui_show_icon, which is configured by android_channel). > > This is a step toward resolving https://crbug.com/1047824, although this > is not a complete solution since this doesn't change the monochrome > behavior. > > Fixed: 1140741 > Bug: 1047824 > Test: aapt dump xmltree TrichromeWebViewGoogle.apk AndroidManifest.xml | grep -A 2 'LauncherActivity' > Test: Same for TrichromeWebViewGoogleBeta, TrichromeWebViewGoogleStable, SystemWebViewGoogle, SystemWebView > Test: adb shell pm enable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity > Test: adb shell pm disable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity > Change-Id: Id996965643a6fea31a34ebe39fb5b2b8ac5f5c0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500435 > Reviewed-by: Hazem Ashmawy <hazems@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Auto-Submit: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822231} TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047824 Bug: 1148909 Bug: b/173091361 Change-Id: Ibf176cb5daaaf27063d9f5bacc5cfb86eb49f5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538153 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827414}
-
Daniel Hosseinian authored
operator<() needs to be overloaded so base::GUID can be used in set containers. Per the style guide, overload all other comparison operators. Bug: 1026195 Change-Id: I9c36f0aee13b34c3bbdfdc3581a84a9c23485e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533649 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#827413}
-
W. James MacLean authored
Add information to the DwoC output to help determine if this is a start- up or shut-down issue. Bug: 1148542 Change-Id: I3ecf8db05beb6b94a7489389fdbdcf9e4694607c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537576 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827412}
-
Rakib M. Hasan authored
This skew test will updated daily by uploading new CIPD packages for each tag created in the M88 branch. The m88 reference will point to the most recent package uploaded. Bug: 1147459, 1147455, 1099017, 1041619 Change-Id: Ib9ae51d2a7379d478cbab68a334c7d2488bf0e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538152 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827411}
-
Adithya Srinivasan authored
This reverts commit 55c31ae8. Reason for revert: Supect this is causing ARC failures in chrome_all_tast_tests (https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11172) Original change's description: > Add desktop focus state change event > > This change add a new event for desktop window focus state change. > With this change, ARC can have different behavior when Chrome window > or ChromeOS desktop get activated. > > BUG=b:171450038 > TEST=Active different window between Chrome/ARC and logcat events > > Change-Id: I11cee5d5279ad12524092518cadd05fff67bab72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519686 > Commit-Queue: Shengsong Tan <sstan@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827122} TBR=oshima@chromium.org,sstan@google.com Change-Id: I20b7407b417b3d54fb6b29dfb08de640592f1b21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:171450038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538115Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827410}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4543697b3755..c4ad6062fd17 2020-11-13 perkj@webrtc.org Ensure EncoderSink::OnBitrateAllocationUpdated not called after Stop If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143311 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic269443757e2e7ee9b5b2dc2a950a1123ded4465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827409}
-
dpapad authored
Before this CL, the only way to include generated files in a generated grd file was to use |manifest_files| as input to generated_grd(), forcing us to use preprocess_grit() even when not necessary. With this CL, |input_files| can hold generated files directly. Bug: 1132403 Change-Id: I6f71458387b3c3cb2284019787f8836326c31b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537595 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827408}
-
Alexander Cooper authored
The OT infrastrucutre requires a single UseCounter to measure. This adds a use counter for RequestLightProbe, which must be gotten before either of the other Light Estimation API methods can be used. Bug: 1148871 Change-Id: Ic9ac4b81fca1460497d4ff0753b7ceadcb982dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538132 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#827407}
-
Scott Little authored
This test is flaky on multiple platforms, so I'm disabling this test. Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42845 TBR=ryansturm@chromium.org,adithyas@chromium.org Bug: 994068 Change-Id: I1ca4f95ea9388e9eb7cb5184d0e821ee242ea91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537937Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827406}
-
Gil Dekel authored
This CL removes a TODO that was added for debugging purposes. The bug this TODO is associated with is now solved and the solution confirmed. Bug: 1105919 Change-Id: I724e18850c3f5c79cbde93e1be31745543680d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538114Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827405}
-
Richard Knoll authored
We're planning to remove support for options when switching from GCM to FCM and this API was the only user of this field. Unexpiring it so we can have fresh metrics (the old data showed 0 usage). Bug: 1148321 Change-Id: I223e80ba0e6e88d3e4344377aec988e1488f954d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534832Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#827404}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I745bb2f15263ca47394f655df57a8e08b7855243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537111Reviewed-by:
-
Ian Kilpatrick authored
Change: https://chromium-review.googlesource.com/c/chromium/src/+/2424899 ... introdcued a fix for freeze more consistent scrollbars for arbitrary descendants of flex layout. However the original code (detected direct descendant scrollbar changes) contained an issue that it would also freeze scrollbars for any OOF positioned children. There exists a wider issue which I've detailed here: https://bugs.chromium.org/p/chromium/issues/detail?id=1148835 But it's relative rare. The fix for this specific regression is to unfreeze the scrollbars before running the OOF layout part. Bug: 1148288 Change-Id: I74be0bf141d13988548d38412e912c8c98d628b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538041Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#827402}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1093185 Change-Id: I30ebb200d5269767b5166a6d66d5577bde6b4cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527689 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827401}
-
Nate Chapin authored
Bug: 1147612 Change-Id: I52ce20f6446c813bd7f51ba8f051930590a0add4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529702 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#827400}
-
Trent Begin authored
This enum represents a routine state where the routine was not run because it is not currently applicatble to the device. e.g. Secure WiFi test when the device is not connected to WiFi. Bug: b:173063870 Change-Id: I0899c284fc51f3878e468e3aff1b6fadbf6ae7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537776Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827399}
-
Eric Lawrence authored
Several enterprises would like a Policy that will prevent the use of the HTTP basic auth scheme over non-secure HTTP. This CL adds such a policy. Bug: 1025002 Change-Id: I1fb10a97cb5edcc953c5e26d8e1c1ad8befb595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527850 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827398}
-
Kelvin Jiang authored
"The associated user script. Owned by the UserScriptInjector that created this object." ^Should be UserScriptSet. Bug: NONE Change-Id: I5a080c33b74a22b8af3b824234a0a89aff8fa9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537410Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827397}
-
Ahmed Mehfooz authored
We need to use opaque colors to make sure the stroke on the outside of the icon doesn't look like it's overlapping with the background color. Bug: 1117581 Change-Id: Id33595d5250327cf07c97f4b737fec7d6785e6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533846 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1f7a8206536e..be466dc7ac2c 2020-11-13 aerotwist@chromium.org [eslint] Change es_modules_import rule to also check unit test files 2020-11-13 patrick.brosset@microsoft.com Flex: Draw correct separators around flex lines and items 2020-11-13 aerotwist@chromium.org [unit type] Update ValueType 2020-11-13 petermarshall@chromium.org tests: Add final changes for parallel e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101784,chromium:1139949,chromium:1148296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3686edebcbc805a70aa8cd5053ce690b68153a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537176Reviewed-by:
-
Xi Han authored
StartSurfaceTest#testShow_SingleAsHomepage{V2}_VoiceSearchButtonShown__Instant_Return are failed/flaky on M/L bots. The failing tests are due to the check of the voice_search_button is too soon. Adding more events to wait. Bug: 1148352 Change-Id: If6780547a089295a47634a3c1489bd77b2496bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533545Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827394}
-
Trevor Perrier authored
This CL disables the test: - TranslateManagerBrowserTest.PageLanguageDetectionConflict It was reported as flaky and appears to timeout the first time it is run but succeed the second. Bug: 1148703 Change-Id: I2e14df16d8b42fc6acab49212adf5020d426b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538093 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
Drops a couple obsolete TODOs which previously tracked changing EncodedAudioChunk and EncodedVideoChunk to IDL dictionary types. This doesn't preclude adding parallel dictionary types that the APIs can consume later, if needed. For the MSE case, keeping them as non-IDL dictionaries retains the current ability for the bindings generator to precisely disambiguate them (for example in matching to an overload or union). This CL intends to increase certainty that that disambiguation capability will remain; otherwise new API shapes depending on it might need to change. Note that keeping them as non-dictionary types is nice for webcodecs; it better retains their immutability and enables potential for reduced/zero-copy scenarios (sandersd@ mentioned this, along with mentioning improved implementation control over behavior like construction and transferring). BUG=1144908 Change-Id: Ib9fb6bcd50b6fe2900908c3380b75b798c71b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535735Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827392}
-
Etienne Bergeron authored
This reverts commit 4718f57e. Reason for revert: Study is over Original change's description: > Add detailed memory dump provider URLIndexPrivateData > > This CL is adding the code to dump memory usage for inner-structures > used by URLIndexPrivateData. > > The purpose of this CL is to estimate the size/count of the pathological > cases and to see which inner strucutures required limits. > > NOTE: This CL need to be reverted before the M88 branch point on Nov 12. > > Bug: 1068883 > Change-Id: I5c4709d7ce7b634aa2ccf5b40bc19d6bff2e77eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504278 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822249} TBR=tommycli@chromium.org,jdonnelly@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068883 Change-Id: I8b7523bf4cbda4d0fc92cd3d8e18b00fcca0d828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537137Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827391}
-
Pavol Marko authored
In onc to shill translation, set IPAddressConfigType and NameServersConfigType to "DHCP" in the resulting ONC data if no value is provided by shill. The default of "DHCP" is consistent with go/onc and with shill behavior. This is important so that these values always have a value when policy decoration happens (the shill -> onc translated ONC is an input to policy_util::CreateManagedONC invoked in ManagedNetworkConfigurationHandlerImpl). The UI can then depend on these always having an ActiveValue, so cros_network_config.mojom has been changed to set the corresponding {ip_address,name_servers}_config_type fields as mandatory. Bug: 1108922, 1109660, 1109670 Test: unit tests + manual on DuT (network settings) Change-Id: I6111a3c7f6af64fac22ea33347dd17774bbda4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530330Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Salvador Guerrero authored
This CL updates the background tracing metrics provider to include antivirus data on uploaded traces, this only applies to windows traces. Bug: 1126192 Change-Id: I909bf8dbe7fe12514d707b9006dcf295f2d5a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532902 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#827389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8bf9368130b8..f1f7c370eb0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifa5e93f1c8b73ba33944473c474e19e1979a2175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538049Reviewed-by:
-
Clark DuVall authored
All major crashes have been fixed and numbers look good. M88 branch was just cut, so should be safe to enable now. Bug: 1126301 Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827387}
-
Clark DuVall authored
This reverts commit 858c31cc. Reason for revert: Forgot to update TelemetryActivity.java Original change's description: > Use weblayerStartupMetric for system_health.weblayer_startup > > The metric was split out of the WebView version, so we should use this > now for WebLayer startup tests. > > Pinpoint job running: > https://pinpoint-dot-chromeperf.appspot.com/job/104b30a9520000 > > Bug: 1146438 > Change-Id: I9938614b94740a3222fb832ab994427b136bf1d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536797 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827339} TBR=johnchen@chromium.org,cduvall@chromium.org Change-Id: Ib36049acdd6f285f2c7f6760a8a951816c23e120 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536844Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827386}
-
Evan Stade authored
I couldn't reproduce or understand the flakiness, but hopefully rewriting the test to use TestWebLayer#crashTab instead of navigating to chrome://crash will resolve the problem. FWIW, in the old version of the test, the navigation itself seemed to fail, in that the post-test screenshot still showed about:blank in the url bar. Bug: 1143788 Change-Id: I35cbca4368f7215fd173692c1d2a24ed34fe8e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535218Reviewed-by:
-
Matt Jones authored
This patch checks if the grid is showing for the top toolbar's overlay as the visual logic in that class is for the stack. This should be a temporary measure until each layout has its own type. Bug: 1147801 Change-Id: I2a61c992febe6307c64ea3a9462fce955a7c9027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535811Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827384}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605268075-beb915b3939660700cb86662fda8b7247e8e8c87.profdata to chrome-linux-master-1605290311-c0a8bccef266e50cf7d2fe9fae22d951549688a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I75c3ee90f996a4ddb3025f97b58cc8f0c1edd7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537293Reviewed-by:
-
Ted Meyer authored
Cleaning up the field trial config here: cl/341906454 Change-Id: I8082c282de63c441e5c6c8e3875f365b1f295571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535628Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#827382}
-
adoneria authored
Until the test framework is stable, run it on updater specific builders and testers. Bug: 1147588 Change-Id: Id12ce00b509b311de575103b3a3dbebc8f890c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535911Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827381}
-
Alexander Cooper authored
The XRWebGLBinding is defined in the WebXR Layers spec (https://immersive-web.github.io/layers/); however, it is also required by both the Lighting Estimation and Raw Camera Access specs. We are not actively working on the layers spec; however, we want to Origin Trial both Lighting Estimationa nd Raw Camera Access. This change simplifies these cross-spec dependencies by shipping the empty XRWebGLBinding interface. I2S: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/6J0yfRuMmSU Bug: 1070819 Change-Id: I8626fa854d892171542cec06a0befac76187fd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519938 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827380}
-
Filip Gorski authored
Moves OSDDelegate into OmniboxSuggestionsDropdown (patchset 1) and flattens things out to a single class (patchset 2). Bug: 1075602 Change-Id: I71322c03538879ba1bac587f24c590f28813e14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530954Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827379}
-
Leonard Grey authored
Adds commands for opening bookmarks: - A composite command labeled "Open Bookmarks..." that allows searching bookmarks when selected. - If user input is "long enough" (currently two characters, will be tuned), "noun first" bookmarks will begin to surface at top level. Bug: 1014639 Change-Id: I910e9ba4992e7705cce2f8c5e23104c8ba6f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535677Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827378}
-
Mason Freed authored
The getInnerHTML API is relatively new, and was not added to the ShadowRoot object. This CL fixes that gap, and adds testing for both getInnerHTML and setInnerHTML on ShadowRoot. Bug: 1042130 Change-Id: Ibae20d7c0e9f44b92932499234e493ba798e06b0 Fixed: 1147752 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536372 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#827377}
-
Roman Arora authored
Reverting the use of afterNextRender in favor for setTimeout causing the Tab Search bubble to not show consistently on Mac. Bug: 1148767 Change-Id: I69157b7b9c7eabbe9e73d36f177f226fdb31c795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537921Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#827376}
-
Gayane Petrosyan authored
1. Reset range counters when new generation is requested. 2. Use ranges when selection starts and ends in the same block which has nested block 3. Fix crash when selection starts or ends with a non text node which has children. Crash is because using length of text content to find last position is incorrect when there are nested children. We should use Position::LastPositionInNode(*node) instead. Bug: 1129650 Change-Id: I13e305f67c28aca7643903f96e258be8fbf8e9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533123 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827375}
-
