- 07 Dec, 2018 40 commits
-
-
Xianzhu Wang authored
The suite is not applicable on these bots. Change-Id: I79d0494d8173d0bcd00a54c6339578506d452ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1368447Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614812}
-
Tomasz Wiszkowski authored
This CL corrects copyright details introduced by 1366780 Change-Id: I8bf73a39a2ca85c45d440d8b4e0c266c1a00e2ed Bug: 871798 Change-Id: I238bc06fd279f5dd0721cd28d16d36f47ee9e92f Reviewed-on: https://chromium-review.googlesource.com/c/1368001Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#614811}
-
Roger Tawa authored
Bug: 912163 Change-Id: Ic01fb78367762b6bddb41c29e557360798b6d1d1 Reviewed-on: https://chromium-review.googlesource.com/c/1363365 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614810}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a63593a10c1b..802dce0de3fa git log a63593a10c1b..802dce0de3fa --date=short --no-merges --format='%ad %ae %s' 2018-12-07 brianosman@google.com Don't try to use NEON ASM files on Windows 2018-12-07 jvanverth@google.com Remove deprecated YUVA interface 2018-12-07 rmistry@google.com [Android compile bot] Fix path to GS file name 2018-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7c985f5c4f1a..0c2dc8c378bb (2 commits) 2018-12-07 egdaniel@google.com Add cap to number of oplists we execute before flushing to the gpu. 2018-12-07 bsalomon@google.com Deuninstantiate 2018-12-07 halcanary@google.com SkQP: document requirement to run git-sync-deps 2018-12-07 halcanary@google.com SkPDF: make_apk script: always include arches 2018-12-07 scroggo@google.com Dummy SkOrientationMarker.cpp so Chromium can compile it 2018-12-07 jvanverth@google.com Use ES3 in iOS test harness Created with: gclient setdep -r src/third_party/skia@802dce0de3fa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I9bdc68cbcc396cc02c93822ab5af243b74a8d368 Reviewed-on: https://chromium-review.googlesource.com/c/1367970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614809}
-
John Budorick authored
instead of --debug, which I initially used in crrev.com/c/1367106 Tbr: martiniss@chromium.org Bug: 912120 Change-Id: Id6ee9838fec597639ea2aaf383334eaa4acbbdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1368407Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#614808}
-
Xiaohui Chen authored
Increase the contrast for a11y. Bug: 910560 Test: locally build and run Change-Id: Iedd3fc2ffa45ca6c637afcc046ff0c35a826f9ab Reviewed-on: https://chromium-review.googlesource.com/c/1368110 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614807}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d1a238cd2311..c1279bc05ec8 git log d1a238cd2311..c1279bc05ec8 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c1279bc05ec8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3bfc08954a0e9976e579da5f4f2d8e2edecb89a0 Reviewed-on: https://chromium-review.googlesource.com/c/1367969Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d888ec76..88875214 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I25b3b15e5c82e39c97d801331fef910fda72f8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1368027Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614805}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/de797ddcb5d0..aab6f4073f7e git log de797ddcb5d0..aab6f4073f7e --date=short --no-merges --format='%ad %ae %s' 2018-12-07 stevenperron@google.com Add documentation for licm option to the spirv-opt help. (#2179) 2018-12-07 stevenperron@google.com Fix invalid OpPhi generated by merge-return. (#2172) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@aab6f4073f7e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I47d37bb50531ec8b70a05f423847048367284c84 Reviewed-on: https://chromium-review.googlesource.com/c/1368166Reviewed-by:
-
Regan Hsu authored
Since the MultiDevice API flag has been enabled, the local device data provider is no longer used. This CL removes the class and instances where it is called. Change-Id: Ibb574128b9faff3f84a19b92b8632325ab1597f2 Bug: 912743 Reviewed-on: https://chromium-review.googlesource.com/c/1366268Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614803}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92795e7e949d..1fd5da74b4c6 Created with: gclient setdep -r src-internal@1fd5da74b4c6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5a06651387052e04ebde394c06058d130b599d3a Reviewed-on: https://chromium-review.googlesource.com/c/1368205Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614802}
-
Yiming Zhou authored
Bug: 847905 Change-Id: I60bc5263467958b7b7e3d0961351829cf8a42fcb Reviewed-on: https://chromium-review.googlesource.com/c/1368278Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614801}
-
Sammie Quon authored
Originally just a 5 line change, not including tests. But saw a lot of variables with __1_ and ___2_. So decided to also refactor a bit and consolidate most of these into a class. So we only have window1_ and window2_ now. Test: ash_unittest *HomeLauncher*GestureHandler.* Bug: 912773 Change-Id: If11f35104dee91a23121f67f6ab3129c8900bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/1366880 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614800}
-
Lily Chen authored
The ReportingCache stores unsent and pending reports, as well as client configurations. Previously, observers were notified upon any change to any of the cached data. This change differentiates changes to the cached reports from changes to the cached clients, and notifies observers appropriately. This will make it easier to add a ReportingStore class which will observe the ReportingCache and persist the changed data to disk. Also renames what was originally ReportingObserver to ReportingCacheObserver to avoid confusion with the JavaScript ReportingObserver interface (https://w3c.github.io/reporting/#interface-reporting-observer). Bug: none Change-Id: I4afd530b703f04da0bcc53e8ad2d615cb4ed0238 Reviewed-on: https://chromium-review.googlesource.com/c/1362191Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#614799}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3dd4e76b19f3..d01e28f41f88 $ git log 3dd4e76b1..d01e28f41 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 apodtele Important doc fix. 2018-12-04 wl [bdf] Ignore data after `ENDFONT'. 2018-12-02 apodtele * builds/windows/visualc/freetype.dsp: Dust off. 2018-11-29 ramakrishnan.nikhil * include/freetype/ftmm.h: Minor. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-change: https://pdfium-review.googlesource.com/c/pdfium/+/46650 Change-Id: Ifd73c204136e434e70bba88f775658efad7f8ce2 Reviewed-on: https://chromium-review.googlesource.com/c/1366076Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#614798}
-
Mark Lieu authored
This change further changes direct calls to Time::Now or the default base::Clock instance to an OfflineClock module within classes which need a Clock pointer to be passed into the class. This eliminates the need for testing-only functions and further allows ease of testing. This change is specific to production files and their related tests in: chrome/browser/android/explore_sites/ components/offline_pages/core/model/ Bug: 906903 Change-Id: I02b84f65b77dc395310995c34ded41d92721aaeb Reviewed-on: https://chromium-review.googlesource.com/c/1352813Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Mark Lieu <mtlieuu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614797}
-
Peng Huang authored
Original change's description: > Revert "Share one GLContext for all RasterDecoder when virtual context is used." > > This reverts commit 1808a743. > > Reason for revert: Null-dereference READ in gpu::gles2::ContextState::api > https://crbug.com/912981 > > Original change's description: > > Share one GLContext for all RasterDecoder when virtual context is used. > > > > With this CL, we will create a GLContextVirtual in RasterDecoderContextState, > > and share it with all raster decoders, display compositoer, etc. It is a > > temporary solution. In follow up CLs, we will share the one GLContext with > > GLES2 as well. In that case, we will use GLContext directly instead of > > GLContextVirtual. > > > > Change-Id: If9b8d1f32e58b32a9d9f8cd07aa10c30432e3183 > > Bug: 902904 > > Reviewed-on: https://chromium-review.googlesource.com/c/1357463 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614694} > > TBR=penghuang@chromium.org,piman@chromium.org > > Change-Id: I2eb66f211d408988f30bfb870425da80e0eb7a4b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 902904 > Reviewed-on: https://chromium-review.googlesource.com/c/1368284 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614738} TBR=penghuang@chromium.org,piman@chromium.org Change-Id: Ie409d5d631509efa978a8741381cedbbbcdb3904 Bug: 902904 Reviewed-on: https://chromium-review.googlesource.com/c/1368031Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614796}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/10b051083c0d..4348ce240aae git log 10b051083c0d..4348ce240aae --date=short --no-merges --format='%ad %ae %s' 2018-12-07 ilnik@webrtc.org Calculate min and max receive timestamps for packets in a video frame 2018-12-07 nisse@webrtc.org Convert all webrtc code to not access EncodedImage::_size directly. 2018-12-07 artit@webrtc.org Replace luci-go dependency to CIPD package Created with: gclient setdep -r src/third_party/webrtc@4348ce240aae The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:851596 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I30370412edd578d87e1a5c88dacb976e648bcf4a Reviewed-on: https://chromium-review.googlesource.com/c/1367968Reviewed-by:
-
Matthew Mourgos authored
Bug: 869643 Change-Id: I85cfff694f3ce43d822c0126906e9266b3c39e9c Reviewed-on: https://chromium-review.googlesource.com/c/1363838 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
-
Wez authored
Bug: 913037 Change-Id: I2086df02bc0323c0a4b10cf3f24b628e62e28e39 Reviewed-on: https://chromium-review.googlesource.com/c/1368405Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#614793}
-
sczs authored
- Renames InfobarCoordinator to InfobarContainerCoordinator to better match its functionality. - Renames InfobarContainerVC to LegacyInfobarContainerVC to support the new Infobar design later on. Bug: 911864 Change-Id: I111747f48c1cbca8ca3f4bc8a174952edf841d21 Reviewed-on: https://chromium-review.googlesource.com/c/1362467Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#614792}
-
Xianzhu Wang authored
fast/repaint was the old directory before we moved all tests from it to paint/invalidation. Move one test left (fast/repaint/sub-frame-svg-background.html) into paint/invalidation. Remove extra baselines. Change-Id: Ifb00ec3488d0baf81e73c756c2e89d2af9116200 Reviewed-on: https://chromium-review.googlesource.com/c/1368111 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Sky Malice authored
When the NTP was open and an article fetch completed, it would cause the list of articles to flicker and be completely replaced. This change removes the flicker, and only articles below the edge of the screen are replaced. Bug: 911489 Change-Id: Id87b221e142533a0bf448a0efe2cdcdf43209dc0 Reviewed-on: https://chromium-review.googlesource.com/c/1363959 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#614790}
-
Xianzhu Wang authored
to ensure we don't regress --disable-blink-features=BlinkGenPropertyTrees badly when experimenting BGPT. Bug: 836884 Change-Id: Ie857f69e90bae243b55993fac58d04c478cb3b48 Reviewed-on: https://chromium-review.googlesource.com/c/1368144 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Brian Sheedy authored
This reverts commit 8b38b5d3. Reason for revert: Root cause fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1367926, workaround no longer necessary. Original change's description: > Add XR instrumentation web content workaround > > Adds a workaround for https://crbug.com/908917 into the XR > instrumentation test setup since attempts to work around the issue in > the test runner haven't been completely successful. This workaround > performs a swipe which should be a no-op when running a RenderTest, > which seems to prevent the flakiness when doing pixel diffs. > > Bug: 908917 > Change-Id: I38bf8fb5abe1c0a2bf19e044dd9237919ec2b019 > Reviewed-on: https://chromium-review.googlesource.com/c/1362293 > Reviewed-by: Bill Orr <billorr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614250} TBR=bsheedy@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 908917 Change-Id: Ie8ca239a9199cf805fb4f4d3257c1b142b3250d7 Reviewed-on: https://chromium-review.googlesource.com/c/1368037Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#614788}
-
Takumi Fujimoto authored
Use-after-free was happening at shutdown due to MediaRouterDialogControllerViews getting destroyed without unregistering itself. We make MRDCV retain a pointer to the dialog widget to make sure it unregisters itself, because GetCurrentDialogWidget() may become null before the actual widget is destroyed. Also do all of the cleanup in OnWidgetClosing() instead of splitting with OnWidgetDestroying(). Bug: 905498 Change-Id: Idf9da7aaf33cd9db512681b688ebd95d0fae08ca Reviewed-on: https://chromium-review.googlesource.com/c/1364295Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#614787}
-
Michael Spang authored
This reverts commit c8e53d0f. Reason for revert: This breaks non-Android platforms. VK_KHR_GET_MEMORY_REQUIREMENTS_2_EXTENSION_NAME is requested on Android only, yet a dependency on it is added to vulkan_function_pointers.cc on all platforms. Original change's description: > Import AHardwareBuffer into a Vulkan Image. > > Added a utility function to create a vulkan image and import AHardwareBuffer > created outside of vulkan device into a vulkan image. > > Bug: 891060 > Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b > Reviewed-on: https://chromium-review.googlesource.com/c/1357658 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614518} TBR=piman@chromium.org,ericrk@chromium.org,vikassoni@chromium.org Change-Id: I11c1d39a43438699d72a93212eedef1d4230518a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891060 Reviewed-on: https://chromium-review.googlesource.com/c/1368406Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614786}
-
Aaron Colwell authored
- Adding DCHECK to make sure CanAccessDataForOrigin() is only called on the UI or IO thread. This is needed for future CLs that will need to use information in the BrowserContext or ResourceContext to determine if data access is allowed. - Fix existing code that was calling CanAccessDataForOrigin() on worker threads so that it doesn't trigger the new DCHECK. Bug: 898281 Change-Id: I03ab137dad3fcec5c7c2152855816156489f91c0 Reviewed-on: https://chromium-review.googlesource.com/c/1359463 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#614785}
-
Etienne Bergeron authored
This CL is changing the kind of observer used by the sampling profiler wrapper class. The proposed implementation is to use the sync version which is fixing early startup tracing/sampling. The previous code was using a Async observer to keep the class thread-safe. Unfortunately, the sampling profiler is not able to start early enough on startup. The hooks are at the right place. The reason why it's not working on startup is because the tasks queue is already loaded of startup tasks to be executed on the main thread. Thus, after activating tracing, there is a long gab between the point where the tigger occurs and when the sampling profiler got created and start to collect samples (e.g. OnTraceLogEnabled). To avoid this delay, we prefer using a Sync observer. That forces the class to be thread-safe. R=oysteine@chromium.org CC=ssid@chromium.org, wittman@chromium.org Change-Id: I02a1deb2f8aa705ccbf5fb6e7026f4588ca1b319 Reviewed-on: https://chromium-review.googlesource.com/c/1359293Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#614784}
-
Michael Thiessen authored
On O+, Android draws a translucent grey overlay over focused views when the device is not in touch mode (as in, the user is using keyboard to navigate rather than touch/mouse). Drawing this overlay over the entire ContentView doesn't make sense, so we should just disable it. We also have to disable it for the CompositorViewHolder, or when we go between NativePages (like NTP) and WebContents, we animate into and out of the grey overlay, because the CompositorViewHolder briefly gains focus. Bug: 912724, 908917 Change-Id: I97b7f688f06581e872898028a48e6e7b4546d710 Reviewed-on: https://chromium-review.googlesource.com/c/1367926Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#614783}
-
Hector Carmona authored
This CL adds the missing metric combination as well as factoring out to make metrics gathering code shareable with the google apps module. Bug: 874154 Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054 Reviewed-on: https://chromium-review.googlesource.com/c/1344998 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614782}
-
Andrew Grieve authored
They have: A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18 (Raw: "24") Rather than just: A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18 Change-Id: Ib397ff275a58e7d0595be8d1611c99e4421b6364 Reviewed-on: https://chromium-review.googlesource.com/c/1367112Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#614781}
-
Tibor Goldschwendt authored
This prevents hitting the dex method count limit. TBR=yfriedman@chromium.org Change-Id: I0c53dae4cf7244d55976f42e58ce4de4ff891855 Reviewed-on: https://chromium-review.googlesource.com/c/1368033Reviewed-by:
-
Eugene But authored
IOSChromeLocalSessionEventRouter will observe multiple WebState objects without using deprecated GlobalWebStateObserver. Also removed browser state check in OnWebStateChange. This check was needed because each WSO callback was called for both BrowserState objects. So the router had to check if the call belongs to correct browser state. After this CL there are no extra calls, hence no need for check. Bug: 910894, 782269, 720786 Change-Id: Ie25ae62efea9edd4a981800d1a43b6ef28b35b14 Reviewed-on: https://chromium-review.googlesource.com/c/1359863 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#614779}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c38fee64ace..de797ddcb5d0 git log 7c38fee64ace..de797ddcb5d0 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 ale64bit@users.noreply.github.com Check that certain decorations cannot be used more than once and/or are mutually exclusive (#2171) 2018-12-07 afdx@google.com Replace loop with selection (#2164) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@de797ddcb5d0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4fd77a288a5c3b6f50bc0d334f2d1f91d4179f37 Reviewed-on: https://chromium-review.googlesource.com/c/1368206Reviewed-by:
-
Boris Sazonov authored
This CL adds SigninHelper.resetSharedPrefs call to OAuth2TokenServiceIntegrationTest.tearDown method. OAuth2TokenServiceIntegrationTest has been causing many test failures in different tests because of the state it has been leaving in shared preferences. Bug: 908542 Change-Id: I10df9d0ab1d268c7da3352ca87ae07659bfa55d2 Reviewed-on: https://chromium-review.googlesource.com/c/1368147Reviewed-by:
-
Wez authored
Also adds ability for test to supply a mock NavigationController to FakeFrame instances. Bug: 893229 Change-Id: I63ddffcd4a13b49b9e67232161255bd72a11a0cb Reviewed-on: https://chromium-review.googlesource.com/c/1334561Reviewed-by:
-
Toni Barzic authored
This was used for testing the lock screen apps apis before note taking app supported lock screen. It should not be needed anymore given that the actual note taking app can be used for testing. Change-Id: I3c678018bfb4e1dacb537fb7e3c58dcad2a4b92c Reviewed-on: https://chromium-review.googlesource.com/c/1347770Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#614775}
-
Yiming Zhou authored
This change adds support for testing the presence of Chrome Password Manager's save fallback. The validation function checks if Chrome is showing the save fallback, and waits up to 5 seconds for Chrome to show the save fallback. Bug: 847905 Change-Id: I1a55a170c89ff0384c647d8e7646de256f4f15d8 Reviewed-on: https://chromium-review.googlesource.com/c/1334552Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Quan Nguyen authored
When the lock screen is shown, the existing system Clipboard is replaced with an empty version. Once the lock screen is destroyed, the old Clipboard state is restored. Bug: 902516 Change-Id: Ifc5b3cee992abd701fe1c80349f8d8ec84f91546 Reviewed-on: https://chromium-review.googlesource.com/c/1354332Reviewed-by:
-
