GitLab

The elements were both 'cr-link-row's with the id sync-status removed in
[1] and [2] respectively.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1871989
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1869657

Bug: 1015805

Change-Id: I495213225e6d1413a537f750a3d265a5885f52c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885555Reviewed-by: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710553}

Also rename WebLayer's NavigationCommitted to ReadyToCommitNavigation for consistency.

Change-Id: Ib7c08067e30987018a3192acfe835d4d00e6e49a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872995
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710552}

Extract the logic of generating BrowserReport from ReportGenerator class. It
can be shared by following classes.
* ReportGenerator: which is existing to generate ChromeDesktopReportRequest.
* ChromeOsUserReportGenerator: which will be newly added to generate
  ChromeOsUserReportRequest (for Chrome OS only).

Bug: 1010213
Change-Id: I4bd64080319732bd200ae719dd1b9af00d41cdda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876033
Commit-Queue: Anqing Zhao <anqing@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710551}

This change reduces the number of stories that we run as part of
system_health_smoke_test from 82 to 27. We do this by limiting ourselves
to health_check stories, which are recognized as the most important to
maintain. (Note also that we aren't running all of the 27 since some of
those are currently temporarily disabled.)

Bug: 1019383
Change-Id: I271a0e94288177e9387c9f5551ff44d6e072b9d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888136Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710550}

Previously we relied solely on a check for the item position to
determine if "Move up" and "Move down" items should be shown in any
given bookmark item menu. This CL updates the check to also makes sure
the bookmark is moveable.

It looks like we had this check at one point and it got lost in a bad
rebase.

BUG=1019178

Change-Id: I595ba7646de23f79bd13e85d0bb2bb1e5d17f413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887732
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710549}

Change-Id: I43d60c450a80288980cf65313a601771a5123128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875648Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710548}

This CL is the next step in a soft transition for updating the Fuchsia
key id type to be a bytes field and rename
fuchsia.media.drm/ENCRYPTION_MODE to fuchsia.media/ENCRYPTION_SCHEME. In
particular, this step removes the LicenseSession/OnKeysChanged event
handler and renames the encryption mode references to scheme.

Bug: fxb/38522 fxb/38438

Change-Id: Ibbb06af16cd10ef3e71fbd0ce70e441e412c3947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884282Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: RJ Ascani <rjascani@google.com>
Cr-Commit-Position: refs/heads/master@{#710547}

This reverts commit 263061fc.

Reason for revert: Causing all builds to fail on mac-builder-perf (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf)

Original change's description:
> Roll clang 373424-64a362e7-1 : n330255-55c223a7-1.
> 
> Since upstream llvm/clang has moved to Github, there are no longer any svn revisions.
> Instead, our package versioning scheme now begins with the number of commits since
> the initial commit in the repository, prefixed by an "n".
> 
> These "n" numbers are NOT comparable to svn revisions.
> 
> Ran `tools/clang/scripts/upload_revision.py 55c223a7ed522293cf9995d07d348368c345d1f2`.
> 
> Bug: 1011815
> Change-Id: If2b9dce272182ca4f0881424e1d64410b796b4c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879890
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710354}

TBR=thakis@chromium.org,hans@chromium.org

Change-Id: I203d5f8c9e3880d2bc85bb5efa422a9654736a6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011815, 1019517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889211Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710546}

https://chromium.googlesource.com/catapult.git/+log/0e87f1419824..762db8a15012

git log 0e87f1419824..762db8a15012 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 dproy@chromium.org Do not try to remove keystone on chromium builds

Created with:
  gclient setdep -r src/third_party/catapult@762db8a15012

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: None
Change-Id: Ic3bc643ea3aebc9369e18e7c1488523d779daeeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710545}

This CL is a revert of the functional parts of commit ef514667. We
have decided that these should not be reported as they skew the values
in the histograms in undesirable ways. These 0 values correspond to
times during which the largest image is not yet fully loaded.

Bug: 1017335
Change-Id: I6bbae41f0e0357198f752291c50a439003cd9bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875285Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710544}

This reduces Android binary size by 11,419B:

https://ci.chromium.org/p/chromium/builders/try/android-binary-size/359741

Note: One UA stylesheet |controls_refresh.css| remains unminimized
in this patch. It will be minimized in a followup patch to address some
relative link issues.

Bug: 1015410
Change-Id: Ibf38b7b8b92e7a64692d3a6d4f30a9d5e41e5d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872009Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710543}

Create implementations of discardable memory primitives using the
behaviour of madvise(MADV_FREE), which are compatible with existing
semantics.

Bug: 1014513
Change-Id: I4b3ddd22eaed923dc57e1b74ea0267dd820a1df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850539
Commit-Queue: Gordon Guan <gordonguan@google.com>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710542}

This adds a new PermissionWizard class which currently just shows the
initial dialog, with title, icon, instruction, and Cancel/Launch
buttons. No functionality or logic, except pressing the Cancel button
will hide the window.

Bug: 1015201
Change-Id: I81c4af01435dfa6d2905b5d8e2a7351cd07f97f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880175
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710541}

Bug: 1003238
Change-Id: I39923254ddffe7d29bef0debc4f8f083547d7f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886134
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710540}

Adding labels for images inside the webview. Also fix a visibility issue
for ChromeVox by setting the webview and the image unselectable.

Bug: b/142957550
Test: Manual Test
Change-Id: I98d1826c5f302df0a696dc9c7a75e10799302720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887848Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710539}

Bug: 1015634
Change-Id: I48e2c78071619827843f45c74852c0a127f75c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879649
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710538}

With the enhancements and past conversion to ModelList/ModelListAdatper,
it internally registers model change processors for each item and to the
corresponding model.  Now you can change individual properties of items
w/o the need for a full update to the list.  Because of this, we also
can remove the need for tracking if this is an active model because the
registration already handles this (when updating the list, it removes
the MCPs associated with the views).

BUG=982818

Change-Id: Iedee74d7fdb0a37bfccde89158795988d69b5cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887654Reviewed-by: Ender <ender@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710537}

If the CryptAuth v2 Enrollment and v2 DeviceSync feature flags are
enabled, DeviceSyncImpl creates a v2 DeviceSync device registry and
device manager to run alongside the v1 DeviceSync device manager.
These two device managers will run in parallel until v1 DeviceSync is
deprecated.

The unit tests were updated to test these new objects. Furthermore,
the unit tests now verify that the correct objects are created for all
permutations of the v2 Enrollment and v2 DeviceSync features flags.

Bug: 951969
Change-Id: I59541a5294e94a560c39bf636357589248ea8045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872416
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710536}

The current lookalike check allows redirects from an IDN site to its non IDN
version if the redirect is to the root of the non-IDN domain. It disallows
any redirect chains longer than 2 URLs including the initial URL.

This is too strict and causes problems when the IDN domain first redirects to
another URL on the same site. As an example, this redirect is blocked:
http://québec[.]ca -> https://québec[.]ca -> https://quebec[.]ca

This CL relaxes the safe redirect check and allows redirect chains longer than 2
as long as the first IDN to non-IDN redirect happens to the root of the non-IDN
domain. In practice, two changes were made:

1. The initial IDN URL can now redirect to arbitrary URLs on the same domain an
   unlimited number of times. This is now OK:
   http://sub1[.]québec[.]ca/path1 -> http://sub2[.]québec[.]ca/path2 ->
   https://sub3[.]québec[.]ca/path3 -> http://quebec[.]ca

2. There can now be an unlimited number of redirects to arbitrary URLs after the
   first redirect from the IDN URL to the root of the non-IDN URL. This is now
   OK:
   http://québec[.]ca/path -> http://quebec[.]ca -> http://somerandomdomain[.]com

We don't necessarily need to implement (2) to fix bug 1015084, but there doesn't
seem to be a good reason to impose that artificial restriction either.

Bug: 1015084
Change-Id: Icc760cb171c7e314609e214b9ee8563e4f320014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881354Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710535}

https://webrtc.googlesource.com/src.git/+log/9cdc9cc1c48d..74f96eccd6fe

git log 9cdc9cc1c48d..74f96eccd6fe --date=short --no-merges --format='%ad %ae %s'
2019-10-29 srte@webrtc.org Removes unused late feedback plot from analyzer.

Created with:
  gclient setdep -r src/third_party/webrtc@74f96eccd6fe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I67ff87f52726b799a27a9d0c9c005dbc76c3f84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888059Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710534}

The old code calculated the necessary size capped at this width, then sized to
that.  This meant that center-/right-aligned labels would align based on their
"used" width instead of the total provided width.  This diverged from the
behavior of Label, which also has a SizeToFit() function, which assigns a
fixed width.

Divergence seems unnecessary and likely to introduce bugs.  The new comment,
param name, and behavior match Label.

Bug: none
Change-Id: If71000363aed778d403fe43ca67c7f399d418e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877807
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710533}

Mostly shortens variable names, does some other comment shortening and inlining
as well.

Bug: 1015717
Change-Id: I27552ae241a1f3194026c966f7bc556d53cad2c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884813
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710532}

Bug: 1018050
Change-Id: I1d3e379c8e286735039280b286f444500e842a1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886072Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710531}

We need to reset the scrolling status (especially LayerTreeHostImpl::
did_lock_scrolling_layer_) when activating the pending tree in which
the currently scrolling node no longer exists.

Previously the situation caused DCHECK failure.

Change-Id: I23b9105ded1767ee27fa37fb75f67c13e81d5699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882301Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710530}

This is just the CrOS adaptation of
https://chromium-review.googlesource.com/c/chromium/src/+/1880538

Bug: 1009128
Change-Id: Ie050cfce6972107170a09877c41e90ec2c40e87a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888370Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710529}

Change-Id: I5e82642af372d789e8ea5a0b636fa3bcf221e173
Bug: 1018175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887735
Commit-Queue: Nick Harper <nharper@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710528}

r694888 (crrev.com/c/1792467) gave a break opportunity after
OOF objects.

For leading OOF objects, there should not be a break
opportunity, but the patch gave to them too. This patch fixes
not to add a break opportunity if there were no preceding
in-flow objects.

Bug: 1018748
Change-Id: I89a8614cdfd85bed1bb8c2f3b6db892697f7add7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886130
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710527}

Roll airmont AFDO profile from 80-3940.0-1572260209-benchmark-80.0.3950.1-r1 to 80-3940.0-1572260209-benchmark-80.0.3951.3-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: Ie799928ffb56b8b6dd74f91ecc00ac5e8777c579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888819Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710526}

This is useful for me as I play with getting sharding working for abridged benchmarks.
Also update help docs so that there is one help doc for each subcommand to make the
--help output look nicer.

Bug: 965158
Change-Id: Ia30f029902bff8c5fea60a1dcf70266c8fc78dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884879
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710525}

The previous logic incorrectly dumped (delayed_run_time - now) even when
delayed_run_time was 0 (i.e. immediate tasks when
!(delayed_fence_allowed_ || add_queue_time_to_tasks), see
TaskQueueImpl::PostImmediateTaskImpl for details).

R=alexclarke@chromium.org

Bug: 1014646
Change-Id: I410b25a75b0b8703a822540e4a4e3531ded1c84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888530
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710524}

This code will initialize the session with new user type --
WebKioskApp.

Note: This CL contains so many files since we have a lot of mocks,
base/impl thrown around.

Bug: 1015383,1006230
Change-Id: Id7858f6733cdf537ab76017fff3959a7e89a4b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872218Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710523}

The text-runs break heuristic now considers the text style.
With this change, a text run will break if it encounters a difference
in the following text style properties:
* font-family
* font-weight
* rendering mode
* font-size
* fill color
* stroke color
* italic flag
* bold flag

Before this change, it used to break only if a font-size difference was
observed.

I added an "ultimate" dump test that tests for all of those properties.

Bug: 985604
Change-Id: Ice4b4a2dcdd8cc9642ca0e9d069a415c5b2700fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771987
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710522}

SurfaceViewManagerMsgStart obsolete in f7df5b34.
PeerConnectionTrackerMsgStart obsolete in bc917af8.

Change-Id: I275f10fe0e1d66b427ca55f96223ed22d7b06ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888382Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710521}

This reverts commit cf629e19.

Reason for revert: Causing a compile issue: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898221248587802272/+/steps/compile/0/stdout

This removes kAdvancedSigninSettingsLinkIdentifier which is used by external_url_signing_egtest.mm

Original change's description:
> Extract unified consent constants target.
> 
> Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations.
> 
> Bug: 922813, 1015907
> Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710479}

TBR=rohitrao@chromium.org,jlebel@chromium.org,zhaoyangli@chromium.org

Change-Id: I1035a519391d68b553770ba3c12747cfe23e6050
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922813, 1015907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888721Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710520}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0a3d2bb99b45..b75031a26eed

git log 0a3d2bb99b45..b75031a26eed --date=short --no-merges --format='%ad %ae %s'
2019-10-25 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check `num_fonts' for TTCs.

Created with:
  gclient setdep -r src/third_party/freetype/src@b75031a26eed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com,thestig@google.com

Bug: None
Change-Id: I4716583e7880f9a2d01c1e80826cd8306cecd5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881414Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710519}

In preparation for launching to all channels in finch.

Change-Id: I581f451ba7e6852df056d785ba824c8d75c7dc31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888125Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710518}

- Fix NavigationRequest() constructor to set source_site_instance for
  history navigations.
- Add DCHECKs in NavigationRequest and OpenURLParams to catch callers
  that try to construct these objects w/o providing
  source_site_instance for URLs that need it.

Bug: 1014483,1018803
Change-Id: I51bbd8c45fcd2f508793b379df06076c8c4ee498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872463Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710517}

Bug: chromium:906739
Change-Id: Ibbd8715c900220242d44ddfef51449b155f81c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877610Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Mingyu Hu <mihu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710516}

This CL converts WatchTimeInterceptor to new Mojo types
using PendingReceiver, Remote and SelfOwnedReceiver.

Bug: 955171
Change-Id: I04db71110cc0d5371754f0e0e142b4893ff061e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885863Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710515}

This reverts commit c56d4c6c.

Reason for revert: I get the following 13 times per update:

C:/src/trunk/src/build/toolchain/win/setup_toolchain.py:284:
SyntaxWarning: assertion is always true, perhaps remove parentheses?
  assert (vc_lib_atlmfc_path,

Original change's description:
> Added assertion message when ATL is not installed.
> 
> The comment above assert did not match behavior
> of assert. This comment has been fixed and an
> explanatory assertion message was added.
> 
> Bug: None
> Change-Id: If9ac26c578ac45fb9e6dd50b1605ecff13bf1323
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881161
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#710425}

TBR=brucedawson@chromium.org,yura.yaroshevich@gmail.com

Change-Id: I18f9431edb7d21435c029a0ce825bfd421f0cc27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888322Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710514}