- 30 Nov, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/732b1bcf..ac4c4dc0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58cd21acfe0803fdfd5651cf7b3b44b588de407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831836}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606715277-7cd8080ef7943d789d7f3f75a67090679d493829.profdata to chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06b48a5e77b3c525acfd7883ad1bc6e35318daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831835}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606715277-5a5c0b93116eb4ed5bae16849c10b7071f9da60f.profdata to chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I65465d08109fb5af1eb9404337222294b0f636bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564971Reviewed-by:
-
Maksim Sisov authored
Fixes a crash when FindDisplayNearestPoint cannot find a suitable display (if num of displays <= 1) and returns nullptr, which is then returned to ScreenOzone by value, which is illegal and results in a crash. Bug: 1135518 Change-Id: Icb1e788bcc0fbda13bc84023999b1b39eebfd1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565119 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#831833}
-
Anton Bikineev authored
qurantine. Bug: 11297512 Change-Id: I819d323831993c36575f64f00def30a2e3686577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563766 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831832}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75aeca4eb9f8..633335551f5d 2020-11-30 aerotwist@chromium.org [DarkMode] Update web audio styles 2020-11-30 janscheffler@chromium.org [Recorder] Fix recorder freezes 2020-11-30 jacktfranklin@chromium.org [Dark Mode] migrate css_overview/cssOverviewSidebarPanel 2020-11-30 jacktfranklin@chromium.org [Dark Mode] migrate css_overview/CSSOverviewProcessingView 2020-11-30 jacktfranklin@chromium.org [Dark Mode]: migrate css_overview/cssOverview.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5f613960ba0cd9c30ed738ff7c04ad286b8f946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564893Reviewed-by:
-
Anqing Zhao authored
According to the CPP style guide, the enumerators should be named like constants, not like macros. That is, use kEnumName not ENUM_NAME. So let's improve SystemFeature accordingly. See: https://google.github.io/styleguide/cppguide.html#Enumerator_Names Bug: 1142785 Change-Id: I9b95c6ed035cf0b5016b562ee9986626e4d511c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563305Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#831830}
-
Luciano Pacheco authored
Change the assert to use '.split('\n')' to compare the files based on a list of lines to make the error message better to understand where is the difference. Bug: 1152668 Change-Id: Ica401046a4da35f0e0fa34870af0a3ed6777c525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558101Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#831829}
-
Rune Lillesveen authored
While working on moving user style into a separate ScopedStyleResolver, the term "author" did not make sense. It also generally didn't seem to add any value here. Bug: 336876 Change-Id: Ib70f4ace0410fc9598e45db349e866beca37bd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563825Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#831828}
-
Mathias Bynens authored
The expected output will change due to [1]. We’ll re-enable the test with new expectations after the devtools-frontend change has landed and rolled into Chromium. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557071 Bug: chromium:1152391 Change-Id: I6b7d5fa352b6f94b865ad2896bc1f3fa102b625f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563668 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#831827}
-
Rune Lillesveen authored
Forcing re-adding all sheets should not be necessary. I probably was at some point. Now, the active style update process should handle all. TEST=StyleEngine.StyleMediaAttributeStyleChange TEST=StyleEngine.StyleMediaAttributeNoStyleChange Change-Id: Ie5af77ca90768b8fe5a39c3e07ddd5025f1c1056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563469Reviewed-by:
-
Jérôme Lebel authored
Remove + kTokenServiceExcludeAllSecondaryAccounts + kTokenServiceExcludedSecondaryAccounts Those pref were used before moving to WKWebView. Related to crrev.com/c/2544972 Change-Id: I84faa8721c622663e018f28e99c158407bcdbc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563473 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#831825}
-
Kushagra Sinha authored
Remove `COMPONENT_EXPORT` from `account_manager::AccountType` enum. Enums do not need to be dll-exported and doing it anyways results in compilation failures on Windows buildbots. Change-Id: I883284f030d9d86657c95cfea8ede4fee0fa522e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565240Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#831824}
-
Richard Knoll authored
CrOS has a different wording (formal vs informal) than on other platforms which results in different strings in some languages. This splits the string into "chromeos" and "not chromeos" parts and adds a meaning so they end up as separate strings in the translation console. Bug: b/172205057 Change-Id: I3cd55ee68edfd30f903d6805bf43452f3dbd7611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563550Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#831823}
-
Roman Sorokin [CET] authored
This reverts commit 1fc0c31c. Reason for revert: speculative revert for BackForwardCacheBrowserTest.PageshowMetrics failure (https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/43304) Original change's description: > Two phase BackForwardCache restore > > Split the BackForwardCache restore flow into two phases: > * disable evictions (e.g. no longer evict if js executes) > * Commit navigation and unfreeze the page and run handlers (pageshow etc) > > This eliminates the existing race were a evict request arrives after > RFH have been swapped and a reload is needed. > > We add a new Lifecycle state property that controls eviction and we > commit the back navigation (and thus swap RFH instances) we wait for > the renderer to ack that eviction is disabled. At this point we can > be sure that no eviction request will arrive from the renderer and we > can commit the navigation. > > Bug: 1153126 > > Change-Id: I4e787a008881a04954b27d201e635b3a18794536 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352815 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831809} TBR=dcheng@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,carlscab@google.com Change-Id: Ib3b972d3644b7bc65353f37cc901e396400e89c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564760Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831822}
-
Bao-Duy Tran authored
This is a reland of f42aaef1 No changes from the original CL which was reverted (https://crrev.com/c/2560280) just because its parent CL (https://crrev.com/c/2550152) had to be reverted (https://crrev.com/c/2560527). That's now been relanded (https://crrev.com/c/2560448) so this reland can go head, too. Original change's description: > Remove unnecessary ime_list_ in InputMethodManagerImpl unit tests. > > Bug: 1134465 > Change-Id: I32cb2d5d67e6bd102f17578d824028527d1c9bdc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551869 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Jing Wang <jiwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831202} Bug: 1134465 Change-Id: I727c3a565ccfb79a55cd85e1be0ebf98239785a4 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel,linux-chromeos-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563045Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831821}
-
Yoshisato Yanagisawa authored
This reverts commit 7e77a598. Reason for revert: Including omit python2, which I have reverted. Original change's description: > Roll Chromite from 9ed30bc3ed29 to 34d74e1ebe96 (7 revisions) > > https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ed30bc3ed29..34d74e1ebe96 > > 2020-11-27 sidereal@google.com chromite: Remove code for generating guest_images.tar > 2020-11-27 chrome-bot@chromium.org Update config settings by config-updater. > 2020-11-27 chrome-bot@chromium.org Update config settings by config-updater. > 2020-11-26 vapier@chromium.org cbuildbot: do not bootstrap when using main & master > 2020-11-25 saklein@chromium.org controller/sysroot: Fix result path usage. > 2020-11-25 vapier@chromium.org cbuildbot: update tot logic to consider main & master equivalent > 2020-11-25 yyanagisawa@chromium.org omit python2 to run goma_ctl. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/chromite-chromium-autoroll > Please CC chrome-os-gardeners@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel > Tbr: chrome-os-gardeners@google.com > Change-Id: I0ac4ea8b50283a9df37ebfea2236f3d545a26a4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562653 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#831595} TBR=joelhockey@chromium.org,agawronska@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If0caf42ce81cdb66122084e06ca4e6168696c0f9 Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563429Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#831820}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69c377e2adf6..75aeca4eb9f8 2020-11-30 jacktfranklin@chromium.org [DarkMode] migrate CSSOverviewCompletedView 2020-11-30 alcastano@google.com Refactor UISourceCodeFrame to use Icon component 2020-11-30 pfaffe@chromium.org Use bytecode offsets in wasm source GoToLine and position indicator 2020-11-30 szuend@chromium.org Implement 'monospace' and 'source-code' CSS classes with CSS variables 2020-11-30 janscheffler@chromium.org [Recorder] Add support for window.open 2020-11-30 aerotwist@chromium.org [unit test] Add debouncer test 2020-11-30 aerotwist@chromium.org Add ls import If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150883,chromium:1152405,chromium:1152714,chromium:1152736,chromium:1153323 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62ee8482411c78d72f53b7cfee82e507b1d1346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564890Reviewed-by:
-
Benoit Lize authored
Bug: 998048 Change-Id: I13373f10e55c3aecfe77081e6bfb1e6b159535af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549968Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831818}
-
Mathias Bynens authored
This patch replaces existing usages of the DevTools `setImmediate` helper with the built-in `queueMicrotask`. This enables us to remove the `setImmediate` helper in [1]. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554560 Bug: chromium:1050549 Change-Id: I618a167323ce8b80cbd0249a76357606d6aa6987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563476Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#831817}
-
Fabian Sommer authored
Refactor common functionality from the tests ForceInstalledAffiliatedExtensionApitest, UserAffiliationBrowsertest, and UnaffiliatedArcAllowedBrowsertest into a common mixin. It can create an user who is affiliated with the device. Fixed: 1082195 Change-Id: I4c5bc19750efe2c15378cdb8c1efd48bd4b8db7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418397 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#831816}
-
Alice Wang authored
This CL moves web sign-in metrics class to native code so that we can log this metric in native code in the future. Bug: 1153068 Change-Id: I4c13a7e0a9df21218fd0a7298e142fdb9ff8ff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562855 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Unittests are updated to cover both ephemeral and OTR Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I46948739e48a59a7990c4bdd4022c8d0758d10f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561390Reviewed-by:
-
arthursonzogni authored
This lines was likely meant to enforce sandbox in SVG document. However, looks very useful, since the "forced sandbox" is only enforced when you commit a navigation. Here CommitNavigation() won't be called and nothing will happen. Moreover, you can already execute Javascript in SVG document. If this was effective, then many SVG document would be broken. Bug: None Change-Id: Ia96f6fe558741ccbea3fdbe615f335d75e700e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563818Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#831813}
-
Marc Treib authored
The concept of "association" doesn't exist anymore, so these numbers were quite meaningless. They were also always very close to zero, since the "start" and "end" times were always recorded synchronously right after each other (though this is not super obvious to see in the code). Bug: 1102837 Change-Id: I0a358b278babf7c22c82731726625dcd48a2a38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540667 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#831812}
-
Roman Sorokin authored
Flaky on Linux TSAN and MSAN TBR=dmazzoni@chromium.org Bug: 1152957 Change-Id: I7cea6abe806611b44b2ddc11418ec544ae3b5a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563475Reviewed-by:
-
Robbie Gibson authored
When scrolling in the web content or NTP, the thumb strip should open/ close in two circumstances: 1. Moving finger down when scroll view starts at top should cause the thumb strip to open. 2. When the thumb strip is peeked, moving finger up should close it. This CL implements this behavior for the NTP. Adding this to web content will be done next by hooking up to the CRWWebViewScrollViewProxy observer methods. Bug: 1094335 Change-Id: I4cd61ff25b1cd5fb4b1b5218bc53d5df7228ff9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560264Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#831810}
-
Carlos Caballero authored
Split the BackForwardCache restore flow into two phases: * disable evictions (e.g. no longer evict if js executes) * Commit navigation and unfreeze the page and run handlers (pageshow etc) This eliminates the existing race were a evict request arrives after RFH have been swapped and a reload is needed. We add a new Lifecycle state property that controls eviction and we commit the back navigation (and thus swap RFH instances) we wait for the renderer to ack that eviction is disabled. At this point we can be sure that no eviction request will arrive from the renderer and we can commit the navigation. Bug: 1153126 Change-Id: I4e787a008881a04954b27d201e635b3a18794536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352815 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/59aa1ef1975a..3d061021c920 2020-11-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 553b5bcd to 2232da5c (287 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I62bea30498f6619866f64e3a1683168893be3d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565010Reviewed-by:
-
Antonio Sartori authored
The policy container collects security policies that apply to a document. It implements a mechanism for inheriting policies from the creator document if navigating to a local scheme. In case of history back/forth navigations to local scheme URLs, we should remember the original policy container that was applied to the document when it was navigated first and re-apply it. This CL implements: 1) Storing the policies of the policy container in the FrameNavigationEntry at RendererDidNavigate time. 2) Reloading the policies when creating a NavigationRequest from a FrameNavigationEntry. Extensive browsertests for this functionality are also implemented. Bug: 1130587 Change-Id: Iabec50cea252507e30e546f1f52f5b426b308062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485058 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#831807}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/759827265102..146912bb62b7 2020-11-30 bikineev@chromium.org blink_gc_metric: Fix missing import. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I2113e7c5f7486276d4cd44afeb075185c767fc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565011Reviewed-by:
-
Mikel Astiz authored
There's no need to postprocess passwords specific during proto->JSON conversion, because the bridge takes care of stripping sensitive fields as exposed in sync-internals. This fixes the node browser in sync-internals and makes other parts of sync-internals more reliable (e.g. traffic log when capturing specifics). In reality the actual traffic to the server should not have field client_only_encrypted_data populated, but now it can be verified. Change-Id: I794a47e80c96bb9a80dce2051117c172f6676219 Bug: 1152342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556840Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831805}
-
Aya Elgendy authored
Add UI support for non-digit pins used via smart cards when user logs in for the first time (which uses the white UI). Previously, Latin letters and characters were consciously ignored. Bug: 1144194 Change-Id: Ic01cf0e327276793c7ad0cc2a23eba9a79320bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552597 Commit-Queue: Aya Nader Elgendy <ayag@chromium.org> Reviewed-by:
-
Colin Blundell authored
Addresses post-landing review comment on https://chromium-review.googlesource.com/c/chromium/src/+/2526087/. Bug: 1116095 Change-Id: I49076e9e318eef175c5d0fb0acf7ee3d57034358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563264 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#831803}
-
Wei Lee authored
We recently introduce image proload mechanism for CCA. But the icons images are missing in the assets list so that for platform app version CCA cannot load its icon properly. This CL adds them back. Bug: b/174340330 Test: Confirm that the camera icon is shown for platform app version Change-Id: I818968bb11bd48aa2f487066dafa2de601694ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563421 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#831802}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606683139-d8471ee05cec96a0e4a5dd6068a792099aab019f.profdata to chrome-win64-master-1606715277-9385c299327136363de38f40b28eb44b3b85ec7c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I71a1483b369870ed624e2bcf8752d0586c60a0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565099Reviewed-by:
-
Anton Bikineev authored
This adds mlippautz@ and bikineev@ to pcscan*. Bug: 11297512 Change-Id: I446439c1da890ef50a04e4fa622da7f4c0cc0f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564758Reviewed-by:
-
Changhao Han authored
DevTools Frontend CL: crrev.com/c/2562700 Fixed: chromium:1138261, chromium:1138260, chromium:1138259 Change-Id: I859bda631a10534a25829ea0926d7d59c7010a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562844Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831799}
-
kouhei authored
Now that we've gathered enough data, remove code to collect UMA histograms: - PerformanceManager.AgentsByTime - PerformanceManager.AgentsPerRendererByTime - PerformanceManager.AgentsUniqueByTime Bug: 1142503 Change-Id: I41a796b27a6445a5351cc5458978443f0b24df96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560026 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831798}
-
Sylvain Defresne authored
The file MDCTabBarViewItemView.h has incomplete nullability specifier in revision c8f7853d1 of MDC which causes the framework autoroller to fail. A patch has been proposed to MDC to add correct nullability specifier to the file. Until this fix lands and rolls, disable the warning when building MDC. Bug: 1153275 Change-Id: Iaa1c6645333c06e8d5b2da0343835f9503100237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562661 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831797}
-
![Roman Sorokin [CET]'s avatar](https://secure.gravatar.com/avatar/7b28a287700b8b8659a03c33a38be1a8?s=80&d=identicon "Roman Sorokin [CET]")
