- 11 Nov, 2020 40 commits
-
-
Joe Downing authored
This change will allow an admin to set a policy to prevent any UI from being shown when a user connects to a non-curtained session. This change is targeted at improving the user experience when the machine is not physically accessible (i.e. we know that a local user cannot interact with the machine) and we want to remove the disconnect window and any other UI in that case. Change-Id: I3ba89e7aaf7538ae5cce4385fb65256cb202ef5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527984 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#826351}
-
Peter Kotwicz authored
BUG=1029038 Change-Id: I81ccafffacc1188e485d9950ee84141143e7a8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527627Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826350}
-
Travis Skare authored
Note: Based on a few historical bugs that address a similar issue. Could not repro on my personal test device, will coordinate verification with reporter. Bug: 1145497 Change-Id: I3d1f9781037fad41cb1f7af578781eed9b7c1ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529971Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#826349}
-
Ian Barkley-Yeung authored
This is the heart of the WebUI JS Error Reporting change. Have the WebUIImpl::MainFrameNavigationObserver observe errors and, if appropriate, send them off as error reports. Since WebUIImpl::MainFrameNavigationObserver is gaining a sigificant amount of functionality, split off into its own class, WebUIMainFrameObserver, to aid unit testing. Also removed the word 'Navigation' from the name as it now observes console messages as well. This is all hidden behind a flag at the moment, so no actual error reports should be generated. It's not complete. This is just 'step 4' in the design document. The error reports still don't have a stack, and we don't handle subframes properly, among other things. Bug: chromium:1121816 Change-Id: I2640afe97ef3d8dd9f92e677844f59e1b08822e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488345Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#826348}
-
Daniel Hosseinian authored
Custom margins break when the previewed content is rotated. Rotating is also a very rare user action in print preview, and it is already unavailable through a UI. Remove the keyboard shortcuts and the context menu options. Bug: 275471 Change-Id: Ia8e9e0efa0c2a676bd0e7a916e1fa848a4a21527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527905Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#826347}
-
Charlie Hu authored
This CL renames 'feature-policy-violation' report type to 'permissions-policy-violation'. Note: [Feature policy reporting](https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=832?q=runtime_enabled_features.json5&ss=chromium) is currently experimental. Bug: 1123116 Change-Id: I7c2c069ef47af4974337b9893f52b26af34dbbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505125Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#826346}
-
Kent Tamura authored
TextField's child box can be taller than the intrinsic content height. So we should center the child box if |ChildAvailableSize().block_size| is not provided and the intrinsic block size is provided. Bug: 1040826 Change-Id: If22091b06bf9b61a6e72eaca045c89fc58b07f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522801 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826345}
-
dpapad authored
Presentation mode needs more work, as it's not supposed to be simply a full screen version of the main content area of the PDF Viewer. Putting it behind PdfViewerPresentationMode flag to facilitate further work on that feature. Fixed: 1147518 Change-Id: I7e81b7f3f26497c19ac490a82c90c2be2b647fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531896Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826344}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/184f98a6b7b4..3a4b8f58ae03 2020-11-11 aerotwist@chromium.org [Timeline] Fix blank traces when impacted_nodes is missing 2020-11-11 tvanderlippe@chromium.org Use TypeScript-authored files in media/ 2020-11-11 me@heardanieljames.com Add 'Save' for images in frames displayed under the Application tab 2020-11-11 janscheffler@chromium.org [WebAuthn] Move newly added authenticator into view 2020-11-11 jacktfranklin@chromium.org Fix new data-grid empty state. 2020-11-11 petermarshall@chromium.org [tests] Re-export mocha functions properly in mocha-extensions 2020-11-11 tvanderlippe@chromium.org Redirect front_end/marked to third_party/marked 2020-11-11 tvanderlippe@chromium.org Use TypeScript-authored files in protocol_monitor/ 2020-11-11 janscheffler@chromium.org Fix regression introduced by typescriptification 2020-11-11 janscheffler@chromium.org [WebAuthn] Add learn more link 2020-11-11 aerotwist@chromium.org TypeScriptify ChartViewport.js 2020-11-11 yiorsi@gmail.com Fix flex or grid adorner is not vertically centered in simplified Chinese version of Chrome 2020-11-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-11 wolfi@chromium.org Disable flaky test 2020-11-11 janscheffler@chromium.org [WebAuthn] Fix flashing text when enabling the panel 2020-11-11 sigurds@chromium.org Display connection id '0' as empty cell in network log 2020-11-11 alexrudenko@chromium.org Add a method to calculate contrast according to APCA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1101784,chromium:1121900,chromium:1125968,chromium:1145186,chromium:1147382,chromium:1147806 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I930f8257b1d5cdbf8106b8ab3cb07a13cfa8c301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826343}
-
Xing Liu authored
Change two strings to plural strings. e.g. "1 unread pages" to "1 unread page". Bug: 1133496 Change-Id: Iecccc6f87feaef3e1237e09f72d16f64d002bd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531494Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826342}
-
Luke Zielinski authored
on wptrunner bots. This is in preparation for triaging the test results. As part of the triage, many of these tests will get more accurate metadata-based expectations created for them. Change-Id: Ia25b03d4cf26bdefd6012528ae21e450b630616b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502949 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826341}
-
David Maunder authored
Storing the price as a string does not scale to the use case where we need to only show a price difference in the event of a decrease in price. Storing as an int64 and storing in micros was chosen because it enables price comparisons and scales to inflated currencies such as yen and provides fractional digits as required. Bug: 1145770 Change-Id: Ia5ced49146ff8dbf1140f2e96328ad58b108e68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528168Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6835e1ab1918..0d4297e6b205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If325d26d5046024f427c2282919125956aafd58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532923Reviewed-by:
-
Leonard Grey authored
Styling still WIP. This change enables the UI to show a prompt chip when a composite command is selected. - Selecting a composite command clears the input and shows a chip with a prompt - Backspace over the prompt when the input is empty informs the backend that the prompt was cancelled, restores the previous user input, and requeries Bug: 1014639 Change-Id: I3fff2bf6cacab28b473c8ddee3a7a41fbb6df945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530796Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#826338}
-
Nico Weber authored
TBR=mstensho Bug: 1147315 Change-Id: I915e4a97e47e02a657fe67d4534694c59bf2552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533017Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826337}
-
Peter Kotwicz authored
This CL adds exported deps for: - org.checkerframework:checker-compat-qual - org.codehaus.mojo:animal-sniffer-annotations This is in preparation to switching to the maven version of guava in order to avoid conflicts with the internal version of guava. BUG=1144019 Change-Id: I4a2c49445f0ae389d508b7bcaac3da9b88935c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527262Reviewed-by:
-
Antonio Gomes authored
This is a reland of 73e9db73 Differs from the original CL by adding a `DEFINE_EXPORTED_UI_CLASS_PROPERTY_TYPE` declaration needed for linking. Original change's description: > Move DefaultFrameHeader to //chromeos/ui/frame/ > > This header/class is directly used by BrowserNonClientFrameViewAsh. > This steps goes one step closed to allow this class to be shared > with Lacros. > > BUG=1113900 > R=jamescook@chromium.org, oshima@chromium.org > > Change-Id: I185560a34265e6ff13c48b48634faf6826f2236a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529570 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825896} R=jamescook@chromium.org Bug: 1113900 Change-Id: Ic0049f5024832104600d6b4e83cb86f1986db120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530292 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#826335}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6f52c21..48a46dd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99064aad8bcae0e1279efbf0100d92258707cb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532673Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826334}
-
Peter Kasting authored
This fixes an insufficient line height issue and improves text contrast. Bug: 1138840 Change-Id: I90030ad6e63dc0642378da26f34a9012c255decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521285 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826333}
-
Kent Tamura authored
crrev.com/804045 changed the intrinsic height of the slider container to 'min-height'. It caused a positioning error in a case where the slider height is shorter than the container's min-height. This CL fixes it by specifying 'align-self: unsafe center' to the slider container. Bug: 1146385 Change-Id: I52313ba86e65799338adff4136be33f020919363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526855 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826332}
-
Jinsuk Kim authored
The reported failing test is a new one that's supposed to run on phone only, but was not annotated accordingly. This CL fixes that. Bug: 1147228 Change-Id: I61d8d0f68bd11fd3112a02a8b272237708010c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526663 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
What's happening is that as the search field goes from empty to having text, the shadow generic container inside of the input goes from not being in the tree to being in the tree. But in AXNodeObject::ChildrenChanged(), we use LastKnownIsIncludedInTree() and we can't update it to a new value. So we think it's still not included in the tree, and update the parent's children. But we also need to update its children too. Originally backed out because it was suspected to be related to test timeouts here: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/76067 Relanding so that we can prove it one way or another. I suspect it was not related. NOTRY=true Bug: 1146214 Change-Id: Idb814ec95f6f04460dda81439b164e214a7ef14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533157Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826330}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5acf6a857b48..bd3792de72cb 2020-11-11 bsalomon@google.com Add SkYUVAInfo-based promise texture image factory 2020-11-11 adlai@google.com Use SkSpan to clean up GrOnFlushCallbackObject API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I0a2d98a55a6a1a5f8d29b0719d256b9e8043554f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532922Reviewed-by:
-
chrome://policyGuillaume Jenkins authored
Some existing policy tests load the chrome://policy page and ensure that it loaded correctly by checking for the checkbox label at the top of the page. This doesn't help catch Web UI issues that happen when displaying the policy table further down the page. This CL changes the selector so it looks for the policy table header, which should help catch more WebUI problems in the future. Bug: 1147191 Change-Id: Ib6c0a7c13d689d12f62eca5c88873bb31e749891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530173Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#826328}
-
Muhammad Hasan Khan authored
Bug: None Change-Id: I72263ea0706df61d7349f0d403e7d1750607d250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530194Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#826327}
-
Liquan (Max) Gu authored
Changes: * Replaced `mPaymentUiService.getPaymentRequestUI() == null` with `mIsCurrentPaymentRequestShowing` as the way to check for 'update- without-show". * Renamed "parseAndValidateDetailsForSkipToGPayHelper" as "parseAndValidateDetailsFurtherIfNeeded" because PRService needs to call it, and PRService does not know about skip-to-gpay. * Moved the main logic of CPRService#updateWith into PRService, with the remaining part called onPaymentDetailsUpdated() left in CPRService. * Since "invokedPaymentApp.updateWith()" is moved into PRService, PRService delegates the dependency MethodChecker. Bug: 1131059 Change-Id: If305338491240b16d230e3ab6b43d0c64c256de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530312 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826326}
-
Chris Lu authored
UXR suggested a new string for the Location Permissions modal that will show before triggering the native location prompt. The modal is a part of an experiment changing the location permissions user experience. Bug: 1138603 Change-Id: I3c9e010785b436b4d6ed506037518df58f591c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530738Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#826325}
-
Natalie Chouinard authored
Toasts with messages that extend beyond a single line should be wrapped to multiple lines rather than truncated. Bug: 1143402 Change-Id: I605f814a03f95628aae0deb5cb7970d0ac66af71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530893Reviewed-by:
-
Yue Zhang authored
Prior to this CL, the tabs created through actions in StartSurface (e.g. clicking MV tiles, using fake box, etc) cannot have parent tabs. This becomes a problem when TabGroup is enabled, as we use parent-children relationship of tabs to maintain TabGroup. This CL fixes this issue by passing down a parent tab supplier to components in StartSurface, so that we can create tabs with parent tabs if needed in StartSurface. Bug: 1119256 Change-Id: Idcc4aafc89a91b1617c7eb14bcc3f448652fbc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444392Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Bailey Berro authored
This change adds the memory test to the SystemRoutineController. Bug: 1128204 Change-Id: I9910664a1f5dd6f5c37f000ea5c965242d9583db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488709Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#826322}
-
Vladimir Levin authored
This patch renames the two functions to indicate that they are used in test environments only. R=danakj@chromium.org Change-Id: I6c76733f2791df4763df2d6ebcf4fc38557aafd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523445 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#826321}
-
Steven Valdez authored
This adds support for the V2 versions, updates the DST and removes verification of the Trust Token redemption records. Bug: 1138432 Change-Id: I3fde214b47d60853e81d9f802c52ea3333745537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527602 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#826320}
-
Leo Lai authored
According to the current program flow, this to-be-removed branch seems a useless special handling. This CL might affect how UserSessionManager utilitzes tpm manager client in the near future. BUG=b:172748724 TEST=unittests. Change-Id: I93f05a45409878db1138c8d49d835f1d7f0c427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525471Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#826319}
-
Filip Gorski authored
Moves the Embedder interface from OmniboxSuggestionsDropdown to a separate file with the name: OmniboxSuggestionsDropdownEmbedder. This interface used to be a standalone thing to begin with and we moved it inside for the period of refactoring. It makes sense to have it standalone, because that is the only part that embedder needs to implement/know of to effectively integrate with the dropdown. Bug: 1075602 Change-Id: Iee75626462b88b343790dbebc31477b9ae33e54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530894Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#826318}
-
Nico Weber authored
After the 2nd-to-last clang roll, release component builds make chrome crash on launch due to CFG. Disable CFG for component builds until we roll in a fix. This does not affect shipping chrome, which doesn't use component builds. CFG was already disabled in debug component builds. Bug: 1147194,1147445 Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#826317}
-
S. Ganesh authored
All the new library/class/interface ids in the BUILD file are now dynamically generated by midl, based off the product name and current version. Bug: 1109612 Change-Id: I3f0806c7266184c78fd61ff25ac511834dc2ed56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530525Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826316}
-
Guillaume Jenkins authored
Enables CBCM by default on Chrome branded build (the --enable-chrome-browser-cloud-management command-line switch is still needed for Chromium builds). Because the logic for checking whether CBCM is enabled or not is now back to being the same on all platforms, this change also removes the IsEnabled delegate method and brings the check back to the core CBCMController class. As a result, the command switch declaration was moved to components so it can be shared between platforms. Bug: 1111435, 1097161 Change-Id: I5f15f06885b4deb3974616667273706931df6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522981 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826315}
-
danakj authored
Convert RenderWidgetHostNSView mojom to use ui::Cursor instead of WebCursor. Then WebCursor is no longer used, which was previously using the SkBitmap param traits.. R=dcheng@chromium.org TBR=inferno@chromium.org Bug: 1144462 Change-Id: I5f06739475e5421ba5f6acdca985bf0e03182744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523334Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826314}
-
Liquan (Max) Gu authored
Context: Currently, "waitForUpdatedPaymentDetails" is used in the payment codebase to mean two things: (1) an action: whether show() should be blocked from showing the payment details until the merchant passes in the payment details with show()'s PaymentDetailsUpdate promise. (2) a state: whether the payment details is now pending for update - once the details is received, the state is reset to false. These two meanings makes it ambiguous for code readers. To clarify it, this CL create mIsShowWaitingForUpdatedPaymentDetails to make it clear when it represents a state (meaning #2). Also, "isShow" makes it easier to read when this variable appears out of the scope of show(), e.g., in PaymentUiService for example. This CL also renames initializeWithUpdatedDetails() as continueShow() to make the control logic explicit. Changes: * Renamed some waitForUpdatedPaymentDetails as isShowWaitingForUpdatedPaymentDetails when it means a state. * Renamed initializeWithUpdatedDetails as continueShow. * Documents about show()'s PaymentDetailsUpdate promise in updateWith(). Bug: 1131059 Change-Id: I6c6b99ce5149c22fc6d7d4327e1eae0dacd10e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529618Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826313}
-
Roman Sorokin authored
Also modify test to verify the behavior. Bug: b/168759134 Change-Id: Ic04de90bb393efba4ad262090305e8232f398a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532075 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826312}
-
