- 04 Nov, 2019 40 commits
-
-
Andy Paicu authored
This reverts commit d1531b9a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 Sample Failed Step: browser_tests Original change's description: > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > The general idea here is to encapsulate more of the hotseat's behavior > into its own class rather than have it all over the shelf layout > manager. Eventually, I hope to get rid of the huge > "CalculateHotseatState" method by setting the hotseat state to the > appropriate values from the relevant places. > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711796} TBR=xiyuan@chromium.org,manucornet@chromium.org Change-Id: I7dd2357dd075bee067c3bad1aa58db788ba1039e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893885Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712119}
-
Huanzhong Huang authored
Currently, cookie controls is hidden when the original third-party cookie blocking is enforced or turned on by the user. This change make it so that cookie controls always stays; in the above situations, cookie controls is disabled, toggle set in accordance with third-party cookie blocking, with an tooltip icon for more information. Bug: 1019706 Change-Id: I3e7892bcda7eaf70c227a0280219307699cf3bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881558 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#712118}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/314fd3513d04..6df81ebf1dcf git log 314fd3513d04..6df81ebf1dcf --date=short --no-merges --format='%ad %ae %s' 2019-11-01 bryan.bernhart@intel.com Support for resource heap tier 2. Created with: gclient setdep -r src/third_party/dawn@6df81ebf1dcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I8233c5e6def6a7d217a9a95332a69681dc7c1441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712117}
-
David Van Cleve authored
(Original commit failed due to a merge conflict.) This CL adds logic processing ESNI DNS responses and surfacing the results via ResolveHostRequest. It contains some nontrivial functionality and some boilerplate. The nontrivial functionality (host_resolver_manager.cc and unittests): - adds the addresses from ESNI records to the *address list* contained in the HostCache entry, so that existing TCP connection logic will be able to connect to ESNI-accompanied addresses in the same manner as addresses without ESNI keys. Before sorting the addresses, partition them on whether or not they have accompanying ESNI keys, so that the stable sort in AddressSorter implicitly breaks ties in favor of addresses associated with ESNI keys. The boilerplate (all changes except HostResolverManager): - extends all "expect only one field is present" logic in prior host_resolver_manager unittests to reflect that there's now another field - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI - extends all subclasses of ResolveHostRequest to implement GetEsniContent() Testing: - Adds a new group of HostResolverManager unittests for ESNI queries. Bug: 1003494 Change-Id: I6ec719d134940d281b2d5a6f366454315cbd2869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895398 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#712116}
-
Scott Violet authored
And adds support for BrowserFragmentControllerImpl containing multiple BrowserControllers. This patch doesn't contain support for creating more than one BrowserController in a BrowserFragment. That will come next. The reason I'm seperating the Views is to support multiple browsers, and it seems as though we should support deleting the view, which is easier with a self contained class. BUG=none TEST=none Change-Id: Idc4a6b2405350b5f9f84d1c046c6d8f839a87ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894749 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712115}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26280ecc7991..5f25e481c49d git log 26280ecc7991..5f25e481c49d --date=short --no-merges --format='%ad %ae %s' 2019-11-04 fmayer@google.com Merge "Count retained and uniquely retained bytes." 2019-11-04 treehugger-gerrit@google.com Merge "Add 'mojom' to ipc tracing and 'navigation' and 'browser' to navigation & loading." 2019-11-04 treehugger-gerrit@google.com Merge "TrackEvent: Migrate from legacy_event.name_iid to track_event.name_iid" Created with: gclient setdep -r src/third_party/perfetto@5f25e481c49d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6a891a4b735aed2c631e7a3746c7ba3efd1dd85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896678Reviewed-by:
-
Sigurd Schneider authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/8cfb8ccc1a..7789823ec9 TBR=yangguo@chromium.org Change-Id: Ia6a3dd292950f61947c95f0ee6e78d226ade5312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893883Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#712113}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97701892. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0071333c67ac5c4d4fd339ecbb3528df7fe7a8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712112}
-
Luke Zielinski authored
The filename of metadata for a multiglobal test must match the name of the FILE that the test originated from, not the name of the test itself. So for a file like foo.any.js which generates foo.any.worker.html, the metadata file must be foo.any.js.ini. For this we must maintian a reverse-mapping from test name to test file in WptManifest and allow lookups via the Port. Bug: 937369 Change-Id: Ida16d68d6e0e4ea113b3cd0a1ce05ad9b5cbbc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893141Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712111}
-
Michael van Ouwerkerk authored
Bug: 1018135 Change-Id: I3f7694d208ed1cdc5064c8af2a2b7de70a172a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893998Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#712110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53ede12e..557cb1d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iba10c157b767737f872d8629f1f8bf383bb6bd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712109}
-
David Maunder authored
TabSuggestionsObserver is used by the orchestrator to broadcast messages about new suggestion results and when tabContexts become invalidated. Bug: 1017896 Change-Id: I5ba99bd920a8fefccf94a3b7137e7dff8bb1074c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879600 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712108}
-
Koji Ishii authored
Following bot results are included. 156 158 162 164 165 168 169 170 171 174 22 lines were removed and 41 lines were deflaked by consecutive results since 140. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id0fcef100da11b89b85047ab9275fe246c334855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892984Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712107}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=sergeyu@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I4f27cfa3d6a83257fcbce08a7b85b82795a9baa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894880 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712106}
-
Mathias Carlen authored
Before this patch required and optional arguments part of a direct action / AA script were not relayed through the direct actions layer. This patch properly adds these args according to the proto definition provided by the backend and forwards those args to the direct action android stack. R=szermatt@chromium.org Bug: b/138833619 Change-Id: I964addd2822c81ccd01353f42085889bafa21ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895332 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712105}
-
Christian O. Andersson authored
weblayer/OWNERS Bug: n/a Change-Id: I46cdc1bb985281a775f0dc01b95366594e3e7b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873727Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Christian O. Andersson <cricke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712104}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcOfferOptionsPlatform directly. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic1d6c34e6d85523cdcd473f74c894e8043924fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884931 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712103}
-
Sean Kau authored
The device cloud policy handlers vector holds unique_ptrs to handlers. It's more readable to call push_back rather than emplace_back since the unique_ptr is created by std::make_unique rather than a call to the unique_ptr constructor. Bug: chromium:1020443 Change-Id: I28326d2a516099865959466c0a3b0522adcfa304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891075 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#712102}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=dullweber@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Ida079509147e988cddc134174315d8d24000a73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895635 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Mark Cogan authored
ChromeTestCase exposes an EmbeddedTestServer property for use by tests, and includes the header for that class in its own header. This means that tests can (and do) use symbols from EmbeddedTestServer without explicitly including them. To make this work, //net:test_support is a public dependency of the egtest test_support targets, so the individual egtest targets can link correctly. This is in general not in line with our "include what you use" policy, which would prefer that code which uses symbols from an API directly includes the header for that API, and explicitly declares it as a dep in gn. This CL: - Makes the test_support dependencies on //net:test_support private. - Changes the EmbeddedTestServer header include in chrome_test_case.h to be a forward declaration. - Updates nineteen egtest.mm files to explicitly include the EmbeddedTestServer header. - Updates twenty-seven targets in BUILD.gn files to have add a //net:test_support as a dependency. Change-Id: Iea336c66a1a7423732e3aaedcf865882b7ac3a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892814 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712100}
-
Mugdha Lakhani authored
Stops periodic background sync timers when the scheduler is destroyed. Change-Id: Ic1d2412df473d74206347cfafbd0fb8c0771b846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893882 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712099}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I0265753725783fb569783ba6006dec01d7793851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893881 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712098}
-
Andy Paicu authored
First failing build: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/50593 TBR=mmenke@chromium.org Bug: 1021021 Change-Id: Iaa80a2212610d407ed1062b50fb8309dd12dfcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894010Reviewed-by:
-
Andy Paicu authored
This reverts commit d8a95882. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "CrOS Shelf: Start moving some hotseat logic into the hotseat widget" > > This reverts commit d1531b9a. > > Reason for revert: > > Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the > culprit for failures in the build cycles as shown on: > https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM > > Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 > > Sample Failed Step: browser_tests > > Original change's description: > > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > > > The general idea here is to encapsulate more of the hotseat's behavior > > into its own class rather than have it all over the shelf layout > > manager. Eventually, I hope to get rid of the huge > > "CalculateHotseatState" method by setting the hotseat state to the > > appropriate values from the relevant places. > > > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > > Commit-Queue: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711796} > > TBR=manucornet@chromium.org, xiyuan@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I231b1da00af70f302dee4382dd05948031af4cf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897695 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712092} TBR=andypaicu@chromium.org Change-Id: Ie10e97f8df7b251ff40d2282808d6ae3369abe2d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893884Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1018130 Change-Id: I9414fc7c9f4b577d1e4b308749fed2da9aef24f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893163Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icd106c73f2dfba2af3a947b0de42de3b93a6595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897636Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=marq@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Ib6832ed38491ccee5452b66cf2ba26f98d530cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895652 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#712093}
-
Andy Paicu authored
This reverts commit d1531b9a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM Sample Failed Build: https://ci.chromium.org/b/8897957936228871696 Sample Failed Step: browser_tests Original change's description: > CrOS Shelf: Start moving some hotseat logic into the hotseat widget > > The general idea here is to encapsulate more of the hotseat's behavior > into its own class rather than have it all over the shelf layout > manager. Eventually, I hope to get rid of the huge > "CalculateHotseatState" method by setting the hotseat state to the > appropriate values from the relevant places. > > Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711796} TBR=manucornet@chromium.org, xiyuan@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I231b1da00af70f302dee4382dd05948031af4cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897695Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a4037d9f325..26280ecc7991 git log 6a4037d9f325..26280ecc7991 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 treehugger-gerrit@google.com Merge "processor: Retain original event ids during export + always export args" 2019-11-04 hjd@google.com Merge "Support UUID" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Don't build VulkanMemoryTracker if graphics module disabled" 2019-11-04 treehugger-gerrit@google.com Merge "processor: Exclude syscalls from build if not needed" Created with: gclient setdep -r src/third_party/perfetto@26280ecc7991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idd82656817c5606e8299bf5c67ffc7edd263251f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897635Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cc2dc64ff13..feac94f2761d git log 4cc2dc64ff13..feac94f2761d --date=short --no-merges --format='%ad %ae %s' 2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e96039218e9d..6c7208f93d6e (8 commits) 2019-11-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fda994c63075..aaa64b76c0b4 (8 commits) Created with: gclient setdep -r src/third_party/skia@feac94f2761d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None,chromium:None Change-Id: Ibc44e2d17f510eb53b8fca0e663e77b5cf4f8c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896147Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8846c8af8511..cc9bf6398c03 git log 8846c8af8511..cc9bf6398c03 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 peah@webrtc.org Revert "Correct AEC3 multichannel functionality activation" 2019-11-04 nisse@webrtc.org Delete gturn support 2019-11-04 peah@webrtc.org Correct AEC3 multichannel functionality activation Created with: gclient setdep -r src/third_party/webrtc@cc9bf6398c03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I781abb115c3fecb8f204cfe445fbfac9d8806665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897354Reviewed-by:
-
Andy Paicu authored
Failing first build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16066?blamelist=1#blamelist-tab Suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 TBR=manucornet@chromium.org Bug: 1021011 Change-Id: I91acd45ed360f5bf4ea24987025bc173b096acb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895346 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Alex Ilin authored
This CL adds a new test DemoSignInTest::TurnOffSync to the suite of live Signin tests. The test does the following: - Turn on sync for Account A - Sign in Account B from the web - Check that Sync is enabled for Account A - Turn sync off from the settings - Check that both accounts are signed out from Chrome and the web This CL also simplifies JavaScript code used to sign user in. Fixed: 1006263 Change-Id: Idd901e5d2eaf55fe69fcbc41d304e25d9fd87ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893994Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712087}
-
Oleg Davydov authored
ExtensionDownloader now reports to its delegate cache status (hit/miss/outdated version) of the extension. We need it for later to gather statistics and, in turn, to investigate how effectively cache works, for example, for force-installed extensions. Bug: 1015817 Change-Id: I22a0e73d2926f073a231fe13c73879608e2df7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868881Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Olivier Robin authored
Change-Id: I8e294d3c99382336ec425c67bb43a29cabdf89df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889871 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Peter E Conn authored
This means that we can replace Origins that are invalid with null. Bug: 1018672 Change-Id: I6faf89e66ea0085ba35b5bab10c58d2ac25a631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886890 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712084}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/618ee509421f..f1e5cd73f658 git log 618ee509421f..f1e5cd73f658 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 afdx@google.com spirv-fuzz: improvements to representation of data synonym facts (#3006) 2019-11-01 stevenperron@google.com Add iOS as a supported platform (#3001) 2019-11-01 rharrison@google.com Reset pointers before iterating in fuzzer to avoid double free (#3003) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f1e5cd73f658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I781d88b3feeae2f9857a902cfe7fc0e44bdd6099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896152Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f00c5e49. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If294a0c1d3d67d7581769f0f8f93b51f08bf5a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897446Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1018133 Change-Id: Ieef750cae110765d8df7333647cf9865f2ac412f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893281Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Antonio Gomes authored
The later is a 1:1 wrapper to the former, and now that the WebRTC feature is Onion soup'ed, the use of third_party/webrtc types is preferred. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I22853ca19e1fe67a95a8508a2bbb7b3ad25ec17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884473 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
