GitLab

This patch fixes CSS outline property for inline elements in flipped
blocks Writing Mode (vertical-rl.)

LayoutObject::addOutlineRects() returns rects in the object's
coordinate, which does not take flipped blocks into account if the
object is not a LayoutBox.

This patch calls LayoutObject::localToContainerRects(), which is
extracted from LayoutBoxModelObject.

BUG=491454

Review URL: https://codereview.chromium.org/1458733002

Cr-Commit-Position: refs/heads/master@{#361297}

Revert of Serve mojo WebUI resources from the same origin as the WebUI itself. (patchset #2 id:20001 of https://codereview.chromium.org/1457623004/ )

Reason for revert:
Causing test failures in the Cast Linux bot, content_browsertests, tests WebUIMojoTest.EndToEndPing and WebUIMojoTest.ConnectToApplication.
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/13153/steps/content_browsertests
Stack trace:
[ RUN      ] WebUIMojoTest.ConnectToApplication
[8517:8517:1124/000407:287044551:FATAL:web_ui_mojo_browsertest.cc(71)] Check failed: base::ReadFileToString(path, &contents, std::string::npos). web_ui_mojo_shell_test.html
#0 0x000000b4fa0e base::debug::StackTrace::StackTrace()
#1 0x000000b5bbeb logging::LogMessage::~LogMessage()
#2 0x0000006d96a7 content::(anonymous namespace)::GetResource()
#3 0x000002f21749 content::WebUIDataSourceImpl::StartDataRequest()
#4 0x000002f1fb9f content::URLDataManagerBackend::CallStartRequest()
#5 0x000002f20588 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIPFv13scoped_refptrIN7content17URLDataSourceImplEERKSsiiiEEENS0_8TypeListIJPS5_S8_RKiSF_SF_EEEE8MakeItSoESB_SD_S8_SF_SF_SF_
#6 0x000000ba8a3d base::debug::TaskAnnotator::RunTask()
#7 0x000000b6091b base::MessageLoop::RunTask()
#8 0x000000b60c29 base::MessageLoop::DeferOrRunPendingTask()
#9 0x000000b60dfd base::MessageLoop::DoWork()
#10 0x000000b48e89 base::MessagePumpLibevent::Run()
#11 0x000000b6e600 base::RunLoop::Run()
#12 0x0000009b669c content::RunThisRunLoop()
#13 0x00000095d853 content::NavigateToURL()
#14 0x0000006d9f68 content::(anonymous namespace)::WebUIMojoTest_ConnectToApplication_Test::RunTestOnMainThread()
#15 0x00000095d2c5 content::ContentBrowserTest::RunTestOnMainThreadLoop()
#16 0x0000009a7a9a content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#17 0x00000099f86e content::ShellBrowserMainParts::PreMainMessageLoopRun()
#18 0x000002d9b015 content::BrowserMainLoop::PreMainMessageLoopRun()
#19 0x000002ee8397 content::StartupTaskRunner::RunAllTasksNow()
#20 0x000002d991ea content::BrowserMainLoop::CreateStartupTasks()
#21 0x000002d9dc96 content::BrowserMainRunnerImpl::Initialize()
#22 0x00000097e635 ShellBrowserMain()
#23 0x000000978af2 content::ShellMainDelegate::RunProcess()
#24 0x000002d73ea2 content::RunNamedProcessTypeMain()
#25 0x000002d74731 content::ContentMainRunnerImpl::Run()
#26 0x000002d73610 content::ContentMain()
#27 0x0000009a75ea content::BrowserTestBase::SetUp()
#28 0x00000095d1b3 content::ContentBrowserTest::SetUp()
#29 0x000000ac41b8 testing::Test::Run()
#30 0x000000ac517a testing::TestInfo::Run()
#31 0x000000ac5613 testing::TestCase::Run()
#32 0x000000acc9d9 testing::internal::UnitTestImpl::RunAllTests()
#33 0x000000acc67e testing::UnitTest::Run()
#34 0x0000009c9dc1 base::TestSuite::Run()
#35 0x0000009603d6 content::ContentTestLauncherDelegate::RunTestSuite()
#36 0x0000009b2806 content::LaunchTests()
#37 0x000000960383 main
#38 0x7f964b45cec5 __libc_start_main
#39 0x000000459519 <unknown>

Original issue's description:
> Serve mojo WebUI resources from the same origin as the WebUI itself.
>
> Currently, mojo resources are served from chrome://mojo and each mojo
> WebUI controller replaces the WebUIDataSource for that origin with one
> containing the resource it needs on construction. If a WebUI page's
> controller (or an equivalent one) was not the last one to be
> constructed, any requests for mojo bindings for its mojo interfaces
> will fail. This change fixes this problem by serving the mojo resources
> from the same origin as the WebUI itself.
>
> BUG=557540
>
> Committed: https://crrev.com/7e10653acb8254226f9b3ca5e0233c298c2ffbc3
> Cr-Commit-Position: refs/heads/master@{#361275}

TBR=sky@chromium.org,jam@chromium.org,tsepez@chromium.org,sammc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557540

Review URL: https://codereview.chromium.org/1467133004

Cr-Commit-Position: refs/heads/master@{#361296}

Move FlagsState class definition to components/flags_ui so that it can
be shared with iOS but leave the global FeatureEntry list definition
in the embedder.

Slightly change FlagsState interface to take the name of embedder
specific switches (switches::kEnableFeatures, ...) and use dummy values
for unit testing.

Split the unit tests moving all those that have no dependency on the
global FeatureEntry to flags_state_unittest.cc. Remove helper testing
function that are no longer useful (overridding global state).

BUG=551954

Review URL: https://codereview.chromium.org/1411453004

Cr-Commit-Position: refs/heads/master@{#361295}

This change migrates the "viewBox" SVG attribute animations over to
SVGRectInterpolationType and enables additive keyframe composite modes
as well as neutral keyframes.

This is a rebased reupload of: https://codereview.chromium.org/1431593004

BUG=530436

Review URL: https://codereview.chromium.org/1415513010

Cr-Commit-Position: refs/heads/master@{#361294}

This patch makes the CSSPropertyParser consume the initial whitespace
at the start, instead of in each of the separate top-level parsing
functions (parseShorthand, parseSingleValue, parseViewportDescriptor,
parseFontFaceDescriptor).

BUG=499780

Review URL: https://codereview.chromium.org/1471933003

Cr-Commit-Position: refs/heads/master@{#361293}

The trace event is associated with the element that was updated,
instead of incorrectly being associated with the element's parent.

BUG=378135

Review URL: https://codereview.chromium.org/1473093002

Cr-Commit-Position: refs/heads/master@{#361292}

Instead of iterating over every handle, only iterate over those that have
a deadline set (and hence can expire). This requires tracking which
handles have deadlines.

A better solution would be to use a priority queue to track the closest
deadline. However, it turns out that no-one currently uses deadlines here, so
the size of |deadline_handles_| will always be 0.

BUG=556865

Review URL: https://codereview.chromium.org/1448233002

Cr-Commit-Position: refs/heads/master@{#361291}

Usage of std::vector for movable types has been recently whitelisted.
https://chromium-cpp.appspot.com/#library-whitelist

BUG=554289

Review URL: https://codereview.chromium.org/1468063002

Cr-Commit-Position: refs/heads/master@{#361290}

This change migrates the "order" SVG attribute animations over to
SVGIntegerOptionalIntegerInterpolationType and enables additive keyframe
composite modes as well as neutral keyframes.

This is a rebased reupload of: https://codereview.chromium.org/1417483015/

BUG=530436

Review URL: https://codereview.chromium.org/1416703004

Cr-Commit-Position: refs/heads/master@{#361289}

The fixme is from 2009[1].

[1] https://chromium.googlesource.com/chromium/src/+/eac8e63e693333ed390be4ae74ac15295c9f95d8

Review URL: https://codereview.chromium.org/1471933002

Cr-Commit-Position: refs/heads/master@{#361288}

https://chromium.googlesource.com/skia.git/+log/93c69fff5350..0a0605d4de31

$ git log 93c69fff5..0a0605d4d --date=short --no-merges --format='%ad %ae %s'
2015-11-23 egdaniel Appeasing the compilers
2015-11-23 egdaniel Fix for recent SrcOver XP Change
2015-11-23 bsalomon Make stencil and cover path rendering have more reasonable bounds.
2015-11-23 joshualitt Remove unecessary GetGlyphIdMetrics call
2015-11-23 joshualitt Move command line print above parse in VisualBench
2015-11-23 egdaniel Don't create a GXPFactory when blend is SrcOver
2015-11-23 joshualitt Move GrAtlasTextBatch blob regeneration to template
2015-11-23 reed scaling API on SkPixmap
2015-11-23 jvanverth Add stroking support to distance field path renderer
2015-11-23 bsalomon Restrict query bounds for reduce clip to dev bounds
2015-11-23 msarett Switch Skia's libjpeg-turbo to 1.4.2
2015-11-23 lsalzman use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in ports/SkMemory_mozalloc.cpp
2015-11-23 mtklein Revert of skstd -> std for unique_ptr (patchset #16 id:300001 of https://codereview.chromium.org/1436033003/ )
2015-11-23 mtklein skstd -> std for unique_ptr
2015-11-23 robertphillips Avoid devolving to a path when conservative clipping with RRects
2015-11-23 fmalita Take span len into account when determining whether gradient is vertical
2015-11-23 scroggo Add SkPngChunkReader.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1474443004

Cr-Commit-Position: refs/heads/master@{#361287}

The bug in GetKnownUserAccountId led to crash on user log on.

BUG=462823
TEST=manual

Review URL: https://codereview.chromium.org/1463753002

Cr-Commit-Position: refs/heads/master@{#361286}

Now it is possible to remove window inside the loop in
TransientWindowManager::OnWindowVisibilityChanged. So
ransient_children_ would contain dangling pointers.

BUG=

Review URL: https://codereview.chromium.org/1464433002

Cr-Commit-Position: refs/heads/master@{#361285}

This UMA reports how much memory did MemoryPurgeController reclaim.

BUG=519146

Review URL: https://codereview.chromium.org/1460603002

Cr-Commit-Position: refs/heads/master@{#361284}

This patch makes visual order elements to ignore bidi-isolate[1]. As a
result, such elements with unicode-bidi: isolate no longer bidi-reorder
their content.

The behavior of bidi-isolate for visual order (iso-8859-8) is not well
defined. It is reasonable to ignore bidi-isolate, however, given visual
order documents ignore dir attributes today.

Without this fix, when bidi-isolate is turned on by default in
crbug.com/391260, dir attributes start to effect, which is likely to
break web-compat.

[1] https://drafts.csswg.org/css-writing-modes-3/#bidi-isolate

BUG=559257

Review URL: https://codereview.chromium.org/1463893002

Cr-Commit-Position: refs/heads/master@{#361283}

To do this, introduces a new render process shared setting for synchronized
painting.

BUG=552545
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1452353002

Cr-Commit-Position: refs/heads/master@{#361282}

This change migrates the following SVG attribute animations over to
SVGNumberOptionalNumberInterpolationType and enables additive keyframe
composite modes as well as neutral keyframes:
 - baseFrequency
 - kernelUnitLength
 - radius
 - stdDeviation

This is a rebased reupload of: https://codereview.chromium.org/1419623009

BUG=530436

Review URL: https://codereview.chromium.org/1418193007

Cr-Commit-Position: refs/heads/master@{#361281}

Cr-Commit-Position: refs/heads/master@{#361280}

Add support for custom properties to the rule property set OM. My
approach adds an extra "if" to many of the standard code paths in
the interest of avoiding unnecessary code duplication, but if
we're really worried about performance, this could be changed.

There are clearly still parts of the code that assumes a property
ID should be enough to lookup an arbitrary property. These will
have to be burned down, but in the meantime I short-circuited
findCSSPropertyWithID for the custom property case.

BUG=551553

Review URL: https://codereview.chromium.org/1405293012

Cr-Commit-Position: refs/heads/master@{#361279}

BUG=550015

Review URL: https://codereview.chromium.org/1471043003

Cr-Commit-Position: refs/heads/master@{#361278}

Metrics added to WebRTC here: https://chromium.googlesource.com/external/webrtc/+/18adf0a79d4a0ea124c7f27fd553382d0b0cb7ac

Review URL: https://codereview.chromium.org/1467233002

Cr-Commit-Position: refs/heads/master@{#361277}

These two macros do the same thing.

BUG=548217

Review URL: https://codereview.chromium.org/1406183010

Cr-Commit-Position: refs/heads/master@{#361276}

Currently, mojo resources are served from chrome://mojo and each mojo
WebUI controller replaces the WebUIDataSource for that origin with one
containing the resource it needs on construction. If a WebUI page's
controller (or an equivalent one) was not the last one to be
constructed, any requests for mojo bindings for its mojo interfaces
will fail. This change fixes this problem by serving the mojo resources
from the same origin as the WebUI itself.

BUG=557540

Review URL: https://codereview.chromium.org/1457623004

Cr-Commit-Position: refs/heads/master@{#361275}

. The sample WindowManager creates various containers, and marks the container
  for user windows to be allowed to have active windows. Other containers may
  also be allowed to have active children in the future.

. For mandoline, the BrowserWindow (which is the WM) marks the root as being
  able to contain active windows. Consequently, the browser window can be
  properly activated.

. Raise a Window to the top when it becomes active.

BUG=548422

Review URL: https://codereview.chromium.org/1459463004

Cr-Commit-Position: refs/heads/master@{#361274}

This is to allow compiling Chrome for Android with use_aura=1.

BUG=507792

Review URL: https://codereview.chromium.org/1467373002

Cr-Commit-Position: refs/heads/master@{#361273}

This can be modified from both the FILE and IO threads.

BUG=559865

Review URL: https://codereview.chromium.org/1464383004

Cr-Commit-Position: refs/heads/master@{#361272}

For menus in chrome-in-mus, we attempt to create a Widget hosted in a native
window. For desktop builds, this means we attempt to host in a HWND or an
X11 window created by DesktopNativeWidgetAura. But for mus, we want to use
NativeWidgetMus. To do this, use the native-widget factory first if it's
available.

BUG=none

Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971
Cr-Commit-Position: refs/heads/master@{#361151}

R=jam@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/1460003004 .

Cr-Commit-Position: refs/heads/master@{#361271}

This patch makes editing/selection/vertical-*.html to use w3c test harness
rather than pixel match for ease of maintain.

This is the first patch of three patches of rewriting vertical-*.html.
Due by Windows command prompt limitation, we can't upload once.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1466543003

Cr-Commit-Position: refs/heads/master@{#361270}

TBR=bruening@chromium.org

BUG=442969

Review URL: https://codereview.chromium.org/1472033002

Cr-Commit-Position: refs/heads/master@{#361269}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/437819f9..6ed50d99

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1464423004

Cr-Commit-Position: refs/heads/master@{#361268}

These tests fail flakily on linux_chromium_chromeos_rel_ng and prevents
patches landing in Chromium CQ.
Disable these tests on CrOS to allow CQ to continue.

Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=DownloadNotificationTest

TBR=yoshiki@chromium.org
BUG=560329

Review URL: https://codereview.chromium.org/1467183004

Cr-Commit-Position: refs/heads/master@{#361267}

Specifying fragment input values with locations bound with
CHROMIUM_path_rendering should work, regardless whether the underlying
driver optimized the variable away or not.

Fixes the case where updating an inactive fragment input would cause
INVALID_OPERATION, because the location was empty.

Fixes the case where updating an fragment input would cause wrong
fragment input to be updated, if the fragment input was inactive and
bound to a location that would be assigned to an unbound fragment input.

Makes the Program::fragment_input_infos_ array linear (non-sparse).  The
location bindings are now handled with
Program::fragment_input_locations_ sparse array.

BUG=542355

Review URL: https://codereview.chromium.org/1415763009

Cr-Commit-Position: refs/heads/master@{#361266}

Create a broker interface for the new Mojo EDK so that the browser can create and duplicate message pipes.

This is needed on Windows because sandboxed processes can't create named pipes or duplicate their handles to other processes. Since the new EDK uses one OS pipe per Mojo pipe, child processes need the parent process' help. When a message pipe is created in a child process, it will ask the browser process to do it. When a child process wants to send a mojo pipe to another process, it exchanges the pipe handle with an integer token that it sends instead. The receiving process can exchange that token with a pipe handle.

With this patch, --use-new-edk works with chrome's sandbox.

BUG=478251
R=rickyz@chromium.org, tsepez@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/1387963004 .

Cr-Commit-Position: refs/heads/master@{#361265}

Leaking it triggered some canary/dev build checks on Windows that ensure we don't leak handles. In this case, the leak is ok, but the simplest thing for now is to stop leaking it. A side-benefit is we ensure that Mojo message loops shut down correctly at process shutdown.

BUG=559238
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1471123002 .

Cr-Commit-Position: refs/heads/master@{#361264}

Reports indicate that this card is affected as well.

TBR=zmo
BUG=543324

Review URL: https://codereview.chromium.org/1469933004

Cr-Commit-Position: refs/heads/master@{#361263}

R=michaelpg@chromium.org
BUG=none
TEST=new Polymer, same great downloads taste!
NOPRESUBMIT=true  # for long lines in crisper.js

Review URL: https://codereview.chromium.org/1462153007

Cr-Commit-Position: refs/heads/master@{#361262}

BUG=529938

Review URL: https://codereview.chromium.org/1473453002

Cr-Commit-Position: refs/heads/master@{#361261}

Review URL: https://codereview.chromium.org/1471653002

Cr-Commit-Position: refs/heads/master@{#361260}

in SDK, it is AppKit.framework/Versions/C/Headers/AppKit.h.
Use the same case, so it would work on case sensitive filesystem.

BUG=

Review URL: https://codereview.chromium.org/1454113004

Cr-Commit-Position: refs/heads/master@{#361259}

This patch is a port of http://wkb.ug/149153, which is a port of a fix
for crbug.com/520282.

The WebKit patch has additional changes to carry more information of
isolated runs along with BidiRun. As we find we need to carry more
context with isolated runs in crbug.com/391260, this change is useful.

BUG=520282

Review URL: https://codereview.chromium.org/1468103002

Cr-Commit-Position: refs/heads/master@{#361258}