GitLab

messaging.js is too large to handle right now.

R=rdevlin.cronin@chromium.org
BUG=475536

Review URL: https://codereview.chromium.org/1097583004

Cr-Commit-Position: refs/heads/master@{#325585}

This makes Speak Selection from the menu work for PDFs on Mac. It also
simplifies the code slightly by creating a function which gets the "full page"
guest if there is one.

BUG=476787

Review URL: https://codereview.chromium.org/1042743002

Cr-Commit-Position: refs/heads/master@{#325584}

BUG=477757

Review URL: https://codereview.chromium.org/1092803002

Cr-Commit-Position: refs/heads/master@{#325583}

In preparation for performing model association while other types are downloading,
the BackendDataTypeConfigurer::ConfigureDataTypes method will now return those
types that are ready to sync without further intervention from sync. These are the
types that were already syncing previously, and therefore don't need to be
downloaded or purged.

A followup patch will add the association logic and tests.

BUG=477063

Review URL: https://codereview.chromium.org/1081413003

Cr-Commit-Position: refs/heads/master@{#325582}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fd0ecf4..d803cda

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1095683003

Cr-Commit-Position: refs/heads/master@{#325581}

This CL cleanups the globals in remoting.js and removes the file itself.
Summary of changes:
1. remoting.getExtensionInfo() -> Application.getExtenstionInfo()
2. remoting.timestamp() -> base.timeStamp()
   I also simplified the implementation with Date.getISOString() instead of
   a custom formatter.
3. remoting.initGlobalObjects() -> Application.initGlobalObjects_()
4. remoting.formatIq -> ClientSession.iqFormatter_

BUG=477119

Review URL: https://codereview.chromium.org/1070223003

Cr-Commit-Position: refs/heads/master@{#325580}

This also adds a GetDelegate() method to the Navigator interface.

BUG=470082

Review URL: https://codereview.chromium.org/1080143003

Cr-Commit-Position: refs/heads/master@{#325579}

Summary of changes:
1. Uses base.OneShotTimer
2. Uses base.EventHooks
3. Uses
     SmartReconnector.prototype.foo = function() {...}
   instead of
     SmartReconnector.prototype = {
       foo: function() {...},
     }
4 Removes this.bound_

BUG=

Review URL: https://codereview.chromium.org/1091103002

Cr-Commit-Position: refs/heads/master@{#325578}

Crash and playback startup success rates remained the same before
and after this change, so reverting the additional complexity. I've
left the cleanup of internal functions though.

BUG=422522
TEST=things work as before.

Review URL: https://codereview.chromium.org/1091093002

Cr-Commit-Position: refs/heads/master@{#325577}

At the moment, all compile-time switches are lowercase. By enforcing
this, we can skip converting it to lowercase on Windows, which saves
one string allocation per call.

On a profile with 2 extensions, HasSwitch is called ~12k times during
startup. In an ideal situation (no paging/cache pressure), the
string allocation under Windows takes ~137ns on an Xeon E5-2690 @
2.9Ghz. So this should shave off at least 1.6ms off a typical startup
with this hardware. For context,
Startup.BrowserMessageLoopStartTimeFromMainEntry is typically
280-300ms on the same hardware, so we should get a ~0.5% improvement.

BUG=472383

Review URL: https://codereview.chromium.org/1046363002

Cr-Commit-Position: refs/heads/master@{#325576}

Revert of Make a mojo:apptests GN meta-target, add apptests. (patchset #3 id:60001 of https://codereview.chromium.org/1050233005/)

Reason for revert:
Caused compile failures (many errors, one example below) on Mac GN bot:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/7019/steps/compile/logs/stdio

gen/mojo/services/html_viewer/blink_resource_map.h:37:58:error: no newline at end of file [-Werror,-Wnewline-eof]
#endif // MOJO_SERVICES_HTML_VIEWER_BLINK_RESOURCE_MAP_H_

Original issue's description:
> Make a mojo:apptests GN meta-target, add apptests.
>
> Add an apptest meta-target in mojo/BUILD.gn.
> Move the apptests targets specified in src/BUILD.gn.
> Add the remaining apptest targets (clipboard, VM, WM).
>
> Was limited to release, allow debug, but exclude component.
> See gn_debug compile error from including component build in PS2:
>   FAILED: /b/build/slave/linux_chromium_gn/build/src/buildtools/linux64/gn --root=/b/build/slave/linux_chromium_gn/build/src -q gen //out/Debug/
>   ERROR at //mojo/shell/BUILD.gn:13:1: Assertion failed.
>   assert(!is_component_build)
>
> BUG=NONE
> TEST=Building mojo:apptests builds all local apptest binaries (on dbg too!).
> R=sky@chromium.org
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/16b112790f541670d5f2ab97dfa70c8b89b44b1f
> Cr-Commit-Position: refs/heads/master@{#325570}

TBR=sky@chromium.org,ben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/1093763002

Cr-Commit-Position: refs/heads/master@{#325575}

Android support library has a bug b/20307607 that causes it
to ignore padding set in XML on older (API 16) Android devices.

BUG=469568

Review URL: https://codereview.chromium.org/1061473004

Cr-Commit-Position: refs/heads/master@{#325574}

This patches the python zipfile implementation to ignore struct unpack errors
in _decodeExtra. See http://bugs.python.org/issue14315

Also adds a --verbose option that enables a bunch of logging to help diagnose
failed symbolization.

Fixes stack tool for gn builds where libs are put in the top-level output
directory.

Review URL: https://codereview.chromium.org/1006603002

Cr-Commit-Position: refs/heads/master@{#325573}

BUG=

Review URL: https://codereview.chromium.org/1064683006

Cr-Commit-Position: refs/heads/master@{#325572}

A good chunk of the web (Facebook and YouTube) require webcrypto. This
takes the code in the content/ directory, puts it in a new top level
component directory, and uses it from html_viewer.

BUG=476568
TBR=jochen

Review URL: https://codereview.chromium.org/1077273002

Cr-Commit-Position: refs/heads/master@{#325571}

Add an apptest meta-target in mojo/BUILD.gn.
Move the apptests targets specified in src/BUILD.gn.
Add the remaining apptest targets (clipboard, VM, WM).

Was limited to release, allow debug, but exclude component.
See gn_debug compile error from including component build in PS2:
  FAILED: /b/build/slave/linux_chromium_gn/build/src/buildtools/linux64/gn --root=/b/build/slave/linux_chromium_gn/build/src -q gen //out/Debug/
  ERROR at //mojo/shell/BUILD.gn:13:1: Assertion failed.
  assert(!is_component_build)

BUG=NONE
TEST=Building mojo:apptests builds all local apptest binaries (on dbg too!).
R=sky@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1050233005

Cr-Commit-Position: refs/heads/master@{#325570}

BUG=470262

Review URL: https://codereview.chromium.org/1090023002

Cr-Commit-Position: refs/heads/master@{#325569}

Changes required:
- fold //base/third_party/nspr/prtime.cc into base
- fixed a compile error causing issues in media_blink_unittests
- fixed various missing dependencies
- disabled chrome_sync_shell_test_apk which needs some more work

Note that this does not mean that things run. I expect they don't :).

R=cjhopman@chromium.org
BUG=359249

Review URL: https://codereview.chromium.org/1089143002

Cr-Commit-Position: refs/heads/master@{#325568}

R=brettw@chromium.org
BUG=468851

Review URL: https://codereview.chromium.org/1021923002

Cr-Commit-Position: refs/heads/master@{#325567}

- adds rules for headings, both entering and speaking.
- adds a '+' delimiter which allows for subsittutions inside of message tokens.

TEST=OutputE2ETest.*

Review URL: https://codereview.chromium.org/1049853002

Cr-Commit-Position: refs/heads/master@{#325566}

Convert URLFetcher[Upload/Download]Progress tests to use
the shared test fixture.  Also add a bonus test where we
cancel/delete a fetcher in an upload progress callback.

BUG=471069

Review URL: https://codereview.chromium.org/1090003003

Cr-Commit-Position: refs/heads/master@{#325565}

Devices with some older drivers for the PowerVR SGX 544 GPU driver do not
return values when an occlusion query is performed, which causes a
hard CHECK to get hit in GLES2Implementation::GetQueryObjectuivEXT.

This adds an entry to the GPU bug list for this device, preventing
occlusion queries from being used on affected devices and driver versions.

BUG=474413

Review URL: https://codereview.chromium.org/1090923005

Cr-Commit-Position: refs/heads/master@{#325564}

Add developerPrivate API functions for repairing a corrupt extension,
showing extension options, and showing an extension's path, and
update the chrome://extensions page to use those.
Also update the chrome://extensions page to use existing
api functions for launching an app and auto-updating.

BUG=461039

Review URL: https://codereview.chromium.org/1085113002

Cr-Commit-Position: refs/heads/master@{#325563}

BUG=477050

Review URL: https://codereview.chromium.org/1088903003

Cr-Commit-Position: refs/heads/master@{#325562}

container_ if we are destroying the instance.

BUG=476590

Review URL: https://codereview.chromium.org/1085423004

Cr-Commit-Position: refs/heads/master@{#325561}

When the DnsConfigServicePosix finishes its initial reading of the
system DNS config, it normally triggers a NetworkChangeNotifier (NCN)
OnDNSChanged() signal.  This can cause in-flight network requests to
abort with ERR_NETWORK_CHANGED.  Avoid aborting requests by:
1. Adding a new NCN signal, OnInitialDNSConfigRead which indicates
   the initial DNS config reading completed but does not represent
   a change in DNS config.
2. Modify HostResolverImpl to not abort requests upon this new
   signal (like it does for the OnDNSChanged signal).
3. Add logic to NetworkChangeNotifierAndroid to emit this new
   signal when safe to do so.  Network requests begin being issued
   immediately after the NCN (and hence DnsConfigService) is
   initialized, so we need to be sure no network change signals
   are missed between NCN initialization completing and the
   OnInitialDNSConfigRead signal.  This is tricky because the
   NCN (and hence DnsConfigService) is initialized on threads
   where file I/O is not allowed.  Were file I/O allowed we could
   simply slurp up the DNS config and hosts file.  Instead we
   start listening for network changes (which is our trigger signal
   for DNS changes on Android) on the initialization thread and
   record the current time to later compare against the hosts
   file's last-modified time to check for changes to the file.
   Actual loading of the DNS config and hosts file is done on
   another thread that allows file I/O.

BUG=470897

Review URL: https://codereview.chromium.org/1047103002

Cr-Commit-Position: refs/heads/master@{#325560}

... which weren't specifying android builds :).

R=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1090053002

Cr-Commit-Position: refs/heads/master@{#325559}

This is due to 2 reasons:
+ Page specific logic should belong to page, not page test.
+ Simplify the repaint measurement control code, which make
it easier to port repaint to TimelineBasedMeasurement.

Trybot link for repaint.gpu_rasterization.key_mobile_sites_repaint:
https://codereview.chromium.org/1098543002

BUG=444703, 455391

Review URL: https://codereview.chromium.org/1089223003

Cr-Commit-Position: refs/heads/master@{#325558}

This patch makes it possible to control BluetoothDiscoveryFilter assigned to discovery sessions through BluetoothEventRouter router.

BUG=407773
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/1083163002

Cr-Commit-Position: refs/heads/master@{#325557}

Revert of [Chromoting] Enable remoting webapp main.html GN build. (patchset #5 id:80001 of https://codereview.chromium.org/1082083005/)

Reason for revert:
Suspected of breaking the build.  For details, see https://code.google.com/p/chromium/issues/detail?id=477869

Original issue's description:
> [Chromoting] Enable remoting webapp main.html GN build.
>
> The previous remoting webapp GN build files were not enabled and at
> least 6 months out of date. This cl fixes the problem by bringing
> the build rules up to date and enables the webapp build.
>
> It also starts to move all the remoting-specific build rules into
> the remoting dir rather than having them in the main build.gn file.
>
> BUG=
>
> Committed: https://crrev.com/62ee8a9cfebbc8bdc037aaa3b37ebfbb45e02472
> Cr-Commit-Position: refs/heads/master@{#325551}

TBR=dpranke@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1090023004

Cr-Commit-Position: refs/heads/master@{#325556}

BUG=477844
TBR=kundaji@chromium.org

Review URL: https://codereview.chromium.org/1097623002

Cr-Commit-Position: refs/heads/master@{#325555}

BUG=477840
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1089923003

Cr-Commit-Position: refs/heads/master@{#325554}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9c79820..fd0ecf4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1097523002

Cr-Commit-Position: refs/heads/master@{#325553}

BUG=476211

Review URL: https://codereview.chromium.org/1060743003

Cr-Commit-Position: refs/heads/master@{#325552}

The previous remoting webapp GN build files were not enabled and at
least 6 months out of date. This cl fixes the problem by bringing
the build rules up to date and enables the webapp build.

It also starts to move all the remoting-specific build rules into
the remoting dir rather than having them in the main build.gn file.

BUG=

Review URL: https://codereview.chromium.org/1082083005

Cr-Commit-Position: refs/heads/master@{#325551}

This CL adds support for plumbing BeginFrames to
VideoFrameProviderClientImpl if it opts into it. This is required for
upcoming video rendering changes to improve video smoothness.

BUG=456991

Review URL: https://codereview.chromium.org/1039533002

Cr-Commit-Position: refs/heads/master@{#325550}

Implement the developer mode warning on mac.
Instead of creating yet-another-bubble-class, refactor the bubble we used for
the toolbar redesign. This includes:
- Expanding ToolbarActionsBarBubbleDelegate.
- Moving the logic for showing the redesign bubble into a new class.
- Updating the redesign bubble to have a more flexible UI (and renaming it to
  ToolbarActionsBarBubble).
Hook up the ToolbarActionsBarBubble for use with ExtensionMessageBubbles, and
implement the highlighting on the toolbar.

Note that this does *not* turn the feature on for mac.

TBR=benwells@chromium.org (OWNERS file change)

BUG=474092

Review URL: https://codereview.chromium.org/1086973004

Cr-Commit-Position: refs/heads/master@{#325549}

BUG=477498
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1092823002

Cr-Commit-Position: refs/heads/master@{#325548}

This is for simplifying https://codereview.chromium.org/1010183002/

This also removes 'if (key == kProgramKey) ...' check from
JsonManifest::ResolveKey. This is safe because kProgram key was
never passed to the function before the change.

BUG=nativeclient:3802
TEST=git cl try, manually checked that both ARC and PNaCl demo still work

Review URL: https://codereview.chromium.org/1070233007

Cr-Commit-Position: refs/heads/master@{#325547}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/97a4012..e49d160

TBR=dcheng@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/1049983004

Cr-Commit-Position: refs/heads/master@{#325546}