- 23 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f6271e66386..61a1e81e89bd git log 9f6271e66386..61a1e81e89bd --date=short --no-merges --format='%ad %ae %s' 2019-10-23 bsheedy@chromium.org Force IPv4 for Telemetry proxy server Created with: gclient setdep -r src/third_party/catapult@61a1e81e89bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1005971 Change-Id: I6c01eaa5f8eb5961564bb1ab3b979cd2124239a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708493}
-
Jay Harris authored
Previously, OnShortcutBehaviorDestroyed was behaving as OnShortcutManagerShutdown. Now this has been fixed observers are guaranteed a chance to remove themselves before the shortcut manager is destroyed. This was causing tests in https://crrev.com/c/1833027 to fail, as observers would only be removed if shutdown was called. This more closely follows the pattern of AppRegistrarObserver. Bug: 860581 Change-Id: Ieee68721c088c9e800b9832cc50d21b0a2dda504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873812Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#708492}
-
Roman Sorokin authored
Bug: 890464 Change-Id: I8fe561d676089b2cb873b846314042e109913a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872223Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708491}
-
Maggie Cai authored
This CL adds preferred apps class that contains preferred apps storage struct, and add and find methods for the struct. Unit tests are also included. BUG=853604 Change-Id: I0c2c6c219720da5b56b1f1ed5e3818c760566487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864495 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708490}
-
Chris Hall authored
Fixes outstanding TODO for M59. R=aboxhall CC=dmazzoni BUG=672205 Change-Id: I197e8db4374185b80bc8fc91ad1208e9c7609380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689919Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708489}
-
Sadrul Habib Chowdhury authored
Use RenderProcessHostCreationObserver and RenderProcessHostObserver APIs, instead of using NotificationService. BUG=357627 Change-Id: Ia3755cd64056484c9b703b31d5a79489785f0e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842556Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#708488}
-
Antonio Gomes authored
This is a preparation CL to Onion souping //content/renderer/media/webrtc, and is part of phase 8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/edit?ts=5d5c1757 BUG=787254 R=dominickg@chromium.org, guidou@chromium.org, haraken@chromium.org Change-Id: Idaf36f81139f56402febc2493a30050c76e7fac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835802Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#708487}
-
Koji Ishii authored
TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I7a87e1b36eb5e3658cb33bbe2648d49b5d1e843e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868776Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708486}
-
Nigel Tao authored
Skia (https://skia.googlesource.com/skia) is a 2-D graphics library, already in use by Chromium as third_party/skia. Wuffs (https://github.com/google/wuffs) is a memory-safe programming language whose standard library includes a GIF image decoder. Wuffs' standard library is also available as transpiled C code. From Skia's (and Chromium's) point of view, Wuffs' standard library is just another C library. It's just not hand-written C. Upstream Skia is moving to use Wuffs for GIF image decoding (https://bugs.chromium.org/p/skia/issues/detail?id=8235). For Chromium, this commit (adding third_party/wuffs, but no change in the generated binaries yet) is the first in a series of commits (see crbug.com/1014044) to have Skia-in-Chromium also use Wuffs. Wuffs is released under the Apache License 2.0: https://github.com/google/wuffs/blob/master/LICENSE Bug: 1014044 Change-Id: I6b41794af09b07aacc48d519651bc397e761ad71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859536Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708485}
-
Ahmed Fakhry authored
- Now auto-rotation is on, when the device is in a physical tablet state, regardless of the UI mode (tablet or clamshell). - Apps' requested orientation locks are only applied while in UI tablet mode, and ignored in UI clamshell mode even if the device is in a physical tablet state. A follow-up CL will handle changes needed for display settings. BUG=925087 TEST=Manually, Added new tests Change-Id: I265dd80563b4532b72ed11aa53206bdc8bfa7dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861049 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#708484}
-
Greg Thompson authored
BUG=None TBR=gab@chromium.org Change-Id: Iaf363523ec156ca0789d52393545683022251699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875087Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708483}
-
James Cook authored
Historically OS settings were synced as part of the browser settings model type. The go/split-settings-sync project is migrating them to a new model type, with separate UI controls. Update all the OS pref registration sites to use registration flags SYNCABLE_OS_PREF and SYNCABLE_OS_PRIORITY_PREF. The prefs were found by manually auditing all pref registration. If the SplitSettingsSync flag is disabled, these prefs are synced as they were before, using the old syncer::ModelType. See the flag check in //components/sync_preferences/pref_service_syncable.cc Fix PrefRegistrySyncable so it runs the registration callback for OS prefs as well as browser prefs. Bug: 1013466 Change-Id: Ie0ba1244a74e300c3292252a83b30768d1644720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866927 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#708482}
-
Xianzhu Wang authored
Previously when we had full screen video overlay, we add the full screen layer as the child of the content parent layer, and detach other graphics layers. This might have problem during compositing update, paint property update, etc. because we don't expect the graphics layers not in the graphics layer tree but still reacheable from CompositedLayerMapping. We are not sure if this caused the crashing bugs like crbug.com/994370 and crbug.com/983292. Now use the method that klausw@ implemlemented for WebXR overlays in https://chromium-review.googlesource.com/c/chromium/src/+/1802674: instead of changing graphics layer tree structure, let painting start from the full screen layer. In this way, compositing update and paint property update etc. will be executed with the full graphics layer tree, and we omit the other layers when collecting graphics layers. Bug: 994370, 983292 Change-Id: I1604663d8a084a6d4270c4e18e86a096bd9b66eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859880 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#708481}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c04792ebef46..8e13e6ed3dfb git log c04792ebef46..8e13e6ed3dfb --date=short --no-merges --format='%ad %ae %s' 2019-10-23 qingsi@webrtc.org Handle no-longer-sticky-in-Q+ WIFI_P2P_CONNECTION_CHANGED_ACTION intent. Created with: gclient setdep -r src/third_party/webrtc@8e13e6ed3dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I70909016ba599edd17d6ab4470afa9b9a8ec1152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874774Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ic7bb4d70e8bec2b82ab14c2afb7faeab7847d2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873113Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708479}
-
Stephen Roe authored
qemu-linux-arm64 is from the /fuchsia/qemu/linux-arm64 CIPD package. Bug: 1015177 Change-Id: Ie193d18e4b52059ad853cee07075979b1faea038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865751Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#708478}
-
Ken Rockot authored
This makes it possible to launch new instances of the Data Decoder service without going through Service Manager APIs. The service is also still accessible through Service Manager, as this allows the many disparate clients across the tree to be ported incrementally. Bug: 977637 Change-Id: I0d534ed1fb9a0ef7545533ad435b010789cccd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869383Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#708477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1834bbb39c1c..29a49c28458d git log 1834bbb39c1c..29a49c28458d --date=short --no-merges --format='%ad %ae %s' 2019-10-22 wbbradley@chromium.org build api metrics: make sure we deserialize metrics in image Create 2019-10-22 vapier@chromium.org loman: make subparser work under python 3 2019-10-22 vapier@chromium.org pushimage: fix up for python 3 Created with: gclient setdep -r src/third_party/chromite@29a49c28458d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id4945758727d1bc06da3c77a3f3f2a17607f3e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874620Reviewed-by:
-
Sophie Chang authored
Bug: 1016987 Change-Id: Ie998aaf0f8d72a4896486c48e04dad120e9618ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874818Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a834f39e2132..db1e79c1c5de git log a834f39e2132..db1e79c1c5de --date=short --no-merges --format='%ad %ae %s' 2019-10-23 dpranke@chromium.org Fix gclient crash with unicode strings in .gclient files. Created with: gclient setdep -r src/third_party/depot_tools@db1e79c1c5de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1016599 Change-Id: I72f36219775e22deb5afcb02b1cfab4e3548997c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875068Reviewed-by:
-
Hirokazu Honda authored
This introduces VideoFrameMapper for GpuMemoryBuffer-based VideoFrame. It is required for tests to map the frame for verification and writing into a file. Bug: 1011281 Test: image_processor_test --save_images on atlas Change-Id: Ie3963e4c7185096d23a5a30507515a3f32144ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865051 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#708473}
-
Jinsuk Kim authored
- Set the position of security icon right in preview tab header in RTL mode. - Using LinearLayout for compositor resource caused a problem in large text mode for accessibility. Reverted the caption layout back to FrameLayout, and manually adjusts the position of text view to give room for the security icon when #overlay-new-layout is enabled. Bug: 1015324, 1015300 Change-Id: Id249fec7e7447c13a60ecfbf4e4b50c4182f280b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868564 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#708472}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/308277131853..ea58518db3b8 Created with: gclient setdep -r src-internal@ea58518db3b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: I9c23192d72e50dfc52c900551c6c3235582e9e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708471}
-
Dana Fried authored
Previously, label buttons could shrink down to elide some of their text (assuming elision is on) but would still report a minimum size equal to their preferred size (i.e. with all text visible). Since label buttons with elision can indeed shrink below their preferred size it makes sense for them to be able to report their actual minimum size. Change-Id: I888554bb98be6da94191fd63194d6738b2690d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874049Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#708470}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie3cd49194cf24e55d9c34298e9e2794aeba73c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874820Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708469}
-
Xing Liu authored
The actual Chime implementation glue code lives in downstream. The public Chrome apk or app bundle only builds an empty one. We use enable_chrome_android_internal to select the correct build target. Bug: 1013386 Change-Id: Iddde5fa2c466724c94bee504abc72b0facd39b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872721Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708468}
-
Xiaoqian Dai authored
Primarily for PM/UX testing. Currently it's still disabled by default. Bug: 997885 Change-Id: Ic2c0c3792923631056de415b6b3f23b70500c605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873289Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#708467}
-
Jinsuk Kim authored
The method is called by a class in chrome.browser.tab package in production code. Makes it a private-package method. Bug: 995903 Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079Reviewed-by:
-
Kent Tamura authored
This CL removes the following runtime flags: - ElementInternals - FormAssociatedCustomElements - FormDataEvent They have been enabled since M77, and M77 stable had no critical issues on these features. Change-Id: I13ae205072c745bc7c6e334161fa55537fff25e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874987Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#708465}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2b0cda4f8db7d999493d8f8e2b4aa9f8496d5a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874623Reviewed-by:
-
Jeff Yoon authored
Replicating GN Args from ios13-beta-sim Change-Id: Ide4590d5bef1b195bf0b1570fef6d76623428919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865044Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708463}
-
K Moon authored
Instead of applying rotation layout changes immediately, rotations will compute and propose the new layout to the JavaScript layer using the "documentDimensions" message. At that point, the JavaScript layer will have the chance to compute a new zoom level (such as for various "fit-to-X" options) before the rotation is applied by posting back a "viewport" message. The overall effect is to eliminate a distracting visual flash when the rotated layout is applied immediately, followed by a zoom adjustment once the layout change is passed to the JavaScript layer. Layout changes are divided into two types: Immediate layout changes reflecting changes in the PDF plugin's state (such as new pages), implemented by RefreshCurrentDocumentLayout(); and deferred layout changes reflecting user requests (such as rotations), implemented by ProposeNextDocumentLayout(), followed by ApplyDocumentLayout(). There are two particularly subtle edge cases: 1. Layout proposals must not be skipped if there would be no change in the layout, as asynchronous layout implies proposals may still be in flight. Proposals care about the future layout state, not the current layout state. 2. Applying a layout may trigger notifications back to JavaScript, which could trigger further layout applications. The implementation must be careful not to enter an infinite loop. For simplicity, this implementation redundantly computes layout at many points. Improvements in this area are deferred to crbug.com/1013800. Bug: 885110 Fixed: 885110 Change-Id: I7b43bd3409eb14159cbd5eb5d3efbd393878257f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747170Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708462}
-
dpapad authored
This method is using /deep/ which only worked in Shadow DOM v0. Extensions has been using SDv1 since M72, and this test is silently doing nothing (does not find any iron-icons to assert on). Fixed: 885401 Change-Id: I1ba5836bb0109337e1439f30453094d65089e822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864018Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708461}
-
Simon Que authored
CI builders: - Linux ASan LSan Builder - Linux TSan Builder Try builders: - linux_chromium_asan_rel_ng - linux_chromium_tsan_rel_ng - gpu-try-linux-nvidia-rel - linux-rel See planned migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org Bug: 950413 Change-Id: Idd0005d75f07245f52097315e062488845d579d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871709Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#708460}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e9c6aa24..224f10ee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0fa1f7e4c147fa1596a632e7a25fa18103b5ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874443Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708459}
-
David Dorwin authored
Added for Mandoline in https://crrev.com/1431133003, they are no longer used. Change-Id: I831d9167ab7dae7debcb23da8aa2dfa964c2c127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867181Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708458}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/05691ddbd2bc..c04792ebef46 git log 05691ddbd2bc..c04792ebef46 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mbonadei@webrtc.org Component Build support for api/task_queue:task_queue_test. 2019-10-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fc69c6f5..83bb172f (708204:708314) Created with: gclient setdep -r src/third_party/webrtc@c04792ebef46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I08e9c32fc9b70d297e8d3f8bf28080e0089d9870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874616Reviewed-by:
-
Sara Kato authored
Change-Id: Ic6be666880d54dba30293c6a4142e4a7a3fe43cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871789 Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
-
David Grogan authored
We were stretching items that had auto cross margins. This patch sets a flag on FlexItem when it needs relayout due to stretching. It's not elegant but is also not intrusive. This reverts commit 2390edbd. Bug: 845235, 1015475 Change-Id: Iebefb670f2d3ae4047565077776a6d7a1ff2c2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867434 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#708455}
-
Marina Sakai authored
This CL replaces all the old GetSymbol with the new API created in CL1810511, and removes the difinition of the old GetSymbol. Bug: 715418 Change-Id: I3337dd98121f8e93102ea5839df870c8a97adf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870158Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#708454}
-
