GitLab

This reverts commit f35977d9.

Reason for revert: causes TCPSocketTest.ReadAndWriteMultiple to flake (timeout)

Bug: 821232

Original change's description:
> Add TCP socket API to network service
> 
> This CL adds TCP socket API to network service.
> This is partly based on mandoline implementation
> (https://codereview.chromium.org/1873463003/)
> 
> Two TCP socket interfaces are added.
> - TCPConnectedSocket
> - TCPServerSocket
> 
> TBR=miu@chromium.org
> 
> Bug: 721401
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64
> Reviewed-on: https://chromium-review.googlesource.com/868711
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542606}

TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org

Change-Id: Id31caa2f5cc54993735586555e68bd3c345600bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/958943Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542696}

CL #2 out of 5.

Converted the following directories:
- third_party/WebKit/Source/core/animation
- third_party/WebKit/Source/core/html
- third_party/WebKit/Source/core/layout

When the ctor is private replaced to base::WrapUnique, otherwise used
std::make_unique.

Removed include of wtf/PtrUtil.h.

Fixed missing includes pointed by git cl lint.

Bug: 781645
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5e5a35de44df03d801a3553b56761126374402e4
Reviewed-on: https://chromium-review.googlesource.com/933882
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542695}

https://chromium.googlesource.com/catapult.git/+log/4b356c746683..548a5bc4b828

$ git log 4b356c746..548a5bc4b --date=short --no-merges --format='%ad %ae %s'
2018-03-12 pasko androidStartupMetric: add request_start_time

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I6ec5f05001dd5905ed2ebd45d804c1f9c0054b6a
Reviewed-on: https://chromium-review.googlesource.com/959522Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542694}

When we create a CSSUnitValue with '' as the unit, we hit a DCHECK
in the unit trie code because the length is 0. This is because we don't
correctly reject the empty string as an invalid unit.

In this patch we fix this. Interestingly, we already have a test to
assert that using an empty unit throws type error. However the test used
an incorrect variable name, causing it to throw a TypeError anyway,
so our tests would've passed no matter what.

Bug: 820905
Change-Id: I72ab5e4010d892042b2cfddf1014ab79d04a846d
Reviewed-on: https://chromium-review.googlesource.com/958624Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542693}

Moved most of the logic related to resolving paths
to ResolvePath and ResolveRelative in filesystem_utils.cc.
Improved SourceDir class to return std::string with resolved path
for cases when returning SourceDir or SourceFile wasn't really needed.

R=brettw@chromium.org, dpranke@chromium.org

Bug: 819720
Change-Id: Ia59da00e83de45431762ebb19a9153471f7e91e3
Reviewed-on: https://chromium-review.googlesource.com/953422Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542692}

TBR=elawrence@chromium.org

Change-Id: I2e0241863946192bef71c92d57be09de55237f30
Reviewed-on: https://chromium-review.googlesource.com/959635Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542691}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/10c5b8fc..be58a3b3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I6da4151977cf9bea4086d5ed64b5761a541eb0f5
Reviewed-on: https://chromium-review.googlesource.com/959614Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542690}

This CL moves UpdateOpenTabsURLs() from the UserActivityLoggerDelegate to the
UserActivityLogger. This is done in preparation for adding a predictor which
will also use some of the URL features as well as other features calculated by
the UserActivityLogger. This predictor will be called from UserActivityLogger.
In a followup, some of these classes will be renamed.

To allow testing UpdateOpenTabsURLs() in the UserActivityLoggerTest instead of
UserActivityLoggerDelegateUkmTest, the unittests are refactored.

Design doc:
https://docs.google.com/document/d/1QXXnRFKiRDvXaxwNTc6djMDC-5e7SXk4i2FI3fpxMdA/edit#heading=h.gjgriz8s7dlc

Change-Id: Icd8515437f0524bf56ad5d4c537814773aa247d7
Reviewed-on: https://chromium-review.googlesource.com/950602
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542689}

https://crrev.com/c/915442 restructured the ownership of objects in app
banner Java code. In particular, InstallerDelegate was moved from
AppBannerInfoBarDelegateAndroid to AppBannerUiDelegate.

For native apps, InstallerDelegate is given
AppBannerInfoBarDelegateAndroid as an observer, and tells it about the
progress of installation. Prior to https://crrev.com/c/915442, when
AppBannerInfoBarDelegateAndroid was destroyed, it would also destroy the
InstallerDelegate, ensuring that it could not be signalled after
destruction. However, there is now the following potential for the
following sequence of (racy) actions:

1. C++ AppBannerInfoBarDelegateAndroid is destroyed. In its destructor,
   destroy() is called on its Java counterpart, resetting the native
   pointer on the Java side.
2. Race: prior to the AppBannerUiDelegate owned by the
   C++ AppBannerInfoBarDelegateAndroid being destroyed, the
   InstallerDelegate owned by AppBannerUiDelegate calls
   onInstallFinished on the Java-side AppBannerInfoBarDelegateAndroid.
   This will eventually call OnInstallFinished.
3. Meanwhile, the C++ AppBannerInfoBarDelegateAndroid's destructor
   continues, clearing the |ui_delegate_| field. This destroys the
   AppBannerUiDelegate and its owned InstallerDelegate.
4. The C++ AppBannerInfoBarDelegateAndroid has OnInstallFinished called
   on it (from 2), which attempts to access |ui_delegate_| and crashes
   with a segmentation fault.

This CL fixes the bug by moving 3 (clearing the |ui_delegate_| field)
to happen before 1 (calling destroy() on the Java-side
AppBannerInfoBarDelegateAndroid). This ensures the InstallerDelegate
is destroyed before the native pointer on the Java-side
AppBannerInfoBarDelegateAndroid is reset, so that any further progress
in installation is not signalled as destruction continues. This prevents
accessing |ui_delegate_| after it is cleared, and prevents the crash.

BUG=819434

Change-Id: Iab0f7cb9044da332b6d4c6ab0a6f1d41a72195ca
Reviewed-on: https://chromium-review.googlesource.com/959409
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542688}

After this refactoring, SignedExchangeHeader
- Validates response header names and values, and
- Constructs HttpResponseHeaders from the response header map.

Bug: 803774
Change-Id: I25c91db1f07c4fcd0e6c62a9d4aa409838361349
Reviewed-on: https://chromium-review.googlesource.com/958647Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542687}

This CL adds workaround to MessageView::SlideOut() for a bug that it did
not work with MessagePopupCollection.

If |by_user| of RemoveNotification is true in SlideOut(),
IncrementDeferCounter() in MessagePopupCollection::OnNotificationRemoved
is called but corresponding DecrementDeferCounter() won't be called.

MessagePopupCollection will be completely rewritten.

TEST=message_center_unittests
BUG=805208

Change-Id: I1a637cef8bdcb25be45647f487f1d29ab3952583
Reviewed-on: https://chromium-review.googlesource.com/952822Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542686}

With these two merged:
https://chromium-review.googlesource.com/c/chromium/src/+/904303
https://chromium-review.googlesource.com/c/chromium/src/+/909216
we can enable tcmalloc for mipsel.

Bug: 810356
Change-Id: Idd63cb9a0e1a9582047ad203edf160b0c532f854
Reviewed-on: https://chromium-review.googlesource.com/947948Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542685}

This patch adds the layout constants for the rounded corners in
bookmark button ink drop highligh and ripple. It also adds the colors
the ink drop animation.

Bug: 810902
Change-Id: I96853d3c66eeca45881901a6d8b2053d2838c16e
Component: Bookmarkbar, theme colors
Reviewed-on: https://chromium-review.googlesource.com/954546
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542684}

This change adds wake lock service to acquire and release cpu wake
locks.

BUG=68944053
TEST=Verified cpu wake lock acquisition and release.

Change-Id: I7353ee394e9a400b4a32d182e551700162ce15a5
Reviewed-on: https://chromium-review.googlesource.com/936051Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@google.com>
Cr-Commit-Position: refs/heads/master@{#542683}

The spec says that setting the current time to null should throw if the
existing currentTime is non-null, or do nothing otherwise.

Bug: 818196
Change-Id: Iac89e46d6b884c924c88b603fbec77b61a337ce2
Reviewed-on: https://chromium-review.googlesource.com/946050Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542682}

Currently, the security text color does not always
match the icon. This CL fixes that by calculating the
color like what was done in OmniboxViewMac.

Bug: 740722
Change-Id: I693625a5b8db0b2400cfe4ab0c26f2421898d4bf
Reviewed-on: https://chromium-review.googlesource.com/949449
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542681}

I'm not sure on the name here. I went with WindowService-ChromeOS as
at some point we will launch the WindowService on other platforms, but
that won't be anytime soon and is likely to be very different. So, I'm
thinking later on we have the field trial WindowService-Desktop.

BUG=814898
TEST=none

Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e
Reviewed-on: https://chromium-review.googlesource.com/932821
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542680}

Right now they're trying to run the tests on the linux host, not the
actual cros devices. This will configure the tests to run on the devices
via ssh.

Bug: 814935
Change-Id: Icef761382276e8ea68b03102c3c5c2d6353c63c3
Reviewed-on: https://chromium-review.googlesource.com/957682Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542679}

This simplifies the process of passing intrinsic sizing info around by
reusing the existing virtual on FrameOwner. Since the sizing info is only
needed by the RemoteFrameOwner implementation, RemoteFrameOwner now uses
LocalFrameView::GetIntrinsicSizingInfo() to calculate it on demand,
rather than relying on LayoutSVGRoot to pass it down.

However, this leads to some issues when building the layout tree; if
LayoutSVGRoot notifies RemoteFrameOwner to recalculate the intrinsic
sizing info, the call to GetIntrinsicSizingInfo() will fail, since the
LayoutSVGRoot is not yet in the actual layout tree.

To fix that, SVGSVGRoot now also overrides AttachLayoutTree() so that
RemoteFrameOwner no longer has to rely on LayoutSVGRoot::StyleDidChange
for the intrinsic sizing info changed notification when building the
layout tree.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2f459e6dcaceae287a2c97bf56da67ddc8a4f8c8
Reviewed-on: https://chromium-review.googlesource.com/958287
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#542678}

std::map is more preferable than std::unordered_map:
https://chromium.googlesource.com/chromium/src/+/master/base/containers/README.md.
For newblue's dispatcher std::map for dbus::Property is required to
match with libbrillo ExportedProperty.

BUG=chromium:812468
TEST=Unit test still passes, manual test on device exercising Bluetooth
device discovery.

Change-Id: I378c383a612fd40997b44191a1ba6df33aa6899d
Reviewed-on: https://chromium-review.googlesource.com/959362Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542677}

This CL uses Can{Read/Write}Clipboard() instead of
CanExecuteWhenDisabled(). CanExecuteWhenDisabled() is only unsed for
clipboard commands only which need to check clipboard accessibility
when execute, replace it for simple and code health.
This CL is second step of [1], next step will introduce
Editor::Command::CanExecute(), and move the predicate in
Editor::Command::Execute() to it.

[1]: http://crrev.com/c/954773Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I0f40d402cf25d118e1096ee54a67f561f95aff98
Reviewed-on: https://chromium-review.googlesource.com/954164Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542676}

Bug: 785955
Change-Id: I9e55da4b8a3f6f1abb1246d14281cc99c7594dc5
Reviewed-on: https://chromium-review.googlesource.com/939737Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Arnar Birgisson <arnarb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542675}

Add one extra level of redirection so that we can avoid the static
cast. This is following the existing model of GetDecryptor() and
GetCdmProxyContext(). See bug for details.

Will rename MediaDrmBridgeCdmContext in the next CL.

Bug: 821114
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8d58b294099d3b0fd9eb73db65a8ef566a5188ec
Reviewed-on: https://chromium-review.googlesource.com/958034Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542674}

The notification_helper process is designed to be launched by COM only. For other
launches, it just won't exit until it's killed manually. Therefore, we should make
the process exit immediately once detecting it's not launched by COM.

Bug: 734095
Change-Id: I0cc23768cf0ec96e8ecbd9b55ab526ba0e1e37c9
Reviewed-on: https://chromium-review.googlesource.com/959347Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542673}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44048672dcd7..f4c2703a6ded

$ git log 44048672d..f4c2703a6 --date=short --no-merges --format='%ad %ae %s'
2018-03-10 iannucci [bot_update] Remove rietveld recipe_module.
2018-03-10 iannucci [bot_update] Remove use_site_config_creds.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I82d6a358a133f2fbfd7f8385523bf4390dcffd49
Reviewed-on: https://chromium-review.googlesource.com/959565Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542672}

https://skia.googlesource.com/skia.git/+log/67f62b1a6101..8103ecae7b53

$ git log 67f62b1a6..8103ecae7 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 brianosman Revert "Add SkColorSpaceXform_skcms"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I8acac68e52ba536335cd291a39fcd23cb2106bc7
Reviewed-on: https://chromium-review.googlesource.com/959621
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542671}

https://webrtc.googlesource.com/src.git/+log/15fb915917f7..5b9c6840b1d9

$ git log 15fb91591..5b9c6840b --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I869b9767e3ad6dcc23d4dd6b6bcc20bfeb10da1d
Reviewed-on: https://chromium-review.googlesource.com/959634Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542670}

This reverts commit d869ab33.

Reason for revert: this breaks automation scenarios in the field, see crbug.com/820555.

Original change's description:
> Remove --disable-infobars.
> 
> This flag is no longer needed by the perf testing infrastructure and can be
> misused for malicious purposes, so remove it.
> 
> BUG=none
> TEST=none
> 
> Change-Id: Iaa875bc887a5a1564ca10ef7d3c2d760a1f7cb11
> Reviewed-on: https://chromium-review.googlesource.com/857604
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528386}

TBR=pasko@chromium.org,pkasting@chromium.org,pfeldman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: I865b1ee1db7d795cf88d2b65cff404c8936b22ce
Reviewed-on: https://chromium-review.googlesource.com/957602
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542669}

Before this CL it was owned by PaintLayer through a std::unique_ptr.
This is probably because it was a rare data back in the age when we had
non-composited mode. Now every PaintLayer always have it.

BUG=818768

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ice8612a3cbe4a3da28e81f3d17f80cf5574ce17a
Reviewed-on: https://chromium-review.googlesource.com/959557
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542668}

It is redundant with the call to UsesCompositedScrolling just below, and
is equivalent to UsesCompositedScrolling + object != paint_invalidation_container.
UsesCompositedScrolling calls two methods plus a virtual, so may be slow.

Bug: 818709

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iab617e3941563ac1994e5732359cf691442a2b7e
Reviewed-on: https://chromium-review.googlesource.com/959444
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542667}

This adds a unittest for the bug fixed in
http://crrev.com/65f6394de68d8e96184234f5b7c8bf1e80f699f1

This updates the scheduler and unittests to use a mock clock
implementation from TestMockTimeTaskRunner, instead of just
mocking the current time directly.

Bug: 816727
Change-Id: I194af8e65bae70f0af3a202e0bbb7653059abcaf
Reviewed-on: https://chromium-review.googlesource.com/947575
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542666}

This method is called in various hot code paths, in particular
in ObjectPaintInvalidator.

Bug: 818709
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6eaf1acadc5ac5721c7e42c900964bcc31fee769
Reviewed-on: https://chromium-review.googlesource.com/959155Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542665}

This makes ~50 additional tests to pass, and 3 to fail.

Paint invalidation can cause styles on a NGPhysicalFragment to
get out of sync with LayoutObject styles.

There were two ways to fix this, I found a) to be cleaner for now.

a) Make PhysicalFragments fetch style from LayoutObject
Tricky part here is that :first-line and overflow:ellipsis get
special styles.

b) Rebuild PhysicalFragment tree with a shallow clonewithstyle
I was unable to find a clean way to trigger tree rebuild here.
Sample experiment to convert paint invalidations into
layout invalidations triggered 100s DCHECK(!NeedsLayout())
Possible fix would be to trap all places that call NeedsLayout()
with intent to relayout, and replace them with NeedsLayout() ||
NeedsNGLayout()

This does not fix all invalidation bugs. DisplayItems outside of
LayoutObject tree do not get invalidated correctly.

fast/css/first-letter-hover.html
fast/history/visited-link-hover-emphasis-color.html

Bug: 819372
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia11f8288b8f45423762c870a43615707d6a0cc93
Reviewed-on: https://chromium-review.googlesource.com/956552
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542664}

https://chromium.googlesource.com/angle/angle.git/+log/203d6365c567..64e5ed2abd8a

$ git log 203d6365c..64e5ed2ab --date=short --no-merges --format='%ad %ae %s'
2018-03-09 lucferron Vulkan: Fix scissor clears + enable dEQP tests
2018-02-25 lfy GLES1: state: Define / initialize GLES1-specific states
2018-03-12 lucferron Vulkan: Enable culling rasterization state dEQP tests

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ia29eef8615b5037089380eb2e8eda2afe4eed7cc
Reviewed-on: https://chromium-review.googlesource.com/959633
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542663}

This cuts down on some of the boilerplate in task unit tests, and is
similar to how the prefetch task tests are written.

Also added TestTaskRunner in TestTaskBase, which is now used in prefetch task tests.

Bug: 802892
Change-Id: I352713d3d9940965bbe0654af57093d12085f3a3
Reviewed-on: https://chromium-review.googlesource.com/953326Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542662}

These tests were flakey due to messages being dropped by the receiver
occasionally when the underlying plaform-specific Channel was closed.

Bug: 764015, 764018, 756112, 810448, 815314, 816620
Change-Id: I2b6cfb105660a570c09b29555da7811541d49ec9
Reviewed-on: https://chromium-review.googlesource.com/959674
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542661}

Currently the icon type is always hard coded to CAST, but it should be
determined using the Cast device capabilities. This patch implements
that logic so that with the CastMediaRouteProvider feature enabled,
the right icon type will be displayed on the device list.

Note this does not impact the MR extension since it has its own logic
to determine icon type.

Bug: 698940
Change-Id: I6afa8eb9db1553fabaf2a8ee617812edb354ae8c
Reviewed-on: https://chromium-review.googlesource.com/956538
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542660}

Bug: 817779
Change-Id: I652c928db764e106a5e94a3bbcce6f11cd9f2d87
Reviewed-on: https://chromium-review.googlesource.com/959593Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542659}

Before the change, when the launcher receives located events outside its
bounds, the launcher will be closed. This change makes the launcher go
back instead of being closed in that case. Going back means that the
launcher will close the folder or search results page if they exist, and
will close itself otherwise.

BUG=814806

Change-Id: I977011bca34e17cb041dd5a598a4b88ec093a930
Reviewed-on: https://chromium-review.googlesource.com/953585Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542658}

This CL implements NetworkScanner and adds tests. This allows the use of
multiple HostLocators by registering it with NetworkScanner.

Bug: chromium:757625
Change-Id: I5c607450196f3f1751cab44ff42b94057d142442
Reviewed-on: https://chromium-review.googlesource.com/952369Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542657}