GitLab

The fix is very subtle.  We need the comment to ensure we don't accidentally
revert the fix.  It's also a helpful reminder that we should try to find a less
brittle solution.

BUG=95619
TEST=None


Review URL: http://codereview.chromium.org/7995015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102436 0039d316-1c4b-4281-b951-d872f2087c98

In cases where we can approximate the vector size in advance,
reserve() that much space rather than building organically.

BUG=97102
TEST=Reduction in crash rate for that bug.


Review URL: http://codereview.chromium.org/8005001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102435 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of CL 7915007.

BUG=None
TEST=New Unittest


Review URL: http://codereview.chromium.org/7976035

TBR=dgarrett@chromium.org
Review URL: http://codereview.chromium.org/7972027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102434 0039d316-1c4b-4281-b951-d872f2087c98

Can't use child_process_launcher_ since it can be reset.

exampe: http://crash/reportdetail?reportid=06b35b6784edc8db

BUG=97338
TEST= see bug
Review URL: http://codereview.chromium.org/8004001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=SyncApiTest.EmptyTags


Review URL: http://codereview.chromium.org/7970018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102432 0039d316-1c4b-4281-b951-d872f2087c98

What seems to be happening is that the client redirect can
result in starting and stopping the page loading again.  As
a result, we quit the message loop when the second load
finishes as well as the first, which can occur either while
we're waiting for the result of a Javascript function, or
while we're waiting for the navigation to occur.  Either
case will result in a test failure.

BUG=88973
TEST=PrerenderBrowserTest.PrerenderClientRedirectInIframe (And probably PrerenderBrowserTest.PrerenderClientRedirectToHttpsInIframe)

Review URL: http://codereview.chromium.org/7981033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102431 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of CL 7915007.

BUG=None
TEST=New Unittest


Review URL: http://codereview.chromium.org/7976035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102428 0039d316-1c4b-4281-b951-d872f2087c98

Don't depend on the embedder creating a plugin. That way embedders can always provide an empty ContentRendererClient interface and still have functional rendering.
Review URL: http://codereview.chromium.org/7972018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97671
TEST=sync_integration_tests.exe


Review URL: http://codereview.chromium.org/7919001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=89276
TEST=
Review URL: http://codereview.chromium.org/8008007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7969027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102424 0039d316-1c4b-4281-b951-d872f2087c98

On Chrome OS it needs to be initialized during the OOBE, and on other
platforms there's no harm in allowing it to initialize itself in its
constructor rather than waiting until a profile is loaded.

BUG=97614
TEST=manual testing

Review URL: http://codereview.chromium.org/8002001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102422 0039d316-1c4b-4281-b951-d872f2087c98

This adds additional methods to PluginService so that most callers can be moved
off PluginList and use the new asynchronous interface. This is in preparation
for moving plugin probing out-of-process on Mac and Linux.

BUG=17863,95114
TEST=none

Review URL: http://codereview.chromium.org/7980011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102421 0039d316-1c4b-4281-b951-d872f2087c98

Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.
Review URL: http://codereview.chromium.org/7977043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102420 0039d316-1c4b-4281-b951-d872f2087c98

Nico's nit from http://codereview.chromium.org/7876004 which came
after I had committed.

TBR=thakis@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7969022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18094
TEST=verfiy per bug rpt

Review URL: http://codereview.chromium.org/7980065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102418 0039d316-1c4b-4281-b951-d872f2087c98

Sending auth error from python server. After posting a request to the /chromiumsync/cred url with the parameter valid=false the server starts sending auth errors repeatedly . To stop the auth errors we have to navigate to the same url with valid=True.


BUG=
TEST=


Review URL: http://codereview.chromium.org/7978043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96490
TEST=Pin a tab and inspect the icon. It's not blurry/fuzzy.


Review URL: http://codereview.chromium.org/7969017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102416 0039d316-1c4b-4281-b951-d872f2087c98

For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. 

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... 

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. 

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7969023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102415 0039d316-1c4b-4281-b951-d872f2087c98

Move JsTransactionObserver code into JsMutationEventObserver.

Move ChangeObserver methods of JsSyncManagerObserver to
JsMutationEventObserver.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7982049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84907
TEST=go to chrome://settings/personal. Sign in to sync. Display should say "Last synced as..." when sync has completed.


Review URL: http://codereview.chromium.org/7976018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97258
TEST=unittest
Review URL: http://codereview.chromium.org/7982034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102410 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ExtensionManifestTest.WebIntents


Review URL: http://codereview.chromium.org/7917006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102409 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102395 - Refactor Win panel mouse watcher to use PanelMouseWatcher base class.

BUG=None
TEST=Panel minimize and restore tests.
Review URL: http://codereview.chromium.org/7977037

TBR=jennb@chromium.org
Review URL: http://codereview.chromium.org/7966026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102408 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a valgrind error in AutofillProfileSyncableServiceTest.ActOnChange
which uses gmock to mock a method that uses these classes. Due to
alignment issues, SyncData.is_valid_ has 3 bytes of uninitalized
padding. The default gmock printer prints all of these bytes, which
causes the uninit access.

BUG=none
TEST=Green memory waterfall

R=akalin@chromium.org


Review URL: http://codereview.chromium.org/7978044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102407 0039d316-1c4b-4281-b951-d872f2087c98

Also modified the pyauto tests in process_count.py to use the new
automation hook.  Verified that this works on my local ChromeOS device,
my local Linux machine, and the Win/Mac trybots.  Re-enabling the tests
on Win/Mac in the CONTINUOUS suite to see if they now pass continuously.

BUG=94650,95142,93822
TEST=None

Review URL: http://codereview.chromium.org/7976016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102406 0039d316-1c4b-4281-b951-d872f2087c98

of content and also move a couple of functions to content that should've
been moved earlier.

BUG=90442
TBR=jam@chromium.org,allanwoj@chromium.org
TEST=

Review URL: http://codereview.chromium.org/7969028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102405 0039d316-1c4b-4281-b951-d872f2087c98

object to facilitate this.

1. ViewMsg_CustomContextMenuAction
2. ViewMsg_ContextMenuClosed
3. ViewMsg_CopyImageAt
4. ViewMsg_MediaPlayerActionAt
5. ViewMsg_DisassociateFromPopupCount
6. ViewMsg_MoveOrResizeStarted
7. ViewMsg_StopFinding

The ViewMsg_FindReplyACK message is now sent by the TabContents::OnFindReply handler.

Continuing changes to get rid of the pattern of IPC messages being sent and processed across content
and chrome.

BUG=87335.
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/8002005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97131
TEST=manually

Review URL: http://codereview.chromium.org/7981030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102403 0039d316-1c4b-4281-b951-d872f2087c98

Some certificates are included in the certificate database in order to
explicitly mark them as untrusted. In our current UI this isn't
indicated and there's at least one, clearly fraudulent, CA in the list
that looks like all the rest.

This change causes these explicitly untrusted CAs to be marked with a
red badge next to them.

BUG=79549
TEST=Open the certificates dialog on Linux/ChromeOS and look for untrusted CA certificates.


Review URL: http://codereview.chromium.org/7272014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102402 0039d316-1c4b-4281-b951-d872f2087c98

 gtk, wayland and aura+x11 needs this, which can just be use_x11

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7969029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97640
TEST=accelerated canvas 2d is truly blocked in linux
Review URL: http://codereview.chromium.org/7995011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91030
TEST=ran on qa-bots for win7 and Vista
Review URL: http://codereview.chromium.org/7966023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102399 0039d316-1c4b-4281-b951-d872f2087c98

When creating app tiles, use HTML template data rather than constructing the hiearchy
in javascript.  Also move style data to the CSS file.  This should improve flexibility
for making future changes.

BUG=none
TEST=Verify that app tiles continue to look and behave the same.
Review URL: http://codereview.chromium.org/8008005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102398 0039d316-1c4b-4281-b951-d872f2087c98

Work in process on discarding a tab (for low memory conditions on CrOS).  Also clean up the strings we use to describe system memory, and eliminate memory as an input for "interestingness" of tabs, since the OOM killer already includes memory as an input.

BUG=none
TEST=Open "about:discards".  Click the "Discard Tab Now" link - the tab at the bottom of the list should close.

Review URL: http://codereview.chromium.org/7983042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102397 0039d316-1c4b-4281-b951-d872f2087c98

Shows the 'Wait for downloads to finish' dialog box when trying to quit.

TBR=rdsmith@chromium.org
BUG=97695
TEST=

Review URL: http://codereview.chromium.org/7970020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Panel minimize and restore tests.
Review URL: http://codereview.chromium.org/7977037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94007,70276
TEST=

Review URL: http://codereview.chromium.org/7811026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102392 0039d316-1c4b-4281-b951-d872f2087c98

This makes compositor_unittests compiles on Linux.

Although running it doesn't work yet because we return NULL in
TestCompositorHost::Create() and it expects something different than NULL.

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7996005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102391 0039d316-1c4b-4281-b951-d872f2087c98

Implement the EmbeddedTool class in valgrind_test.py to allow running tools that are embedded into binaries.
Merge tools/asan with tools/valgrind.

This CL depends on http://codereview.chromium.org/7926011/
Review URL: http://codereview.chromium.org/7922010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102390 0039d316-1c4b-4281-b951-d872f2087c98