GitLab

ParallelDownloadJob is introduced for parallel downloading.
This CL moves the class to components/download, where all the download code
will eventually locate.
Most of the code changes are moving files and fixing includes.
One major change is that DownloadManagerImpl now passes a URLRequestContextGetter
to DownloadItemImpl, and it will be passed to ParallelDownloadJob for issuing requests.

Bug: 803135
Change-Id: Ie83f6225e8f764a7aa46ad8c35ea03fce911b889
Reviewed-on: https://chromium-review.googlesource.com/985893Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547111}

https://skia.googlesource.com/skia.git/+log/f5b418839f2e..df1681ec0661

$ git log f5b418839..df1681ec0 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 csmartdalton Revert "vulkan: Blacklist MSAA path renderer on Qualcomm drivers"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I273c15191302903385359be5c32b789d328b9e7d
Reviewed-on: https://chromium-review.googlesource.com/987391
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547110}

This patch changes "mixed-editability-{4,5}.html" to utilize |selection_test()|
for ease of maintenance.

Because of "mixed-editability-4.html" and "mixed-editability-5.html" use same
sample, this patch integrates them.

Bug: 679977
Change-Id: Ic5e2e8e69413a8c060b905effdb8e33f611de5b2
Reviewed-on: https://chromium-review.googlesource.com/985932Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547109}

This patch changes text find related functions in |Editor| class as static
member function as preparation of them to moving |TextFinderHelper| class
to reduce source code size of |Editor| class for improving code health.

Change-Id: I1f274ae07568fd66a3dea8443b8bb03b6b896057
Reviewed-on: https://chromium-review.googlesource.com/985680Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547108}

This patch changes "mixed-editability-{6,7}.html" to utilize |selection_test()|
for ease of maintenance.

Because of "mixed-editability-6.html" and "mixed-editability-7.html" use same
sample, this patch integrates them.

Bug: 679977
Change-Id: I0615e588ec95198e3ce8d4de2233180a2b5aaff9
Reviewed-on: https://chromium-review.googlesource.com/985994Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547107}

https://chromium.googlesource.com/angle/angle.git/+log/5cf4d06cd460..b1de5a7e633e

$ git log 5cf4d06cd..b1de5a7e6 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 oetuaho Prevent stack overflow due to recursive swizzle of an l-value
2018-03-29 ynovikov Skip ComputeShaderTest.groupMemoryBarrierAndBarrierTest on NVIDIA D3D11

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: If5deef2744df6321ddf70ff8d3a5f6585a38260b
Reviewed-on: https://chromium-review.googlesource.com/987493Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547106}

LLD currently ignores /PROFILE, so it does not enable /OPT:ICF and
/OPT:REF for chrome_elf.dll. chrome_elf_import_unittests checks that the
linker strips dead dependencies on user32.dll and shell32.dll, so it
currently fails when chrome_elf.dll is linked with LLD.

I will fix this bug in upstream LLD, but in the meantime this will fix
the issue. This change also seens like it is more explicit and reduces
gn complexity, so maybe we should leave it like this after the LLD fix.

R=brucedawson@chromium.org, thakis@chromium.org

Bug: chromium:827075
Change-Id: Icd2a09aab031b7ff07738892c12a5de1ec9936b9
Reviewed-on: https://chromium-review.googlesource.com/986694
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547105}

Adds mojom equivalents of {ReadOnly,Writable,Unsafe}SharedMemoryRegion.
These are typemapped to the new base types.

The typemap implementation is currently written by wrapping and
unwrapping generic platform handles rather than relying on Mojo's
shared buffer implementation.

Existing mojom shared buffer handle consumers will be converted to use
these types in place of raw handle<shared_buffer>. The (mojom) types
here will eventually wrap handle<shared_buffer> instead of raw platform
handles.

This is to ease the transition to new shared memory semantics while
also getting us something we want, i.e., stronger shared memory type
safety for common mojom uses.

Bug: 826213
Change-Id: Iba36758b70953492997e744eeecaf7b7403627fc
Reviewed-on: https://chromium-review.googlesource.com/982577Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547104}

Thanks to nedwilliamson@ (on gmail) for an alternative perspective
plus a reduction to make fixing this much easier.

Bug: 826626, 518908, 537063, 802886
Change-Id: Ibfa01416f9a8e7f7b361e4f93b4b6b134728b85f
Reviewed-on: https://chromium-review.googlesource.com/985052Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547103}

Previously, we were using ClipPaintPropertyNode::Root, which is incorrect because
everything is clipped by the frame. (In RLS mode, the frame's LayoutView always has
overflow clipping, so there is always a cliipping container.)

Bug: 825280

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iee2c55bc32caeb1f8f0f057c6325a995af3b32ec
Reviewed-on: https://chromium-review.googlesource.com/985906
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547102}

This patch implements a custom slider that provides the basic
functionality of the paper-slider but provides an additional option to
display a label for the current slider value. The slider has the Prefs
Behavior integrated with it.

This slider has a general implemention and is ready to be used in other
locations as well.

Functionalities implemented:
 - Slider works the same way as the paper-slider in terms of mouse and
   keyboard interactions.
 - Additionally The slider displays a label on mouse hover and keyboard
   focus.
 - The slider only works for discrete values or options.

This patch also adds web ui tests for all the slider functionalities.

A video of this slider in use can be found on the bug link below.

Bug: 798906
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I55fa98eb438ed1c48b4f40c14d8c05085e7a45b4
Component: Display Slider, display settings, webui tests
Reviewed-on: https://chromium-review.googlesource.com/985127
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547101}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: I5f3055270a8c695ed50a69262554f19e9bad3caf
Reviewed-on: https://chromium-review.googlesource.com/978281Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547100}

Move OnNewWebVrFrame to SubmitFrame to ensure that ShouldDrawWebVr() can
return true as soon as the first frame starts processing, don't
reset webvr_frame_processing_ when finishing a UI frame, and clear
frame state on exiting WebVR mode within a VR browser session.

This fixes two related problems:

- OnNewWebVrFrame was called from OnWebVrFrameAvailable which is in the
  middle of the WebVR frame "processing" lifecycle. As a result,
  ShouldDrawWebVr() remains false for a while after an incoming
  SubmitFrame, and if OnVSync gets called during that interval it'll run
  DrawFrame(-1) to draw a UI frame in the middle of processing the WebVR
  frame.

- DrawFrameSubmitNow was erroneously setting webvr_frame_processing_
  to false for UI frames. As a result, the unexpected DrawFrame(-1)
  could reschedule the next SubmitFrame too early, writing a
  new frame to the Surface before the previous frame was processed.

Depending on the timing, the results could include a lost WebVR frame
due to overstuffing the Surface, frames arriving unexpectedly on the
SurfaceTexture, or having the first WebVR frame's acquired GVR buffer
stolen by the UI frame or next WebVR frame which also results in a lost
WebVR frame.

The missing cleanup on exiting WebVR mode could cause the next WebVR
page to not animate due to its frames being blocked, resulting in the
timeout spinner showing.

Change-Id: I02669c6fb7c2c86870ccb9b227d055b2a5d539f4
Reviewed-on: https://chromium-review.googlesource.com/987301
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547099}

Clicking with mouse will still expand username if it had been shortened
by ellipsis.
Username can still be focused with a screen reader.

Bug: 826654
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia77fa1f5ac6b90a9b97102ea4724df7d9f308a41
Reviewed-on: https://chromium-review.googlesource.com/984521Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547098}

This reverts commit 0d9dad32.

Reason for revert: This is causing some failure on builders, please see
http://crbug.com/827445 for more info.

Original change's description:
> Reland "Android: Add extra fields related to resources to crash reports."
>
> This is a reland of 3e261e9b.
>
> Reason for reland:
>   * Fixed deps order (caused flaky compile errors)
>   * Fixed cronet apk by removing resources dep
>
> Original change's description:
> > Android: Add extra fields related to resources to crash reports.
> >
> > This CL adds two fields to Android crash reports. Specifically:
> > 1. custom_themes: Whether or not the user has apps installed for using
> > custom themes. This should help debug obscure resources related
> > crashes.
> > 2. resources_version: The product version as stored in resources.arsc.
> > This should help us detect if we tried to load resources from the old
> > apk during an update.
> >
> > Bug: 820591
> > Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f
> > Reviewed-on: https://chromium-review.googlesource.com/969597
> > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#545798}
>
> Bug: 820591
> Change-Id: Id30e79ed508dbecc1b277a0450ec7784120e2efe
> tbr: yfriedman@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/981156
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546211}

TBR=yfriedman@chromium.org,thestig@chromium.org,agrieve@chromium.org,estevenson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 820591
Change-Id: Iccdbb25f2d9698df6b37cdac96df9420aa333789
Reviewed-on: https://chromium-review.googlesource.com/987273
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547097}

Mainly the string change.
Since we add more text in the ToS page, split the ToS in two phases.
First phase shows ToS webview and limited contents.
Second phase show all the content, make this page scrollable and scroll to
the bottom. ToS webview height should not change when the flow goes from
phase one to phase two.
Changes affect on both OOBE flow and in-session Arc opt-in.
For OOBE flow, show usage/diagnose status in ToS page if user is device
owner and has previously confirmed sending usage/diagnose data.
Call update ToS webview height when necessary in OOBE flow.

Bug: b/73452374
Bug: 826927
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I33fe36403be86cb9b157417747740e786a6510a2
Reviewed-on: https://chromium-review.googlesource.com/984492
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547096}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I5cf008a7a7901121262c7f0d87a02e0ef0ea3c26
Reviewed-on: https://chromium-review.googlesource.com/987472Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547095}

Dangerous download prompt (a native dialog) was removed in
https://codereview.chromium.org/2314903003 for DANGEROUS_FILE. The
intention was to improve usability (a.k.a user don't need to click
"Keep" twice) when chrome don't know if this file is dangerous.
Recently, we realize that skipping this native dialog can
potentially give attacker who've already get control over
chrome://downloads page the ability to to land a dangerous file
without a proper user gesture. Therefore, we decided to add back
this dangerous download prompt for DANGEROUS_FILE.

This CL simply reverts the changes of md_downloads_dom_handler* in
https://codereview.chromium.org/2314903003

Bug: 595841
Change-Id: I90123617ea9044687ee52841e80a3847b9451bc7
Reviewed-on: https://chromium-review.googlesource.com/986739Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547094}

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I679c25020c26d987588f56641554cdb13b22ce49
Reviewed-on: https://chromium-review.googlesource.com/985242Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547093}

Bug: 773928, 812099
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I861a40dff62c4a4fd2929ff5644a23ebad0334b7
Reviewed-on: https://chromium-review.googlesource.com/971467
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547092}

Adds the ability to --enable_features=TouchOptimizedUi which changes
the return value of ui::MaterialDesignController::DefaultMode() only
on ChromeOS and only when a touch device is present.

Initially, enable by default on ChromeOS.

Bug: 801582
Change-Id: I325de1c022c3e5893c059b2d774426a38232a641
Reviewed-on: https://chromium-review.googlesource.com/981832Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547091}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f3f1110ffae1..33146a20418a

$ git log f3f1110ff..33146a204 --date=short --no-merges --format='%ad %ae %s'
2018-03-26 jkop Wall-clock time and dashboard are no longer new.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic21fc7ba8d0b7ce73a81d9006de2177212838be7
Reviewed-on: https://chromium-review.googlesource.com/986936Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547090}

TBR: hbos
Bug: 827450, 680172
Change-Id: I2d351e517dae3b011bd477c9482e756344df4fe2
Reviewed-on: https://chromium-review.googlesource.com/987394Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547089}

Changes Init() not to pass in the content_window_, and changes
implementations not to cache it. There is no reason for each DWTH to
cache the content_window_ when it can get it from the
DesktopNativeWidgetAura.

BUG=none
TEST=none

Change-Id: I7e89b81606079e5e291fd528d275c8a47ada1c8e
Reviewed-on: https://chromium-review.googlesource.com/986930
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547088}

https://skia.googlesource.com/skia.git/+log/04bea3bf76e2..f5b418839f2e

$ git log 04bea3bf7..f5b418839 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 96310cdad..5cf4d06cd (5 commits)
2018-03-29 robertphillips Add SK_API to GrContextThreadSafeProxy
2018-03-29 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ ffeadc2cb..d8ece14aa (1 commit)
2018-03-28 halcanary SkPDF/Clusterator: expose to the light of a unit test

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: Ia923056376ef97b52574a04ee94abb0c9b2c1236
Reviewed-on: https://chromium-review.googlesource.com/987115Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547087}

https://webrtc.googlesource.com/src.git/+log/a21090b7706e..9d6f73bfb299

$ git log a21090b77..9d6f73bfb --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id6d17b9e58fb6a9822a56598284b6078745502ab
Reviewed-on: https://chromium-review.googlesource.com/987114Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547086}

BUG=none
TEST=none

Change-Id: If0c65e7139facaa72f19a92e41939dd82646839e
Reviewed-on: https://chromium-review.googlesource.com/855776Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547085}

Otherwise there may be a clip inversion when drawing mask layers
for objects which include CSS clip.

Bug:822906

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I037304f4b6d777bf14aa1204631dac7cf24da139
Reviewed-on: https://chromium-review.googlesource.com/986718Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547084}

This CL changes the implementation of the said method to print out the
primaries coordinates instead of the Chromatic adaptation matrix, if
CUSTOM primaries are used.  The former is more informative than the
latter.

Example output with primaries triangle (edid and recalculated) can be
found in https://i.imgur.com/p5q9uyY.png (https://imgur.com/a/gdj62).

Bug: 821393
Change-Id: I690d2d6df1ece0ca75e4dcbbdb42bbd092eb234c
Reviewed-on: https://chromium-review.googlesource.com/985316
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547083}

Adds EmitAshInitialized method to session_manager_client - the
method requests from session manager to emit "ash-initialized"
upstart signal. The signal can be used to run upstart jobs that
should be run when ash is initialized - for example, to run hammerd
task, which will ensure that detachable base pairing signals are
emitted after ash starts observing dbus signals emitted by hammerd.
DetachableBaseHandler relies on hammerd signals to determine when,
whether a detachable base notification should be shown to the user, so
these signals should be re-emitted whenever ash is (re)started.

Makes ash::Shell::Init call the new session manager method to actually
emit the upstart signal once it's done initializing.

BUG=818057

Change-Id: If901e125f8f3f8563c22a0633644a0c6ff143f7d
Reviewed-on: https://chromium-review.googlesource.com/981330
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547082}

The ownership chain for the instance_ variable looks like:
LayoutCustom -> CSSLayoutDefinition::Instance -> v8::Object (instance_).

As LayoutCustom isn't a ScriptWrappable (lifetime is manually controlled)
using the TraceWrapperV8Reference was the wrong thing to do there.

Changed to ScopedPersistent.

Bug: 726125
Change-Id: I452a44e6914d042ca12f3bce3f8bce4a068bba5d
Reviewed-on: https://chromium-review.googlesource.com/986986Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547081}

When in WebVR presentation, if we transition to metaworld to accept a
permission, when we return we should not show the permissions.

Bug: 827304,827306
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9280a04950dcc24f163be9f58fbf27c14c9ab6bd
Reviewed-on: https://chromium-review.googlesource.com/986290
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547080}

This patch refactors inefficient usage of GetCharacterRange
as discussed in CL:979732.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1d1b135eaf8d7a12f0fd918316428d5bf30cbcc0
Reviewed-on: https://chromium-review.googlesource.com/981848Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547079}

It's better to put the class definition in a header file and the implementation
in a C++ source file. Then, the source file is made part of the project, meaning
it is compiled separately.

BUG=791371

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ic58d0c714b405ced8974aca22c3b20f7b479682f
Reviewed-on: https://chromium-review.googlesource.com/982751Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#547078}

These pieces will be used to store/represent page thumbnails.

Bug: 794828
Change-Id: I242ec8376a36b2b41590bf89fb166a924aa13ca7
Reviewed-on: https://chromium-review.googlesource.com/984952
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547077}

This adds three new metrics and fixes two existing ones to ensure
they are recorded accurately when we suspend for preload=metadata,
the new metrics are:

Media.PreloadMetadataSuspendWasIdeal.Audio
Media.PreloadMetadataSuspendWasIdeal.AudioVideo
Media.PreloadMetadataSuspendWasIdeal.Video

Which are boolean and set to true if a preload=metadata suspend is
not *immediately* aborted. Immediate abort can only result from
WMPI not knowing the true playback state until HAVE_FUTURE_DATA;
this is a lie we'd like to fix, and these metrics will help us
judge the importance of fixing it.

The fixed metrics are:
Media.HasEverPlayed
Media.TimeToFirstFrame.SRC
Media.TimeToPlayReady.SRC

HasEverPlayed is fixed by not counting the BUFFERING_HAVE_ENOUGH
event when it's issued for a suspended startup (determined by
a new media log property, which is gross, but how the existing
system must work for now).

TimeToFirstFrame and TimeToPlayReady are metrics which are relative
to the time of load start, but this does not work when we stop
after metadata. To ensure these metrics are still accurate once
playback does resume, we cache the |time_to_metadata_| value and
use it account for the section of time prior to metadata suspend.

BUG=694855, 827396
TEST=manually verified chrome://histograms has the right values.

Change-Id: I5cdeea08a798ed0875c2ce603d6ee2b9a31d1e55
Reviewed-on: https://chromium-review.googlesource.com/980589
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547076}

Without this dependency component builds will fail to link.

TBR: sergeyu
Bug: 822474
Change-Id: Ieb8d7309117e6e55c5fa3c8866920e1495dbbc3b
Reviewed-on: https://chromium-review.googlesource.com/987395Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547075}

This reverts commit d3f34a3f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [DevTools] prepare tests for new queryObjects
> 
> TBR=pfeldman@chromium.org
> 
> Bug: chromium:825349
> Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3
> Reviewed-on: https://chromium-review.googlesource.com/978844
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545600}

TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:825349
Change-Id: I21810896da315aea8179938f32e90a2512012252
Reviewed-on: https://chromium-review.googlesource.com/987332Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547074}

When the P2P Sharing flag is turned on, all existing offline pages will
become legacy pages.  Before they can be shared, they must be published
to a public directory.

This is the first of several changes to publish the file.  This adds the
calls down to publish the file, but doesn't actually do the publishing
yet.

Subsequent changes will publish the file, and update the OfflinePageModel
database with the new file path, and include unit tests for the code
which actually takes the actions.

This change covers one of two entry points.  Here we cover entry via
the chrome overflow menu.  The second entry point is from the downloads
home activity, which will be in another changelist, but should be able
to re-use parts of this change (perhaps the
OfflinePageBridge.publishThenShare method).

Bug: 758690
Change-Id: I31dc8db25b274d98f4bac88c98a96776c1d02c0b
Reviewed-on: https://chromium-review.googlesource.com/982734
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547073}

Change API contract for IPAddress::AssignFromIPLiteral() such that on failure the original value is reset.

This addresses a TODO, and avoids a copy in the success case.

Change-Id: I8ff0f1154a7e4a8085c6a9f50d72bb99dfb51b7c
Reviewed-on: https://chromium-review.googlesource.com/985907Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547072}