- 11 Sep, 2020 40 commits
-
-
Vadim Shtayura authored
Based on pools.cfg in infradata/config. Not really used by anything yet. One complication is per-milestone projects: we "fork" builders, but not Swarming pools. So some chunks of configuration should be defined only on the main branch. R=gbeaty@chromium.org, estaab@chromium.org, iannucci@chromium.org BUG=1123142 Change-Id: I4850e1be0efc6215a0bc58f3ad707dbdc3a1e473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401814Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806273}
-
Sinan Sahin authored
Bug: 1067365 Change-Id: If721820718fec110e2e606a5fde4a9a3a2af7038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382963Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#806272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab5010493df3..30d3022f727a 2020-09-11 ethannicholas@google.com Moved SkSL type into IRNode, now accessed via a method 2020-09-11 johnstiles@google.com Reland "Add InlineCandidateAnalyzer to locate candidate functions for inlining." 2020-09-11 johnstiles@google.com Pass non-temporary Program::Settings to convertProgram. 2020-09-11 egdaniel@google.com Reduce the amount of forced dedicated allocations we do in Vulkan. 2020-09-11 jmadill@chromium.org Port to ANGLE's GN files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1127358 Tbr: reed@google.com Change-Id: Ic95f7d99034bf209bc1b351fed5eb03376d79071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806271}
-
Xiaohui Chen authored
Previously ambient window is sharing the same window container as the lock screen. It is behind the shelf buttons, e.g. logout, shutdown. We need to be able to hide those button according to UX. Additionally using a separate window container from lockscreen makes it possible in the future to show Ambient mode before lockscreen window is created to facilitate a better transition. Bug: b:162596816 Test: run existing unit tests and manual test. Change-Id: I21390685f4408e0a6c85d33e1c04db9fb10c9ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402291Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806270}
-
sczs authored
Bug: 1127014, 1085419 Change-Id: Ia87c235ca32e60396e721f1821eafc78f44c9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404958Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#806269}
-
Matt Menke authored
And always enable it. We've decided that we want to have the feature enabled when we launch network partitioning, so there's no reason to keep around the path where it's disabled. Bug: 1126059 Change-Id: Ie02a4a52544e63319fdcae81dce6e9d4aea27684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398903Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#806268}
-
Natalie Chouinard authored
After the AndroidFontLookup implementation was switched to using a PostTask to fetch the font, and an Executor to run the callback, these tests were only passing because the callback (checking assertions) wasn't being run at all in tests. This fixes that issue by initializing native to ensure PostTasks are run, and adding a runLoop to run the Executor tasks (the latter mirrors the Mojo ExecutorFactoryTest). Bug: 1111148 Change-Id: I71eda8b1ab20ed2aabf8810303a6435b5007aaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404073Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#806267}
-
Mike Wasserman authored
This reverts commit 4986fdfd. Reason for revert: Chrome Apps regression: crbug.com/1125403 and crbug.com/1125858 Original change's description: > cros: V2 apps open on the same display as GetDisplayForNewWindows. > > This emulates behaviour for browser and V1 apps [1]. Adjusts bounds on > app creation if the new window display is different than the saved > bounds. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/window_sizer/window_sizer.cc;drc=2f11470d7ad8963a9add116df64d2edd1b85d3a4;l=274?originalUrl=https:%2F%2Fcs.chromium.org%2F > > Test: browser_tests ChromeNativeAppWindowViewsAuraAshBrowserTest.OpenOnTheCorrectDisplay > Bug: 1080390 > Change-Id: I5a705a0875ae8a1fb35d1f1a92613c3f38bef7d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189575 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769381} TBR=xiyuan@chromium.org,benwells@chromium.org,calamity@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1080390 Change-Id: Ie0962dd5ebae9c2837d2a74503583d9c48748882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405618Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806266}
-
Becca Hughes authored
Change-Id: Ic6254af767545e783605a6f0cbe853601fcec236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405750Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#806265}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the H264 decode accelerator. This is verified via chrome:tracing and codepen.io/miguelao/full/MMxGJw that plays 4 1280x546 H.264 videos at the same time. Tracing is captured for a few seconds, basically with this patch we have 2 SubmitBuffers() calls adding up to ~0.461ms/frame versus ToT individual SubmitBuffer() calls (4 of them) ~0.504ms in total -- which gives an aggregate of about ~40us improvement, or savings of about ~10%. Since decoding itself takes about the 0.390ms/frame, savings are OKish, so let's take them. This is all on my BSW device (reks), Improvements are of course extremely small, the advantages of this CL are in reducing lock/unlock churn and associated contention. This benefit grows with the amount of decodes (e.g. Meet grid scenarios). Bug: b/166646505 Change-Id: Id51bb6db39e4f7b9d67760f86b8f8963f20c2b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405586Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#806264}
-
Morten Stenshorne authored
If the inline-size is deduced from the min/max size somehow (e.g. shrink-to-fit), a font size change may change the intrinsic (min/max) sizes, which in turn may affect the inline-size of the element. Additionally, we need to make sure that we actually DO recalculate the intrinsic size of all elements affected by a font size change. Note that this bug also exists in the legacy layout engine, but this CL doesn't address that. Bug: 1125109 Change-Id: Ibb33648fcb9bc6c9061d95e42b7f3c4db7b1bd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404847Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#806263}
-
Elly Fong-Jones authored
There are three: * The app dialog view, which is now always window-modal * The Aura eye dropper dialog, which is now always window-modal * The generic message box dialog, which loses support for system modal on non-ChromeOS and will DCHECK if asked to be system modal. Bug: 1121132 Change-Id: I7e10431db9a0001adb8d081bb19b974a46046fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398943 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806262}
-
Ben Pastene authored
The test is failing on CrOS and blocking LKGM updates. This disables it while we figure out what regressed to allow for LKGM updates. Bug: 1127052 Change-Id: Ie44baff4b78e495c1af42b4f01e4b6bb6b16071d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404749 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#806261}
-
Jan Wilken Dörrie authored
...showGooglePasswordManager Bug: 903249 Change-Id: I8e76df331263ca52846fe48f94b2cbbc412a9ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403282Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806260}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/995a78a14b4b..8ed34138a32b 2020-09-11 jacktfranklin@chromium.org Migrate detached DOM tree heap layout test to e2e 2020-09-11 tvanderlippe@chromium.org Load emulated_devices images from bundle instead of remote If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0a5d5dbab5cc6450e7c39cdfcf05b4a78e0405a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406322Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d05e532c6bd2..dbd34449af20 2020-09-11 cwallez@chromium.org Roll third_party/spirv-cross/ bad9dab8d..bdbef7b1f (3 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I75c4755f416e75fe6b1d9a8c691e1f7f4f59727a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406326Reviewed-by:
-
Avi Drissman authored
Starting in macOS 10.14, access to the Safari bookmarks file was restricted. Chromium didn't notice, and would proceed anyway, because it assumed that if the file was there, it could be read. That's not true in the general case anyway, so fix it. History import from Safari broke many years ago when they moved to a database for their storage from using a plist. No one realized that it broke, and since it's access restricted from 10.14 on, there's no point in fixing it, so this CL removes it. Bug: 850225 Change-Id: I984ba22a3bcce60ed39cc4fb45331d38f6a6fa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404529Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806257}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a35a5ecf. With Chromium commits locally applied on WPT: 8bac593b "Test helper: In answer, apply remote description before local description." 428b08c5 "[Sanitizer API] Add empty config dictionary." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I76074d99303be0a2333e7c1b9dce4ea06a622c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404807Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806256}
-
Xiaohan Wang authored
This CL refactors how KeySystemConfigSelector::SelectConfig() returns the results. A Status is added to provided more details on the config is not supported. The promise rejection messages are also updated to return different strings on different statuses, which could be useful or troubleshooting. Currently we still return the same message for kUnsupportedKeySystem and kUnsupportedConfigs to avoid updating many tests and potentially affect existing JS application. In the future we may consider returning different strings for that case. For kUnsupportedPlatform we return a different string. This should be fine for privacy because it'll only be returned when the platform does not support the key system at all and should not reveal any user/device information. Bug: 760720,1126664 Change-Id: I8df167e5c3e86607917d5414a558aae32eed027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405734Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806255}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 5c52ad843..0c20b03c8 (3 commits) https://quiche.googlesource.com/quiche.git/+log/5c52ad843f8a..0c20b03c83cc $ git log 5c52ad843..0c20b03c8 --date=short --no-merges --format='%ad %ae %s' 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_do_not_use_stream_map. 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_remove_streams_waiting_for_acks. 2020-09-10 bnc Use IETF application error codes for STOP_SENDING frames. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: Iba8427627fcbfd7417a0d619f80f8b139c153cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404718 Auto-Submit: Ian Swett <ianswett@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806254}
-
Sven Zheng authored
Sometimes gsutil cp operation can fail and cause tree closing. Retry the operation to mitigate the flaky issue for gcs. Bug: 1126956 Change-Id: I5f397768745c845f0e61ad87fd1b725e13dfd4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404395 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#806253}
-
Wez authored
LOG(FATAL) message content is now provided in Crashpad dumps via an annotation, so there is no longer value in providing markers to allow the stack to be scanned for the message. Removing this also avoids the need to update the test not to cause failures in ASAN builds. Bug: 802393, 1119821 Change-Id: I6a64778f4da527597e9bb0874fe5764fbf87716a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404926 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#806252}
-
Prabir Pradhan authored
Exo gamepad vibration is disabled by default. We add a toggle in chrome://flags that allows gamepad vibration to be enabled for Exo clients that support it. BUG=b:158673179 TEST=manual. Enable flag, and ensure exo client can vibrate gamepad. Change-Id: I4b64b8eb49bba8c7620af80cdaf2ac17ceb3b6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402110 Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#806251}
-
Ayu Ishii authored
This is a reland of 612ba1ba. This CL removes .gni references to v8_cookie_match_type.{cc,h} that were overlooked in the original CL. Original change's description: > CookieStore: Remove matchType > > This change removes matchType option from CookieStoreGetOptions. > This decision has been discussed here [1], and will > be revisited after launch to re-evaluate if the option > is good to have or if we should do a full cleanup of > the option. > > [1] https://github.com/WICG/cookie-store/issues/128 > > Bug: 1124497 > Change-Id: I845c6e872aa25d138114ccf0b0a74332adeb650d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402132 > Commit-Queue: Ayu Ishii <ayui@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805855} Bug: 1124497 Change-Id: Ie79c492c5ec4f1a2dbcccbe886910500f9e89087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404123Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#806250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ec1f5c76dcd..409a8e40330a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039881,chromium:1040645 Tbr: chanli@google.com,sebsg@google.com Change-Id: Iaeecf2709aab0a23ea5cdf3dffce8f39ad926098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806249}
-
Tommi authored
This is to facilitate interface changes in webrtc. No functional change. Bug: webrtc:11908 Change-Id: I19f56192ddddc93c0577cb76d163bfbb0ce6175b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406216 Auto-Submit: Tommi <tommi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#806248}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009110800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/_QUWBlAB3zSpGuENS-ygkl0rPTkolBKtlvjdPANqPVEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ic28566eea2b0c4e218921bb2b582fb5b449f1790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406268Reviewed-by:
-
Robert Ogden authored
Every NSP has its own URLLoaderFactory, so this CL adds a simple counter to that class and when the max is reached, sends ERR_FAILED to all further requests. Bug: 1127120 Change-Id: I14b8509bdd2c3a0de371675bfe37520c26fc8064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404157Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#806246}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009110800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/EkH9HKyhEJ36FSRAshQQ9CzkNiofxiGuB3jzZVyXqhcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/141204984,b/157694064,b/162294373,b/165887300,b/166760020,b/167632244,b/168265185,b/168265337 Tbr: media-app@grotations.appspotmail.com Change-Id: I099475d47eb6d1021f0eef50f553c2111b512a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406265Reviewed-by:
-
Darwin Huang authored
The format used is already implied by the class name, so remove this redundant information. Also, add some subclass comments for consistency and clarity. Refactoring change only. No functional changes intended. Change-Id: I25e7d354e22a30ea164c9eab74d2d7f36e5a10e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405565 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#806244}
-
Amy Huang authored
and also remove DIA dependencies. Setting DLLVM_ENABLE_DIA_SDK=OFF makes LLVM default to the native symbolizer, which was recently implemented, and allows us to remove the DIA dependency. There aren't many existing test cases for this, so at the moment it's possible there are edge cases where the native symbolizer doesn't work. Change-Id: I8ff395f47869296b01bc3c11f3afdeae102664d5 Bug: 1126219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399515 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#806243}
-
Jan Wilken Dörrie authored
This change removes the kPasswordManagerOnboardingAndroid feature. While code-complete, this feature was never launched. Bug: 983445, 1126051 Change-Id: I4a56e924163805fa28e9ac2e2574e26c1864e508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403481 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#806242}
-
James Cook authored
Make it behave like a secondary browser icon: * Always pin it when the flag is set, similar to policy-pinned apps * Default position is to the right of the browser icon * Context menu does not contain an "Unpin" item Also change the app name from "LaCrOS" to "Lacros", since we've settled on the simpler capitalization and I'm adding a test that references the name. Bug: 1127153 Test: added to unit_tests Change-Id: I08ba806d481580988f2be284d8d1ccb6210ea8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405737 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806241}
-
Maggie Chen authored
Currently, the command line switch "--show-dc-layer-debug-borders" shows borders for only one overlay. This CL extends the support for multiple overlays on Windows. Bug: 1117235 Change-Id: I4ba74a24fa402b5b89411e5c079672f6b9bfbcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405559 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#806240}
-
Clark DuVall authored
This method may try to access the dex file, so ignore strict mode violations. Bug: 1105096 Change-Id: I4afe88888ec8de39e7c4ea9c1ee89e1dba9ce2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404379Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#806239}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I18605f14aec2ffe24bb2155467c353d1cb05e9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406328Reviewed-by:
-
Olga Gerchikov authored
Implemented calculating current time based on multiple scroll offsets for both blink and cc ScrollTimeline. Bug: 1094014 Change-Id: I1c724a1a5191bfa36b91926c1c30a1385cfee10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387079Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#806237}
-
Josiah K authored
AX-Relnotes: N/A Change-Id: Id6b8b37f5dadabf689aceafda8fd8f5636fbfabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406374Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806236}
-
Aaron Leventhal authored
Bug: 1123883,1124757,1125186 Change-Id: I9caf47c94551c2edfb9221fce8f3105f9563aa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405938 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Garrett Beaty authored
These compile targets are currently specified in recipe configuration. Bug: 1091004 Change-Id: Ie69bf59618152a9f0efa7e267c7ed37bf6816a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391511 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#806234}
-
