- 26 Sep, 2017 40 commits
-
-
Sadrul Habib Chowdhury authored
Dispatch the commands in Page domain through an UberDispatcher. Follow up CLs make this change for the other domains (Browser, Target). This is in preparation for adding WindowManager domain. BUG=758061 Change-Id: I35e9dcae13ee9f80e4d81054bdfaf2c5292785ad Reviewed-on: https://chromium-review.googlesource.com/674263 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504474}
-
EhsanK authored
Adding a test for https://crrev.com/502847. Bug: 766982, 763812 Change-Id: I23bd8d27cb2b83ee527f12a9103f82e8eac0b115 Reviewed-on: https://chromium-review.googlesource.com/682597 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504473}
-
Eugene But authored
This method will be used to gracefully handle SSL errors when WebState is not in a tab. Bug: None Change-Id: Iee02ce69deda84d595e6bd5ab815317afb82f12d Reviewed-on: https://chromium-review.googlesource.com/683464 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504472}
-
Tom Anderson authored
R=thestig@chromium.org TBR=michaelpg@chromium.org Change-Id: Ie26a81bf7f3bbf0beaf64565ae703c5134c997e7 Reviewed-on: https://chromium-review.googlesource.com/685268Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504471}
-
Peter Mayo authored
In the layer impl unittest. Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5b1de75269b30c160e1ffc369aff09a353d8ca10 Reviewed-on: https://chromium-review.googlesource.com/685259 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504470}
-
Lei Tian authored
When CCT opens url like https://expired.badssl.com, the strikethrough scheme sometimes does not display. This is because in CustomTabToolbar, updateSecurityIcon does not demphasize the url before emphasize it and this causes OmniboxUrlEmphasizer.hasEmphasisSpans() sometimes returns true and prevents the emphasis. To fix the problem, remove the hasEmphasisSpans check and always deEmphasizeUrl before emphasizeUrl the url. BUG=754985 Change-Id: I16143c4237d71ce9d5b860597f523942d314ba25 Reviewed-on: https://chromium-review.googlesource.com/675769 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#504469}
-
yucliu authored
Implement HDCP check in CastCdm. Given all Cast video products provide HDCP or equivalent content protection, the check is performed at platform level for all key systems, instead of querying each CDM. Note: Use command line arg --enable-blink-features=EncryptedMediaHdcpPolicyCheck to enable the API. BUG=internal b/64899044 TEST=Custom test page Change-Id: I5d56aa471d91675b546e433f05f32f359d817915 Reviewed-on: https://chromium-review.googlesource.com/676102Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504468}
-
Mircea Trofin authored
Instead of waiting until the test harness timeouts the test, we wait for a set period of time for the about:blank window to open, after which we fail the test. Bug: chromium:765738 Change-Id: I8635c19683a3791801bc3e75a3fc3bf16872b6f2 Reviewed-on: https://chromium-review.googlesource.com/676283 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504467}
-
Derek Cheng authored
Change-Id: I41469fc27e3c88e8aff19532abd2d5ac307824bf Bug: Reviewed-on: https://chromium-review.googlesource.com/682651Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#504466}
-
Alexander Alekseev authored
This Cl fixes a race in Time Zone Resolver Manager when checking if Local State has been initialized. Bug: b/64065854 Change-Id: If681dc675e0219fda7c9b37307c7f205394c62fd Reviewed-on: https://chromium-review.googlesource.com/682734 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#504465}
-
Xiyuan Xia authored
Code clean up and no behavior change. Bug: None Change-Id: I503e2ada644d827be7a5fe8b3e7f228130287b36 Reviewed-on: https://chromium-review.googlesource.com/685299Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504464}
-
Rouslan Solomakhin authored
Before this patch, when the user closes the PaymentRequest error message that states "Transaction failed, please try again," PaymentResponse.complete() promise would be rejected. This is contrary to the spec, which says the PaymentResponse.complete() promise should be resolved when the user closes the UI. Spec: https://www.w3.org/TR/payment-request/#complete()-method This patch changes the behavior of closing browser to resolve the PaymentResponse.complete() promise instead. After this patch, when the user closes the PaymentRequest error message that states "Transaction failed, please try again," PaymentResponse.complete() promise is resolved with undefined. Bug: 756298 Test: CompleteTest.ResolveCompletePromiseOnUnknownError Test: CompleteTest.ResolveCompletePromiseOnUserClosingUI Test: https://w3c-test.org/payment-request/payment-response/complete-method-manual.https.html Change-Id: If21b4b1c459432acf6f3156ddf26304f04f87918 Reviewed-on: https://chromium-review.googlesource.com/682794 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#504463}
-
Sky Malice authored
Bug: 482154 Change-Id: I634489e826f6f92d45977d438a6e1f39e862a330 Reviewed-on: https://chromium-review.googlesource.com/677585Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#504462}
-
Devlin Cronin authored
Instead of being friended by the SimpleFeature class, have unittests use the public setters. In addition to being more clear, this cleans up the header file. Bug: None Change-Id: Ia20359cf8ca35fc55eca8df1b7414b1d4f3ffea1 Reviewed-on: https://chromium-review.googlesource.com/679741 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#504461}
-
Tom Anderson authored
BUG=768020 R=thestig@chromium.org Change-Id: Iaf520e6f064cdc44977607fdac8be7137648bbfd Reviewed-on: https://chromium-review.googlesource.com/685506Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504460}
-
Thanh Pham authored
left of and non-overlapping with a hovered UIElement. In Chrome UI Devtools, users enter the inspection mode and pin an element by left-clicking on a window/widget or view on the Chrome UI. When user moves the cursor outside of the current UIElement, if the pinned UIElement is on the top left of and doesn't overlap with the hovered UIElement rectangle, the layout will display horizontal and vertical distances between the pinned UIElement and the UIElement under cursor as shown in picture below. This case refers to R1_TOP_PARTIAL_LEFT_R2. Bug: 750143 Change-Id: I03923aa251af63a4d820efd88c974679bf1e7c93 Reviewed-on: https://chromium-review.googlesource.com/591930 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504459}
-
Morten Stenshorne authored
In this teste there's a (rather) deeply nested subtree of column-flow flex containers. The root of this subtree is itself a flex item in a row-flow container. It has a sibling item whose child changes width, without affecting the flexed size of the deeply nested subtree. This shouldn't require the subtree to be re-laid out, but it currently does get re-laid out, thanks to the fix for bug 752078. Bug: 766633 Change-Id: I3d76736730f18082a299907f7b2a543d2b087ba8 Reviewed-on: https://chromium-review.googlesource.com/680216Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#504458}
-
Mustafa Emre Acer authored
Captive portal interstitial is currently only compiled if ENABLE_CAPTIVE_PORTAL_DETECTION is present. This flag enables Chrome's own captive portal detection and is off on Android. However, we still want to be able to display a captive portal interstitial on Android, by way of checking the certificates served by portals. For that reason, this CL enables the captive portal interstitial on Android and uses the CaptivePortalCertificateList feature to detect captive portal related certificates. It also adds a Java test for the new interstitial. Bug: 642993 Change-Id: I6be15ce10a5039fb1b1d8da0e7ef2f2c27dc48b4 Reviewed-on: https://chromium-review.googlesource.com/661795 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#504457}
-
Lutz Justen authored
Introduces a setting in policy_templates.json to specify whether a Chrome OS policy is managed by Google cloud management ('gc') or by Active Directory ('ad'). Sets a bunch of policies to 'gc'-only that don't work for Active Directory (e.g. device reporting, kiosk). The following changes for 'gc'-only policies: - The authpolicy daemon, which converts Active Directory GPO to policy protobufs, ignores them, see CL:608134. - They are not included in Chrome OS ADMX templates since they're specified with Google's web UI, not through Active Directory GPO. - Likewise, the HTML docs don't show example values, registry locations etc. BUG=chromium:662417 TEST=components/policy/tools/template_writers/test_suite_all.py Checked ADMX and HTML docs from ninja -C out/Release -j 2000 policy_templates Change-Id: Ib02ae8095c1052efb44a957e47b4b7628a4bdda5 Reviewed-on: https://chromium-review.googlesource.com/677289 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#504456}
-
Paul Meyer authored
This patch removes a few debugging artifacts that were left in the reporting-observer/intervention.html layout test. Change-Id: I132a73b87c32d9a2fdb83a241ef733cb61f727e9 Reviewed-on: https://chromium-review.googlesource.com/677976Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#504455}
-
Stephen Martinis authored
We switched over to a new bot, which has a different gpu. This CL updates the swarming dimensions to have the correct GPU. NOTRY=true Bug: 732463 Change-Id: Ibb4f034ad78e4ec294be679e70bb9f3b0ef5f61c Reviewed-on: https://chromium-review.googlesource.com/685475 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504454}
-
Lei Zhang authored
Change-Id: I3510dcafacab2471b02762670527dc299411c7b2 Reviewed-on: https://chromium-review.googlesource.com/683616 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#504453}
-
Sigurdur Asgeirsson authored
Bug: 753363 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ic9045893035329b8434fd8ca7fe18735c57f842c Reviewed-on: https://chromium-review.googlesource.com/684874Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504452}
-
Rohit Rao authored
These view controllers are currently contained children of MainViewController. When the experiment is enabled, they are presented instead. This CL also adds a completion handler to [MainViewController setActiveViewController:completion:]. This handler will be used in a future CL. BUG=768563 Change-Id: Iefead6de0a1471dcd07c67d634acbab15c70b9c3 Reviewed-on: https://chromium-review.googlesource.com/683196Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#504451}
-
Ned Nguyen authored
Bug: 767970 Change-Id: I9d8ccbd188c4e38bf1059d7b850ccc43b1a079c4 Reviewed-on: https://chromium-review.googlesource.com/684617Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#504450}
-
chrome://download-internalsDavid Trainor authored
Add chrome://download-internals to expose long-running download state, as the system is now a root service of multiple other features. This CL sets up the initial skeleton and pipeline. Future CLs will add more capabilities. This page will be used by more download-related features in the near future (e.g. background fetch). Sets up the following framework in the download service: Logger: The public interface to the log code. Can be queried for state and returns base::Value objects. Logger::Observer: Used to notify external components (e.g. WebUI) about internal state changes. LogSink: The internal interface that should be notified by internal components about potential log-worthy changes. LogSource: The internal interface that Logger will request state from. BUG=736235 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0df66753884a2bc3f8e5ef7e0466cc879616a3a1 Reviewed-on: https://chromium-review.googlesource.com/592314 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504449}
-
Robert Sesek authored
Currently the code assumes that a TYPE_DEFAULT MesssageLoop will be backed by CFRunLoop, which is required to receive the CoreMIDI callbacks. In the future, that assumption may not be true, so explicitly request a TYPE_UI (CFRunLoop) pump. Bug: 753544 Change-Id: I5464e1299d8cb99d6fbf37d8b342417487117744 Reviewed-on: https://chromium-review.googlesource.com/682834 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#504448}
-
Michael Giuffrida authored
This reverts commit b29b6884. Reason for revert: CrOS browser_tests failing in debug builds Bug: 768949 Original change's description: > cros: AuthSyncObserver observes SigninErrorController > > - Make AuthSyncObserver observe SigninErrorController in addition > to sync service so that auth errors caused by other services > are caught as well. > - Fix an edge case that OAuth2LoginManager marks valid oauth2 > token when it thinks /MergeSession succeeds regardless of > whether there is any auth error; > > Bug: 760610 > Test: OAuth2Test.SetInvalidTokenStatus > > Change-Id: Idbaee9f7faa1aa2aff939a1540bfcfdd9f49c96c > Reviewed-on: https://chromium-review.googlesource.com/658378 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504391} TBR=xiyuan@chromium.org,achuith@chromium.org Change-Id: If3421269787c16081e1fd00382e5d92f73d8f082 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760610 Reviewed-on: https://chromium-review.googlesource.com/685398Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504447}
-
Eric Holk authored
Wasm's trap-based bounds checks are only supported on Linux x64 right now. This test makes sure it is not incorrectly enabled on other platforms. Bug: v8:5277 Change-Id: Id95ba47d228707ba5ccbfde50b59ff8b26e8c79e Reviewed-on: https://chromium-review.googlesource.com/682874 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#504446}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/15dffdf6bd8d..7d04f1b0ab48 $ git log 15dffdf6b..7d04f1b0a --date=short --no-merges --format='%ad %ae %s' 2017-09-26 dsinclair Hide FX_HandleParentPath 2017-09-26 dsinclair Share public part of CFGAS_FontMgr declaration 2017-09-26 dsinclair Move font source into CFGAS_FontMgr Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifcb623446f57ef4d53f6b930b2a73fc67cee3840 Reviewed-on: https://chromium-review.googlesource.com/685256 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504445}
-
Andrew Grieve authored
This reverts commit e3f445df. Reason for revert: Broke compile: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20KitKat%20Builder/builds/3365 Original change's description: > Remove //chrome/android:chrome alias > > Downstream rename is now complete. > > Bug: 731186 > Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9 > Reviewed-on: https://chromium-review.googlesource.com/684956 > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504437} TBR=nyquist@chromium.org,agrieve@chromium.org Change-Id: I65a66e72aabc72986c8e9aacef485807cab98c3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 731186 Reviewed-on: https://chromium-review.googlesource.com/685635Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#504444}
-
Yuwei Huang authored
When a connection is closed by the host, ChromotingClient will first get the notification on network thread, then free the connection object and notify UI components on the UI thread. In some rare situations, a mouse event may be posted to the network thread after the connection is reset and before ChromotingSession starts cleaning up resources, and causes segfault because the input_stub is already freed by the connection. This CL fixes this problem by immediately resetting the input_stub when the connection is being reset. Bug: 766698 Change-Id: I95d230565154dfe3762b9de516f5fa02dabb2bba Reviewed-on: https://chromium-review.googlesource.com/683801Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#504443}
-
Corentin Wallez authored
BUG=angleproject:2137 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5e50aab356858f84c6d198dc8dc387eed5998480 Reviewed-on: https://chromium-review.googlesource.com/685035Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#504442}
-
Nate Fischer authored
Previously, WebView would explicitly post onPageStarted for loadDataWithBaseUrl, since this navigation was handled by blink and it did not generate the event. With browser-side navigation (PlzNavigate), this is no longer the case and the navigation code will post this event under the normal pipeline. For this reason, we need to disable the extra postOnPageStarted when browser-side is turned on. As part of the implementation, this adds a Java wrapper around IsBrowserSideNavigationEnabled. This also modifies an integration test to check that we only get onPageStarted called once. Bug: 702785 Test: run_webview_instrumentation_test_apk -f LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted Change-Id: I3abc7b3503feee26e5b2438f9b039be30750e4ef Reviewed-on: https://chromium-review.googlesource.com/683634Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504441}
-
Michael Giuffrida authored
This reverts commit be622beb. Reason for revert: Breaks PDFToPWGRasterBrowserTest.TestSuccess Bug: 768938 Original change's description: > Roll src/third_party/freetype/src/ 6f2b6f8f7..02e80da60 (1 commit) > > https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6f2b6f8f72ff..02e80da6090c > > $ git log 6f2b6f8f7..02e80da60 --date=short --no-merges --format='%ad %ae %s' > 2017-09-24 apodtele Tweak per-face LCD filtering controls. > > Created with: > roll-dep src/third_party/freetype/src > R=bungeman@chromium.org,drott@chromium.org > > Change-Id: Ief384669998d1994f574fdf86229a05ec16f6426 > Reviewed-on: https://chromium-review.googlesource.com/682176 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Ben Wagner <bungeman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504362} TBR=bungeman@chromium.org,drott@chromium.org Change-Id: I5d8d33e6800dd282538a066bc0109620f8e36521 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/685397Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#504440}
-
Francois Doray authored
WorkerPool is being deprecated in favor of TaskScheduler. NSS functions may reenter //net via extension hooks. If the reentered code needs to synchronously wait for a task to run but the thread pool in which that task must run doesn't have enough threads to schedule it, a deadlock occurs. To prevent that, calls to NSS functions are made within the scope of a MAY_BLOCK base::ScopedBlockingCall which increments the thread pool capacity after a short timeout. Bug: 659191 Change-Id: I2a2719f7c104f1ecf8cac7e4019836920c777261 Reviewed-on: https://chromium-review.googlesource.com/648328 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504439}
-
wutao authored
We want a mechanism to defer ui::Layer painting during animation. There are two benefits. First, we will not do layer compositing and rasterization at the same time. Second, we can cache the render surface of the animating layer. In deferred paint mode, the |damaged_region_| in SchedulePaint() will be accumulated and drawn after the deferred paint request is removed. Changes: 1. Added APIs of [Add|Remove]DeferredPaintRequest(). 2. Modified SchedulePaint() and SendDamagedRects() to defer painting. Bug: 761109 Test: linux build and device. Change-Id: I7d9710b7a6e758b6a70550d62e9cbce64333ee6b Reviewed-on: https://chromium-review.googlesource.com/646906 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504438}
-
Andrew Grieve authored
Downstream rename is now complete. Bug: 731186 Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9 Reviewed-on: https://chromium-review.googlesource.com/684956Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#504437}
-
Vladimir Levin authored
This patch does the following: - Moves the decode implementation to ImageLoader - Adds the decode functionality to SVGImageElement - Reworks the decode functionality to use microtasks to align with the proposed spec changes: https://github.com/whatwg/html/pull/2965 This patch also cleans up some tests and adds <picture> tests. R=fs@opera.com, domenic@chromium.org Bug: 705669 Change-Id: I736f44c59cc173bda9f89000eaea309ddfbbeb85 Reviewed-on: https://chromium-review.googlesource.com/665381 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#504436}
-
kylechar authored
Add WrapRefCounted() which is a better named version of make_scoped_refptr(). The new name matches the MakeUnique/WrapUnique convention already established. Update a subset of callsites to use the WrapRefCounted() or MakeRefCounted<T>() if possible. Other callsites will be updated in a followup CL and make_scoped_refptr will be deleted. Bug: 765333 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea443d3d60f7b158b4bbbc0f43f5c3b4fad1c079 Reviewed-on: https://chromium-review.googlesource.com/684557 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504435}
-