GitLab

The filename and URL may contain special characters that require escaping
Or otherwise the json file won't open

BUG=850734

Change-Id: Ic4164cd0512c0ba288b6039b2b4bd8dc4f63bb0d
Reviewed-on: https://chromium-review.googlesource.com/1091391Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565467}

This CL adds more detailed test case for EncryptedMediaTest.PolicyCheck
when using Widevine key system. Note that the test is bypassed on
ChromeOS since Widevine CDM on ChromeOS doesn't support this API yet.

Bug: 849846
Test: Add more detailed test case.
Change-Id: Iae08027f8fae25710dd5b997ff4942c234c04192
Reviewed-on: https://chromium-review.googlesource.com/1087438
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565466}

Fix DCHECK in NetworkServiceTestHelper on network process shutdown because bindings are destructed on the wrong thread.

Bug: 846445
Change-Id: I765b613ea68201382da3f437e9f6a57904839bba
Reviewed-on: https://chromium-review.googlesource.com/1091806Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565465}

Instead of creating and destroying the ClientResourceProvider with
the LayerTreeFrameSink, create it once and keep it around until the
LayerTreeHostImpl is destroyed. This allows ResourceIds to remain
valid when the LayerTreeFrameSink is replaced while software
compositing (which can happen if the viz service crashes).

We add a method ShutdownAndReleaseAllResources() on
ClientResourceProvider that will release any exported resources,
marking them as lost, instead of doing so in the destructor,
so that the owner of the class can control the timing more without
needing to heap-allocate the class.

We also take away the allowance for importing a ResourceId and
not removing it before destroying the ClientResourceProvider (or
calling ShutdownAndReleaseAllResources()). Instead we have it
DCHECK() if this occurs, reporting the stack trace from where
the resource was imported. We do this because marking resources
that are not exported as lost is silly, since they were imported
they could have been removed. A bunch of unit test changes are done
to remove resources that were imported because of this.

Two unit tests that tested the case of destroying the
ClientResourceProvider while imported resources were present are
removed since it is no longer supported.

When the CompositorFrameSink is lost, the LayerTreeHostImpl loses
the ability to receive back resources it had previously exported.
We add a method ReleaseAllExportedResources() on
ClientResourceProvider to handle this case, which removes the
export count on all resources, releasing any marked for deletion
previously. When software compositing, they do not need to be
marked lost, but when gpu compositing they do since the display
compositor modifies texture metadata in order to use them. Tests
for the new method are added, as well as to verify that in
LayerTreeHostImpl, when the CompositorFrameSink is replaced, that
the ResourceIds are not kept around.

The software-resources-aren't-lost distinction is not important in
this CL, since LayerTreeHostImpl destroys all its resources
regardless when it tears down the ResourcePool and
RasterBufferProvider. However for external clients which provide a
resource through TextureLayer, the ResourceId can remain valid in
software compositing.

R=piman@chromium.org

Bug: 826886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85a867c2830c31d39796ff971e01a221e5716812
Reviewed-on: https://chromium-review.googlesource.com/1083617Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565464}

Opening an entire bookmark folder with more than 20 bookmarks in it
from the bookmarks bar using Cmd+Click on a Cocoa browser is currently
broken. This happens in the bookmark draggable button's action.

The action may run a nested loop, which may see the mouse "up" event and
cause the action to be performed again, inside the nested loop. We also
need to ensure the bookmark button doesn't enter its _own_ nested run
loop, since the mouse up has already been eaten by the nested run loop
inside the action.

Failure to do so causes the action to happen twice, which results in the
nested run loop of the action spawning another, nested, run loop within
itself, which never exits. This puts the browser into a very weird state.

TEST=On Mac (chrome://flags/#views-browser-windows DISABLED), have a folder
     on the bookmarks bar with >20 items and Cmd+Click it. Accept the dialog.
     Bookmarks should open.

Bug: 849135, 840387
Change-Id: I7e1eaf57dff956647cbdcf2cb449bb971cada074
Reviewed-on: https://chromium-review.googlesource.com/1090513
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565463}

Prior to crrev.com/c/1026630, SSLConfig.channel_id_enabled defaulted to
true, meaning that the proxy SSLConfig had Channel ID enabled. That CL
flipped SSLConfig.channel_id_enabled to default to false, but only set
channel_id_enabled on the server config, not also the proxy config. This
change should restore the behavior of Channel ID on proxies to what it
was before crrev.com/c/1026630.

Bug: 848953
Change-Id: Ibfde08309803e4bebac622b0d6366a2256ff2b58
Reviewed-on: https://chromium-review.googlesource.com/1089859Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565462}

R=weiliangc@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I15e59cebabd9b8fd018c1342d5d3658f847a3627
Reviewed-on: https://chromium-review.googlesource.com/1089663Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565461}

There are still cases that LayoutSVGEllipse asks LayoutSVGShape
for ShapeDependentStrokeContains() when it decided to bypass the
path for optmization in UpdateShapeFromElement().

Bug: 850659
Change-Id: If8f8fd512183477ec7472ebb5b28c7d8333aa0bd
Reviewed-on: https://chromium-review.googlesource.com/1091871
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#565460}

Sources that run on BeginFrames can delegate their skipped
frame logic to SkippedFrameTracker.

SkippedFrameTracker handles the following corner cases:
1) when non-consecutive BeginFrames are received.
2) when the producer is not trying to produce.

Bug: 790759
Change-Id: I99d4067d4eab79f220b892256d8d3d49d1af1209
Reviewed-on: https://chromium-review.googlesource.com/1070994
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565459}

Add an instrumentation test that checks for element visibility when the
default search engine is toggled.

BUG=841928

Change-Id: I878a4b486b988310899fcc3f88a751e90a97ee3e
Reviewed-on: https://chromium-review.googlesource.com/1091188Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565458}

Bug: 849811
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib034544b40403e47e1c7c538b70b93e9d3f6ee8c
Reviewed-on: https://chromium-review.googlesource.com/1087783
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565457}

UrlUtilities.getTelNumber crash if the url param does not contain ":",
add a check to the function preventing from crash.

Bug: 830086
Change-Id: Icb82df469986f329a5fdaf6ce3b20624a0530acb
Reviewed-on: https://chromium-review.googlesource.com/1091885
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565456}

We don't increment the crashed UMA for GPU_PROCESS_KIND_UNSANDBOXED. Don't
increment the launched UMA either.

Bug: 846333
Change-Id: I3f5845c3bd1b221640a11098ed7c5b7b1da2148b
Reviewed-on: https://chromium-review.googlesource.com/1091492Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565455}

With this change, package_arcore will be true for dev and canary builds.

Bug: 841881
Change-Id: Ib2a75e5a87cdc9776c674cc24293017966a56fe5
Reviewed-on: https://chromium-review.googlesource.com/1091642
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565454}

Provides more insight on the overlay state in the logs. Typically this
is used to signal that a video should be visible on Chromecast.

This only triggers on changes, so it should be infrequent enough not to
spam the log, but useful enough for developers to know when overlays are
in use.

BUG=b/79195588
TEST=Ran on device and verified the state change is shown in logs.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8af803ee1b28d9588d3cf9baee1af0804b5ece92
Reviewed-on: https://chromium-review.googlesource.com/1090795Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565453}

Bug: 612667
Change-Id: I6bd52794bf6122813770338a93509d295bf4a7cb
Reviewed-on: https://chromium-review.googlesource.com/1060458Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565452}

This adds the Utility class ApiHelperForO. It moves references to
RenderProcessGoneDetail, which was added in O, into a separate class. On
pre-O devices, this reduces log spam caused by a NoClassDefFoundError.
It also improves startup time.

Bug: 791099, 838702
Test: adb logcat | grep 'Failed resolution of'
Test: run_webview_instrumentation_test_apk -f org.chromium.android_webview.test.AwContentsClientOnRenderProcessGoneTest#*
Change-Id: Iee47d5d5553b6eb339123fbea238dcbf9969de49
Reviewed-on: https://chromium-review.googlesource.com/1089477
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565451}

Disabling overscroll glow in the way we did (in
https://codereview.chromium.org/2632493005) caused pull-to-refresh to
break. VR UX folks want overscroll glow anyways now, so let's just
turn it back on and un-break pull-to-refresh.

(Pull-to-refresh was broken because the overscroll controller wasn't
receiving Animate calls, so when the glow got 'shown' it never animated
away so the code thought it was always visible, and therefore prevented
pull-to-refresh)

Bug: 838679
Change-Id: I06fdbaadedfec702d43bf1915f3b05703da3d039
Reviewed-on: https://chromium-review.googlesource.com/1091658Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565450}

Adds a DisplayCutoutHost mojo interface that is implemented
by WebContentsImpl. When ViewportFitChanged is called by
the renderer we fire the ViewportFitChanged method on
WCO. This allows the browser to change the UI based on
the ViewportFit state.

On the Blink side changes to ViewportFit bubble up through
Document which will call the DisplayCutoutHost Mojo
interface.

BUG=838400

Change-Id: I701f8c367167c5d630800f9d41004b88d95f63f3
Reviewed-on: https://chromium-review.googlesource.com/1038786
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565449}

Change-Id: I8d7607fa1735d75cb1cc22c61dff5aa8aca8ed4c
Reviewed-on: https://chromium-review.googlesource.com/1090322Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565448}

Data savings are considered to be the size of the network usage on the
page compared to an estimate. If the user saved data, we report that
savings, if the user went over the estimate, we report 0 savings.

Bug: 797987
Change-Id: I5afb3c4409331c1d86c23cf80263abfaef9abdd5
Reviewed-on: https://chromium-review.googlesource.com/1091116Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565447}

Provide a suitable constraint space when calculating min/max inline
sizes for an orthogonal flow root. ComputeMinMaxSize() in NGBlockNode
typically ended up creating its zero-sized constraint space, which would
typically result in large block sizes (since there'd e.g. only be space
for one word per line).

Set percentage resolution size too, instead of leaving it at 0x0.
Percentages are often unresolvable (i.e. indefinite), in which case we
should of course refrain from resolving them, rather than resolving the
percentage against zero (which we used to do).

Add a DCHECK that we're always provided with a constraint space when
calculating min/max for orthogonal flows, as using the zero-size one
will not produce the correct result.

Bug: 848225
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic0aac380b2b733d3a55b25396c89584e4468899d
Reviewed-on: https://chromium-review.googlesource.com/1090845
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565446}

Move the download home chips closer to the proper spec values.  This
involves:
- Removing the icon from the chip.
- Updating the colors/layout to match the new design.
- Removing ChipView as it is no longer needed.

BUG=839489

Change-Id: Ibdf2d9912014ad3bd90ed37b5ec2aa970d0db630
Reviewed-on: https://chromium-review.googlesource.com/1088187
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565445}

The icon tint for non-modern is not set programmatically, which causes
the icon showing the wrong tint after the tint is cleared for favicon
bitmaps.

Bug: 849884
Change-Id: Ic1017b7a4df9672bc34f650dbdf27098718a625f
Reviewed-on: https://chromium-review.googlesource.com/1091694Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565444}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I64e98c4083329a77c0ca079a2781455a2df121a3
Reviewed-on: https://chromium-review.googlesource.com/1091456Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565443}

Notable changes:
 - updated testLinkWithBlankTargetWithoutUserGesture to execute script
   without user gesture
 - removed NavigationActionInitiationType::kScriptInitiated because there
   is no way to tell if action was initiated by the script (coordinates or
   SyntheticClickType can be 0 for valid link clicks).
 - Updated webView:createWebViewWithConfiguration: to use
   GetNavigationActionInitiationTypeWithVoiceOverOn, because there is no
   need to inspect action.description when Voice over is Off.
   -userIsInteracting can give false positives for link clicks, which is
   ok. window.open also have these false positives, so if the page wants
   to open a popup, it can exploit window.open.

Bug: 849749
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c179c9df2d6bce3253e46272c2f14e0eb6224bc
Reviewed-on: https://chromium-review.googlesource.com/1087389
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565442}

MediaTransferProtocolDaemonClient currently provides a low-level
ReadDirectoryEntryIds() method, and MtpManager does the translation to
the high-level ReadDirectory() method that MTPDeviceTaskHelper
understands.

Change MtpManager's ReadDirectory() method to ReadDirectoryEntryIds(),
so it acts more like a pass-through. Make MTPDeviceTaskHelper handle the
translation.

BUG=769630

Change-Id: I5154bd4beac0b6ab15579f166cdf8b8add6a7dac
Reviewed-on: https://chromium-review.googlesource.com/1080214
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565441}

This makes the AvatarToolbarButton toggle like a MenuButton similarly to
the adjacent BrowserAppMenuButton (which is actually a MenuButton).

Bug: chromium:849911
Change-Id: I30690c61dd9b9b58b80e28dcbc85dc9e72835b9d
Reviewed-on: https://chromium-review.googlesource.com/1091592
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565440}

Using wpt-import in Chromium 0635a5ef.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19164

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

TBR=foolip

No-Export: true
Change-Id: I85260495f00161b3cca3115b491e62231aa838e8
Reviewed-on: https://chromium-review.googlesource.com/1091648
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565439}

This will be used by manifest parser.

We now pass around a Cursor struct instead of CharType*
and return error type from all internal parsing methods.

Bug: 704441
Change-Id: If2773404d66d6a264cc5b573d7132ad57db117cd
Reviewed-on: https://chromium-review.googlesource.com/1072525Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565438}

Also, making sure the source of motion events is set, in order
to avoid warnings from InputEventConsistencyVerifier.

BUG=848740

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id1ee62b2d9eb63a6a3058b7a0914914823cf81d9
Reviewed-on: https://chromium-review.googlesource.com/1089856
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565437}

To allow testing with a local collector (that has decryption disabled),
we no longer encrypt HTTP UMA uploads if the destination is localhost.

Bug: 849127
Change-Id: Ied550633e7c11724bb6f61932963914b09560978
Reviewed-on: https://chromium-review.googlesource.com/1091274Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565436}

Bug: 850565
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6976b6e8a99938fd93a630955b9358153ab09fba
Reviewed-on: https://chromium-review.googlesource.com/1091280Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565435}

This log is huge and isn't going to make sense for users. Instead
of displaying it directly, we want to show a string explaining
what its contents are.

  there is a one-line message there, check filed feedback to see
  that the whole iwlwifi_dump log is included in system_logs

Bug: 792644
Test: file feedback, check system information dialog and see that
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01048934d348243fd1b127eec0a30b33a6437922
Reviewed-on: https://chromium-review.googlesource.com/738868Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Eric Caruso <ejcaruso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565434}

Update a subset of the //net tests to pump the message loop until a
particular event occurs by creating a RunLoop and passing its
QuitClosure to TestDelegate::set_on_<event>(..), or by using the
RunUntilComplete() helper.

Bug: 850145
Change-Id: Icc3cff76d5a7b93e92d2799ef9410bd41a31024f
Reviewed-on: https://chromium-review.googlesource.com/1084034
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565433}

InitialCommitInChildFrame and HistoryInertCommit are handled ~identically, and
seem to be safe to merge.

Change-Id: I3f4eca1a6b2174a9fc6ae5e73b5240d19f6b36ce
Reviewed-on: https://chromium-review.googlesource.com/1089875
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565432}

Currently, in the new Android horizontal tab switcher, we show the close button
on the left side of the tab (in LTR mode) in both portrait and landscape
orientations. We've decided we want to put it on the right side to improve
readability of the favicons. This CL moves the close button to be on the right
in both portrait and landscape modes.

This CL also cleans up the logic for determining which side to put the button
on, since we currently repeat the same logic in multiple places, which is very
difficult to maintain. I'm adding a parameter on LayoutTab that Stack can keep
updated so TabListSceneLayer doesn't have to replicate the logic for the check.

Bug: 849397,831359
Change-Id: I01559d56d084ffe3c2a2a35468c8a62fa5a16a16
Reviewed-on: https://chromium-review.googlesource.com/1089572Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565431}

This CL fixes a memory leak that occurs in LocalSafeBrowsingDatabaseManager that
was seen on the Linux Asan bot [1].  The race occurs when a delayed
initialization task happens after the database is closed during shutdown.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Tests%20%281%29/46741

BUG=None

Change-Id: I45043c243bc6b5af948c8171d72e50f203611395
Reviewed-on: https://chromium-review.googlesource.com/1090235Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565430}

Changes:
We fixed this for shelf before
(https://codereview.chromium.org/2894743002), but not for
app launcher which results in inconsistent behavior. So
fix this for launcher as well.

Bug: 850335
Change-Id: I19849658ad0617fe7326895b58efd72261eb8a8c
Reviewed-on: https://chromium-review.googlesource.com/1091277Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565429}

The CL maps the Page.setWebLifecycleState devtools
protocol method to httphandler endpoints.

Change-Id: I1eb66cb3e6c73b55949974fc572456c81ffaeed6

Bug: chromium:837709
Change-Id: I1eb66cb3e6c73b55949974fc572456c81ffaeed6
Reviewed-on: https://chromium-review.googlesource.com/1066395
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565428}