- 23 Sep, 2020 40 commits
-
-
Glen Robertson authored
Iteration order was implied but never stated before. We need to rely on it for correctness. eg. crrev.com/c/2398449 Change-Id: I2050dffb44da68950261db319981537178fea2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407622 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#809781}
-
Gabriel Marin authored
These are indicative of unsupported perf record commands. BUG=b:169068625 Change-Id: Id04dd286cd77ab0ee6d04f9e3e3ff3986802c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424710Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#809780}
-
Philip Jägenstedt authored
Bug: 1131471 Change-Id: I46758dfffb63e98f42a262b6e398a01beca3bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424093 Auto-Submit: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809779}
-
Morten Stenshorne authored
Don't let contents of boxes with non-visible overflow affect initial column balancing block-size estimate. Bug: 829028 Change-Id: I7d4be18001da7f41676f1254df43ab0e083e3ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425043 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809778}
-
Swapnil authored
This CL reports the installation stages for force installed extensions in an increasing order. This is done in order to investigate the extensions stuck in CREATED stage. Bug: 989526 Change-Id: I82e07f30c6768c7bde30a76b61b9987173f76fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421375 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809777}
-
Alex Turner authored
Registers binders to allow UkmRecorderInterface to be used in worker contexts. As these binders are not currently registered, calling WorkerGlobalScope::UkmRecorder() causes a renderer crash. This can occur when MediaSource::isTypeSupported() is called in a dedicated worker context (with experimental web features enabled). Bug: 1122971 Change-Id: If79cbd74cf7d88c66a9fc0eda820c60b682dc5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424504Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#809776}
-
Eric Seckler authored
|time_delta| can be a rather large microsecond value, multiplying with |process_cpu_time_delta| can cause uint64 overflow. Instead, compute a double factor from time_delta/total_delta first. Bug: 1129004 Change-Id: I8ff9fd6a03551d1bdde29d263f76b1f5857ed3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424192Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#809775}
-
Benoit Lize authored
This CL adds accounting for the thread cache, and surfaces the data in about:tracing when the thread cache is used for the FastMalloc() partition. The recorded data shows that for FastMalloc(), the current settings catch the vast majority of allocations, at a small memory cost, and that most allocations are on the main threads, as expected for FastMalloc(). Bug: 998048 Change-Id: Iaa55deb12f0c04dd7f301e15c7497b817f4843e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424309 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809774}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ie9ae99bb4a06167a424fd9bd79d26d30e6531b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422139 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809773}
-
Maksim Moskvitin authored
There might be no events triggerring lazy initialization of StandaloneTrustedVaultBackend while device registration needs to be completed. This CL removes lazy initialization logic and backend is now always initialized in client ctor. Bug: 1102340 Change-Id: I83a4e4d79bd7dc0f076d9795a814b514e143f99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424305 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809772}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6db3a24c19e7..75e5ed6161fc 2020-09-23 shaobo.yan@intel.com Support Noop Copy for B2T, T2B and T2T Copies 2020-09-23 cwallez@chromium.org Fix deprecation errors for indexFormat being set. 2020-09-23 cwallez@chromium.org Fix compilation on ChromeOS 2020-09-22 enga@chromium.org Pass the old/new VkImageLayouts to Vulkan image import/export 2020-09-22 brandon1.jones@intel.com Change wgpu::Color from floats to doubles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1c3b392c89abcb0e87dca1993cfc880db3a10223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809771}
-
Harald Alvestrand authored
In certain cases involving stopped transceivers, a sender or receiver can be created with an already closed DTLSTransport, which will cause the state to be set to "closed" even when it is already closed. Allow this case. Bug: webrtc:11840 Change-Id: I21aad316f5cf74a6b4bf18ac87fcf460afc74531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424260Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#809770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aad83522fd17..80f8eba22fbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tschumann@google.com Change-Id: Ia07a96abff2785413e513577c6af5ca888387f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425897Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809769}
-
Brian Ho authored
Currently, enabling SkiaRenderer on Chrome OS causes the entire screen to flicker due to partial enablement of HW overlays [1]. To remedy these synchronization issues, we need to schedule the primary plane overlay with a valid fence. On Android, this is accomplished via platform-specific code that extracts a fence from a GLImage [2][3]. In this CL, we take a more robust approach by creating the fence on OverlayRepresentation read. The OutputPresenter can subsequently use this fence if it exists/ the SharedImage type supports it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2342262 [2] https://source.chromium.org/chromium/chromium/src/+/master:gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc;l=75;drc=23f61cb65a94208dc2c4728e895e87d47f64a8b6 [3] https://source.chromium.org/chromium/chromium/src/+/master:ui/gl/gl_surface_egl_surface_control.cc;l=323;drc=5c860faff8acca32094b87f229b630519326372e Bug: 1114290 Test: CrOS with SkiaRenderer doesn't flicker Change-Id: Ie429ef6dab66fce18d6b3f37133c4bb9ecf602cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404148Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#809768}
-
Mariam Ali authored
This CL capitalizes the letters for Guest and Incognito in the chip menu to follow the guide in go/chromewords. Screenshot: https://screenshot.googleplex.com/AcFJbt6g6skM2oY.png Bug: 1105763 Change-Id: I208f3b9f7ab9150b33d84d60b76342b1199a830c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421667 Commit-Queue: Mariam Ali <alimariam@google.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#809767}
-
Avi Drissman authored
This shouldn't be necessary; when the last frame is deleted the observer should remove itself. However, for paranoia's sake, remove the observers as sessions are closed. Bug: 1123557 Change-Id: If0109eafee7fd2ba38480849b99ee42bbafe5b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424711 Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809766}
-
Christoph Schwering authored
The feature is not referenced in the code. Bug: 1007974 Change-Id: I21b990a88044af91bfb4da4abb47c26280ce01bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409942 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#809765}
-
Peter Boström authored
As BubbleDialogModelHost::Close() tear-down (removal of model_) is synchronous, but views isn't. We need to check and see if the model_ has been destroyed when checking for the initially-focused view. A TODO is left to see if we can prevent GetInitiallyFocusedView() from being called after Widget::Close() has been called. Bug: 1106422, 1130181 Change-Id: I8056c3dd242e9ec5ce8fc909a0f558dc7a264dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425363Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809764}
-
David Jean authored
Removed orientation [uikit_]ui_util fncts that relied on [[UIApplication] sharedApp].keyWindow. Change-Id: I2936c5c1afd2c682fa967db896ba3b5161144be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424085 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809763}
-
Christoph Schwering authored
The feature is not referenced in the code. Bug: 1007974 Change-Id: Iadd81ab6d92f9b459ab9249d1d8cbbfec4327f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409699 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4f973a50bbbc..d937502d15b9 2020-09-23 treehugger-gerrit@google.com Merge "Update clang to llvmorg-12-init-5035-gd0abc757-3" 2020-09-23 hjd@google.com Merge "Remove Dropbox code from android_internal" 2020-09-23 taylori@google.com Merge "perfetto-ui: Only intialize GA on prod or staging" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I185979c36c3b6ab390135f9b848f872b790fdecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425893Reviewed-by:
-
Peter Boström authored
BubbleDialogDelegateView::Close() removes all its children. GridLayout wasn't built for dynamically removing children, so its ColumnSets holds on to stale pointers to Views previously in the hierarchy. This causes problems when asynchronous calls are made to get the bubble's preferred size before Widget::Close() asynchronously finishes. This is solved by removing the GridLayout as layout manager before the children are removed. Future updates to GridLayout would preferably accommodate removal of children. Bug: 1106422, 1130111 Change-Id: I2181856ae9669fbce9e6f3dfa347c468c7c5d567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425141 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/6af91b3510..d3614de617 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/6af91b3510..d3614de617 Bug: None Change-Id: Idc78d32cf450e70082cb827fea2bdcfdae2a41ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424287Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#809759}
-
Jose Dapena Paz authored
Fix this error: ../../printing/page_range.h:20:3: error: ‘uint32_t’ does not name a type Introduced in this commit: https://chromium-review.googlesource.com/c/chromium/src/+/2351580 Bug: 951519 Change-Id: I0c86cfc5dc711b062021dd8661d27d6442e7d47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423909 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809758}
-
Luke Zielinski authored
This requires adding a PRESUBMIT.py to /testing/scripts to run the unit tests. Includes some small updates to wpt_common, mainly: - ensuring crashlot artifact path is added to output json - replacing os.path.exists with FileSystem.exists Bug: 1131478 Change-Id: Ia470f57b43709d20825d7f91017647b85d71ad48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422346 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Caitlin Fischer authored
This implements the new GOOGLE_WEB_PROPERTIES_FIRST_PARTY and GOOGLE_WEB_PROPERTIES_TRIGGER_FIRST_PARTY variations types, which allow us to limit the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Adding support for this involved sending a map of headers rather than a single header to the renderer. A map is used because the request context is unknown until the process of sending the request has started. So, the renderer needs to know the appropriate headers to send in first- and third-party contexts. Bug: 1094303 Change-Id: I447219b1cc80b0dc8552b440e6ad07b2fdb15d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411489Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#809756}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when |Navigator.javaEnabled| is called. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I5d6c24996680d9776a34300ed765a614a9518fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423585Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#809755}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: Id621eb8c0c4cd388c09f30cf7ea4937fc566eadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424511Reviewed-by:
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Change-Id: I25fddca92048669e25674070b0f619368270346c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424073Reviewed-by:
-
Sigurd Schneider authored
This allows to expose certain methods only on the impl, not on the public interface. Bug: chromium:1069378 Change-Id: I3623aadb5f9d9ebb7f2dae4c78cb830ee74f55b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426043Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#809752}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/edd7f9e94d43..aac41bd6780a 2020-09-23 sprang@webrtc.org Removes dead fallback code from rtcp::CompoundPacket. 2020-09-23 titovartem@google.com Introduce debug network stats 2020-09-23 kron@webrtc.org Add field trial to force outgoing video playout delay 2020-09-23 alessiob@webrtc.org AGC2 saturation protector: simplify interface and impl 2020-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f294a94c..590f451b (808500:809630) 2020-09-22 hta@webrtc.org Revert "Remove stopped transceivers at both local and remote SetDescription" 2020-09-22 alessiob@webrtc.org AGC2 Saturation Protector: switch to ring buffer 2020-09-22 ilnik@webrtc.org Make VP9 correctly accept middle-layer singlecast 2020-09-22 sprang@webrtc.org Reland: Wires up WebrtcKeyValueBasedConfig in media engines. 2020-09-22 kwiberg@webrtc.org RTC_LOG: Fix bug introduced in a recent CL 2020-09-22 handellm@webrtc.org common_video/h264: Make ssilkin@webrtc.org owner. 2020-09-22 chunbo.hua@intel.com Strip AUD NALUs from H.264 bitstream 2020-09-22 nisse@webrtc.org Delete video source proxying in WebRtcVideoSendStream 2020-09-22 hta@webrtc.org Remove stopped transceivers at both local and remote SetDescription 2020-09-22 kwiberg@webrtc.org RTC_LOG: Internally, pass logging severity as template argument 2020-09-22 kwiberg@webrtc.org RTC_LOG: Remove unnecessary optimization 2020-09-22 kwiberg@webrtc.org RTC_LOG: Mark a trivial function with `constexpr` 2020-09-22 asapersson@webrtc.org Make LibvpxVp8Encoder::GetCpuSpeed() to always read from CpuSpeedExperiment for arm. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia2e5e6d7813b3c7c2c629b531fd9418e28fba9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425896Reviewed-by:
-
Christian Dullweber authored
Show amount of used storage in cookies page in PageInfo. Fix cookie deletion by using a populated website object. Screenshot: https://crbug.com/1077766#c46 Bug: 1077766 Change-Id: Ifce703ba4af9bdd14da8403516871b7c8001eb02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416371 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809750}
-
Monica Basta authored
This CL adds a cr-customize-themes element to chrome://settings/manageProfile page behind a feature flag. This CL focuses on the native side and it doesn't include necessary style changes which will be included in future CLs. When the UI is ready, this element will be put under the "NewProfilePicker" feature. In order to use a cr-customize-themes component in WebUI, a WebUIController class must enable mojo bindings and implement customize_themes::mojom::CustomizeThemesHandlerFactory interface. This CL applies these necessary changes to SettingsUI. Screenshot with the feature flag enabled: https://drive.google.com/file/d/1W1NITMHGbzHRzq1LeClp96Mh98B2MNGv/view?usp=sharing Bug: 1129186 Change-Id: I18ead20f57e3bb0486e4821a946ea4e0aff3a242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414301 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809749}
-
Maksim Sisov authored
We got some reports that include log where we could see that chrome used a format which doesn't support scanout. However, it's unclear what exactly happens. Thus, this patch adds additional information that will include the buffer format the chrome tries to use. Bug: 1128997 Change-Id: I09774bd506d624d4db05acc92c6a20884b664e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424198 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
David Grogan authored
Without a specified height, the rects should have received a 0 height. It appears these tests passed in Chrome because of a Blink SVG bug that gave the rects a height. These tests didn't pass in Firefox. See https://bugzilla.mozilla.org/show_bug.cgi?id=1666643 Change-Id: I13053947e343572426f4e584d68bc52191482f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425723 Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809747}
-
Nohemi Fernandez authored
Bug: 1131027 Change-Id: I02a1824f34d25c29d4a67f66b362514d63963236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424163 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#809746}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600840405-46e4cd70bd3de973a171c7f611770f78487d203a.profdata to chrome-linux-master-1600861496-aa5ced2b846bf1462377e76f5270436b4108dec5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ie6b83afd0777afc19e1f57e4118a85e8ca42c987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426283Reviewed-by:
-
Egor Pasko authored
This reverts commit f889004d. Reason for revert: http://crbug.com/1130358#c13 Original change's description: > Reland: PR_SET_DUMPABLE 1 briefly if opening pagemap fails > > This is often necessary on Android to read /proc/self/pagemap. Without > prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on > Canary. This potentially leads to bias in reporting > MappedAndResidentMemoryFootprint2. > > What happened since it last landed as http://crrev.com/808298: > * Setting the process back to non-dumpable was often returning an error > and hitting a (P)CHECK > * In crash dumps logcat started right at the failure, so it is not > possible to see whether prctl(PR_SET_DUMPABLE, 1) succeeded prior to > the failure, my guess is that it failed too > * In the reland, avoid prctl(SET_DUMPABLE, 0) if prctl(SET_DUMPABLE, 1) > failed before that > > Bug: 1070618 > Change-Id: Ic9bfbdad6c72a1388eb80c3b6c9e6c772c8e431c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421730 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809373} TBR=pasko@chromium.org,ssid@chromium.org,rsesek@chromium.org Change-Id: I3ae4695cca87eb4e878a195f84352fd5f19889d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425053Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809744}
-
Fabio Tirelo authored
The tests for URLBlocklist and URLAllowlist already exist, but they are not enabled on Android. Enabling them to prevent future regressions. Bug: 1131160 Change-Id: I6c4139ee2e3b65d7405a256dbeaf562bdf0854c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424493Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809743}
-
Tim Schumann authored
This reverts commit d1e1c165. Reason for revert: Suspected to break NearbyOnboardingPageTest.All on linux-chromeos-dbg Original change's description: > [Nearby] Add onboarding to receive dialog > > This converts the onboarding and visibility pages to use the > nearby-template-page and hosts them in receive dialog. If the user > attempts to enter high visibility mode and nearby is not enabled, we > force onboarding to be run first. > > Screenshot of onboarding running from settings: > http://screen/xnm86ZduzQ6bGEr.png > > Bug: b:154866951 > Change-Id: I195fa803762635f0a19d58d7d4db919c825b8ffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420770 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809599} TBR=khorimoto@chromium.org,vecore@google.com Change-Id: I7b078ac34fedb3b1d4c96c01623c2f35d23286e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:154866951, 1131390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424094Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#809742}
-
