- 05 Nov, 2018 34 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b21e88ed6dd..0a8b4e1acbd6 git log 2b21e88ed6dd..0a8b4e1acbd6 --date=short --no-merges --format='%ad %ae %s' 2018-11-04 fmalita@chromium.org [skottie] Add support for explicit text line breaks 2018-11-04 reed@google.com remove empty devKern from SkPaint 2018-11-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@0a8b4e1acbd6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I0eb084784270bb0e79100a55f94c424ae9a89cc8 Reviewed-on: https://chromium-review.googlesource.com/c/1317170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605245}
-
Hayato Ito authored
This is a kind of follow-up CL of https://crrev.com/c/1270596. It would be better to fix the root cause, instead of early return in JSBasedEventListener::handleEvent. Accessibility folks might want to look further to decide what we should do if event's target can't be set there. Bug: 892970 Change-Id: Ic2a14242c611133df68cfc3ec6e24cb9d20bf214 Reviewed-on: https://chromium-review.googlesource.com/c/1272937Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605244}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib690418ad7f66fab003f7ddc8ca44e33faa2ae2d Reviewed-on: https://chromium-review.googlesource.com/c/1316599Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605243}
-
Kunihiko Sakamoto authored
This reverts commit ea1a3ea1. Reason for revert: broke fast/canvas/canvas-composite-shadow.html on Win10. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43023 Original change's description: > rebaseline SK_LEGACY_OP_COLOR_AS_BYTES > > This flag was repurposed... the real thing we're rebaselining > is https://skia-review.googlesource.com/c/skia/+/167264, which > affects situations with solid colors and unusual blend modes. > > Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 > Reviewed-on: https://chromium-review.googlesource.com/c/1316754 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605216} TBR=fmalita@chromium.org,mtklein@chromium.org Change-Id: I1592f49dd54abd4da3f9abbd3d85cce40cddc5d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1317071Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605242}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/files fast/filesystem fast/forms fast/frames Most of this patch is mechanical rebaseline, except that: - Some LayoutNG-specific baselines become redundant and are removed - Two LayoutNG-specific baselines are added due to LayoutNG doesn't include \u000C in Element.innerText while legacy does. Bug: 887148 Change-Id: Ie92bfd289ee494930896365f81efb54ebbb02424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1308253Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605241}
-
Kunihiko Sakamoto authored
This reverts commit 14c0b604. Reason for revert: Following tests are timing out - MojoCoreTest.SanityCheck - MojoCoreTest.BasicMultiprocess on MSAN bots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12687 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9416 Original change's description: > [mojo] Add IPC support to core shared library > > Updates the mojo_core shared library so that it is actually suitable > for production IPC use. Namely: > > - MojoInitialize now spins up a background thread for I/O and gives > it to the core impl. > - A flag is added to Initialize(), allowing shared library consumers > to initialize themselves as a broker process. > - The thunks helper correctly loads the mojo_core library with > RTLD_DEEPBIND set, avoiding heap crossover within the core impl > due to e.g. malloc and free lazy-binding to different heaps > - Fixes the thunks header to compile as C once again, as it was > missing some struct keywords. > - Adds MojoShutdown to the core ABI as a necessary call for shared > library consumers who want clean shutdown. > > This also adds a new multiprocess test consuming the shared library > to tie together and validate all of the above changes. > > Bug: 809320 > Change-Id: Ic1c56d99c86fd4a2dc7f812ee152994ced35ece6 > Reviewed-on: https://chromium-review.googlesource.com/c/1306347 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605109} TBR=rockot@google.com,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 809320 Change-Id: I19816cf592bacd58dbb452cd32bea4df7a8077be Reviewed-on: https://chromium-review.googlesource.com/c/1317297Reviewed-by:
-
S. Ganesh authored
Bug: 833687 Change-Id: I60ca6e5ef75a8dabbf9e15d5a10e2738fa83d303 Reviewed-on: https://chromium-review.googlesource.com/c/1295732 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#605239}
-
Luciano Pacheco authored
These 2 tests are flaky on MSAN and ASAN, disabling it them until they get fixed. Bug: 899664 Change-Id: I0ee7b0fd58731f47b03637f21a55f27254ae576b Reviewed-on: https://chromium-review.googlesource.com/c/1317210Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605238}
-
Zhuoyu Qian authored
Move: build/scripts/{ => core/css}/make_css_value_id_mappings.py build/scripts/{ => core/css}/templates/css_value_id_mappings_generated.h.tmpl This CL has no behavior changes. Bug: 732657 Change-Id: Ia914f52ca9b78d802d3994cc88f2731e66a2017e Reviewed-on: https://chromium-review.googlesource.com/c/1314015 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by: -
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I95717738ae95c2cee3caa3ff75e43be068e02bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1314075Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d88f2e88..5d6dd803 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52658fe329b887822e7938e94d9c55fd170d544b Reviewed-on: https://chromium-review.googlesource.com/c/1316710Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605235}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie763396344fb7b76a698636353e8a54c0bab3898 Reviewed-on: https://chromium-review.googlesource.com/c/1317296Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605234}
-
Sergei Datsenko authored
As now we have keepalives being sent from drivefs we don't need such a long timeout to detect stuck service. BUG=chromium:889732 Change-Id: I828c1e59fb889aba223f45d327cf68c4e5eaf37f Reviewed-on: https://chromium-review.googlesource.com/c/1309373Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#605233}
-
Alexey Baskakov authored
We will reuse it in WebAppInstallManager. This is a cut-and-paste CL, no behavior change. Bug: 875698 Change-Id: If126780727852bb0ce53979b027a01b1c00b58bc Reviewed-on: https://chromium-review.googlesource.com/c/1314016Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#605232}
-
Hwanseung Lee authored
Namespace should be lower-cased. DOMWindowTimers Namespace also should be lower-cased, and it is used to [ImplementedAs] to implement WindowTimers. According to Blink IDL extended attributes[1], it doesn't mention class name's rule. so it looks like not violate to use snake_case in any rules. However this CL makes DOMWindowTimers a static-only class because ImplementedAs=dom_window_timers is inconsistent with other ImplementedAs instances. This CL has no behavior changes. [1]https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/bindings/IDLExtendedAttributes.md#ImplementedAs_i_m_s_a Bug: None Change-Id: Ia1d7305ebc28feb0c50d6b406ab381998959038e Reviewed-on: https://chromium-review.googlesource.com/c/1307533 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
-
Kunihiko Sakamoto authored
These failed on build bots probably due to the end of DST. TBR=skym@chromium.org,fgorski@chromium.org,pnoland@chromium.org Bug: 901698 Change-Id: I2b8231a71f483f38b161f012f7c081e35232c9a6 Reviewed-on: https://chromium-review.googlesource.com/c/1317109Reviewed-by:
-
Tsuyoshi Horo authored
This CL moves the location where SignedExchangeRequestHandler is created when NetworkService is disabled from CreateNonNetworkServiceURLLoader() to StartWithoutNetworkService() where ServiceWorkerRequestHandler is created. Bug: 898733 Change-Id: If122c3ae296dca7382417f204754ac3ba8f78206 Reviewed-on: https://chromium-review.googlesource.com/c/1298094 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605229}
-
Kunihiko Sakamoto authored
This reverts commit f7c11345. Reason for revert: suspected of causing sizes failure on linux-rel build bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/9414 Original change's description: > Use new tcmalloc on Linux builds by default. > > This changes the default version of tcmalloc used by Chrome on Linux > from a modified tcmalloc 2.0 to a modified tcmalloc 2.7. > > See discussion at http://shortn/_db7vovHkbm for benchmarks and analysis. > > BUG=724399 > > Change-Id: I75b89fcb0e22c2ca627634a6581c937608f4ce6f > Reviewed-on: https://chromium-review.googlesource.com/c/1278949 > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605104} TBR=scottmg@chromium.org,wfh@chromium.org,gmx@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 724399 Change-Id: I87bb7d8c826207d6cad159efc4c26e8c88707135 No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1316950 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
This CL restores disabled TrayAccessibilityTest browser tests by using SystemTrayTestApi mojo interface. Although now the style of the test is Mash compliant, it still doesn't work with Mash because some a11y features are not yet ported to Mash. TEST=browser_tests BUG=850014 Change-Id: I25bc3ec4b7409eb97632e9b14fc91aedf8fed178 Reviewed-on: https://chromium-review.googlesource.com/c/1309554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#605227}
-
Alexander Nohe authored
Set the index to the first image when there are no images selected. This change will allow the edit text to appear visible when shift selecting all the images in the gallery. Bug: 900619 Change-Id: I673b8ab229e9e665b2852d3e0c9d357dc82a40bc Reviewed-on: https://chromium-review.googlesource.com/c/1309997Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#605226}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL renames it to not "event_names" but "event_interface_names" because "event_names" is ambiguous between event type names and event interface names. This CL has no behavior changes. Bug: 889726 Change-Id: I7bc12ae7cacff0b4a8e36eafe1dbe0d77dd804ca Reviewed-on: https://chromium-review.googlesource.com/c/1314087Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605225}
-
Trent Apted authored
Also add a unit test to seed the base folder for testing. Bug: 879035 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I031545c083f7dab84a1d0605cda16fc02f7367b6 Reviewed-on: https://chromium-review.googlesource.com/c/1306959 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 888276 Change-Id: Ibd3e557ad55ff48daf1e3347ec27ff6fd235a47f Reviewed-on: https://chromium-review.googlesource.com/c/1311837 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
The referenced bug seems to be fixed, and nothing seems to read the flag (anymore.) Change-Id: I9975182364e9344e2dde88cb70211e78b10b69c1 Reviewed-on: https://chromium-review.googlesource.com/c/1314634Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#605222}
-
Sam McNally authored
If a FakeItem is the current entry and a volume is mounted or unmounted, Files app switches to the default display root since the FakeItem doesn't have a VolumeInfo. Omit switching if the current root is not a native entry. Bug: 900870 Change-Id: I943959112135ceb5752207f87e6810a4ec60ae0f Reviewed-on: https://chromium-review.googlesource.com/c/1312148 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Jamie Madill authored
These files were from an obsolete ANGLE integration. Bug: 843346 Tbr: thakis@chromium.org Change-Id: I630cf9c5126c979fa28c768f04cafb80dceb2083 Reviewed-on: https://chromium-review.googlesource.com/c/1316594 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#605220}
-
Trent Apted authored
This is basically a "revert" of r155769, which landed 6 years ago. Problem: The hardware play/pause key currently stops working in the CrOS Audio Player in tablet mode. The event is not dispatched to the web contents. Note an external keyboard or USB headset can send this key event in tablet mode, even though events from a convertible's regular keyboard are suppressed. r155769 introduced logic that causes all accelerators to be processed as though they have the same priority as, e.g., Alt+Tab when the AppList is visible. Now, in tablet mode, the AppList _always_ declares itself visible. So currently no key combinations bound to Ash accelerators are dispatched to webcontents when in tablet mode. This is bad. r155769 was to fix https://crbug.com/142067 - "Ctrl+Space unable to switch keyboard layouts in the AppList". This occurred because an AppList button had focus, not the text field. To retain current behaviour, instead update the two Button subclasses to return false for SkipDefaultKeyEventProcessing(), thereby prioritizing accelerators over their 'space' activation. There are other buttons in the app list, but they do not currently forward space to the search box (See https://crbug.com/901245). These button types disappear or change focus to the search box when searching anyway - only SearchResultBaseView seems to really benefit from being able to handle Ctrl+Space. Bug: 899094 Test: AudioPlayerBrowserTest.NativeMediaKey Change-Id: I1cb585d88d57a775fdfa15ecfdce197ae52dfcdd Reviewed-on: https://chromium-review.googlesource.com/c/1312439 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jeremy Roman authored
ScriptPromise is perfectly happy with a v8::Local<v8::Value>, which is created on the way to ScriptValue anyhow. Change-Id: Ib9e6529bcac0262ffd2ddb89ce4de0cfe5587c81 Reviewed-on: https://chromium-review.googlesource.com/c/1316098Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605218}
-
Maggie Chen authored
This is an optimization to reduce the size of damage rect in surface aggregation. When clipping is on, we should clip the child surface damage rects before adding them to the parent damage rect. BUG=900422 Change-Id: Ia85f1d86bf4ba13ac66167c5de04c657d66d175c Reviewed-on: https://chromium-review.googlesource.com/c/1309318Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605217}
-
Mike Klein authored
This flag was repurposed... the real thing we're rebaselining is https://skia-review.googlesource.com/c/skia/+/167264, which affects situations with solid colors and unusual blend modes. Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 Reviewed-on: https://chromium-review.googlesource.com/c/1316754 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#605216}
-
Ilya Sherman authored
There is no reason to include "slowly" in this method name, as it's not meaningfully slower than any other histogram that might be recorded in Java. (I would expect any JNI calls to dominate the runtime performance.) TBR=jochen@chromium.org Bug: None Change-Id: Id606696351783a5b39fa7908cbc3f3d681188567 Reviewed-on: https://chromium-review.googlesource.com/c/1313672Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605215}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc4f8515bb5a26edbdbdd595c88ef943d701fbd7 Reviewed-on: https://chromium-review.googlesource.com/c/1317172Reviewed-by:
-
Giovanni Ortuño Urquidi authored
For the most part, this CL just moves the controller logic out of BluetoothDetailedView and into UnifiedBluetoothDetailedViewController. But there are three exceptions: 1. Before, Layout() was called at the end of BluetoothDetailedView::DoUpdate(). Now, Layout() is called indirectly in UpdateDeviceScrollList() through, ShowBluetoothDisabledPanel, HideBluetoothDisabledPanel, and BluetoothDetailedView::UpdateDeviceScrollList(). 2. BluetoothDetailedView::UpdateDeviceScrollList() used to perform the following steps: 1. Clear the device list 2. If state is not "powered" show the "bluetooth disabled" panel and return. 3. Otherwise hide the "bluetooth disabled" panel. 4. Update the device list. Now UBDVC::UpdateDeviceScrollList() performs the following steps: 1. If state is not "powered" then call BDV::ShowBluetoothDisabledPanel() and return 1.1. Clear device list 1.2. Show "bluetooth disabled" panel 2. Otherwise call BDV::HideBluetoothDisabledPanel() 2.1. Hide "bluetooth disabled" panel 3. Call BDV::UpdateDeviceScrollList() 3.1. Clear device list 3.2. Populate device list with current devices. Similar set of steps but except that "clear device list" is performed by two separate functions. 3. Discovery stops when UnifiedBluetoothDetailedViewController gets destroyed. Before, discovery was stopped when BluetoothDetailedView was destroyed. Change-Id: I4727bcdf35e0f84ab16ff0bace8f3d89aefc58de Reviewed-on: https://chromium-review.googlesource.com/c/1308241 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605213}
-
Eric Karl authored
To make Viz's GPU proc startup more like non-Viz, and hopefully avoid the increased crash rate when trying to connect, this change delays establishing the connection to the Viz/GPU process until we establish our first GpuChannel. TBRing fsamuel as I want to get this baking in tonight's Canary for potential mergethis tuesday. TBR=fsamuel@chromium.org Bug: 897272 Change-Id: I4234040a58cb5af13594adf2e1d9287b043aac1b Reviewed-on: https://chromium-review.googlesource.com/c/1317031 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605212}
-
- 04 Nov, 2018 6 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55aff748. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I93cc8076f2e377eec1d1bdeeb377a0e97c7a1776 Reviewed-on: https://chromium-review.googlesource.com/c/1317130 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605211}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I68849e37c788f2d4423e95ca8afe0bceb49a5455 Reviewed-on: https://chromium-review.googlesource.com/c/1316697Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e4081554d06..2b21e88ed6dd git log 7e4081554d06..2b21e88ed6dd --date=short --no-merges --format='%ad %ae %s' 2018-11-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@2b21e88ed6dd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I65f58e4a975f397bec02d20219de18aefec9338a Reviewed-on: https://chromium-review.googlesource.com/c/1316695Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682c7b60bfe3..46e156a4422d Created with: gclient setdep -r src-internal@46e156a4422d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia3dc993851fc54046a98355c9a88d0b2c817a5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1316694Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605208}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35240cdb..d88f2e88 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b3704448e20be5bb5815ab6e1be21631ad97e29 Reviewed-on: https://chromium-review.googlesource.com/c/1317128Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff910b52. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I118f911c1cf15e3dac5c9487c53b04d79a9c75a7 Reviewed-on: https://chromium-review.googlesource.com/c/1317127 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
