- 16 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/65fccf7b5f04..b82a1e239de5 2020-09-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-16 saklein@chromium.org portage_testable: mask chromiumos and portage overlays 2020-09-16 saklein@chromium.org dependency service: Cache dependency data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6d0dac6a482730ecd4f5ef8ef8091f1d39d1fbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807573}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f21b6caecea..5d45ebc33fa8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: bcwhite@google.com Change-Id: I2c7e2867fff440add2a6551b2a861c9cdc54392e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414531Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807572}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49c0daeb..69e49314 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7dfd0997decd7b2a5a57357276b2231c1c7997cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414017Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807571}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4dd62a619adf9da025ecefe5a5f2d289454cd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414851Reviewed-by:
-
Alexander Surkov authored
ax_dump_tree tool: add --pid command line argument on Mac/Linux to dump accessible tree by process id Bug: None Change-Id: Ie374dfb692757f1106d81cfbde652ac31e8c9db9 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410121 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807569}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600257341-cdcb93ba007df24b60057506da5b299c67d8a739.profdata to chrome-linux-master-1600273595-fec2fba6dfa6bd9b7e3dd69b0eab2bf1cda7b0a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0a6a669a5b8ce1d9c0326e5e576cc3a618fa5b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414855Reviewed-by:
-
Stephen McGruer authored
This is required for the MVP builders, which will run a subset of the WPT tests for Web Payments and Web Identity. It is also useful for local users of the script, to let them not run the entire WPT test suite. Bug: 1127055 Change-Id: I8142593a2afd9b2bcd94750765a3f626e5484310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412813 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#807567}
-
Alex Newcomer authored
multipaste is the name for the project at ash/clipboard/*. Change-Id: I341fed5b620a7e3262c71c56aa6fe1ca3df4f339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414908 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807566}
-
rajendrant authored
cache-control: no-transform should be respected and LiteVideo should not throttle them. When content-length is missing in the response headers it should throttle with minimal latency. Bug: 1127059 Change-Id: I1a9055c40d7ca1a54c53696e2fec816e54a59f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412703 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#807565}
-
Anastasiia N authored
Bug: 1127861 Change-Id: I26642c3fb4e465ca1adf6dde3eb363fd079476c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409692Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#807564}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fa54364cea0b..78e9acd96726 2020-09-16 kwiberg@webrtc.org UntypedFunction: Add unit tests and fix a few issues 2020-09-16 mbonadei@webrtc.org Clobber iOS builders. 2020-09-16 lndmrk@webrtc.org Explicitly enable CDEF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I94f8871f30421af39b1dba6ebcae6065e579df3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414528Reviewed-by:
-
Domenic Denicola authored
Change-Id: I12ffb1e19491bcd233c74262ee0d9900e848958e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412688Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#807562}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5ee7c40c31b..4f6dfcfe8801 2020-09-16 jegarc@microsoft.com Normalize ShadowSwatchPopover behavior 2020-09-16 jacktfranklin@chromium.org Fix loading images in components server 2020-09-16 andoli@chromium.org Disables flaky e2e test on the Issues tab 2020-09-16 jacktfranklin@chromium.org Migrate heap snapshot multiple retainers layout test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110817,chromium:1126496,chromium:1128534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib42c838d72f264996cfbb6b399266edb0d401dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414609Reviewed-by:
-
Hazem Ashmawy authored
Fixed: 1128749 Test: None Change-Id: Iede90216836e07b0627420f0d2661787e4616e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414291Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#807560}
-
Xiaohan Wang authored
This reverts commit 175e67fe. Reason for revert: Needs to wait for src-internal DEPS roll to be landed. Original change's description: > widevine: Add `ignore_missing_widevine_signing_cert` gn arg > > When Widevine CDM host verification signing failed due to no > signing cert, the build process will fail by default. However, > developers making local builds typically don't have those certs. > This CL introduces `ignore_missing_widevine_signing_cert` gn arg > so the error caused by missing Widevine signing cert could be > ignored. > > By default, `ignore_missing_widevine_signing_cert` is set to false > on official bots (is_official_build=true) to catch real failures. > Developers needing to set `is_official_build` can manually set > this gn arg to be true to suppress the error. > > Bug: 1127616 > Change-Id: I41a43e922399497c75f1f967219d41d1566d90dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412933 > Commit-Queue: John Rummell <jrummell@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807513} TBR=xhwang@chromium.org,mmoss@chromium.org,jrummell@chromium.org Change-Id: I9a67901d83a13881180fcfe63cecb240cc5ebcde No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414652Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807559}
-
Stephen McGruer authored
This is mostly a code cleanup; it seemed weird that if you pass '--help' to the script it would generate the manifest files before showing you the command line! Bug: None Change-Id: I00515216c6883ee38d591993a59bf9d960163b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412695Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#807558}
-
Anne Lim authored
Update integration test to ensure that instrument_id is included when PDM retrieves server cards from GetServerCreditCards. Bug: 1121806 Change-Id: Ifcb45c3ca774f32e5545d25bf8f71d491ef1239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411441 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807557}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/511a82c95fc7..1a6e1152b10b 2020-09-16 sebmarchand@chromium.org Allow forcing a clean shutdown via an environment variable. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1124774 Tbr: oysteine@google.com Change-Id: I4ff301ff11ff3b3ded506811d0266ccffd0a4363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414352Reviewed-by:
-
ckitagawa authored
This CL refactors the PlayerCompositorDelegate to structure it in a way that is more amenable to testing. This CL also adds a significant amount of test coverage for PlayerCompositorDelegate. PlayerCompositorDelegateAndroid is refactored to be compatible with the changes to PlayerCompositorDelegate, but it is not tested as it is relatively well tested from the Java side. This boosts coverage to > 85%. Further coverage is difficult as the edges are a result of difficult to simulate failures. Bug: 1128927 Change-Id: Id7467209ab2858043655ae374e55ac699e4e1778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412893Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#807555}
-
Dave Tapuska authored
Add API to query the FrameSinkId from RenderFrameProxy now blink needs to be able to return that. Add a fake FrameSinkId to FrameTestHelpers to ensure test isn't comparing invalid FrameSinkIds. BUG=1097816 Change-Id: Ia47721071b2a39c6cebe476f514813bf06d7706a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410300Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#807554}
-
Mohamed Amir Yosef authored
This CL queries both the profile and account store for password use, and makes sure the PasswordProtectionService is invoked only after both stores respond. Bug: 1119286 Change-Id: Iedab99826f7822c14da6cbf7c876bd9de8609738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410486 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Harry Cutts authored
Python 3 became the default in January, causing the scripts to error unless explicitly run with Python 2 (which will be removed from test images soon). Bug: none Test: run scripts with Python 2 then 3, and compare the output Change-Id: I6d4aef94cb3de45f710875f04449f756d0592cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414769 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807552}
-
Dale Curtis authored
This reverts commit 1114fa98. Reason for revert: Test is still failing: https://bugs.chromium.org/p/chromium/issues/detail?id=1128773 Original change's description: > Fix a disabled download test > > There are several issues with this download test: > 1. The new download progress info bar will mess up with the duplicate > infobar when trying to find the latter. > 2. Download update may never go through DownloadManagerService in > download's new code paths > 3. Only 1 duplicate infobar will show at a time, so the > AllowMultipleInfoBars test is no longer valid > > This CL fixes the above 3 issues. > > BUG=597230 > > Change-Id: I9cfbfcd51c040dc77bd4f6e0cb0f6bfaf967a912 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411732 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807120} TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org Change-Id: I93f954848b44b9df16bb0534c3a8fe523a754e4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 597230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414770Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807551}
-
Ted Meyer authored
I got my hands on an old AMD laptop, and the gallium driver worked very well and was saving power even at 720p, so there's no reason to block that for now. Bug: 1116703 Change-Id: Ib15bc2b93f33e99adad7569dd825e167b503a0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409967 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807550}
-
Nicolas Ouellet-Payeur authored
Annotations now have an added_in_milestone="XX" field, to indicate when the annotation was first added in Chrome. This will be useful to generate documentation, and easily see what's new in every release. In addition, this CL updates traffic_annotation_auditor to enforce that every annotation has the added_in_milestone field. Version information extracted with this script: https://pastebin.com/KTWEMakU Bug: 1107860 Change-Id: I5cd349c938f5ee60e2227cf540da10ac3f2547a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404146 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#807549}
-
Kuo-Hsin Yang authored
This interface exports the function provided by the chromeos memory pressure module in //chromeos/memory/pressure/. This interface will be used by chrome, CrOS VM and ARCVM to query system memory pressure status. The clients of this interface shall try to release memory when the memory pressure is high. BUG=b:149833548 Test: dbus-send --system --type=method_call --print-reply \ --dest=org.chromium.MemoryPressure /org/chromium/MemoryPressure \ org.chromium.MemoryPressure.GetAvailableMemoryKB Change-Id: I795b688433ef8c5ab58a7d2099f369655f7b41c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409423Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807548}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I059cda5bed6712f503f3b9c41108ff365d4eb797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414296 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#807547}
-
ckitagawa authored
This CL adds a variant of StartSurfaceTest where no tabs are present. In this situation the UI for tabs shouldn't be shown, but the remainder of the UI should remain unchanged. This automates a P1 manual testcase. Bug: 1091317 Change-Id: Ibbd08b668228c347e6d4c2e129ab2284fefe8a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391614Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#807546}
-
Dirk Pranke authored
This CL changes //tools/mb/mb.py so that when you run the `run --swarmed` subcommand, it passes the command line and relative cwd directly as part of the swarming task rather than relying on swarming to read it out of the isolate. Bug: 1119643 Change-Id: I1b0a7785d08886b86e267d186a93e7027a6cefe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413177Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#807545}
-
Leonard Grey authored
Bug: 1014639 Change-Id: I2168155284dd77296a6e26410e0d242092de8b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410525 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807544}
-
Owen Min authored
Three example cls for blocklist/allowlist renaming are broken due to a missing '/c/'. Change-Id: Ia586dc337a92c4e22f353304ba6b99098791ee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414829 Auto-Submit: Owen Min <zmin@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807543}
-
Dana Fried authored
Avoids a case that reliably reproduces the attached bug, but does not completely fix the bug. (Also makes sense since other touches outside tabstrip close the tabstrip, so this is consistent with existing/designed behavior.) Bug: 1126230 Change-Id: If39c356594c639c11821ff36b3b3fcd238885186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411399Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#807542}
-
Bo authored
This reverts commit b8079095. Reason for revert: DumpWithoutCrashing no longer needed Original change's description: > Add a DumpWithoutCrashing to RPHI::ProcessDied > > After some discussion of a bug in webview that detects "abnormal" > renderer process terminations, this failing DCHECK may be the cause. So > add a DumpWithoutCrashing and see if it gets and if so, what the stack > is. > > Bug: 1115216 > Change-Id: Iaa969d2c6cd7e25237be3ee0ae52fcd5aececfd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359555 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798764} Bug: 1115216 Change-Id: I0aa82cfc5708f5b31bfc850f2b4cdc45e3553429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412938Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Alex Turner authored
Currently, many subresource_filter/ web_tests rely on the behavior that Frames are tagged as ads immediately when they are created if ad script is on the stack. This flow requires that first the script's URL is set as disallowed, then the script is loaded and then the frame can be created. This new call allows for web tests to more simply create ad frames by setting their ad status directly. We adapt existing web_tests to use this new functionality. We remove the ad script creation and onload setting boilerplate that is no longer necessary, also converting affected promise_tests to async_tests to further simplify them. These changes will additionally allow for an upcoming refactor that defers ad status calculation until the frame has navigated to access additional information. As this logic is in the subresource_filter/ component, it cannot be used in web-tests. Bug: 1119476 Change-Id: Id2fc2faa392f06c3b1845981f06f19a0650461d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364956 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#807540}
-
Robert Ogden authored
We'll experiment with the delay to find something ideal. Bug: 730587 Change-Id: Ib583939abfbf641f43ce15103ce20e75a9fae4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412551Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#807539}
-
Stephen Chenney authored
When classifying images for dark mode the src rect can be smaller than 1x1 (the src is a floating point rect). Rather than rounding down, giving divide by 0, we should round up. The downstream code was reviewed to look for cases where this might break and none were identified. Bug: 1119761 Change-Id: I4b8eea35ff33274a0f30e68f1487677ea4f19c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413040 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#807538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2610e8261e9e..1592361414e0 2020-09-16 herb@google.com add special type for SkGlyphIndex If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I6eb8e37c3e73ee4db5f0fe7b45bd040d67f201e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414350Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d1382ae74fac..b14a3f7cf6d0 2020-09-16 treehugger-gerrit@google.com Merge "Fixed mouse hover over slice" 2020-09-16 treehugger-gerrit@google.com Merge "Log unwinding errors in heapprofd e2e test." 2020-09-16 treehugger-gerrit@google.com Merge "probes: update vmstat counters to latest 4.14 and 4.19" 2020-09-16 hjd@google.com Merge "perfetto_cmd: Remove Dropbox upload code" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iec7259997d8b7c252e2c32e69800543767b2c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414470Reviewed-by:
-
Robbie Gibson authored
Accessing the pasteboard on startup seems to cause hangs in the pasteboard machinery often. These hangs are in system code, but we can work around them by not accessing the pasteboard on startup. For the location bar, this is relatively simple because we present the edit menu ourselves. For the omnibox view controller, the edit menu is presented by the system. To know the pasteboard state before the edit menu is presented, we check the state when editing starts on the omnibox text field. Bug: 1121957 Change-Id: Icadb1710b2ea3684fe4250d556a3bd355339a0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414270 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807535}
-
Kyle Horimoto authored
Will be used to create a Bluetooth Classic connection via the Nearby Connections library; required because we will not have access to the full RemoteDeviceRef object when making the request (only the ID will be available). Bug: 1106937 Change-Id: I80ea9f180f95525cd8b679c3ac15eb418b1007c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412839 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807534}
-
