- 05 Oct, 2020 40 commits
-
-
Joe Mason authored
This object will create a memory request for a single renderer process and send it immediately. The renderer will perform the request at the next GC as specified by the measurement mode. This implementation actually sends memory requests to all renderers and ignores responses from the unininteresting ones. A followup will only send the request to the given renderer process. Also updates ExpectBindAndRespondToQuery to test the process ID with gmock matchers instead of DCHECK, so that it can be called multiple times with different process ID's in the same test. R=chrisha, ulan Bug: 1080672 Change-Id: Icba4b66f60bd32b86ea7786441aa84559395b570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430063 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813872}
-
Albert Chaulk authored
Test: loaded webview on device in incognito context Bug: b/167428704 Change-Id: If327a22657fe0e9b989df7cd3bdb8fe8e97a0143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388886Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#813871}
-
Austin Eng authored
This makes previously broken ref tests on Win crash the GPU process instead, though the tests still render to the canvas correctly when run. This same crash already exists on Linux before this patch, but the crash isn't reported by the harness. This is likely a pre-existing issue in Chrome where Dawn SharedImages don't work with the screenshots. In general, canvas readback for WebGPU is currently unimplemented. Bug: 976495, 1083478 Change-Id: I345151bd6ce38fc00e52c1efd12bddb8a425e283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438893 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813870}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04482985b204..9f0c89bd5660 2020-10-05 terelius@webrtc.org Allow RTCP packets longer than 1500 bytes in RTC event log. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134107 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0931871d91b0e306e3f63bd910d2f30c60171f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813869}
-
Hidehiko Abe authored
Currently OS_LINUX is defined in Chrome OS build, but it will be unset. This CL is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I4dd508f10e28438632c98a5b8692d5fbdc04b388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449870Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#813868}
-
Rouslan Solomakhin authored
Before this patch, macOS browser test for loading and removing iframe with many payment requests sometimes timed out because the test created 4096 instances of PaymentRequest. This patch reduces the number of PaymentRequest objects by 75% to 1024. After this patch, macOS browser test for loading and removing iframe with many payment requests should not timeout. Bug: 1129573 Change-Id: Ibca3c55d68285edc85fb712337847951bba71aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443937Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813867}
-
David Bienvenu authored
Change-Id: I18d23eb64d576ea1e9ff443f2de7b9c0c03da81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448664 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#813866}
-
Bo Liu authored
Hopefully getting the stack and some info of of when a !normal_termination and kInvalidSigno happens will be helpful to pin down the cause. Bug: 1115216 Change-Id: I4bda59c1e27782e7688d1594c8af6efba6c1c9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448058Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813865}
-
Tom Anderson authored
base::FileDescriptorWatcher is not usable on the main thread because it is initialized as a UI thread, when an IO thread is required. Since it's a UI thread, it's able to dispatch events already without special FD watching. All that's required is creating an X11EventSource. This CL creates the event source where necessary so that KeyboardLayoutMonitorLinux can dispatch events. R=lambroslambrou CC=rkjnsn@chromium.org Fixes: 1133481 Change-Id: I6e0a380c7c1168c4b1515be10ec34e67d0ae0d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444530 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#813864}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88d84cce..8c063270 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfa04c4a4b77cccab7f25faaf89e2b5957c7c994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449933Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813863}
-
Brandon Wylie authored
Better alignment with the requirements (delete everything when a user deletes history in a time range) could eliminate the crashes seen in the linked bug. Bug: 1133268 Change-Id: I35690a4c70a9447949467731e67f163fa6acbae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439636 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813862}
-
Nick Harper authored
Bug: 1131222 Change-Id: I874d4b99c888c7ebbf7a7830836ee02441962f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446019Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813861}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I50663e97b9957e7dfcf326563810fd92cc9e4ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450853Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1134761 Change-Id: Ie2252ac8e57ef0dd2c71d1de523e2f67c58e9a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446527Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813859}
-
Tarun Bansal authored
Change-Id: Ia5614d5ae288ad82656e6f86271dbeaa7a24359a Bug: 1095566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446516Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813858}
-
Michael Ludwig authored
Bug: 1135225 Change-Id: Idde7cd70c5d2f6595d286f885b8b50a36792b05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450694 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#813857}
-
dpapad authored
The former is deprecated and no longer receives any updates. Bug: 1087970 Change-Id: I15cb6beb49eb55fb7fa7489459d7072ba8e2f66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444486Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#813856}
-
Fabrice de Gans-Riberi authored
Previously, all contexts would share the same port for remote debugging, resulting in the main context failing to open the remote debugging port randomly. With this change, only the main context uses the default port. All other contexts use an ephemeral port. Bug: 1076982 Change-Id: I6fa2fee65c10277c5e5e705d051e13f7db62057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443531 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1407cfd9e5f4..422c039e8e1b 2020-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I06f352594ed23da6e2975116dace28140edad321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449908 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Anthony Polito authored
This is a reland of 7fc5d2f9 Original change's description: > Make expand_owners use dirmd/metadata if available > > Fix tests that were pre-broken > > Bug: 1102997 > Change-Id: Ice303cf2ab3f382ad6e0345b355aaa3e214d209a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388950 > Commit-Queue: Anthony Polito <apolito@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808432} Bug: 1102997 Change-Id: Ic9b58e2e279e8495d3bff7cfef68e569f5cab881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450734Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Cr-Commit-Position: refs/heads/master@{#813853}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00a8b5bb4fcb..e61500059aa7 2020-10-05 johnstiles@google.com Use SkBitSet for the work list, instead of a set<int>. 2020-10-05 johnstiles@google.com Minor improvements to SymbolTable::addWithoutOwnership. 2020-10-05 robertphillips@google.com Pull blur mask key creation into its own subroutine 2020-10-05 bsalomon@google.com In GrVkRenderTarget reset sk_sp instead of unref'ing underlying object 2020-10-05 jvanverth@google.com Revert "Remove use of legacy display globals." 2020-10-05 bungeman@google.com Remove use of legacy display globals. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I245752d504dbf05ec72a96bb97f0f23b8593c63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450518Reviewed-by:
-
Weilun Shi authored
This was accidentally commented in the split xml's cl because we don't want to extract OWNERS while splitting them. Change-Id: Ibe3a566d46a64c1a41ae5eb9c7a1eddcd008ca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450733 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#813851}
-
Josh Simmons authored
This reverts commit 568372e8. Reason for revert: While these now skip the Marshmallow bot due to lack of network, it appears that these still fail on android-pie-x86-rel which apparently does have network access. Will investigate further but rolling this back for now. Original change's description: > Add network restriction for translate tests so we can reenable them. > > These tests were failing on networkless phones in lab. We should probably figure out how to mock out the translate service for these, but for now this is a step in the right direction. > > Bug: 1130712 > Bug: 1127786 > > Change-Id: Ifd7cb1176ae9beb89c1f44268af9c0add9f29a99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446894 > Commit-Queue: Josh Simmons <jds@google.com> > Reviewed-by: Scott Little <sclittle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813456} TBR=sclittle@chromium.org,jds@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1130712 Bug: 1127786 Change-Id: Ib2809b0bcf973c841bd1cbb661a5fcd44a71500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450729Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#813850}
-
Elly Fong-Jones authored
It is obsoleted by the ability to set the initially focused view on WidgetDelegate. Bug: 1075649 Change-Id: I668de102313c3923b3e385b85aa640718e4a1d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450949Reviewed-by:
-
Dylan Cutler authored
We are interested in seeing if using this method to see which rendering context types a particular client supports leaks identifying information about users that persists across different origins. The previous instrumentation just recorded what types of rendering contexts sites are using, but did not record whether those contexts were supported. This information can be recovered from the new instrumentation in the IdentifiableSurface type I created for this CL. Bug: 973801 Change-Id: I353e8d65af50a4a8e994dfa7f603d5823b88f019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442138 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#813848}
-
Sorin Jianu authored
This is a white space change. Change-Id: Ic58d54926987e7e311f12868863b4520dc69ef23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449993 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#813847}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/25493aef9427..dee4a03873a1 2020-10-05 noreply@google.com Initial import of Cast Core protocol message definitions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ifd002fe50349dceff95d4643764f5916df7581cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450517Reviewed-by:
-
Reid Kleckner authored
1. Have //tools/valgrind/OWNERS delegate to //tools/memory/OWNERS. We don't really used valgrind on Chromium anymore anyway. Sanitizer stuff lives in //tools/memory these days. 2. Add Vitaly Buka to OWNERS. He has committed to Chromium more recently than glider@ (May 2020 vs. 2018). 3. Remove bruening@. Derek has moved on to other projects, and Derek has not committed to Chromium since 2016. R=thestig@chromium.org Change-Id: I60caee6ab7163b05a50b50938c4bb2ba349a1452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450271Reviewed-by:
-
Scott Violet authored
Specifically in NewTabDelegate. BUG=1134224 TEST=covered by tests Change-Id: Icb3dcd49b70e27fc363b9a4a325daa51280f1f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446716Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813844}
-
Andre Le authored
- Added a timer to the controller when the button is pressed. If after a long time and the current state is different from the requested state, it means something when wrong and we should switch back to the original state. - Remove the connecting state in the controller. BUG=1106937,1126208 Change-Id: I4f20894e863b4285c9043702f099d6908d558857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441256 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813843}
-
Ali Juma authored
This re-enables tests that were broken in iOS 13.4 because of webkit.org/b/211449 and fixed in iOS 14. Bug: 1076598,1076233 Change-Id: I57590c7f1dde81d1104ec4f30f2681a1fa9b6304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446024Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#813842}
-
Jesse McKenna authored
This change replaces the reference to the deprecated "isTestCommand" setting in keybindings.json5 with its replacement, "group": "test". This makes keybindings.json5 match tasks.json5, which uses the new syntax. This also fixes a small typo. Change-Id: Ie5a6cdb22610f27222105ff079e47dddd7160378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432138Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813841}
-
Matt Jones authored
This patch moves the ownership of the top toolbar's overlay to the top toolbar's coordinator. This way, the toolbar has complete control over the visual elements that constitute it. Bug: 1100332 Change-Id: I27e69fd4dc50d24d3ff667b8b833ef9e6d449690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359737 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#813840}
-
Dana Fried authored
Creates a mode that allows scrolling without a scrollbar in either direction as well as the ability to treat scroll-specific events (e.g. mousewheel events) as horizontal scroll inputs. Changes: * Adds a third scrollbar state: visible but not enabled * Allows enabled/disabled/invisible state for vertical scrollbar as well as horizontal (previously only horizontal scrollbar could be hidden/ disabled). * Adds the option to treat vertical scroll events as horizontal, so that for example a mousewheel or vertical scroll gesture can allow a horizontal-scroll-only pane to scroll. Bug: 1122214 Change-Id: I7f01b26b33ede76e1903ee37a493a2818b7b1103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433254 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813839}
-
Leonard Grey authored
This change fleshes out the model sent to the WebUI layer by CommanderHandler. It also switches inline strings for constants and sends a new WebUI message to reinitialize state on show. Bug: 1014639 Change-Id: I2e2fb7b4403cc201272feb01c53901243b8fe377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446774Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#813838}
-
Natalie Chouinard authored
This reverts commit 5a4717f4. Reason for revert: Compile failures on downstream build https://crrev.com/i/3309264 not yet rolled. Original change's description: > Rename font-related Chrome resources part 3/3 > > BUG=1129255 > TBR=twellington > > Change-Id: I7acff50f82c1a0bc0b7a2d55e09cd307b447f033 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446540 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813828} TBR=yfriedman@chromium.org,pkotwicz@chromium.org Change-Id: I90d3fc2d8fb97047ca0edc3b1d955fcdfafecbd9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450919Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813837}
-
James Vecore authored
The fast advertising uuid was not being passed through to StartDiscovery in the NearbyConnections layer. Fixed: 1134779 Change-Id: I94e16540a41d635834cd74febd4eb2b4ffb309c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448110Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#813836}
-
Henrique Nakashima authored
This breaks about 2.7% of package dependencies cycles and makes it clear modules can use ChromeVersionInfo. Bug: 1131982 Change-Id: If1fed6174cd08bd2f20371d1de99c43011fd947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429231Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#813835}
-
Eugene But authored
This CL adds the following key-values: - OSVersion (string) - in-background (bool) - session restoration (bool) Bug: 1103752 Change-Id: Ib9217d451bc4684a819e9f07fa968cf42792e586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444389Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#813834}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/378347c17f31..83c2cb106077 2020-10-05 jleconte@google.com Reland "Fix pop up statement when triaging with an existing bug." 2020-10-05 nuwanda@google.com Add ListFiles function to cloud storage 2020-10-05 jleconte@google.com Revert "Fix pop up statement when triaging with an existing bug." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128919,chromium:1134978 Tbr: oysteine@google.com Change-Id: Ic64a99c6861648c3507e9f149eeb784e90ddee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450569Reviewed-by:
-
