Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Jul, 2017 33 commits
  3. 30 Jul, 2017 7 commits
    • Koji Ishii's avatar
      Fix :first-letter pseudo element to inherit correctly · 48bdfcea
      Koji Ishii authored 
      The :first-letter pseudo element may not be a child of the element in
style/box tree.

For example:
  <div><span>text</span></div>
creates:
  <div>
    <span>
      <div:first-letter>t</div:first-letter>
      ext
    </span>
  </div>

FirstLetterPseudoElement computes this correctly on creation, but
inherited from <div> on RecalcStyle(). This patch fixes the inheritance
on RecalcStyle() too.

Inline layout code assumes that a text box has the same style as its
parent inline box. The incorrect style on FirstLetterPseudoElement
breaks this assumption.

Bug: 450002, 507757, 739800
Change-Id: Icda675f5ffbb705c4b87f9d23cca34f24c4763ee
Reviewed-on: https://chromium-review.googlesource.com/593067Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490692}
      48bdfcea
    • Bugs Nash's avatar
      Added null safety to CSSParserContext args in CSSProperty utils files · 26f38f3f
      Bugs Nash authored 
      This patch
- Changed CSSParserContext argument from * to & for null safety and
  readability in the remaining utils files in core/css/properties
- Changed the CSSPropertyParserHelpers::ConsumeCommaSeparatedList
  parameter pack argument to a universal reference with perfect
  forwarding so that reference arguments can be passed through it.

Bug: 668012
Change-Id: I5e607c9a1f8e26d7848092468d666f9879711941
Reviewed-on: https://chromium-review.googlesource.com/590910Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Reviewed-by: default avatarRenée Wright <rjwright@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490691}
      26f38f3f
    • Robert Hogan's avatar
      Re-enable test bug41262-3.html · b1758611
      Robert Hogan authored 
      Bug: 714862
Change-Id: Ic584853df872456a788b3ef45a06d8c346f50516
Reviewed-on: https://chromium-review.googlesource.com/593307Reviewed-by: default avatarRobert Hogan <robhogan@gmail.com>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490690}
      b1758611
    • Zijie He's avatar
      Reland "Implement EvaluateCapability and its tests" · 9bb4149f
      Zijie He authored 
      This is a reland of 62d23080
Original change's description:
> Implement EvaluateCapability and its tests
>
> This change adds --type=evaluate_capability command line parameter to execute
> host binary in "evaluate capability" mode. Meanwhile a helper function
> int EvaluateCapabilityForkedly() has been added to execute the host binary to
> evaluate certain functionality, and retrieves its output.
>
> Return value is too simple for the evaluation, e.g. for DirectX capturer, both
> initialization result and DirectX version are required. To make it simple, in a
> coming change, we can directly output the host attributes regarding to the
> DirectX capturer into console, so the network process needs not to execute any
> DirectX related logic.
>
> Bug: 741926
> Change-Id: Ief06bed7b9297318bd387106108eccd02180e066
> Reviewed-on: https://chromium-review.googlesource.com/575730
> Commit-Queue: Zijie He <zijiehe@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490121}

Bug: 741926
Change-Id: I9b882afbc415613ecc3308e7e1b95806d0ae8051
TBR: joedow@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/592009
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: default avatarZijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490689}
      9bb4149f
    • Kenneth Russell's avatar
      Add workaround for intermittent compositor context losses. · 6290b07d
      Kenneth Russell authored 
      On current Android versions there is a race condition while sending
the application to the background. The browser attempts to drain its
graphics pipeline and cease rendering, but in the meantime one call to
eglSwapBuffers fails. This causes the compositor's context to be lost,
and since this is treated as a severe failure, it causes all active
WebGL content to be blocked.

To work around this problem but maintain strictness on other
platforms, add a time-expiring driver bug workaround that applies to
the current and next Android release.

BUG=744678

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4eb1344f17b6b12cabf8964856e0645473797a8e
Reviewed-on: https://chromium-review.googlesource.com/584037Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490688}
      6290b07d
    • Jialiu Lin's avatar
      Add functions to support password protection warning UIs. · 6cdf8ec1
      Jialiu Lin authored 
      Add function to handle warning on shown events, and warning
completed events. These event handling covers UMA recording,
updating security state, update cached verdicts, and etc. 

Bug: 741138
Change-Id: I5945a7d28244672e52bd00be67e17165b680a122
Reviewed-on: https://chromium-review.googlesource.com/585780
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarLuke Z <lpz@chromium.org>
Reviewed-by: default avatarMustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490687}
      6cdf8ec1
    • Alexis Hetu's avatar
      Using SwiftShader for Layout Tests on Windows · fc83d355
      Alexis Hetu authored 
      Turing on SwiftShader for Layout Tests on Windows.
Added expectations for tests which will require rebaselining.

Bug: 726075
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ida42b4f47061436d512230059f0ffd9240658b80
Reviewed-on: https://chromium-review.googlesource.com/514443
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490686}
      fc83d355