- 23 Aug, 2018 40 commits
-
-
Clark DuVall authored
This is a reland of e00fddec Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan. Verified this works with msan build. Original change's description: > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > This is a reland of a9ed46b7 > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > was flaky in the original change. Added logic in the test to wait for the > connection type change. > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > Original change's description: > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > A getter is used for NetworkConnectionTracker because some services that > > use ResourceRequestAllowedNotifier are initialized early in browser > > startup (e.g. VariationsService), and only perform the initialization > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > allows us to run get the connection tracker at that point so we don't get > > DCHECKs about being on the UI thread when running > > content::GetNetworkConnectionTracker(). > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > ApplicationContext, which is available everywhere. It also matches non-IOS > > usage more closely, since we have it as a global there. > > > > Bug: 868021 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584849} > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > Bug: 868021 > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1185602 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585387} TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org Bug: 868021, 876861 Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1187081 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585565}
-
Jordy Greenblatt authored
As MultiDevice is consolidating its release blockers, I want to clean out my todo list to make it as easy as possible to line up and burn down bugs. For context, multidevice_subpage.js: khorimoto multidevice_subpage is now taking care of building the 'forget device' dialog multidevice_setup_dialog.cc: I already added the strings Change-Id: Ic8aa834f247df5064240dbc6f2b910acd2cb10b3 Reviewed-on: https://chromium-review.googlesource.com/1186030Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#585564}
-
Lei Zhang authored
Change-Id: Ie1299b65bfb6a6b05e91cd2f8fed55f73f208734 Reviewed-on: https://chromium-review.googlesource.com/1186269Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585563}
-
Adithya Srinivasan authored
This CL has a few changes that should simplify onion souping webfilesystem_impl and webfilewriter_impl: - Adds sync versions of Write, Truncate and ReadDirectory in the FileSystemManager interface and makes all the other methods sync - Makes each WebFileSystemImpl and WebFileWriterImpl own a unique dispatcher object (allowing it to call dispatcher methods on worker threads without worrying about thread safety). They directly call the sync methods of the mojo service in order to block the worker thread (instead of using WaitableEvent and posting tasks on the main thread). - PepperFileSystemHost now directly connects to the FileSystemManager service instead of using FileSystemDispatcher. Bug: 787281 Change-Id: Ib497c0a6700c52a7abf4661f2f6a959c11b63519 Reviewed-on: https://chromium-review.googlesource.com/1175149 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#585562}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9db44ed0ef7f..4c6514490e96 git log 9db44ed0ef7f..4c6514490e96 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 reed@google.com fix dashimpl underflow 2018-08-23 mtklein@google.com fix clamp_0/clamp_1 stages in lowp 2018-08-23 fmalita@chromium.org [skottie] Improved text rendering 2018-08-23 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9259fd0d4f4c..c40974417610 (1 commits) 2018-08-23 robertphillips@google.com Add GPU-side caching of mask-filtered path masks (take 2) 2018-08-23 bsalomon@google.com Try again to fix leak of SkSL parser map when built standalone 2018-08-23 robertphillips@google.com Add 0-blur-sigma check to directFilterMaskGPU Created with: gclient setdep -r src/third_party/skia@4c6514490e96 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:875494 TBR=fmalita@chromium.org Change-Id: I14937f931974c643045181bd29f7ab477fc4fc00 Reviewed-on: https://chromium-review.googlesource.com/1187202Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585561}
-
chrome://discardsScott Haseley authored
In the Lifecycle State column, we were showing internal TabLifecycleUnitStates rather than Page Lifecycle states. As a result, we were showing "active" for the active, hidden, and passive page lifecycle states. As chrome://discards will be used by external developers, we should show Page Lifecycles States from the spec (https://github.com/WICG/page-lifecycle). This CL plumbs focus to the discards UI and uses the 3-tuple of (internal_tab_state, visibility, focus) to compute the page lifecycle state. Internal states are still shown in parentheses to aid in TabManager debugging, e.g. "hidden (pending frozen)". Bug: 856321 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb6f0a098cc165c0b7544b3f27a7317f8c78caa1 Reviewed-on: https://chromium-review.googlesource.com/1114282 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#585560}
-
Dominik Röttsches authored
Preparation for matching src: local() descriptors in @font-face declarations from Blink. Unit test added which tests matching against the set of test fonts we are using on Linux. Bug: 859898 Change-Id: I4b28e2ef01edbc01e5a30c24480ef893bd32c9b2 Reviewed-on: https://chromium-review.googlesource.com/1124697Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#585559}
-
Gabriel Marin authored
Original CL: https://chromiumcodereview.appspot.com/11857007 TCMalloc: restrict maximum size of memory allocations For security purposes, we restrict the maximum size of memory allocations under what can be indexed by an int. BUG=169327 NOTRY=true BUG=724399,b:70905156 Change-Id: I530659b9d0f519db1bc70f8d8f5b15537dc1f1b8 Reviewed-on: https://chromium-review.googlesource.com/1184336 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I033579043cecd5a122175936255ab237e1ffb709 Reviewed-on: https://chromium-review.googlesource.com/1179091 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 845a36ef. With Chromium commits locally applied on WPT: 2160c22c "Modify source path for wpt test of Accept-CH" 3152c6f7 "[UserTiming] Correct measure where start is undefined" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23213 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rob.buis@samsung.com: external/wpt/quirks NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I83e0217a8f0b870b676980fb99d0715f5968994a Reviewed-on: https://chromium-review.googlesource.com/1186549 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585556}
-
Gabriel Marin authored
Original CL: https://chromiumcodereview.appspot.com/10391178 1. Enable large object pointer offset check in release build. Following code will now cause a check error: char* p = reinterpret_cast<char*>(malloc(kMaxSize + 1)); free(p + 1); 2. Remove a duplicated error reporting function "DieFromBadFreePointer", can use "InvalidGetAllocatedSize". BUG=724399,b:70905156 Change-Id: I77b71593373d0c279b95f27cb4931be41c8605b0 Reviewed-on: https://chromium-review.googlesource.com/1184335Reviewed-by:
-
Carlos Knippschild authored
This is an attempt to improve histogram documentations to use more standard wording among similarly tracked histograms and clarify what each histogram and bucket is actually tracking. Change-Id: I07c4551075e670ec4676848a1e7e3fa4df584cac Reviewed-on: https://chromium-review.googlesource.com/1125418Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#585554}
-
Ted Meyer authored
PipelineController (closure) <----- calling this closure allows the rest of the track switch | and seek queue to continue to happen. ^ | | v | FFmpegDemuxer::OnSelectedVideoTrackChanged | (closure) <----- closure is passed down, but this function | | toggles some stream bits and then passes | | the closure down to the seek. | | | v | FFmpegDemuxer::SeekAnyEnabledVideoFrame | (closure) <----- If there are no tracks to enable, we're | | done, and can call the closure -----------| | | v | FFmpegDemuxer::SeekInternal | (closure) <----- Otherwise, we keep state that we're enabling | | a track and seeking it. This state lets us | | know later that we should drop some audio | | frames. | v | FFMPEG MAGIC | (closure) <----- Push the callback into an ffmpeg callback | | | | | v | FFmpegDemuxer::FFmpegAfterSeekCallback | (closure) <----- FFmpeg has moved it's file cursor back to | wherever the seek point was, and is now | reading the interleaved data from all | streams. The state set in | SeekAnyEnabledVideoFrame lets us keep track | of which of these frames are actually | worth re-rendering; we drop the audio, play | the video, and since in-band text isn't | displayed, we just ignore it and let it | go out of sync. | At this point, the closure is also called | and the pipeline is free do whatever. ---------| Bug: 663999 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I30897e3f7daddd2a818af47475e20f049665236d Reviewed-on: https://chromium-review.googlesource.com/1132678 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585553}
-
Dana Fried authored
Update profile icon badging for shortcuts and taskbar on Windows, bump icon version to get automatic update. Use circular profile icon when creating taskbar and desktop shortcut icons. Image preview (new icons vs. old icons, showing both transparent and non-transparent avatars) https://drive.google.com/file/d/1smDN3CBvlYWehIjtRwyIRYKax3_1_F3g/view?usp=sharing R=droger@chromium.org, sky@chromium.org, tbergquist@chromium.org Bug: 857069 Change-Id: Id41d68a7f6f56583801d6cd112cf4ed7fd3e35bb Reviewed-on: https://chromium-review.googlesource.com/1185403Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#585552}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I4cc6bde5c2d738bf5bc908735110ac420325e86c Reviewed-on: https://chromium-review.googlesource.com/1183663Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#585551}
-
ziyangch authored
Remove send usage report toggle from cast setting menu. Make the crash report upload directly decided by internal code. Use timer to control the periodic crash upload tasks. Bug:79208340 Test:change the frequency of uploading to 5 seconds switch the toggle and check whether the update function works and the status of upload function. view the remove effect of cast setting menu. Merge-With: eureka-internal/175156 Change-Id: Ia49c10edb3b2b65fd62bf5734d0ca06376a60d09 Reviewed-on: https://chromium-review.googlesource.com/1114227 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585550}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: Ibfce629a890785c6b367d38ab45b05ecac893934 Reviewed-on: https://chromium-review.googlesource.com/1183488Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#585549}
-
Xiaocheng Hu authored
Legacy layout has a bug that, whitespaces before <br> are not collapsed (https://crbug.com/40634). The issue is fixed in NG. This difference results in that, in some editing/selection layout tests, one less character is moved through when EditingNG is enabled, so these tests fail. This patch removes the spaces before <br> so that these tests pass. Bug: 707656 Change-Id: I4256865abb0a1fe925cfa584fe111b8ba8312332 Reviewed-on: https://chromium-review.googlesource.com/1185998Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585548}
-
Lukasz Anforowicz authored
A failed navigation commits a fake data: page (see RenderFrameImpl::LoadNavigationErrorPageInternal). This commit should preserve most aspects of the original request which failed. This includes the http method and POST data. This CL makes sure that the |failed_request| in RenderFrameImpl::CommitFailedNavigation includes POST data (this is fixed by making sure that CreateURLRequestForNavigation preserves the POST data. This CL also passes |failed_request| from RenderFrameImpl::CommitFailedNavigation into WebLocalFrameImpl::CommitDataNavigation - this ensures that the |failed_request|'s properties are properly preserved. This CL also makes sure that |replace| value calculated in RenderFrameImpl::CommitFailedNavigation is correct not only for reloads, but also for back/forward navigations. Bug: 860807, 869117 Change-Id: Id4e781379defddb26f4e684632d173c46a6f660f Reviewed-on: https://chromium-review.googlesource.com/1153564Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#585547}
-
Tonko Sabolčec authored
[Password Manager] Fix negative performance by not reading the database twice when merging passwords with Sync After enabling the feature which deletes undecryptable logins and recovers Sync users who lost their passwords, there were a significant negative performance impact (the sync association time for passwords has almost doubled). This fix skips checking if each password could be decrypted (which is currently done for every user) if the first read from database succeeds. For ~95% of users it's not even required to check which passwords are decryptable, because reading from database immediately succeeds. For other ~5% of users it's expected that those check would have to be done only once while recovering. Bug: 791541 Change-Id: I460f3692eef330b82ae18fa9f6d52de834ee06e1 Reviewed-on: https://chromium-review.googlesource.com/1186463Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Cr-Commit-Position: refs/heads/master@{#585546}
-
Eric Robinson authored
This adds a checksum that's computed when a ruleset is indexed for the first time. The checksum is stored in prefs and used to determine if the ruleset file is valid when loaded. This prevents crashes from errors not picked up by the flatbuffer verifier when the ruleset file has unexpectedly changed on disk. Bug: 847933 Change-Id: Idc4cdd8520b2b53d27e66d98184d58767891db31 Reviewed-on: https://chromium-review.googlesource.com/1093152Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#585545}
-
Ramin Halavati authored
DevTools preferences are moved to the persistent storage list for incognito mode. This part of the CL does not make any behavioral change. Android preference regarding DevTool enabling is removed from the incognito whitelist as it is not set from inside an incognito window. Bug: 861722 Change-Id: Iab189675cdef808f5d03398bb4e7eb6fd9378e97 Reviewed-on: https://chromium-review.googlesource.com/1180881Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585544}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ded74c1409ac..5a571a1d27ef git log ded74c1409ac..5a571a1d27ef --date=short --no-merges --format='%ad %ae %s' 2018-08-23 dgarrett@google.com commands: Use cros_mark_as_stable --buildroot. 2018-08-23 dgarrett@google.com request_build: Add "cbb_workspace_branch" support. Created with: gclient setdep -r src/third_party/chromite@5a571a1d27ef The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idc99788a441c452e79d6aefdb857f948aece7e5a Reviewed-on: https://chromium-review.googlesource.com/1186663Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585543}
-
ziyangch authored
Bug:79208340 Test: locally build and run. Merge-With: eureka-internal/187358 Change-Id: I14cdab64976f27bdaafc473a10c90ad4868b890a Reviewed-on: https://chromium-review.googlesource.com/1148650 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585542}
-
Scott Little authored
This reverts commit c40ba7f2. Reason for revert: broke compile, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7457 Original change's description: > applist: Introduce HomeLauncherGestureHandler. > > Introduce swipe down gesture to homecher. This cl implements the design > at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# > > The design doc states to use a new ScopedClass but after a bit more > thought I think that would be more difficult especially once animations > are added. > > This should be behind a enabled by default flag, but I do not want to > merge too much during code review, so I will add the flag shortly > after this lands. > > Test: added tests > Bug: 872319 > Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 > Reviewed-on: https://chromium-review.googlesource.com/1184326 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585524} TBR=xiyuan@chromium.org,sammiequon@chromium.org,weidongg@chromium.org Change-Id: Ibf5e3a77faec1b2347669c4ae30b47467f3427f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872319 Reviewed-on: https://chromium-review.googlesource.com/1187086Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#585541}
-
Weidong Guo authored
Background: When active window exists, toggling overview mode will show a enlarge/shrink animation instead of slide up/down animation. In this case, app list should stay invisible during the animation. Changes: Only run animation when overview mode is using slide animation. Otherwise, set the animation duration to 0 so that app list will immediately disappear when overview mode is on and will immediately show up after overview mode animation when overview mode is off. Bug: 876781 Change-Id: Ifc7af8838beead1dbd1b6d70ee46eec3af19dc19 Reviewed-on: https://chromium-review.googlesource.com/1186036 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585540}
-
Jacob Dufault authored
- scrollbar fades in and out - scrollbar now only appears when scrolling - scrollbar disappears after a short while if the list was not scrolled Bug: 859228 Change-Id: I5478f387bd733ded02c476d2de05881df6b8d9ea Reviewed-on: https://chromium-review.googlesource.com/1185800Reviewed-by:
-
Randy Rossi authored
This CL removes the platform check for windows/linux/mac when deciding when to announce the startup message. The message should be spoken for all platforms. This script is not executed on Android anymore so there is no longer any reason to prevent the message from being spoken on that platform. For ChromeOS, however, the existing onIntroduceChromeVox listener is used to announce startup. The criteria therefore changed to !isChromeOS. Installed on Chromecast and verified message is spoken to fix the bug. Bug: 875935 Test: Installed on ChromeOS and verified message still spoken Change-Id: I078ee4aaab6ed3cedabcc43edbb6660aa9c7523e Reviewed-on: https://chromium-review.googlesource.com/1181931Reviewed-by:David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585538}
-
Weidong Guo authored
Changes: Change from ASCIIToUTF16 to UTF8ToUTF16. Bug: 876953 Change-Id: I6cc3fc093b3ee7dc7d1a94e17c118ad7d0c4a573 Reviewed-on: https://chromium-review.googlesource.com/1186135Reviewed-by:
-
Jan Wilken Doerrie authored
This change adds skeletons of classes required for implementing publishing advertisements for WinRT. Actual functionality will be added in a follow-up CL. Bug: 821766 Change-Id: Ib80e8a53810457765ed5e48550d683e1f595ded8 Reviewed-on: https://chromium-review.googlesource.com/1187144Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585536}
-
Christian Biesinger authored
Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1185641 Follows the instructions from go/benchmarks-on-fyi-waterfall This benchmark takes about 12 minutes to run based on my experience with Pinpoint. No-Try: True Change-Id: Ie470b7e6404210275d459378174f1d5aeeb2f518 Reviewed-on: https://chromium-review.googlesource.com/1185642 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585535}
-
Hector Carmona authored
These files were copied from Google Apps NUX and modified slightly. Bug: 832933 Change-Id: I8fd79b2e00d2224e20c6159f478e54defaad0d73 Reviewed-on: https://chromium-review.googlesource.com/1185919Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#585534}
-
James Cook authored
If ChromeVox has ever been turned on during a user session then AutomationManagerAura and AXHostService will be enabled, even if ChromeVox is turned off later. When the shortcut viewer app launches it sees automation is enabled and AXRemoteHost caches the enabled state. When ChromeVox is turned on again AXHostService will generate another OnAutomationEnabled() message to the remote app. Instead of just early-exiting because "automation is already on", re-serialize the app's node tree and send load complete. This is consistent with how AutomationManagerAura behaves today. Bug: 876407 Test: added to views_mus_unittests Change-Id: Ib906da907ca20bbaa3509af72b137462ba006e28 Reviewed-on: https://chromium-review.googlesource.com/1185897Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585533}
-
Anna Offenwanger authored
Change spelling of XREnviromentIntegrationProvider to XREnvironmentIntegrationProvider. Because apparently it's spelled environ not enviro. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I001157b168e325aeab03ec9e1bb22532b8c25b45 Reviewed-on: https://chromium-review.googlesource.com/1186963Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585532}
-
Eric Karl authored
The SurfaceSynchronization feature breaks this test, but after discussion it turns out this test is verifying behavior that is no longer used (or planned to be used in the near future). Disabling the test for now and filing a bug so we can discuss ways to work around this if we want to re-enable in the future. R=twellington@chromium.org Bug: 876943, 871772 Change-Id: I4949b17b20e6376b9b659d9af6cb5d727f348f51 Reviewed-on: https://chromium-review.googlesource.com/1186111 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Pavel Shmakov authored
Show a dialog with a warning before opening an incognito Custom Tab when incognito tabs are already present. Bug: 871738 Change-Id: I378c34be29d920204fd9c0103547af20b8f33c9d Reviewed-on: https://chromium-review.googlesource.com/1177753 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585530}
-
Zhongyi Shi authored
No flag update. In QUIC, move TTL logic from QuicServerStream to QuicStream. Not protected. No functional change expected because the TTL interface is not used yet. Merge internal change: 209152580 https://chromium-review.googlesource.com/c/chromium/src/+/1185984 Reduce the size of some quic enum types to 1 byte, and change some int8_t enums to uint8_t. Not protected. Merge internal change: 209149404 https://chromium-review.googlesource.com/c/chromium/src/+/1185983 Store QuicStreamFrame inline within QuicFrame. Not flag protected. (Data structure layout change, hard to protect.) Merge internal change: 209007693 https://chromium-review.googlesource.com/c/chromium/src/+/1185978 Factor out the code for creating KeyExchange objects from QuicCryptoServerConfig::ParseConfigProtobuf into a KeyExchangeSource object which is passed into the QuicCryptoServerConfig's constructor. Merge internal change: 209002409 https://chromium-review.googlesource.com/c/chromium/src/+/1185917 Rollback of internal change 208339929. Merge internal change: 208974769 https://chromium-review.googlesource.com/c/chromium/src/+/1185870 Update stream flow controller on QuicStream::Read(). We are observing that our send window is not getting updated on reads. From the QuicStream::Read() comment and current usage in qbone, it looks like perhaps the Read method should call back to QuicStream::AddBytesConsumed(). Merge internal change: 208892429 https://chromium-review.googlesource.com/c/chromium/src/+/1185867 Enable version 99 testing in QUIC End to End tests Merge internal change: 208877810 https://chromium-review.googlesource.com/c/chromium/src/+/1185864 In QUIC, increase random bytes length to 20 bytes in IETF stateless reset packet. Protected by --quic_more_random_bytes_in_stateless_reset. Merge internal change: 208805996 https://chromium-review.googlesource.com/c/chromium/src/+/1185853 Use the async version of KeyExchange::CalculateSharedKeys in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Protected by --quic_use_async_key_exchange. Merge internal change: 208764362 https://chromium-review.googlesource.com/c/chromium/src/+/1185849 Split QuicCryptoServerConfig::ProcessClientHelloAfterGetProof() into ProcessClientHelloAfterGetProof and ProcessClientHelloAfterCalculateSharedKeys. Follow up CLs will use the async version of CalculateSharedKeys and will pass in ProcessClientHelloAfterCalculateSharedKeys as the callback. Merge internal change: 208762327 https://chromium-review.googlesource.com/c/chromium/src/+/1185846 Add a new async version of KeyExchange::CalculateSharedKey to allow the key exchange operation to be offloaded. Follow up CLs will enable this new codepath in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Merge internal change: 208760423 https://chromium-review.googlesource.com/c/chromium/src/+/1185842 Disable QUIC v35. Protected by --quic_disable_version_35. Merge internal change: 208714937 https://chromium-review.googlesource.com/c/chromium/src/+/1185782 Deprecate --gfe2_reloadable_flag_quic_disable_version_42. Also removes QUIC_VERSION_42 code. Merge internal change: 208698903 https://chromium-review.googlesource.com/c/chromium/src/+/1185739 Deprecate --gfe2_reloadable_flag_quic_disable_version_41_2. Also removes QUIC_VERSION_41 code. Merge internal change: 208668770 https://chromium-review.googlesource.com/c/chromium/src/+/1185528 Remove an unreachable QUIC_BUG_IF in QuicUnackedPacketMap. Not protected. Merge internal change: 208654236 https://chromium-review.googlesource.com/c/chromium/src/+/1185493 Deprecate --quic_use_static_stream_collection_in_write_blocked_list. Merge internal change: 208645294 https://chromium-review.googlesource.com/c/chromium/src/+/1185492 Deprecate --quic_add_to_blocked_list_if_writer_blocked. Merge internal change: 208644812 https://chromium-review.googlesource.com/c/chromium/src/+/1185488 In QuicConnection, notify debug_visitor after a connectivity probing packet is sent. Protected by --quic_notify_debug_visitor_on_connectivity_probing_sent. Merge internal change: 208530778 https://chromium-review.googlesource.com/c/chromium/src/+/1185407 Change-Id: I3bee166d54607a6297cb0c43f079ecdf96f5d0d1 Reviewed-on: https://chromium-review.googlesource.com/1185999 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585529}
-
Tessa Nijssen authored
The following changes were made: - Store reference to monitor bounds - Rename variable to determine child menu position - Renamed anchor bounds - Renamed menu bounds - Removed Calls to gfx::Rect's origin Store Reference to Monitor Bounds state_.monitor_bounds -> monitor_bounds Renamed Variable to Determine Child Menu Position create_on_the_right -> create_on_right Also cleaned up initialization. Renamed Anchor Bounds owner_bounds -> anchor_bounds The variable is described as being the anchor bounds in a comment above its instantiation. Renamed Menu Bounds pref -> menu_bounds More descriptive name. Removed Calls to gfx::Rect's Origin origin().x() -> x() origin().y() -> y() Calls to x() and y() return the origin's x and y positions. Adding a call to the origin is unnecessary. Change-Id: I29d9b669d567b3d978da721c1b34b9399a1e8178 Reviewed-on: https://chromium-review.googlesource.com/1145544Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Stephan Herhut authored
There is a mechanism that registers the size of the backing store of a typed array with v8 if such backing store is used by a typed array in a v8 isolate. This is done so that v8 can properly assess the memory pressure of an isolate in the presence of external allocations. With shared array buffers, we can no longer attribute a buffer to a specific isolate, as it might be used by multiple isolates at the same time. The current implementation tries to work around this by only registering with one isolate but ultimately fails at doing so, leading to false data. As a stop-gap fix, this change disables registering of shared buffers completely to at least keep the data consistent while we design a working solution. Change-Id: Ib007cbad6af80e6c82d6ab809bf14ce95c54fc93 Bug: chromium:877055 Reviewed-on: https://chromium-review.googlesource.com/1186461 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585527}
-
John Abd-El-Malek authored
This way it can be used by tests inside content. Bug: 817187 Change-Id: If1a7c1470b738296f8d121a796f5b5b2492497d6 Reviewed-on: https://chromium-review.googlesource.com/1186028 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
