- 05 Apr, 2018 40 commits
-
-
Mikel Astiz authored
Follow-up to https://chromium-review.googlesource.com/997197 where, presumably, the wrong test was disabled. TBR=beccahughes@chromium.org TBR=thomasanderson@chromium.org Bug: 829228 Change-Id: Icd680733174a87d05172fe842b0dc0eed46aa80d Reviewed-on: https://chromium-review.googlesource.com/997745 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548429}
-
Jennifer Apacible authored
Currently, all Picture in Picture code is housed in chrome/. Since only some of the Picture in Picture work is Chrome specific, we move the more generic work into content/. This change completely moves the PictureInPictureWindowController and OverlaySurfaceEmbedder into content/. This change will also pave for some future work related to user initiated commands from the window, such as play/pause. IPC messaging for MediaPlayerDelegateMsg must be done through content/ rather than in chrome/. OverlayWindowViews continues to be the desktop Chrome implementation of OverlayWindow, which is now moved into content/. With the convergence of historically platform-dependent implementations (views vs cocoa) into just views, there will only be one window implementation for Chrome. BUG: 726619 821874 Change-Id: I6ef73552c6729aec235f4a6d176fd4109f6674b3 Reviewed-on: https://chromium-review.googlesource.com/972841 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548428}
-
Adam Langley authored
It took me a little while to figure out why the bounds in this function were valid so I added some comments. Change-Id: I1244b966dbb6b7984dfc4fbceaa7ed6a2f369aa3 Reviewed-on: https://chromium-review.googlesource.com/984958Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548427}
-
Christopher Grant authored
Latest UX spec drops this element in favor of controller tooltips. BUG=829059 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I933a6c0e6ba2877a13777200a9774328ea04a826 Reviewed-on: https://chromium-review.googlesource.com/996525Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548426}
-
Jinho Bang authored
Until now, we had to use IsSecureContext() to check whether an execution context is a secure context manually. But we can use [SecureContext] instead of the manual check now. After this change, all related APIs including PaymentRequest will not be exposed in non-secure context. Bug: none Change-Id: Ie5b3fc6641e882cc2844595fea350b6adb3425db Reviewed-on: https://chromium-review.googlesource.com/818594Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#548425}
-
Raphael Kubo da Costa authored
This prevents GCC from spamming the build with warnings such as ../../base/message_loop/message_pump_for_io.h:39:22: warning: missing terminating ' character #error Platform doesn't define MessagePumpForIO Change-Id: Ice62f39141a613c2ab4a56c031826c43292f287f Reviewed-on: https://chromium-review.googlesource.com/997632 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548424}
-
Xida Chen authored
The comments in this function is a copy-paste of OnSetTouchAction. This CL simplifies it. TBR=dtapuska@chromium.org Bug: None Change-Id: I279871ad1e92084c95eff990785ca1591e17f5df Reviewed-on: https://chromium-review.googlesource.com/997761Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548423}
-
Andrey Kosyakov authored
... just tell content to proceed with no certificate instead of cancelling the request. Bug: 757181 Change-Id: Ib7db0d5bbbdf73dfd3bad4fb5827519eb8c0dbbd Reviewed-on: https://chromium-review.googlesource.com/996954Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548422}
-
Michael Lippautz authored
Verification requires iterability of pages implying that we cannot have a linear allocation area. The area was however potentially set up during compaction. Bug: chromium:757440 Change-Id: I9b12ecac032893aaa6d6f022149cec0a6130ebf9 Reviewed-on: https://chromium-review.googlesource.com/997672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548421}
-
Annie Sullivan authored
NOTRY=true Bug: 828917 Change-Id: I5c36321a1e1ac1c5076e8e3025f9007e47142f73 Reviewed-on: https://chromium-review.googlesource.com/996183 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#548420}
-
Marc Treib authored
This CL plumbs the IdentityManager through to PSS, via SigninManagerWrapper. There are no behavioral changes, in particular the IdentityManager isn't used at all yet. Uses will follow soon (https://crrev.com/c/983914). This does require a small test change to make the newly-instantiated IdentityManager happy (without that change, it complains that its view of the primary account isn't consistent with SigninManager's). Bug: 825190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8b313f5572339a2c1319725fa4012b4a41365e08 Reviewed-on: https://chromium-review.googlesource.com/995414 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#548419}
-
Emily Hanley authored
Change-Id: I0c30913c829ee940f984b7df83cf813083f6be76 Reviewed-on: https://chromium-review.googlesource.com/992994Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#548418}
-
Amirhossein Simjour authored
When an autofill option is selected, before Autofill popup closes, the focus might be on autofill and the input connection might be null. This patch makes sure that this doesn't lead to crash. Change-Id: Ifcafd1de990c9f9789b455544f8feddef13e8be6 Reviewed-on: https://chromium-review.googlesource.com/996798Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#548417}
-
Francois Doray authored
TaskScheduler needs access to command line arguments in an upcoming CL that allows disabling background tasks via a command line argument (https://chromium-review.googlesource.com/c/chromium/src/+/996439). The order of initialization matches what is done elsewhere in the codebase. Bug: 726937 Change-Id: I4e709db4c7f36c9e062d43aa686f5309cc8f3745 Reviewed-on: https://chromium-review.googlesource.com/996559Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548416}
-
Kevin McNee authored
These affected tests process GesturePinchUpdates outside of a GesturePinchBegin/End pair. We add the missing begin and end events. Bug: 787924 Change-Id: Ic087d85b39bb7a39c794c62dea06cba622125a12 Reviewed-on: https://chromium-review.googlesource.com/986540Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#548415}
-
Francois Doray authored
These properties are available on TabLifecycleUnitExternal, which is intended for use outside of chrome/browser/resource_coordinator/. Bug: 775644 Change-Id: I5708c3be32806c0109ad04ece1fffaa5f1f0709f Reviewed-on: https://chromium-review.googlesource.com/858046 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#548414}
-
Allen Bauer authored
Added IsMaterialRefreshMode() function to ChromeLayoutProvider. Bug: 822000 Change-Id: I379d7603838cdec60b3f94fc0e163e9907995b61 Reviewed-on: https://chromium-review.googlesource.com/988052 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548413}
-
Gabriel Charette authored
This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle() Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which focused on RunLoops with a variable name. The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Includes should have been stripped if the was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 781352 Change-Id: Ieef9ec8a22e3c7451a27124b447883db7ff3f500 Reviewed-on: https://chromium-review.googlesource.com/995975Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9db18b4f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15368 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing kojii@chromium.org: external/wpt/css/css-scoping mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mstensho@chromium.org: external/wpt/css/css-multicol worker-dev@chromium.org: external/wpt/workers TBR=foolip No-Export: true Change-Id: I16e485d604f6bbfa375cd14d8624a12641304ad1 Reviewed-on: https://chromium-review.googlesource.com/996863 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#548411}
-
Kristian H. Kristensen authored
CL:989024 updated the MD5 sums for the video_VideoDecodeAccelerator test, but thanks to the magic of copy and paste, the VP8 sum ended up being the same as the VP9 sum. Fix that. BUG=827032 TEST=video_VideoDecodeAccelerator Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> TBR=dalecurtis@chromium.org,posciak@chromium.org Change-Id: If55a5371c45ae01103f80f4007df8e7338570142 Reviewed-on: https://chromium-review.googlesource.com/994068 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548410}
-
Andrew Grieve authored
Show $root_gen_dir to make it more obvious when paths are generated. Expand "Other" in canned_queries to have one group per top-level directory to give a bit more granularity. Change-Id: Ib9630b5aa04e1c52d51e3afa8772a4a2d4392555 Reviewed-on: https://chromium-review.googlesource.com/996909Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#548409}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/61ee69a66e73..26ad1acbcb4c $ git log 61ee69a66..26ad1acbc --date=short --no-merges --format='%ad %ae %s' 2018-04-04 mpsuzuki * src/truetype/ttobjs.c (trick_names): Add 3 tricky fonts (#53554), `DFHei-Md-HK-BF', `DFKaiShu-Md-HK-BF' and `DFMing-Bd-HK-BF'. (tt_check_trickyness_sfnt_ids): Add checksums for 3 tricky fonts in above. 2018-04-03 wl Minor comment improvement. 2018-04-01 wl * builds/toplevel.mk (work): Use $(SEP). 2018-03-30 wl [truetype] Fix memory leak (only if tracing is on). 2018-03-26 apodtele Documentation improvement. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org BUG=chromium:811110 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1053 ChromiumOS-Issue: chromium:825973 Change-Id: Icfc49484a500e0c75edebb7d58b76d3c7442d5ea Reviewed-on: https://chromium-review.googlesource.com/995918 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#548408}
-
Rayan Kanso authored
Bug: N/A Change-Id: I039eec4367b8989af4738e480f4083cb635f9db4 Reviewed-on: https://chromium-review.googlesource.com/997816Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548407}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec8d7a766a7e..8c177b33bdde $ git log ec8d7a766..8c177b33b --date=short --no-merges --format='%ad %ae %s' 2018-04-05 chrome-bot Update config settings by config-updater. 2018-04-05 smbarber Revert "cbuildbot_launch: Clean distfiles cache when too old" 2018-04-04 dgarrett chromeos_config: Move fuzzer template to 'informational'. 2018-04-03 pprabhu cbuildbot_launch: Clean distfiles cache when too old 2018-04-04 chrome-bot Update config settings by config-updater. 2018-04-04 akeshet remove whirlwind-no-vmtest-pre-cq from default set Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:814989,chromium:829055 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic84d9c712043bce2cfaa2452eb101b70ec29843e Reviewed-on: https://chromium-review.googlesource.com/997754Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548406}
-
https://github.com/google/sanitizers/issues/295Nico Weber authored
Bug: none Change-Id: Ib11ae467efea7ce3a44375850ddbf78524914aef Reviewed-on: https://chromium-review.googlesource.com/996853Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548405}
-
Hirokazu Honda authored
This CL just deletes one TODO. It stated that we would call VEA::TryToSetupEncodeOnSeparateThread() with an ad-hoc background worker thread. In our current stack, there is no need to do this. BUG=chromium:828047 TEST=None Change-Id: I034e6a9e20101e54b08a664479bffb4e8f3df0f9 Reviewed-on: https://chromium-review.googlesource.com/997054Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#548404}
-
Stephen McGruer authored
The upstream spec has removed the 'timing' objects and replaced them with updateTiming/getTiming methods on AnimationEffect. It also removed and renamed a few timing idl interfaces; see the bug for full details. This CL also refactors the timing input parsing, aiming to make the public TimingInput API match what the spec requires and not expose other unnecessary methods. See https://github.com/w3c/csswg-drafts/pull/2432 for the spec change. Bug: 823384, 823386 Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324 Reviewed-on: https://chromium-review.googlesource.com/975923Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548403}
-
Francois Doray authored
The goal is to expose this in chrome://discards. Bug: 775644 Change-Id: I17c68b5e03ac578b593f754f652aad8e9ee3cd7b Reviewed-on: https://chromium-review.googlesource.com/993417Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548402}
-
Mikel Astiz authored
The test is failing quite regularly on Mac10.12, e.g: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/13210 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Felements%2Felements-panel-rewrite-href.js&showFlaky=true The flakiness regressed recently on Mac10.12. TBR=einbinder@chromium.org NOTRY=true Bug: 806645 Change-Id: I14a6f37a4266e0d0eee35039f6765976f2fb2937 Reviewed-on: https://chromium-review.googlesource.com/997739Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548401}
-
Francois Doray authored
The function is no longer used since occlusion tracking is done by aura::WindowOcclusionTracker. Bug: 973682 Change-Id: I1bee51d47547f1e91f375c0f591dbd27664155de Reviewed-on: https://chromium-review.googlesource.com/996299Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548400}
-
Michael Lippautz authored
Since df7973c4 there is no way to trigger individual write barriers on deleted values, because: a. write barriers are emitted for complete backing stores and their processing already takes care of deleted values b. for moving and copying the reinsertion takes care of omitting deleted values Bug: chromium:757440 Change-Id: I43fb8f43936d471e7ad6d1fb7f0da6c8bd626e52 Reviewed-on: https://chromium-review.googlesource.com/992932Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548399}
-
Daniel Fenner authored
The camera supports absolute positioning via an extension unit (as opposed to the camera terminal unit as many other cameras do). So before issuing a v4l2 command to do absolute positioning we map the command to that extension unit. In case the camera does not implement that extension unit (e.g. all non-logitech cameras) this mapping just silently fails. BUG: 826296 Change-Id: I939de844375efc6b8a756efe0877cb4bf0dc9a56 Reviewed-on: https://chromium-review.googlesource.com/982056 Commit-Queue: Daniel Fenner <dfenner@google.com> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#548398}
-
Calder Kitagawa authored
reloc_utils.cc contained an infinite looping and a crashing out-of-bounds behavior due to unsafe input. This resolves these "fatal" errors. Fuzzing has found no other infinite loops or crashes for the Windows PE dissasembler nor has ASAN detected any other out-of-bounds memory issues. The fuzzer will be committed separately once it is more performant (i.e. >= 1000 exec/s). Change-Id: Ieb07f77fb7b062238b4ce1587bcde45a4d3b7788 Reviewed-on: https://chromium-review.googlesource.com/996488Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#548397}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/77df816c..7e9556c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iece56ab0db140d0443608d3f036800a08d46a8c9 Reviewed-on: https://chromium-review.googlesource.com/996882Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#548396}
-
Boris Sazonov authored
This CL adds the preliminary version of an animated header image for the new sign-in screen. The header image is added as an animated vector in signin_header_animation.xml. For older versions of Android API this animated vector is supported via support library. Bug: 814728 Change-Id: I394cffbd3dc9c9426a14272dad33a6e6c8e2cd72 Reviewed-on: https://chromium-review.googlesource.com/992933 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#548395}
-
Matt Menke authored
I misunderstood the boolean parameter. This check is intended to be advisory, rather than something that blocks landing CLs. Bug: 746977, 598073 Change-Id: Ib7695f7bea15f1613a4f9e73e0258fa231340161 Reviewed-on: https://chromium-review.googlesource.com/992393Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#548394}
-
jonross authored
StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched is flaking with a timeout on Windows in viz_browser_tests. Filtering it out. TBR=kylechar@chromium.org TEST=StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched Bug: 829300 Change-Id: I78a776cd133edc17caa9291612ac980d8c500943 Reviewed-on: https://chromium-review.googlesource.com/997758Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#548393}
-
Hiroki Nakagawa authored
This is a preparation CL for enabling to establish WebSocket connection off the main thread. In the current implementation, mixed content checks for WebSocket are bound with LocalFrame. This blocks off-main-thread WebSocket. To unblock it, this CL introduces IsWebSocketAllowed() in MixedContentChecker that can do the checks based on both LocalFrame and WorkerGlobalScope. Bug: 825740 Change-Id: I2cb951b4c23b072605602d6a5dc4a38e28ac5bd5 Reviewed-on: https://chromium-review.googlesource.com/983076Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#548392}
-
Mike West authored
This patch adjusts the `SecureContext` IDL attribute to take an argument, as we need to restrict the relevant bits and pieces to secure contexts iff a specific flag is set. We'll unfortunately need to keep that in place until and unless we decide that we can reasonably remove an enterprise opt-out. Intent to Deprecate/Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ANnafFBhReY/1Xdr53KxBAAJ Spec bug: https://github.com/whatwg/html/issues/3440 Bug: 588931 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5bedd2ca6f420a88ddbcff65e4223fad224ac0a7 Reviewed-on: https://chromium-review.googlesource.com/982625Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#548391}
-
Eric Noyau authored
Removing all includes of base/ios/ios_util.h in files where base::ios:: is actually not used anymore. In a handfull of places this required replacing it with an import of base/logging.h. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia5b06338c40f7e4f52ca11dc88b12b85d7078f11 Reviewed-on: https://chromium-review.googlesource.com/988013Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#548390}
-