Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 08 Feb, 2010 6 commits
  3. 07 Feb, 2010 7 commits
  5. 06 Feb, 2010 14 commits
    • dglazkov@chromium.org's avatar
      2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> · 88d01648
      dglazkov@chromium.org authored 
              No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54466 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88d01648
    • dglazkov@chromium.org's avatar
      2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> · 204f7105
      dglazkov@chromium.org authored 
              Reviewed by Adam Barth.

        Using inlines and function-level statics don't mix, according to gcc.
        https://bugs.webkit.org/show_bug.cgi?id=34663

        De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

        It appears that the initialization check, generated by gcc doesn't account
        for a possibility that the function may be inlined, resulting in lazy
        initialization failure for more than one inlined instance of the function.

        No behavior change, so no new tests.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::deviceRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54465 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      204f7105
    • barraclough@apple.com's avatar
      Change UStringImpl::create to CRASH if the string cannot be allocated, · 44fb4f7d
      barraclough@apple.com authored 
      rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods.  In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@54464 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      44fb4f7d
    • ap@apple.com's avatar
      Reviewed by Oliver Hunt. · 5f4ec56c
      ap@apple.com authored 
              https://bugs.webkit.org/show_bug.cgi?id=34670
        TestNetscapePlugin should work with Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
        browser doesn't tell what it supports.



git-svn-id: svn://svn.chromium.org/blink/trunk@54463 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5f4ec56c
    • hamaji@chromium.org's avatar
      2010-02-05 Shinichiro Hamaji <hamaji@chromium.org> · b2fe5017
      hamaji@chromium.org authored 
              Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * platform/gtk/Skipped:
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: svn://svn.chromium.org/blink/trunk@54461 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b2fe5017
    • ggaren@apple.com's avatar
      Added an ASSERT to catch an implausible but theoretically possible leak. · dd5604e7
      ggaren@apple.com authored 
              
Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
        
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.



git-svn-id: svn://svn.chromium.org/blink/trunk@54460 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dd5604e7
    • ggaren@apple.com's avatar
      Removed these special Windows expected results because they represented · 914d7459
      ggaren@apple.com authored 
      incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@54459 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      914d7459
    • eric@webkit.org's avatar
      2010-02-05 James Hawkins <jhawkins@chromium.org> · 056a8496
      eric@webkit.org authored 
              Reviewed by David Levin.

        [Chromium] Rename autocomplete* to suggestions* to prepare for the
        refactoring of AutocompletePopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=34664

        * public/WebView.h:
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::hideAutofillPopup):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::suggestionsPopupDidHide):

git-svn-id: svn://svn.chromium.org/blink/trunk@54458 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      056a8496
    • eric@webkit.org's avatar
      2010-02-05 Kwang Yul Seo <skyul@company100.net> · e20529b5
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        [BREWMP] Define SYSTEM_MALLOC 1
        https://bugs.webkit.org/show_bug.cgi?id=34640

        Make BREWMP use system malloc because FastMalloc is not ported.

        * wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54457 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e20529b5
    • eric.carlson@apple.com's avatar
      2010-02-05 Eric Carlson <eric.carlson@apple.com> · e15c53d0
      eric.carlson@apple.com authored 
              Unreviewed revert of r54454, until I can generate new results

        * media/video-loop-expected.txt:
        * media/video-loop.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@54456 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e15c53d0
    • cmarrin@apple.com's avatar
      Fixed changed virtual function in GraphicsLayerCACF and call order issues · 26617960
      cmarrin@apple.com authored 
              https://bugs.webkit.org/show_bug.cgi?id=34348
        
        The correct virtual function in GraphicsLayerCACF is now being
        called. We also fixed an issue in QTMovieWin where the size
        of the movie was not being set correctly because the call order
        was changed.
        
        I also changed the order of a couple of calls in QTMovieWin to account
        for changed calling order from the logic above.



git-svn-id: svn://svn.chromium.org/blink/trunk@54455 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      26617960
    • eric.carlson@apple.com's avatar
      2010-02-05 Eric Carlson <eric.carlson@apple.com> · 698585e8
      eric.carlson@apple.com authored 
              Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=33671
        [GTK] media/video-loop.html fails intermittently on Gtk Bots

        Rewrite test to make it less timing dependent.

        * media/video-loop-expected.txt:
        * media/video-loop.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@54454 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      698585e8
    • dpranke@chromium.org's avatar
      2010-02-03 Dirk Pranke <dpranke@chromium.org> · 0d1934a4
      dpranke@chromium.org authored 
              Reviewed by Eric Seidel.

        Add a simple test implementation and the WebKit Mac implementation
        for the layout_tests/port package. Also add a simple test driver of
        that interface.

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/driver_test.py: Added.
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/mac.py: Added.
        * Scripts/webkitpy/layout_tests/port/test.py: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@54452 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0d1934a4
    • dpranke@chromium.org's avatar
      2010-02-03 Dirk Pranke <dpranke@chromium.org> · 273a0a62
      dpranke@chromium.org authored 
              Reviewed by Eric Siedel.

        Refactor the port package into an object-oriented style and merge
        path_utils into it. We add a 'base' and a 'chromium' object to the
        port package; this will allow us to easily add new ports (like
        WebKit Mac).

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/rebaseline-chromium-webkit-tests:
        * Scripts/run-chromium-webkit-tests:
        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/base.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:




git-svn-id: svn://svn.chromium.org/blink/trunk@54449 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      273a0a62
  7. 05 Feb, 2010 13 commits
    • eric@webkit.org's avatar
      2010-02-05 James Hawkins <jhawkins@chromium.org> · f0ff4bec
      eric@webkit.org authored 
              Reviewed by David Levin.

        [Chromium] Remove an unused forward declaration in WebKitClient.h.

        https://bugs.webkit.org/show_bug.cgi?id=34622

        * public/WebKitClient.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54448 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f0ff4bec
    • kdecker@apple.com's avatar
      Reviewed by Mark Rowe. · 7c332e91
      kdecker@apple.com authored 
              https://bugs.webkit.org/show_bug.cgi?id=34661
        <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
        * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
        (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.



git-svn-id: svn://svn.chromium.org/blink/trunk@54447 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7c332e91
    • enrica@apple.com's avatar
      Horizontal scrollbar works in reverse at milliondollarcu.be · 6ac6e802
      enrica@apple.com authored 
      <rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848
        
Reviewed by Simon Fraser.

Added a manual test.

* manual-tests/win: Added.
* manual-tests/win/horizontal-scroll-composited.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):



git-svn-id: svn://svn.chromium.org/blink/trunk@54446 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6ac6e802
    • ossy@webkit.org's avatar
      Rubber-stamped by Kenneth Rohde Christiansen. · 130b30b0
      ossy@webkit.org authored 
      [Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

* platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.



git-svn-id: svn://svn.chromium.org/blink/trunk@54445 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      130b30b0
    • ossy@webkit.org's avatar
      Rubber-stamped by Kenneth Rohde Christiansen. · 6dd04e74
      ossy@webkit.org authored 
      Update expected results after r54441 to make buildbot happy.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.



git-svn-id: svn://svn.chromium.org/blink/trunk@54444 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6dd04e74
    • eric@webkit.org's avatar
      2010-02-05 James Hawkins <jhawkins@chromium.org> · 2acb357f
      eric@webkit.org authored 
              Reviewed by Darin Fisher.

        Implement WebInputElement::isActivatedSubmit().

        https://bugs.webkit.org/show_bug.cgi?id=34623

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::isActivatedSubmit):

git-svn-id: svn://svn.chromium.org/blink/trunk@54443 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2acb357f
    • eric@webkit.org's avatar
      2010-02-05 Ryan Leavengood <leavengood@gmail.com> · c0bf4d2b
      eric@webkit.org authored 
              Reviewed by David Levin.

        Implementation of GlyphPage::fill() for Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        Covered by existing tests.

        * platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp

git-svn-id: svn://svn.chromium.org/blink/trunk@54442 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c0bf4d2b
    • kenneth@webkit.org's avatar
      Unreviewed, missed in earlier commit. · f7de5703
      kenneth@webkit.org authored 
      Add expected frame flattening results for Qt.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54441 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f7de5703
    • kenneth@webkit.org's avatar
      Implement flattening of framesets · 22a870b3
      kenneth@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html
       fast/frames/flattening/frameset-flattening-grid.html
       fast/frames/flattening/frameset-flattening-simple.html
       fast/frames/flattening/frameset-flattening-subframe-resize.html
       fast/frames/flattening/frameset-flattening-subframesets.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
* page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
* rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

* Api/qwebpage.cpp:
(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):
* Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameSetFlatteningEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

* fast/frames/flattening/frameset-flattening-advanced.html: Added.
* fast/frames/flattening/frameset-flattening-grid.html: Added.
* fast/frames/flattening/frameset-flattening-simple.html: Added.
* fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
* fast/frames/flattening/frameset-flattening-subframesets.html: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@54440 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      22a870b3
    • cjerdonek@webkit.org's avatar
      Provided a way in check-webkit-style to specify filter rules · e11f0f73
      cjerdonek@webkit.org authored 
      on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=33684

* Scripts/webkitpy/style/checker.py:
  - Added _PATH_RULES_SPECIFIER configuration variable.
  - In ProcessorOptions class--
    - Changed the CategoryFilter attribute to FilterConfiguration.
    - Added path parameter to is_reportable().
  - Renamed ArgumentDefaults filter_rules attribute to
    base_filter_rules.
  - Updated ArgumentPrinter class.
  - Added filter rule validation to ArgumentParser (instead of
    in CategoryFilter constructor).

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated unit tests as necessary.
  - Added unit tests for PATH_RULES_SPECIFIER.

* Scripts/webkitpy/style/error_handlers.py:
  - Updated DefaultStyleErrorHandler to use file path when
    calling is_reportable().

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated unit tests as necessary.

* Scripts/webkitpy/style/filter.py:
  - Marked CategoryFilter internal with an underscore.
  - Removed argument validation from CategoryFilter.
  - Added FilterConfiguration class.

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated CategoryFilterTest class.
  - Added FilterConfigurationTest unit tests.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed _is_test_filename() code.
  - Removed hard-coded path checks from check_include_line().

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed three unit tests related to exempted files.

git-svn-id: svn://svn.chromium.org/blink/trunk@54439 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e11f0f73
    • simon.fraser@apple.com's avatar
      2010-02-05 Simon Fraser <simon.fraser@apple.com> · 100b3fd5
      simon.fraser@apple.com authored 
              Reviewed by Dan Bernstein.

        Changing display type of parent of input on focus causes input field to not receive key events
        https://bugs.webkit.org/show_bug.cgi?id=34620
        <rdar://problem/7584572>

        When layout affects a text input, the RenderTextControl gets destroyed and
        recreated, which in turn makes a new innerTextElement. However, if the text field was
        focused, the VisibleSelection is left pointing to the old innerTextElement, so text
        input no longer works.

        The fix is to call updateFocusAppearanceSoon() when attaching the input element,
        which will update the selection if necessary.

        Test: fast/forms/restore-selection-after-layout.html

        * dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable,
        m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection
        (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter.
        (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
        * dom/Element.cpp:
        (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
        * dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.

git-svn-id: svn://svn.chromium.org/blink/trunk@54438 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      100b3fd5
    • kenneth@webkit.org's avatar
      [Qt] Apply the command line options as settings to the graphics system. · 117eb99e
      kenneth@webkit.org authored 
      Reviewed by Ariya Hidayat.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
* QtLauncher/webview.h:
(WebViewGraphicsBased::setItemCacheMode):

git-svn-id: svn://svn.chromium.org/blink/trunk@54437 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      117eb99e
    • pfeldman@chromium.org's avatar
      2010-02-05 Pavel Feldman <pfeldman@chromium.org> · 8cb9c735
      pfeldman@chromium.org authored 
              Reviewed by Timothy Hatcher.

        Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

        https://bugs.webkit.org/show_bug.cgi?id=34646

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.show):
        (WebInspector.CookieItemsView.prototype._update):
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
        (WebInspector.CookieItemsView.prototype._createDataGrid):
        (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare):
        (WebInspector.CookieItemsView.prototype._populateDataGrid):
        (WebInspector.CookieItemsView.prototype._createSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
        (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
        (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        (WebInspector.DataGrid.prototype.autoSizeColumns):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.dataGridForResult):


git-svn-id: svn://svn.chromium.org/blink/trunk@54436 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8cb9c735