- 21 Jan, 2020 40 commits
-
-
Kent Tamura authored
file-input-disabled.html is merged into the new test. Bug: 1040828 Change-Id: I3eeca8ff9f44011f0efb023ee15f1a13463967ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011463Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#733521}
-
Kent Tamura authored
They are merged into FileInputType::UpdateView(). This CL has no behavior changes. Bug: 1040828 Change-Id: Ie08598ce562842eee02b15575bcf278c4ce58b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011464Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03acc60fb5fc..8265f5d3dc2a git log 03acc60fb5fc..8265f5d3dc2a --date=short --first-parent --format='%ad %ae %s' 2020-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8265f5d3dc2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02dbc38d07ff73347582fe805388ee3b30291e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733519}
-
Kent Tamura authored
This CL makes the code robust for UA shadow tree changes. This CL has no behavior changes. Bug: 1040828 Change-Id: I373b5c01255149890f25b194f3777199dbaad2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011465Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f22f1ff3190..71b8b765a231 git log 9f22f1ff3190..71b8b765a231 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 bsalomon@google.com Remove proxy offset param to SkGpuBlurUtils::GaussianBlur. Created with: gclient setdep -r src/third_party/skia@71b8b765a231 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Ib48da2d54db83969d404fdc153dab515671c1e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011445Reviewed-by:
-
nancy authored
BUG=1038487 Change-Id: I0bfd6721faee80fe02c85da07ad329085c68afaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011466Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#733516}
-
Rachel Wong authored
The code that will call this logging function is at https://chromium-review.googlesource.com/c/chromium/src/+/1999973. Bug: 1014839 Change-Id: Iccf37f350ead2e5f900624e2ad554aedbd54bc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989735Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#733515}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9845b87dd548f20f48050b9f98a8a621fb938982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008024Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733514}
-
Alexandre Courbot authored
The size of the GL image is supposed to be the visible size, while the buffer itself shall be imported with its own coded size and stride. Before crrev.com/c/1982499, we did not pass any size information with the buffer, so as a workaround the size was set to the coded size and the buffer imported with its coded size into the GPU or DC, which resulted in visible green lines on the right or lower end of the image when coded_size != visible_size. Now that we are importing the buffer using a NativePixmapHandle, we can set the GL image to be the correct visible size. BUG=b:141579960 TEST=240p h.264 video plays in Youtube web without visible green line on Kukui. TEST=video playback working on Kevin. Change-Id: I870892c41197ed210c7b7455975669a3473891f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010243 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733513}
-
Alexandre Courbot authored
The doc for this method was still referring to deprecated and deleted members. BUG=b:146842214 TEST=Chromium builds for arm-generic. Change-Id: Ia8bf76ffa3091b73b8c6c5d95721de8b8a3d71d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010242 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Adds comments to ColorChooser and ColorChooserClient. Also removes ColorInputType::EndColorChooser as it is only used from ClosePopupView. Bug: None Change-Id: I9a169a53e0c9c4e3e9eddef5f08f49b651a0c705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010595Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733511}
-
Moe Ahmadi authored
Bug: 1041663 Change-Id: I97a0bd19a9c2711df293553be80deb5c4e0eb8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007970 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733510}
-
Tsuyoshi Horo authored
We will implement "Save page as Web Bundle" feature behind this flag. Bug: 1040752 Change-Id: Ia898adf1470730116d96d583aa8acce37bfd8d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007806Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733509}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/299f213a7f6c..dc9588f19d70 Created with: gclient setdep -r src-internal@dc9588f19d70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8460fcd44f10ec89bcf789f8d7db740f8e074300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733508}
-
Anand K. Mistry authored
Bug: None Change-Id: Ib4e5288d590321f0911c9c60a583b97291716008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007794Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#733507}
-
Rachel Sugrono authored
selected Check-select an image and a PDF file, show the files in Quick View, and down-arrow to the PDF file. Check the PDF file is displayed in Quick View (tests a bug where the PDF file was not being displayed, which was fixed in CL:2007795). Bug: 1038799 Change-Id: I5e6eda55c64458f7fd82a343597906399ba5feda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010602 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733506}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef05567733eb..9f22f1ff3190 git log ef05567733eb..9f22f1ff3190 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 reed@google.com use transpose of inverse for transforming normals Created with: gclient setdep -r src/third_party/skia@9f22f1ff3190 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I1ccc27eeccb0978986305cfeae338ed98eafc39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011421Reviewed-by:
-
Mike Reed authored
See Skia CLs https://skia-review.googlesource.com/c/skia/+/265298 https://skia-review.googlesource.com/c/skia/+/265299 Change-Id: I159f471befddee2877cb631c461e075b2793ef44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011044 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#733504}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4458357f. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ica1e221dad2abef552fd5bf9d188039dafe04aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010932Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733503}
-
Nicolás Peña Moreno authored
This CL attempts to fix the flaky timeouts in the test virtual/omt-worker-fetch/external/wpt/resource-timing/resource_timing_buffer_full_eventually.html by doing the following: 1. Set it to be 'long'. This is a slow test due to the large amount of fetches. 2. Set the number of elements added at a time to 8, which is faster than 100 in my experimentation. 3. Do not wait for onload to begin appending scripts. Bug: 1041707 Change-Id: Iddf37a72135e1f82c23c3e71c8da40eca13b8f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011294Reviewed-by:
-
Rachel Sugrono authored
selected Check-select an image and a text file, show the files in Quick View, and down-arrow to the text file. Check the text file is displayed in Quick View (tests a bug where the text file was not being displayed, and fixed in CL:2007795). Bug: 1038799 Change-Id: I7ef509de8ffcf418e9476c8216d0ea32d94ca011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010601Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2cffc801c156..299f213a7f6c Created with: gclient setdep -r src-internal@299f213a7f6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: Iffa1ddf383c2c2dc452b3b91d31ebe1779d3671d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010339Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62475e95da5b..845a09b8241e git log 62475e95da5b..845a09b8241e --date=short --first-parent --format='%ad %ae %s' 2020-01-20 ianelliott@google.com Vulkan: glDeleteTexture unbind all image texture units Created with: gclient setdep -r src/third_party/angle@845a09b8241e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Id129579419465faab42cde3d023a3c1319341427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010340Reviewed-by:
-
Hiroki Nakagawa authored
clients-matchall-client-types.https.html manually cleans up controlled frames at the end of each test case. This doesn't work when the tests fail on the way, and that unexpectedly prolongs lifetime of a service worker. This is the reason why the second test failed with the following message. "Error: wait_for_state must be passed a ServiceWorker" This CL fixes it by cleaning up the frames using add_cleanup() helper. Bug: n/a Change-Id: I0f0e71a55814d114665eff824c917c918ac993f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010600Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#733498}
-
Prabir Pradhan authored
When it was first implemented, adding a relative-pointer-delegate would also enable pointer capture (locking the pointer). This change makes it so that the pointer can only be locked through the pointer-constraints protocol. Bug: b/124059008 Test: exo_unittests, manual testting using ArcPointerCaptureTestApp Change-Id: Ied0f1c658aa713026e622f4ce26009e261d4f653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992355Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#733497}
-
Fergus Dall authored
It seems to be possible for shared references to CrostiniRestarter to outlive CrostiniManager. Since all of CrostiniRestarter assumes that CrostiniManager still exists, this can cause crashes. Switch CrostiniRestarter to being exclusivly owned by CrostiniManager and handing out weak pointers to callbacks. Bug: 1040797 Change-Id: Ib65c79c7c81111aad88435b3c95da0c64226e791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996112Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#733496}
-
Isabella Scalzi authored
If the user opens Quick View after selecting multiple files of different types, the user is unable to use the "open" button from Quick View. This is due to the openInNewButtonTap_ (OPEN button) handler using taskController_.executeDefaultTask, which retrieves the tasks for the entire mutli-selection, rather than for the item shown in Quick View. Fix this: create a local variable containing the tasks for the currently viewed item, and retrieve the tasks from here when the "open" button is clicked from Quick View. This could potentially be racy. Will address this in a future patch. Bug: 1038799 Change-Id: Ie4186f4f4162eff1b89d5334bd5b5bcab9089450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010236Reviewed-by:
-
Anand K. Mistry authored
Bug: 939235 Change-Id: Ie020c44ef00557f9f28da12294b717d9a325bb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006903 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Samuel Huang authored
This reverts commit c8af0e6f. Reason for revert: The fix is effective for local build, but not Canary. Also, a better fix is available. Reverting this first simplifies merge into trunk. Original change's description: > [DFM] Defer ModuleUtil.recordModuleAvailability() call to onFinishNativeInitialization(). > > Previously, ModuleUtil.recordModuleAvailability() was called from > ChromeApplication.attachBaseContext(). A side-effect of MU.rMA() is that > it initializes SplitCompat. However, for yet-to-be determined reason, > this early initialization causes failure downstream in > ChromeContentBrowserClient, so that if a DevUI page is loaded as the > active page, restarting Chrome would cause it to fail to load! > > This CL alleviates the problem by deferring the MU.rMA() call to > ChromeBrowserInitializer.onFinishNativeInitialization(), thereby > avoiding initializing SplitCompat too early, while still recording > module metrics at start-up. > > Bug: 1036753 > Change-Id: I21c02dc957f494fb76c959c772a6f77db8b933a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003253 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732158} TBR=yfriedman@chromium.org,huangs@chromium.org,wnwen@chromium.org NOTRY=true Bug: 1036753 Change-Id: I2d566cb8b34f8f409b74a072a079706bf042f4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011440Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733493}
-
Bo Liu authored
cc does not have control over when to produce a frame for webview / synchronous compositor as it does over chrome. There is a lot of down side to waiting for draw, when the pathological case for happens frequently causing both poor performance on the main thread and higher latency. Synchronous compositor also had a fallback tick that runs "fake" draws after invalidate to ensure the compositing pipeline is never stalled. This is no longer necessary with this change, so remove fallback tick and some unused code in swap messages. Bug: 1025695 Change-Id: I240f01662ccdf6f9c35912c421ea1ef0e40b1cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986934Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733492}
-
Denis Bessonov authored
This reverts commit 0156c949. Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly. Original change's description: > Fix 0,0-0x0 turning into PaintOp::kUnsetRect. > > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early > return prevents the effect_bounds_stack_.back() update in a > ConversionContext::UpdateEffectBounds call. This results in keeping default > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect. > > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for > details). Application of this patch fixes the lagging print preview. > > R=fmalita@chromium.org, samans@chromium.org > > Bug: 918240 > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958 > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714293} Bug: 918240 Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733491}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cbab43ca0aa3..03acc60fb5fc git log cbab43ca0aa3..03acc60fb5fc --date=short --first-parent --format='%ad %ae %s' 2020-01-21 tmathmeyer@chromium.org Fix display bug in Media tab event table Created with: gclient setdep -r src/third_party/devtools-frontend/src@03acc60fb5fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ice7b0eab8f759cdfc30e5825d635ccb58110c414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010337Reviewed-by:
-
Anand K. Mistry authored
MountPoint uses a simple callback for result, instead of having to register an observer and waiting for the appropriate event. The strong ownership semantics of MountPoint also mean that explicit unmount are no longer necessary. Bug: 939235 Change-Id: I8478e414b8b7cc1c462985f272dea108547f67c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006895Reviewed-by:
-
nancy authored
Add Shelf menu items, MENU_OPEN_NEW and MENU_CLOSE, for built_in apps: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/internal_app_shelf_context_menu.cc?l=25 BUG=1038487 Change-Id: I2b50bf2aa5f393b0e23645e72ac7b87b7b7d9534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009601Reviewed-by:
-
Jing Wang authored
When the user types certain text, such as "my email is ", we would like suggest the corresponding email address. This metric records how many times users trigger this suggestion. These metrics were introduced by cr/289566860 Bug: 1042084 Change-Id: Ibdf88d44d1bcbe7bab7376534b085f5e153e99f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000278Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733487}
-
nancy authored
When more components use AppService, the public interfaces without comments could be very confused to use. So add the comments to AppServiceProxy's public interfaces. BUG=1016159 Change-Id: Ibf7470a356b15cafccc5def2fd478e79914f5fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009594Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/761790f8..bf7181f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I364f66f3eba01ceb2c93314e68c3511841f753d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010931Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733485}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Ie5e834f38eae482407592226cea890818125926c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011290Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#733484}
-
Kenichi Ishibashi authored
This accessor was exposed for ServiceWorkerStorage but all usage of installing_registrations_ have moved into ServiceWorkerRegistry. Bug: 1039200 Change-Id: Iff5820a7acc4341886f02873328b79a1cbbbe684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010598Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abf20c44084a..2cffc801c156 Created with: gclient setdep -r src-internal@2cffc801c156 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I5ae6daeaa4bc80637005207cff0e178e7cc0a061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010334Reviewed-by:
-
