- 30 Jan, 2020 40 commits
-
-
Jazz Xu authored
This CL adds picture-in-picture button to zenith dialog. Will follow up with integration tests and unit tests. Bug: 1047314 Change-Id: Id435d557b2eb80ac8d262da7f137a72b1cc1908c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030353Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#737098}
-
evliu authored
This CL updates the default style of the caption settings preview text to better reflect the actual style of the captions when no custom caption settings are specified. Bug: 1046441 Change-Id: I66fc357d86dadfb9a756d6e77d78a01c0a85eb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028160 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737097}
-
Yulun Wu authored
Bug: 1047373 Change-Id: Iff288056d2006c9c97aa0f517e8d7f66e592f143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032046 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#737096}
-
John Chen authored
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html occasionally timeout on MacOS 10.14, adding to TextExpectations. TBR=wangxianzhu@chromium.org Bug: 1008826, 1028242 Change-Id: I9b0908a8c89c1915a62d7fe922359927afc2ab6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032027Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737095}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6c3dc3581eaf..79b36b640692 git log 6c3dc3581eaf..79b36b640692 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 capn@google.com Fix use after free 2020-01-30 capn@google.com Have Kokoro accept imports from Piper 2020-01-30 amaiorano@google.com Subzero: fix incorrect cast 2020-01-30 capn@google.com Export Vulkan API entry functions 2020-01-30 capn@google.com Support LLVM 9+ build changes 2020-01-30 bclayton@google.com Regres: Fix unix build 2020-01-29 capn@google.com Regres: aways use build output path for ICD json 2020-01-29 capn@google.com Associate bug IDs with unimplemented functionality 2020-01-29 amaiorano@google.com Fix memory leak in rr::Optimizer 2020-01-29 bclayton@google.com Regres: Make it work on windows. 2020-01-29 amaiorano@google.com Subzero: implement coroutines for Win32 2020-01-29 bclayton@google.com SpirvShaderDebugger: Expose builtins in HLSL / GLSL. 2020-01-29 bclayton@google.com Vulkan/Debug: Add VariableContainer::extend() Created with: gclient setdep -r src/third_party/swiftshader@79b36b640692 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1047150 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib8e99e0b23bed6674e1dcac87ef61a8dffc74481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737094}
-
Jeremie Boulic authored
Follow-up to crrev.com/c/2016689. Convention has been to use AndroidFiles* instead of AndroidPlayFiles in the chromium code base. Bug: 1044495 Change-Id: If38cdaa971b2a4a2b96c2b298ddc9d1c3cc5ae02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027009 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#737093}
-
Ali Juma authored
safe_browsing.mojom depends on content/, but is currently located in components/safe_browsing/core/common, where content/ dependencies are being removed as part of converting this component into a layered component. This CL splits safe_browsing.mojom into two files. Most of the old file moves to a new location (components/safe_browsing/content/common), while the rest moves to a new file (safe_browsing_url_checker.mojom) in the current location, since it is needed by SafeBrowsingUrlChecker, which will remain part of components/safe_browsing/core. This CL also makes the components/safe_browsing/content/common:common target build on iOS, as part of components_unittests. TBR=boliu,yfriedman Change-Id: I4497a5aeddf69350f77d193902e15823241e46fd Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020510 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737092}
-
Sigurdur Asgeirsson authored
This allows fuzzing to deserialize arbitrary messages, while still checking programming errors. Bug: 1046895 Change-Id: Iafc5418ddbcbf8197ce3991d08c4f8d7bf374234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031165 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#737091}
-
Natalie Chouinard authored
The package name for Clank settings has been changed from preferences to settings. Update the presubmit check for AlertDialogs. Bug: 1027271 Change-Id: I6f57d3cccf20768274197210fdc1ab372e8e3cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031542Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737090}
-
James Darpinian authored
In https://crrev.com/c/1991969 I added a new, faster way to disable ARB_texture_rectangle support in ANGLE's shader translator. This change starts using it in Chrome, replacing the earlier change introduced in https://crrev.com/c/1842223 The original change https://crrev.com/c/1992548 was reverted because CopyTextureCHROMIUM generates shaders that use ARB_texture_rectangle even in WebGL contexts. This reland includes code to temporarily enable ARB_texture_rectangle during CopyTextureCHROMIUM. Bug: angleproject:3770 Change-Id: I81180a21d109a02d96f1896880d7ea2fe19d6fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017932 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737089}
-
nancy authored
When select 'Also clear data from Chrome...' for bookmark, the extension is uninstalled first, then when clear data, it crashes when GetFullLaunchURL from the extension, because the extension has been uninstalled. So add scoped_ptr for the extension, which is the same implementation from the ExtensionUninstallDialog: https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_uninstall_dialog.h?l=160 https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_uninstall_dialog.cc?l=176 BUG=1047092 Change-Id: Idca8172a671f69efe2e9b9ce19fb2037d3f57fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029475Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737088}
-
Kyle Milka authored
Add some basic tests for the ShareSheetPropertyModelBuilder. Bug: 1009124 Change-Id: Id9951814533bd9c3da3e63e1fb1a39e802e424fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019333 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#737087}
-
Ben Pastene authored
Not sure if this will work. But theoretically this will prevent non-googlers from adding these trybots onto their CL via "cq_include_trybots" footer. If this works, we'll be able to trim down (but not fully delete) the code at http://shortn/_Nxx3vpeckc. Bug: 1047347 Change-Id: Idf1b95b5ee258e8a30d21dd480558861082f1f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032025 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#737086}
-
Chris Hamilton authored
This migrates all of the code in fuchsia/ to use blink::WebMessagePort instead of directly manipulating Mojo pipes, and manually encoding messages. It preserves the existing APIs so that downstream dependents can migrate. A further CL will rip out the deprecated API. BUG=803242 Change-Id: I75e74f40ee25dfba8cbf70cf58be53a4947d491d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028209 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#737085}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cf899c949229..5071ae68a0f7 git log cf899c949229..5071ae68a0f7 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 tsepez@chromium.org Remove unused CPDF_PageObjectHolder::Transform(). 2020-01-30 tsepez@chromium.org Remove unused CPDF_TextObject::SetPosition() variant. 2020-01-30 thestig@chromium.org Remove |CPDF_DIB::m_pMaskStream|. 2020-01-30 tsepez@chromium.org Remove unused CFX_Matrix::Shear() 2020-01-30 thestig@chromium.org Consolidate code into CPDF_Image::CreateXObjectImageDict(). Created with: gclient setdep -r src/third_party/pdfium@5071ae68a0f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iad583ef6ec269fee11858751657451a79bca5da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031623Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds wrapper methods of following methods: * ClearUserData() * ClearUserDataByKeyPrefixes() * ClearUserDataForAllRegistrationsByKeyPrefix() The purpose of this change is to reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Adding these wrappers moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage to ServiceWorkerRegistry. Bug: 1039200 Change-Id: I8f3a2b42cf215aa125999018dcdfcbd628f2cd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026509 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737083}
-
Charlie Hu authored
This CL adds support for origin trials for document policy by adding GetAvailableDocumentPolicyFeatures to feature_policy_helper.cc. Potentially need to rename feature_policy_helper and GetDefaultNameFeatureMap later. Change-Id: I3f703c3d4f5a2c4f635b99839d06308a2c9eff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008322Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#737082}
-
Avery Musbach authored
OverviewItem::Restack refers to the "dragged" window in variable names and comments, but as of [1], the window is no longer guaranteed to be the dragged window. Also, the whole function is hard to read. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2024148 Fixed: 1047486 Change-Id: I10c51e80ef8c9b1fce86ab60f8834fd5eaca8a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031925 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#737081}
-
Tibor Goldschwendt authored
Bug: 1042534 Change-Id: I7c8cd470fd9d313ceb851d9d28731909152bc180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025952 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#737080}
-
Rakib M. Hasan authored
Add the Mac10.14 to a tag declaration list in TestExpectations. Bug: 986447 Bug: 1028242 Change-Id: I74371a2e6f34573259546697502de6c89001e76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031712 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#737079}
-
Anupam Snigdha authored
On Windows, input service has a callback when the keyboard is shown/dismissed so the browser could scroll the content into view if its occluded by the VK. This callback is an async call and doesn't align with focus notification from the renderer process. If we reset the keyboard observer before the VK is dismissed, then the callback wouldn't be called and the content would be occluded by the VK. This fix removes the code that resets the keyboard observer right after the dismiss VK is called. The observer is reset during DetachFromInputMethod call. Bug: 1039766, 1046708 Change-Id: I27118daa0c99d35eae9aa80a33ab32a8d155ddf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021419 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#737078}
-
nancy authored
BUG=1038487 Change-Id: Ie93ef246c20053ee5c34c1c4dcba7fe5ecd93ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026847 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737077}
-
Matthew Mourgos authored
Currently the ShelfWidget animates while a child layer (animating_background_) animates at the same time. In this CL, by changing the ShelfWidget to use a layer transform for animation, the the animating_background_ and the ShelfWidget will have an animation which will look a bit smoother. Bug: 1043366 Change-Id: I09752f247a0da0989e14dbfad09d0e22b4a60011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016045Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737076}
-
John Lee authored
These methods will soon be used elsewhere to determine if a drag should be allowed or not. Bug: 1005560 Change-Id: Ief93fdf35c034301f310bf519859f3e8dafcb8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030045 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
John Chen authored
virtual/threaded/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-end-to-end.js, which is known to timeout occasionally on Mac 10.13, has been observed to timeout on Mac 10.14 as well. TBR=wangxianzhu@chromium.org Bug: 1018064, 1028242 Change-Id: Ic0d054a960ec5866adf9e9142d444956fd3ddf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032010Reviewed-by:
-
Nick Harper authored
Remove the Extensions.Messaging.IncludeChannelIdBehavior histogram and the code around it. includeTlsChannelId is left on the public API for now, so we can audit whether removal would cause significant breakage. Change-Id: I738f1df33627629a62fc5a945ec7b116a2111f97 Bug: 1016425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015777 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737073}
-
alex linker authored
Dummy placeholder |kUnknown| representing the category of app which was the source of the URL being opened as a part of intent handling metrics. BUG=1044710 TEST= ran IntentHandlingMetrics.* unit tests Change-Id: I4fd9b5047dbb8ff578211ebeb59cb984cdb41a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023709 Commit-Queue: Alex Linker <ajlinker@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1047288 Change-Id: I55fec25ad936033cccdacc3880b341ac02c6374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031868Reviewed-by:
-
Ahmed Fakhry authored
The flag is expiring in M-81, and the feature launched in M-78. It is time to remove the flag and the associated base::Feature. This simplifies the code greatly. BUG=1043361 TEST=Should compile and all tests should pass. Change-Id: Id400f11c2bcc2810beda42336e4a1d026586ed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029067 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737070}
-
Michael Spang authored
This script does not work currently: Traceback (most recent call last): File "build/fuchsia/exe_runner.py", line 36, in <module> sys.exit(main()) File "build/fuchsia/exe_runner.py", line 32, in main args.package_dep, args.child_args, run_package_args) AttributeError: 'Namespace' object has no attribute 'package_dep' Fix it to account for changes to the package runner. Change-Id: I292bdd3af4e72add1001d54cbb14e1aa3bdc8ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031993 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737069}
-
Kenichi Ishibashi authored
The purpose of this change is to reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Adding the wrapper moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage to ServiceWorkerRegistry. Bug: 1039200 Change-Id: I82d06c283c06f373842ee8d6a975f6364086ef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026907 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL modifies GLOutputSurfaceBufferQueue to handle the case where GetOverlayTextureId() and SwapBuffers() are called without first calling BindFramebuffer(): this indicates that the client didn't draw but still wants to swap. Prior to CL:1977969, on such case, GetOverlayTextureId() would return the texture that was obtained in the last call to BindFramebuffer(). This CL is intended to do the same: if GetOverlayTextureId() is called, and we know that the client is not currently drawing, we still return the last texture that was attached to the framebuffer. Additionally, this CL ensures that we end access to a shared image prior to emitting the command buffer command to swap the buffers to avoid synchronization issues. Android Q no longer produces flickering. Inspecting a page using added a unit test for empty swaps. Bug: 1046055 Test: Visiting https://www.funwithmama.com/bento-boxes-for-kids/ on chrome: //inspect on Android Q no longer causes a DCHECK crash. Also Change-Id: I86dc72f920a97b598028023f203aa5be4da2a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024177Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737067}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e998f17e0ce..be99ee8f17f9 git log 8e998f17e0ce..be99ee8f17f9 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 terelius@webrtc.org Add more options for tuning the RobustThroughputEstimator through field trial. 2020-01-30 srte@webrtc.org Revert "Inlines NullAudioPoller functionality into AudioState class." 2020-01-30 srte@webrtc.org Inlines NullAudioPoller functionality into AudioState class. Created with: gclient setdep -r src/third_party/webrtc@be99ee8f17f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I65b4b67b289d7136b80864653e7e6a8c0ff4f2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031692Reviewed-by:
-
Regan Hsu authored
* Copy and clean SearchInSettings strings from Browser to OS. * Add searchNoOsResultsHelp with it's own URL. Bug: 967888 Change-Id: I824bd4385c123bdeace61ef89386818108afac10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013644Reviewed-by:
-
Stefan Zager authored
This CL is meant to test two hypotheses: that the local root document's lifecycle changes between the end of UpdateAllLifecyclePhases and the hit test; and that the LocalFrame containing the iframe element has a null page_. For details see comment #6 on the bug. BUG=1041252 Change-Id: I8ac48062a5c87b7e9424e24a616657610c1af807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028747Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#737064}
-
Clark DuVall authored
This also required moving the kBlockPromptsIfDismissedOften and kBlockPromptsIfIgnoredOften features to //components/permissions. Since HostContentSettingsMapFactory is a //chrome concept, I added an Initialize() method on PermissionDecisionAutoBlocker to initialize with the correct HostContentSettingsMap. Bug: 1025609 Change-Id: Ie8e6f963e310c2f6284078ded7dcf88e85de937e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025874Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
David Black authored
It is potentially unsafe to destroy AssistantWebViewImpl during handling of suppressed navigation events. This was not previously an issue for Assistant as the Content Service backed implementation notified handlers of this event over mojo, so destruction was performed after the suppression sequence had completed. Note that this is currently only affecting proactive suggestions as only proactive suggestions currently uses target="_blank" for its links in conjunction w/ the destruction sequence which triggers code path [1] as opposed to code path [2]. [1] http://shortn/_H18kMl1jSt [2] http://shortn/_J5ss5Vjirn Bug: b:148484855 Change-Id: I9e42c371a3f53e16c6112bd4f7506ea2de749f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026689Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#737062}
-
James Hollyer authored
The discovering property in bluez is often delayed in updating. This has caused issues in the past. This change ensures that that property is only used in testing so that it will no longer cause any bugs. Bug: 1013678 Change-Id: I8afbdef6385189d62b1d47ceee16474da06d2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003355 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737061}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e702867eed40..08f1abcc5bb0 git log e702867eed40..08f1abcc5bb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 pfaffe@chromium.org Fix two issues in debugger plugins Created with: gclient setdep -r src/third_party/devtools-frontend/src@08f1abcc5bb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4550afd5e21cb56f544a5cd1ed5b28437c87a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031633Reviewed-by:
-
Brian Sheedy authored
Switches the SkiaRenderer Dawn builders to use the 'gpu_tests' mixin instead of 'gpu_fyi_tests', as the FYI version causes them to attempt to build ANGLE conformance tests. These tests aren't necessary on this configuration, and are currently failing to build. Bug: 1046947 Change-Id: I7aed86f11f359de966bc47a896c392f247812246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028739 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#737059}
-
